Re: [Mesa-dev] r600
Am Donnerstag, den 28.11.2019, 13:22 +1000 schrieb Dave Airlie: > On Wed, 27 Nov 2019 at 21:08, Gert Wollny > wrote: > > > > Before that I'd like to un-tabbify the whole r600 driver code, > > because all the other parts of mesa I've been touching use spaces, > > and it makes it more convenient to have the same WS handling > > everywhere. > > > I'm not against it from a style point of view, but from a it totally > breaks git history, blame, cherry-picking and many other useful > things I'd really ask you to reconsider and just use editorconfig > Fair enough, I'll keep the tabs for now and see whether I can get editorconfig to work for me. Best, Gert ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [radeonsi] enable OpenGL 4.6
Hi, The setting is radeonsi_enable_nir=true Marek On Wed., Nov. 27, 2019, 23:42 Dieter Nützel, wrote: > Hello Marek and Pierre-Eric, > > GREAT work but this time I'm to stupid (tired). > I only 'see' 4.5. - E.g. that R600_DEBUG/AMD_DEBUG=nir is set. > Was at the dentist yesterday... > > > https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/1142033-amd-s-radeonsi-driver-finally-enables-opengl-4-6-but-you-need-to-first-enable-nir?p=1142054#post1142054 > > Greetings, > Dieter > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] i965: update Makefile.sources for perf changes
brw_performance_query_metrics.h was removed in 134e750e16bfc53480e0bba6f0ae3e1d2a7fb87c and brw_performance_query.h was removed in 8ae6667992ccca41d08884d863b8aeb22a4c4e65 remove reference to these files from Makefile.sources Signed-off-by: Jonathan Gray Cc: 19.2 19.3 --- src/mesa/drivers/dri/i965/Makefile.sources | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/Makefile.sources b/src/mesa/drivers/dri/i965/Makefile.sources index ed6b880bc20..469ee2f5d2d 100644 --- a/src/mesa/drivers/dri/i965/Makefile.sources +++ b/src/mesa/drivers/dri/i965/Makefile.sources @@ -35,9 +35,7 @@ i965_FILES = \ brw_object_purgeable.c \ brw_pipe_control.c \ brw_pipe_control.h \ - brw_performance_query.h \ brw_performance_query.c \ - brw_performance_query_metrics.h \ brw_program.c \ brw_program.h \ brw_program_binary.c \ -- 2.24.0 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [PATCH] winsys/amdgpu: avoid double simple_mtx_unlock()
pthread_mutex_unlock() when unlocked is documented by posix as
being undefined behaviour. On OpenBSD pthread_mutex_unlock() will call
abort(3) if this happens.
This occurs in amdgpu_winsys_create() after
cb446dc0fa5c68f681108f4613560543aa4cf553
winsys/amdgpu: Add amdgpu_screen_winsys
Signed-off-by: Jonathan Gray
Cc: 19.2 19.3
---
src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
index a89432d8594..2fe227c9213 100644
--- a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
+++ b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c
@@ -326,7 +326,6 @@ amdgpu_winsys_create(int fd, const struct
pipe_screen_config *config,
aws = util_hash_table_get(dev_tab, dev);
if (aws) {
pipe_reference(NULL, &aws->reference);
- simple_mtx_unlock(&dev_tab_mutex);
/* Release the device handle, because we don't need it anymore.
* This function is returning an existing winsys instance, which
--
2.24.0
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] [radeonsi] enable OpenGL 4.6
Hello Marek and Pierre-Eric, GREAT work but this time I'm to stupid (tired). I only 'see' 4.5. - E.g. that R600_DEBUG/AMD_DEBUG=nir is set. Was at the dentist yesterday... https://www.phoronix.com/forums/forum/phoronix/latest-phoronix-articles/1142033-amd-s-radeonsi-driver-finally-enables-opengl-4-6-but-you-need-to-first-enable-nir?p=1142054#post1142054 Greetings, Dieter ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] r600
On Wed, 27 Nov 2019 at 21:08, Gert Wollny wrote: > > Hello Dave, > > I was wondering how much interest you still have in R600? I'm preparing > to start feeding my NIR work as MRs to continue my work in-tree. It is > currently only for Evergreen and still far from feature parity > with TGSI (no tesselation, no images, nor SSBOs), some things regress, > but some things are also fixed, so obviously the backend will only be > enabled on explicit request. > > Before that I'd like to un-tabbify the whole r600 driver code, because > all the other parts of mesa I've been touching use spaces, and it makes > it more convenient to have the same WS handling everywhere. > > Whould this be okay with you? I'm not against it from a style point of view, but from a it totally breaks git history, blame, cherry-picking and many other useful things I'd really ask you to reconsider and just use editorconfig. Maybe r600 is quiet enough now we don't have to worry about that much backports or cherry-pick, so I'll leave it up to you. At least leave sb alone since we probably want to kill that someday if your NIR backend gets there, and I doubt you want to touch it too much either. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v2] mapi: avoid text relocation in x86 tsd stubs
OK, I didn't know there is a patch in mail list. BTW, it seems there is no
meaningful difference
with the generated code: when it's trying to align to 32 bytes border,
since the actual code size
is between 32 and 64, actually the entry size is 64. So in this case,
balign to 32 or 64 has same result
I heard that mesa will change to use libglvnd, if that will happen soon,
then we don't worry about code here
any more.
On Wed, Nov 27, 2019 at 5:57 AM Jonathan Gray wrote:
> On Sun, Nov 11, 2018 at 03:47:35PM +1100, Jonathan Gray wrote:
> > Make similiar changes to libglvnd to avoid a text relocation in
> > x86 tsd stubs fixing the build with lld.
> >
> > v2:
> > - store the address of the GOT in ebx required before calling PLT stub
> > - change .balign values to match X86_ENTRY_SIZE
>
> When a different version of this patch was committed/pushed in
> 45206d7673adb1484cbdb3eadaf82e0849c9cdcf
> (with author rewritten to imply I wrote the commit message)
> it did not include the .balign changes to match the entry size change.
>
> Was this purposefully skipped or overlooked as the bugzilla patch was
> used?
>
> The diff to what was committed and this patch is
>
> diff --git a/src/mapi/entry_x86_tsd.h b/src/mapi/entry_x86_tsd.h
> index bd8db7b19f9..1dec3ed86c4 100644
> --- a/src/mapi/entry_x86_tsd.h
> +++ b/src/mapi/entry_x86_tsd.h
> @@ -34,18 +34,18 @@
> #define X86_ENTRY_SIZE 64
>
> __asm__(".text\n"
> -".balign 32\n"
> +".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
> "x86_entry_start:");
>
> #define STUB_ASM_ENTRY(func)\
> ".globl " func "\n" \
> ".type " func ", @function\n"\
> - ".balign 32\n" \
> + ".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n" \
> func ":"
>
> #define STUB_ASM_CODE(slot) \
> "push %ebx\n\t" \
> - "call 1f\n\t"\
> + "call 1f\n" \
> "1:\n\t" \
> "popl %ebx\n\t" \
> "addl $_GLOBAL_OFFSET_TABLE_+[.-1b], %ebx\n\t" \
> @@ -53,7 +53,7 @@ __asm__(".text\n"
> "mov (%eax), %eax\n\t" \
> "testl %eax, %eax\n\t" \
> "jne 1f\n\t" \
> - "call " ENTRY_CURRENT_TABLE_GET "@PLT\n\t" \
> + "call " ENTRY_CURRENT_TABLE_GET "@PLT\n" \
> "1:\n\t" \
> "pop %ebx\n\t" \
> "jmp *(4 * " slot ")(%eax)"
> @@ -63,7 +63,7 @@ __asm__(".text\n"
>
> #ifndef MAPI_MODE_BRIDGE
>
> -__asm__(".balign 32\n"
> +__asm__(".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
> "x86_entry_end:");
>
> #include
>
> >
> > Signed-off-by: Jonathan Gray
> > Cc: mesa-sta...@lists.freedesktop.org
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108541
> > ---
> > src/mapi/entry_x86_tsd.h | 22 ++
> > 1 file changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/src/mapi/entry_x86_tsd.h b/src/mapi/entry_x86_tsd.h
> > index 0c28c8ff068..1dec3ed86c4 100644
> > --- a/src/mapi/entry_x86_tsd.h
> > +++ b/src/mapi/entry_x86_tsd.h
> > @@ -31,25 +31,31 @@
> > #define HIDDEN
> > #endif
> >
> > -#define X86_ENTRY_SIZE 32
> > +#define X86_ENTRY_SIZE 64
> >
> > __asm__(".text\n"
> > -".balign 32\n"
> > +".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
> > "x86_entry_start:");
> >
> > #define STUB_ASM_ENTRY(func)\
> > ".globl " func "\n" \
> > ".type " func ", @function\n"\
> > - ".balign 32\n" \
> > + ".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n" \
> > func ":"
> >
> > #define STUB_ASM_CODE(slot) \
> > - "movl " ENTRY_CURRENT_TABLE ", %eax\n\t" \
> > + "push %ebx\n\t" \
> > + "call 1f\n" \
> > + "1:\n\t" \
> > + "popl %ebx\n\t" \
> > + "addl $_GLOBAL_OFFSET_TABLE_+[.-1b], %ebx\n\t" \
> > + "movl " ENTRY_CURRENT_TABLE "@GOT(%ebx), %eax\n\t" \
> > + "mov (%eax), %eax\n\t" \
> > "testl %eax, %eax\n\t" \
> > - "je 1f\n\t" \
> > - "jmp *(4 * " slot ")(%eax)\n"\
> > + "jne 1f\n\t" \
> > + "call " ENTRY_CURRENT_TABLE_GET "@PLT\n" \
> > "1:\n\t" \
> > - "call " ENTRY_CURRENT_TABLE_GET "\n\t" \
> > + "pop %ebx\n\t" \
> > "jmp *(4 * " slot ")(%eax)"
> >
> > #define MAPI_TMP_STUB_ASM_GCC
> > @@ -57,7 +63,7 @@ __asm__(".text\n"
> >
> > #ifndef MAPI_MODE_BRIDGE
> >
> > -__asm__(".balign 32\n"
> > +__asm__(".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
> > "x86_entry_end:");
> >
> > #include
> > --
> > 2.19.1
> >
> > ___
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
htt
[Mesa-dev] [ANNOUNCE] mesa 19.3.0-rc5
Hi list, Mesa 19.3.0-rc5 is now available as the latest release in the 19.3 series. This is a pretty small release, likely due to tomorrow being a major US holiday. The majority of the changes are for radv, but there's a few other bits and pieces here too: v3d, r600, freedreno, and old intel, just to name a few. Dylan Shortlog Alejandro Piñeiro (1): v3d: adds an extra MOV for any sig.ld* Bas Nieuwenhuizen (2): radv: Do not change scratch settings while shaders are active. radv: Allocate cmdbuffer space for buffer marker write. Dave Airlie (1): llvmpipe/ppc: fix if/ifdef confusion in backport. Dylan Baker (1): VERSION: Bump version for -rc5 Eric Engestrom (1): vulkan: delete typo'd header Gert Wollny (1): r600: Disable eight bit three channel formats Hyunjun Ko (1): freedreno/ir3: fix printing output registers of FS. Ian Romanick (1): intel/fs: Disable conditional discard optimization on Gen4 and Gen5 Jose Maria Casanova Crespo (1): v3d: Fix predication with atomic image operations Timothy Arceri (3): radv: add some infrastructure for fresh forks for each secure compile radv: add a secure_compile_open_fifo_fds() helper radv: create a fresh fork for each pipeline compile Yevhenii Kolesnikov (2): glsl: Enable textureSize for samplerExternalOES meson: Fix linkage of libgallium_nine with libgalliumvl Zebediah Figura (1): Revert "draw: revert using correct order for prim decomposition." git tag: mesa-19.3.0-rc5 https://mesa.freedesktop.org/archive/mesa-19.3.0-rc5.tar.xz SHA256: f910f36818d5a5fe93f15cc53372b8a33fa7916ff45fb1e830a487dee12b5007 mesa-19.3.0-rc5.tar.xz SHA512: 25d59baabddafe63512d9998e3ac21f847a32a2639d6b7f106729a3dc7112fec334e3634bda6a17fd0ce8b993e6bc35a5d15fa33a4c9006aaa941db9f5366424 mesa-19.3.0-rc5.tar.xz PGP: https://mesa.freedesktop.org/archive/mesa-19.3.0-rc5.tar.xz.sig signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v2] mapi: avoid text relocation in x86 tsd stubs
On Sun, Nov 11, 2018 at 03:47:35PM +1100, Jonathan Gray wrote:
> Make similiar changes to libglvnd to avoid a text relocation in
> x86 tsd stubs fixing the build with lld.
>
> v2:
> - store the address of the GOT in ebx required before calling PLT stub
> - change .balign values to match X86_ENTRY_SIZE
When a different version of this patch was committed/pushed in
45206d7673adb1484cbdb3eadaf82e0849c9cdcf
(with author rewritten to imply I wrote the commit message)
it did not include the .balign changes to match the entry size change.
Was this purposefully skipped or overlooked as the bugzilla patch was
used?
The diff to what was committed and this patch is
diff --git a/src/mapi/entry_x86_tsd.h b/src/mapi/entry_x86_tsd.h
index bd8db7b19f9..1dec3ed86c4 100644
--- a/src/mapi/entry_x86_tsd.h
+++ b/src/mapi/entry_x86_tsd.h
@@ -34,18 +34,18 @@
#define X86_ENTRY_SIZE 64
__asm__(".text\n"
-".balign 32\n"
+".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
"x86_entry_start:");
#define STUB_ASM_ENTRY(func)\
".globl " func "\n" \
".type " func ", @function\n"\
- ".balign 32\n" \
+ ".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n" \
func ":"
#define STUB_ASM_CODE(slot) \
"push %ebx\n\t" \
- "call 1f\n\t"\
+ "call 1f\n" \
"1:\n\t" \
"popl %ebx\n\t" \
"addl $_GLOBAL_OFFSET_TABLE_+[.-1b], %ebx\n\t" \
@@ -53,7 +53,7 @@ __asm__(".text\n"
"mov (%eax), %eax\n\t" \
"testl %eax, %eax\n\t" \
"jne 1f\n\t" \
- "call " ENTRY_CURRENT_TABLE_GET "@PLT\n\t" \
+ "call " ENTRY_CURRENT_TABLE_GET "@PLT\n" \
"1:\n\t" \
"pop %ebx\n\t" \
"jmp *(4 * " slot ")(%eax)"
@@ -63,7 +63,7 @@ __asm__(".text\n"
#ifndef MAPI_MODE_BRIDGE
-__asm__(".balign 32\n"
+__asm__(".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
"x86_entry_end:");
#include
>
> Signed-off-by: Jonathan Gray
> Cc: mesa-sta...@lists.freedesktop.org
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108541
> ---
> src/mapi/entry_x86_tsd.h | 22 ++
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> diff --git a/src/mapi/entry_x86_tsd.h b/src/mapi/entry_x86_tsd.h
> index 0c28c8ff068..1dec3ed86c4 100644
> --- a/src/mapi/entry_x86_tsd.h
> +++ b/src/mapi/entry_x86_tsd.h
> @@ -31,25 +31,31 @@
> #define HIDDEN
> #endif
>
> -#define X86_ENTRY_SIZE 32
> +#define X86_ENTRY_SIZE 64
>
> __asm__(".text\n"
> -".balign 32\n"
> +".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
> "x86_entry_start:");
>
> #define STUB_ASM_ENTRY(func)\
> ".globl " func "\n" \
> ".type " func ", @function\n"\
> - ".balign 32\n" \
> + ".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n" \
> func ":"
>
> #define STUB_ASM_CODE(slot) \
> - "movl " ENTRY_CURRENT_TABLE ", %eax\n\t" \
> + "push %ebx\n\t" \
> + "call 1f\n" \
> + "1:\n\t" \
> + "popl %ebx\n\t" \
> + "addl $_GLOBAL_OFFSET_TABLE_+[.-1b], %ebx\n\t" \
> + "movl " ENTRY_CURRENT_TABLE "@GOT(%ebx), %eax\n\t" \
> + "mov (%eax), %eax\n\t" \
> "testl %eax, %eax\n\t" \
> - "je 1f\n\t" \
> - "jmp *(4 * " slot ")(%eax)\n"\
> + "jne 1f\n\t" \
> + "call " ENTRY_CURRENT_TABLE_GET "@PLT\n" \
> "1:\n\t" \
> - "call " ENTRY_CURRENT_TABLE_GET "\n\t" \
> + "pop %ebx\n\t" \
> "jmp *(4 * " slot ")(%eax)"
>
> #define MAPI_TMP_STUB_ASM_GCC
> @@ -57,7 +63,7 @@ __asm__(".text\n"
>
> #ifndef MAPI_MODE_BRIDGE
>
> -__asm__(".balign 32\n"
> +__asm__(".balign " U_STRINGIFY(X86_ENTRY_SIZE) "\n"
> "x86_entry_end:");
>
> #include
> --
> 2.19.1
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
[Mesa-dev] r600
Hello Dave, I was wondering how much interest you still have in R600? I'm preparing to start feeding my NIR work as MRs to continue my work in-tree. It is currently only for Evergreen and still far from feature parity with TGSI (no tesselation, no images, nor SSBOs), some things regress, but some things are also fixed, so obviously the backend will only be enabled on explicit request. Before that I'd like to un-tabbify the whole r600 driver code, because all the other parts of mesa I've been touching use spaces, and it makes it more convenient to have the same WS handling everywhere. Whould this be okay with you? Best, Gert ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
