Re: [Mesa-dev] [PATCH] i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data

2015-02-20 Thread Matt Turner 
Reviewed-by: Matt Turner matts...@gmail.com

It might be a good idea to make the fs_reg(struct brw_reg) explicit to
prevent this kind of mistake from happening.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data

2015-02-20 Thread Jordan Justen 
The brw_imm_ud will yield a HW_REG which then will introduce a barrier
for certain optimization opportunities.

No piglit regressions seen with gen8 (simd8vs).

Suggested-by: Matt Turner matts...@gmail.com
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
Cc: Matt Turner matts...@gmail.com
---
 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp 
b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index fa7d32c..b1b75821 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -3016,7 +3016,7 @@ fs_visitor::emit_untyped_atomic(unsigned atomic_op, 
unsigned surf_index,
*/
   assert(stage == MESA_SHADER_VERTEX || stage == MESA_SHADER_COMPUTE);
   emit(MOV(component(sources[0], 7),
-   brw_imm_ud(0x)))-force_writemask_all = true;
+   fs_reg(0x)))-force_writemask_all = true;
}
length++;
 
@@ -3079,7 +3079,7 @@ fs_visitor::emit_untyped_surface_read(unsigned 
surf_index, fs_reg dst,
*/
   assert(stage == MESA_SHADER_VERTEX || stage == MESA_SHADER_COMPUTE);
   emit(MOV(component(sources[0], 7),
-   brw_imm_ud(0x)))-force_writemask_all = true;
+   fs_reg(0x)))-force_writemask_all = true;
}
 
/* Set the surface read offset. */
-- 
2.1.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/fs: Use fs_reg for CS/VS atomics pixel mask immediate data

2015-02-20 Thread Matt Turner 
On Fri, Feb 20, 2015 at 1:14 PM, Jordan Justen
jordan.l.jus...@intel.com wrote:
 The brw_imm_ud will yield a HW_REG which then will introduce a barrier
 for certain optimization opportunities.

 No piglit regressions seen with gen8 (simd8vs).

 Suggested-by: Matt Turner matts...@gmail.com
 Signed-off-by: Jordan Justen jordan.l.jus...@intel.com
 Cc: Matt Turner matts...@gmail.com

By the way, there are some more in gen6_gs_visitor.cpp if you'd like
to clean those up as well.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev