Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-29 Thread Samuel Iglesias Gonsálvez 


On 28/08/18 23:41, Andres Gomez wrote:
> Andrii, Samuel, should we also include this in the stable queues ?

Yes, please. Add it to stable queue.

Sam

>
> On Wed, 2018-08-15 at 18:20 +0300, asimiklit.w...@gmail.com wrote:
>> From: Andrii Simiklit 
>>
>> When the SVBI Payload Enable is false I guess the register R1.4
>> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
>> and GS stops to write transform feedback when the transform feedback 
>> is not active.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
>> Signed-off-by: Andrii Simiklit 
>> ---
>>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
>> b/src/mesa/drivers/dri/i965/genX_state_upload.c
>> index ea5ad55..0f82500 100644
>> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
>> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
>> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>>  #if GEN_GEN < 7
>>   gs.SOStatisticsEnable = true;
>>   if (gs_prog->info.has_transform_feedback_varyings)
>> -gs.SVBIPayloadEnable = true;
>> +gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
>>  
>>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as 
>> it
>>* was previously done for gen6.




signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-28 Thread Andres Gomez 
Andrii, Samuel, should we also include this in the stable queues ?


On Wed, 2018-08-15 at 18:20 +0300, asimiklit.w...@gmail.com wrote:
> From: Andrii Simiklit 
> 
> When the SVBI Payload Enable is false I guess the register R1.4
> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
> and GS stops to write transform feedback when the transform feedback 
> is not active.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> Signed-off-by: Andrii Simiklit 
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index ea5ad55..0f82500 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>  #if GEN_GEN < 7
>   gs.SOStatisticsEnable = true;
>   if (gs_prog->info.has_transform_feedback_varyings)
> -gs.SVBIPayloadEnable = true;
> +gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
>  
>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it
>* was previously done for gen6.
-- 
Br,

Andres
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-28 Thread andrey simiklit 
Hello,

Thanks a lot)

Regards,
Andrii.

On Tue, Aug 28, 2018 at 4:35 PM Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:

> On Tuesday, August 28, 2018 2:02:07 PM CEST Samuel Iglesias Gonsálvez
> wrote:
> > I'll do it later today.
>
> Done!
>
> Sam
>
> >
> > Thanks for contributing!
> >
> > Sam
> >
> > On 28/08/18 13:59, andrey simiklit wrote:
> > > Hi all,
> > >
> > > Could somebody push it if it seems good for all?
> > >
> > > Regards,
> > > Andrii.
> > >
> > > On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez
> > >
> > > mailto:sigles...@igalia.com>> wrote:
> > > The patch seems fine to me. I also tested it on Intel CI and there
> > > were no regressions.
> > >
> > > Reviewed-by: Samuel Iglesias Gonsálvez 
> > > 
> > >
> > > Thanks,
> > >
> > > Sam
> > >
> > > On 15/08/18 17:20, asimiklit.w...@gmail.com
> > >
> > >  wrote:
> > >> From: Andrii Simiklit 
> > >> 
> > >>
> > >> When the SVBI Payload Enable is false I guess the register R1.4
> > >> which contains the Maximum Streamed Vertex Buffer Index is filled
> by
> > >> zero
> > >> and GS stops to write transform feedback when the transform
> feedback
> > >> is not active.
> > >>
> > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> > >> Signed-off-by: Andrii Simiklit 
> > >> 
> > >> ---
> > >>
> > >>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > >> b/src/mesa/drivers/dri/i965/genX_state_upload.c index
> > >> ea5ad55..0f82500 100644
> > >> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > >> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> > >> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context
> *brw)
> > >>
> > >>  #if GEN_GEN < 7
> > >>
> > >>   gs.SOStatisticsEnable = true;
> > >>   if (gs_prog->info.has_transform_feedback_varyings)
> > >>
> > >> -gs.SVBIPayloadEnable = true;
> > >> +gs.SVBIPayloadEnable =
> > >> _mesa_is_xfb_active_and_unpaused(ctx);
> > >>
> > >>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are
> > >>   enabled as it
> > >>
> > >>* was previously done for gen6.
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-28 Thread Samuel Iglesias Gonsálvez 
On Tuesday, August 28, 2018 2:02:07 PM CEST Samuel Iglesias Gonsálvez wrote:
> I'll do it later today.

Done!

Sam

> 
> Thanks for contributing!
> 
> Sam
> 
> On 28/08/18 13:59, andrey simiklit wrote:
> > Hi all,
> > 
> > Could somebody push it if it seems good for all?
> > 
> > Regards,
> > Andrii.
> > 
> > On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez
> > 
> > mailto:sigles...@igalia.com>> wrote:
> > The patch seems fine to me. I also tested it on Intel CI and there
> > were no regressions.
> > 
> > Reviewed-by: Samuel Iglesias Gonsálvez 
> > 
> > 
> > Thanks,
> > 
> > Sam
> > 
> > On 15/08/18 17:20, asimiklit.w...@gmail.com
> > 
> >  wrote:
> >> From: Andrii Simiklit 
> >> 
> >> 
> >> When the SVBI Payload Enable is false I guess the register R1.4
> >> which contains the Maximum Streamed Vertex Buffer Index is filled by
> >> zero
> >> and GS stops to write transform feedback when the transform feedback
> >> is not active.
> >> 
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> >> Signed-off-by: Andrii Simiklit 
> >> 
> >> ---
> >> 
> >>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> >> b/src/mesa/drivers/dri/i965/genX_state_upload.c index
> >> ea5ad55..0f82500 100644
> >> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> >> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> >> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
> >> 
> >>  #if GEN_GEN < 7
> >>  
> >>   gs.SOStatisticsEnable = true;
> >>   if (gs_prog->info.has_transform_feedback_varyings)
> >> 
> >> -gs.SVBIPayloadEnable = true;
> >> +gs.SVBIPayloadEnable =
> >> _mesa_is_xfb_active_and_unpaused(ctx);
> >> 
> >>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are
> >>   enabled as it
> >>   
> >>* was previously done for gen6.



signature.asc
Description: This is a digitally signed message part.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-28 Thread Samuel Iglesias Gonsálvez 
I'll do it later today.

Thanks for contributing!

Sam


On 28/08/18 13:59, andrey simiklit wrote:
> Hi all,
>
> Could somebody push it if it seems good for all?
>
> Regards,
> Andrii.
>
> On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez
> mailto:sigles...@igalia.com>> wrote:
>
> The patch seems fine to me. I also tested it on Intel CI and there
> were no regressions.
>
> Reviewed-by: Samuel Iglesias Gonsálvez 
> 
>
> Thanks,
>
> Sam
>
> On 15/08/18 17:20, asimiklit.w...@gmail.com
>  wrote:
>> From: Andrii Simiklit  
>> 
>>
>> When the SVBI Payload Enable is false I guess the register R1.4
>> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
>> and GS stops to write transform feedback when the transform feedback 
>> is not active.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
>> Signed-off-by: Andrii Simiklit 
>> 
>> ---
>>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
>> b/src/mesa/drivers/dri/i965/genX_state_upload.c
>> index ea5ad55..0f82500 100644
>> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
>> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
>> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>>  #if GEN_GEN < 7
>>   gs.SOStatisticsEnable = true;
>>   if (gs_prog->info.has_transform_feedback_varyings)
>> -gs.SVBIPayloadEnable = true;
>> +gs.SVBIPayloadEnable = 
>> _mesa_is_xfb_active_and_unpaused(ctx);
>>  
>>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled 
>> as it
>>* was previously done for gen6.
>



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-28 Thread andrey simiklit 
Hi all,

Could somebody push it if it seems good for all?

Regards,
Andrii.

On Thu, Aug 23, 2018 at 4:53 PM Samuel Iglesias Gonsálvez <
sigles...@igalia.com> wrote:

> The patch seems fine to me. I also tested it on Intel CI and there were no
> regressions.
>
> Reviewed-by: Samuel Iglesias Gonsálvez 
> 
> Thanks,
>
> Sam
>
> On 15/08/18 17:20, asimiklit.w...@gmail.com wrote:
>
> From: Andrii Simiklit  
>
> When the SVBI Payload Enable is false I guess the register R1.4
> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
> and GS stops to write transform feedback when the transform feedback
> is not active.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> Signed-off-by: Andrii Simiklit  
> 
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index ea5ad55..0f82500 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>  #if GEN_GEN < 7
>   gs.SOStatisticsEnable = true;
>   if (gs_prog->info.has_transform_feedback_varyings)
> -gs.SVBIPayloadEnable = true;
> +gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
>
>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it
>* was previously done for gen6.
>
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-23 Thread Samuel Iglesias Gonsálvez 
The patch seems fine to me. I also tested it on Intel CI and there were
no regressions.

Reviewed-by: Samuel Iglesias Gonsálvez 

Thanks,

Sam

On 15/08/18 17:20, asimiklit.w...@gmail.com wrote:
> From: Andrii Simiklit 
>
> When the SVBI Payload Enable is false I guess the register R1.4
> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
> and GS stops to write transform feedback when the transform feedback 
> is not active.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> Signed-off-by: Andrii Simiklit 
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index ea5ad55..0f82500 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>  #if GEN_GEN < 7
>   gs.SOStatisticsEnable = true;
>   if (gs_prog->info.has_transform_feedback_varyings)
> -gs.SVBIPayloadEnable = true;
> +gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
>  
>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it
>* was previously done for gen6.



signature.asc
Description: OpenPGP digital signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-17 Thread Iago Toral 
Hi Andrey,
Thanks for the report and all the analysis work on your side. I am on
holidays at the momentand from tomorrow onwards I won't have reliable
internet access but Samuel will be back fromhis vacaction next week and
he might be be able to have a look at the problem and your patch.
Thanks,Iago
On Wed, 2018-08-15 at 18:26 +0300, andrey simiklit wrote:
> Hi all,
> 
> This workaround just helps me to avoid the graphical corruption on
> SNB but
> I not sure is it good idea.
> Regards,
> Andrii.
> 
> On Wed, Aug 15, 2018 at 6:20 PM,   wrote:
> > From: Andrii Simiklit 
> > 
> > 
> > 
> > When the SVBI Payload Enable is false I guess the register R1.4
> > 
> > which contains the Maximum Streamed Vertex Buffer Index is filled
> > by zero
> > 
> > and GS stops to write transform feedback when the transform
> > feedback 
> > 
> > is not active.
> > 
> > 
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> > 
> > Signed-off-by: Andrii Simiklit 
> > 
> > ---
> > 
> >  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
> > 
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > 
> > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > b/src/mesa/drivers/dri/i965/genX_state_upload.c
> > 
> > index ea5ad55..0f82500 100644
> > 
> > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> > 
> > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> > 
> > @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context
> > *brw)
> > 
> >  #if GEN_GEN < 7
> > 
> >   gs.SOStatisticsEnable = true;
> > 
> >   if (gs_prog->info.has_transform_feedback_varyings)
> > 
> > -gs.SVBIPayloadEnable = true;
> > 
> > +gs.SVBIPayloadEnable =
> > _mesa_is_xfb_active_and_unpaused(ctx);
> > 
> > 
> > 
> >   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are
> > enabled as it
> > 
> >* was previously done for gen6.
> > 
> > -- 
> > 
> > 2.7.4
> > 
> > 
> > ___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-15 Thread andrey simiklit 
Hi all,

This workaround just helps me to avoid the graphical corruption on SNB but
I not sure is it good idea.

Regards,
Andrii.

On Wed, Aug 15, 2018 at 6:20 PM,  wrote:

> From: Andrii Simiklit 
>
> When the SVBI Payload Enable is false I guess the register R1.4
> which contains the Maximum Streamed Vertex Buffer Index is filled by zero
> and GS stops to write transform feedback when the transform feedback
> is not active.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
> Signed-off-by: Andrii Simiklit 
> ---
>  src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c
> b/src/mesa/drivers/dri/i965/genX_state_upload.c
> index ea5ad55..0f82500 100644
> --- a/src/mesa/drivers/dri/i965/genX_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
> @@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
>  #if GEN_GEN < 7
>   gs.SOStatisticsEnable = true;
>   if (gs_prog->info.has_transform_feedback_varyings)
> -gs.SVBIPayloadEnable = true;
> +gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
>
>   /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled
> as it
>* was previously done for gen6.
> --
> 2.7.4
>
>
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/gen6/xfb: handle case where transform feedback is not active

2018-08-15 Thread asimiklit . work 
From: Andrii Simiklit 

When the SVBI Payload Enable is false I guess the register R1.4
which contains the Maximum Streamed Vertex Buffer Index is filled by zero
and GS stops to write transform feedback when the transform feedback 
is not active.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579
Signed-off-by: Andrii Simiklit 
---
 src/mesa/drivers/dri/i965/genX_state_upload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c 
b/src/mesa/drivers/dri/i965/genX_state_upload.c
index ea5ad55..0f82500 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -2806,7 +2806,7 @@ genX(upload_gs_state)(struct brw_context *brw)
 #if GEN_GEN < 7
  gs.SOStatisticsEnable = true;
  if (gs_prog->info.has_transform_feedback_varyings)
-gs.SVBIPayloadEnable = true;
+gs.SVBIPayloadEnable = _mesa_is_xfb_active_and_unpaused(ctx);
 
  /* GEN6_GS_SPF_MODE and GEN6_GS_VECTOR_MASK_ENABLE are enabled as it
   * was previously done for gen6.
-- 
2.7.4

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev