Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Vedran Miletic]

On 05/22/2016 10:13 PM, Giuseppe Bilotta wrote:

On Sun, May 22, 2016 at 1:08 PM, Serge Martin  wrote:


Mesa or MESA spelling shouldn't be an issue. And that would be coherent with
CL_PLATFORM_VENDOR that is returning "Mesa"


Excellent. I'll unify the version string suffix to the title-cased version.



Very nice.


Second question: shall I squash the introduction of the SHA1 in Clover
with the introduction of the LLVM version everywhere, or should I keep
those as separate patches?


I have no opinion on that.


I think I'll rework the thing as two separate patches (one to define
the version string suffix in a single place, the other to add LLVM
version to it).



Looking forward to reviewing these.

Regards,
Vedran

--
Vedran Miletić
vedran.miletic.net
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Giuseppe Bilotta]

On Sun, May 22, 2016 at 1:08 PM, Serge Martin  wrote:
>
> Mesa or MESA spelling shouldn't be an issue. And that would be coherent with
> CL_PLATFORM_VENDOR that is returning "Mesa"

Excellent. I'll unify the version string suffix to the title-cased version.

>> Second question: shall I squash the introduction of the SHA1 in Clover
>> with the introduction of the LLVM version everywhere, or should I keep
>> those as separate patches?
>
> I have no opinion on that.

I think I'll rework the thing as two separate patches (one to define
the version string suffix in a single place, the other to add LLVM
version to it).

Best regards,

-- 
Giuseppe "Oblomov" Bilotta
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Serge Martin]

On Tuesday 17 May 2016 22:54:01 Giuseppe Bilotta wrote:
> On Sun, May 15, 2016 at 10:54 PM, Giuseppe Bilotta
> 
>  wrote:
> > On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić  wrote:
> >> How about also adding Mesa git version, like "OpenGL core profile
> >> version string" has now?
> > 
> > That's probably a good idea. Conversely, would it be sensible to add
> > the LLVM version string to the OpenGL version string too? Maybe the
> > entire suffix vendor string could be unified across GL and CL?
> 
> Ok, unification of the version string would actually cause a small
> issue due to the fact that in OpenGL we use the spelling "Mesa",
> whereas in clover for some reason we use "MESA". It should be
> relatively safe to change the OpenCL spelling to match the OpenGL
> spelling (I'm not aware of any software that explicitly does things
> differently on detecting Clover checking for the version string) or
> just keep it separate?

Mesa or MESA spelling shouldn't be an issue. And that would be coherent with 
CL_PLATFORM_VENDOR that is returning "Mesa"

> 
> Second question: shall I squash the introduction of the SHA1 in Clover
> with the introduction of the LLVM version everywhere, or should I keep
> those as separate patches?

I have no opinion on that.

 - Serge

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Giuseppe Bilotta]

On Sun, May 15, 2016 at 10:54 PM, Giuseppe Bilotta
 wrote:
> On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić  wrote:
>
>> How about also adding Mesa git version, like "OpenGL core profile
>> version string" has now?
>
> That's probably a good idea. Conversely, would it be sensible to add
> the LLVM version string to the OpenGL version string too? Maybe the
> entire suffix vendor string could be unified across GL and CL?

Ok, unification of the version string would actually cause a small
issue due to the fact that in OpenGL we use the spelling "Mesa",
whereas in clover for some reason we use "MESA". It should be
relatively safe to change the OpenCL spelling to match the OpenGL
spelling (I'm not aware of any software that explicitly does things
differently on detecting Clover checking for the version string) or
just keep it separate?

Second question: shall I squash the introduction of the SHA1 in Clover
with the introduction of the LLVM version everywhere, or should I keep
those as separate patches?

-- 
Giuseppe "Oblomov" Bilotta
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Giuseppe Bilotta]

On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić  wrote:
> 2016-05-15 3:32 GMT+02:00 Francisco Jerez :
>> Giuseppe Bilotta  writes:
>>
>>> Code generation (kernel compilation) may sometimes hit LLVM-specific
>>> bugs. Adding the used LLVM version to the version string may make bug
>>> triaging easier.
>>>
>>> Signed-off-by: Giuseppe Bilotta 
>>
>> Acked-by: Francisco Jerez 
>>
>
> Acked-by: Vedran Miletić 
>
> How about also adding Mesa git version, like "OpenGL core profile
> version string" has now?

That's probably a good idea. Conversely, would it be sensible to add
the LLVM version string to the OpenGL version string too? Maybe the
entire suffix vendor string could be unified across GL and CL?

-- 
Giuseppe "Oblomov" Bilotta
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Vedran Miletić]

2016-05-15 3:32 GMT+02:00 Francisco Jerez :
> Giuseppe Bilotta  writes:
>
>> Code generation (kernel compilation) may sometimes hit LLVM-specific
>> bugs. Adding the used LLVM version to the version string may make bug
>> triaging easier.
>>
>> Signed-off-by: Giuseppe Bilotta 
>
> Acked-by: Francisco Jerez 
>

Acked-by: Vedran Miletić 

How about also adding Mesa git version, like "OpenGL core profile
version string" has now?

Regards,
Vedran

-- 
Vedran Miletić
http://vedranmileti.ch/
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Francisco Jerez]

Giuseppe Bilotta  writes:

> Code generation (kernel compilation) may sometimes hit LLVM-specific
> bugs. Adding the used LLVM version to the version string may make bug
> triaging easier.
>
> Signed-off-by: Giuseppe Bilotta 

Acked-by: Francisco Jerez 

> ---
>  configure.ac   | 2 +-
>  src/gallium/state_trackers/clover/api/device.cpp   | 2 +-
>  src/gallium/state_trackers/clover/api/platform.cpp | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> I believe similar additions could be made for OpenGL version strings as well.
>
> diff --git a/configure.ac b/configure.ac
> index 023110e..4fcadcf 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2116,7 +2116,7 @@ if test "x$enable_gallium_llvm" = xyes; then
>  LLVM_COMPONENTS="${LLVM_COMPONENTS} all-targets ipo linker 
> instrumentation"
>  LLVM_COMPONENTS="${LLVM_COMPONENTS} irreader option objcarcopts 
> profiledata"
>  fi
> -DEFINES="${DEFINES} -DHAVE_LLVM=0x0$LLVM_VERSION_INT 
> -DMESA_LLVM_VERSION_PATCH=$LLVM_VERSION_PATCH"
> +DEFINES="${DEFINES} -DHAVE_LLVM=0x0$LLVM_VERSION_INT 
> -DMESA_LLVM_VERSION_PATCH=$LLVM_VERSION_PATCH 
> '-DMESA_LLVM_VERSION_STRING=\"$LLVM_VERSION_MAJOR.$LLVM_VERSION_MINOR.$LLVM_VERSION_PATCH\"'"
>  MESA_LLVM=1
>  
>  dnl Check for Clang internal headers
> diff --git a/src/gallium/state_trackers/clover/api/device.cpp 
> b/src/gallium/state_trackers/clover/api/device.cpp
> index bc93f91..0d0f77b 100644
> --- a/src/gallium/state_trackers/clover/api/device.cpp
> +++ b/src/gallium/state_trackers/clover/api/device.cpp
> @@ -300,7 +300,7 @@ clGetDeviceInfo(cl_device_id d_dev, cl_device_info param,
>break;
>  
> case CL_DEVICE_VERSION:
> -  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION;
> +  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION " LLVM " 
> MESA_LLVM_VERSION_STRING;
>break;
>  
> case CL_DEVICE_EXTENSIONS:
> diff --git a/src/gallium/state_trackers/clover/api/platform.cpp 
> b/src/gallium/state_trackers/clover/api/platform.cpp
> index cf71593..06eb4ec 100644
> --- a/src/gallium/state_trackers/clover/api/platform.cpp
> +++ b/src/gallium/state_trackers/clover/api/platform.cpp
> @@ -57,7 +57,7 @@ clover::GetPlatformInfo(cl_platform_id d_platform, 
> cl_platform_info param,
>break;
>  
> case CL_PLATFORM_VERSION:
> -  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION;
> +  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION " LLVM " 
> MESA_LLVM_VERSION_STRING;
>break;
>  
> case CL_PLATFORM_NAME:
> -- 
> 2.8.1.372.g9612035
>
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

[Giuseppe Bilotta]

Code generation (kernel compilation) may sometimes hit LLVM-specific
bugs. Adding the used LLVM version to the version string may make bug
triaging easier.

Signed-off-by: Giuseppe Bilotta 
---
 configure.ac   | 2 +-
 src/gallium/state_trackers/clover/api/device.cpp   | 2 +-
 src/gallium/state_trackers/clover/api/platform.cpp | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)


I believe similar additions could be made for OpenGL version strings as well.

diff --git a/configure.ac b/configure.ac
index 023110e..4fcadcf 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2116,7 +2116,7 @@ if test "x$enable_gallium_llvm" = xyes; then
 LLVM_COMPONENTS="${LLVM_COMPONENTS} all-targets ipo linker 
instrumentation"
 LLVM_COMPONENTS="${LLVM_COMPONENTS} irreader option objcarcopts 
profiledata"
 fi
-DEFINES="${DEFINES} -DHAVE_LLVM=0x0$LLVM_VERSION_INT 
-DMESA_LLVM_VERSION_PATCH=$LLVM_VERSION_PATCH"
+DEFINES="${DEFINES} -DHAVE_LLVM=0x0$LLVM_VERSION_INT 
-DMESA_LLVM_VERSION_PATCH=$LLVM_VERSION_PATCH 
'-DMESA_LLVM_VERSION_STRING=\"$LLVM_VERSION_MAJOR.$LLVM_VERSION_MINOR.$LLVM_VERSION_PATCH\"'"
 MESA_LLVM=1
 
 dnl Check for Clang internal headers
diff --git a/src/gallium/state_trackers/clover/api/device.cpp 
b/src/gallium/state_trackers/clover/api/device.cpp
index bc93f91..0d0f77b 100644
--- a/src/gallium/state_trackers/clover/api/device.cpp
+++ b/src/gallium/state_trackers/clover/api/device.cpp
@@ -300,7 +300,7 @@ clGetDeviceInfo(cl_device_id d_dev, cl_device_info param,
   break;
 
case CL_DEVICE_VERSION:
-  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION;
+  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION " LLVM " 
MESA_LLVM_VERSION_STRING;
   break;
 
case CL_DEVICE_EXTENSIONS:
diff --git a/src/gallium/state_trackers/clover/api/platform.cpp 
b/src/gallium/state_trackers/clover/api/platform.cpp
index cf71593..06eb4ec 100644
--- a/src/gallium/state_trackers/clover/api/platform.cpp
+++ b/src/gallium/state_trackers/clover/api/platform.cpp
@@ -57,7 +57,7 @@ clover::GetPlatformInfo(cl_platform_id d_platform, 
cl_platform_info param,
   break;
 
case CL_PLATFORM_VERSION:
-  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION;
+  buf.as_string() = "OpenCL 1.1 MESA " PACKAGE_VERSION " LLVM " 
MESA_LLVM_VERSION_STRING;
   break;
 
case CL_PLATFORM_NAME:
-- 
2.8.1.372.g9612035

___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev