Re: Lavapipe performance question during interactive drawing

2023-05-08 Thread George Karpathios
Hi Dave,

Indeed after setting LP_DEBUG=fs I get a lot of repetitive printing during
the interactive actions. After some more searching it finally seems that
the problem is on our side, which forces some pipelines to be continuously
re-created.
Thanks everyone for your help, and I apologize for the confusion and the
hassle. :/

Best regards,
George


On Fri, May 5, 2023 at 11:14 PM Dave Airlie  wrote:

> On Fri, 5 May 2023 at 21:30, George Karpathios  wrote:
> >
> > Hi list,
> >
> > I'm using Lavapipe for Vulkan software rendering support in a modeling
> application. I notice a large performance hit (with any Mesa version) in
> the following scenario: The user clicks & drags the mouse in order to
> create a simple shape (e.g. plane, cube, sphere) dynamically and the result
> is being rendered (basic gray shading) in real-time alongside the movement
> of the mouse. Lavapipe seems to be struggling a bit to keep up with this
> action as the frame time goes up to over 1 second. On the other hand, on a
> more "static" scene I can get great fps (30-60) while panning/rotating a
> scene, after Mike Blumenkrantz's recent improvements (many thanks for those
> again!).
> >
> > I've uploaded a screenshot of the VS profiler showing the hot path at
> https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts on
> this. Thanks once more for your time.
>
> That's a lot of fragment shader recompiles in llvmpipe_update_fs,
> LP_DEBUG=fs might give some more info if you have a debug build of
> mes.
>
> Dave.
>


Re: Lavapipe performance question during interactive drawing

2023-05-05 Thread Dave Airlie
On Fri, 5 May 2023 at 21:30, George Karpathios  wrote:
>
> Hi list,
>
> I'm using Lavapipe for Vulkan software rendering support in a modeling 
> application. I notice a large performance hit (with any Mesa version) in the 
> following scenario: The user clicks & drags the mouse in order to create a 
> simple shape (e.g. plane, cube, sphere) dynamically and the result is being 
> rendered (basic gray shading) in real-time alongside the movement of the 
> mouse. Lavapipe seems to be struggling a bit to keep up with this action as 
> the frame time goes up to over 1 second. On the other hand, on a more 
> "static" scene I can get great fps (30-60) while panning/rotating a scene, 
> after Mike Blumenkrantz's recent improvements (many thanks for those again!).
>
> I've uploaded a screenshot of the VS profiler showing the hot path at 
> https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts on 
> this. Thanks once more for your time.

That's a lot of fragment shader recompiles in llvmpipe_update_fs,
LP_DEBUG=fs might give some more info if you have a debug build of
mes.

Dave.


Re: Lavapipe performance question during interactive drawing

2023-05-05 Thread Mike Blumenkrantz
Anything as long as it exhibits the issue.

On Fri, May 5, 2023 at 11:52 AM George Karpathios  wrote:

> Not sure, I may have to get approval first. Will see what I can do. If so,
> are there any specific options you'd like enabled? Thanks
>
> Best regards,
> George
>
> On Fri, May 5, 2023 at 5:33 PM Mike Blumenkrantz <
> michael.blumenkra...@gmail.com> wrote:
>
>> Can you provide a gfxreconstruct of the scenario?
>>
>> On Fri, May 5, 2023 at 10:32 AM George Karpathios 
>> wrote:
>>
>>> Hi Mike,
>>>
>>> Thanks for responding. I commented the call
>>> to lvp_find_inlinable_uniforms() in lvp_pipeline.c but unfortunately it
>>> didn't help this time. It may have gotten a bit worse actually.
>>>
>>> Best regards,
>>> George
>>>
>>>
>>> On Fri, May 5, 2023 at 3:08 PM Mike Blumenkrantz <
>>> michael.blumenkra...@gmail.com> wrote:
>>>
 Hi,

 Can you try commenting out the same lines from last time and see
 whether that affects anything?


 Mike

 On Fri, May 5, 2023 at 7:30 AM George Karpathios 
 wrote:

> Hi list,
>
> I'm using Lavapipe for Vulkan software rendering support in a modeling
> application. I notice a large performance hit (with any Mesa version) in
> the following scenario: The user clicks & drags the mouse in order to
> create a simple shape (e.g. plane, cube, sphere) dynamically and the 
> result
> is being rendered (basic gray shading) in real-time alongside the movement
> of the mouse. Lavapipe seems to be struggling a bit to keep up with this
> action as the frame time goes up to over 1 second. On the other hand, on a
> more "static" scene I can get great fps (30-60) while panning/rotating a
> scene, after Mike Blumenkrantz's recent improvements (many thanks for 
> those
> again!).
>
> I've uploaded a screenshot of the VS profiler showing the hot path at
> https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts
> on this. Thanks once more for your time.
>
> Best regards,
> George
>



Re: Lavapipe performance question during interactive drawing

2023-05-05 Thread George Karpathios
Not sure, I may have to get approval first. Will see what I can do. If so,
are there any specific options you'd like enabled? Thanks

Best regards,
George

On Fri, May 5, 2023 at 5:33 PM Mike Blumenkrantz <
michael.blumenkra...@gmail.com> wrote:

> Can you provide a gfxreconstruct of the scenario?
>
> On Fri, May 5, 2023 at 10:32 AM George Karpathios 
> wrote:
>
>> Hi Mike,
>>
>> Thanks for responding. I commented the call
>> to lvp_find_inlinable_uniforms() in lvp_pipeline.c but unfortunately it
>> didn't help this time. It may have gotten a bit worse actually.
>>
>> Best regards,
>> George
>>
>>
>> On Fri, May 5, 2023 at 3:08 PM Mike Blumenkrantz <
>> michael.blumenkra...@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> Can you try commenting out the same lines from last time and see whether
>>> that affects anything?
>>>
>>>
>>> Mike
>>>
>>> On Fri, May 5, 2023 at 7:30 AM George Karpathios 
>>> wrote:
>>>
 Hi list,

 I'm using Lavapipe for Vulkan software rendering support in a modeling
 application. I notice a large performance hit (with any Mesa version) in
 the following scenario: The user clicks & drags the mouse in order to
 create a simple shape (e.g. plane, cube, sphere) dynamically and the result
 is being rendered (basic gray shading) in real-time alongside the movement
 of the mouse. Lavapipe seems to be struggling a bit to keep up with this
 action as the frame time goes up to over 1 second. On the other hand, on a
 more "static" scene I can get great fps (30-60) while panning/rotating a
 scene, after Mike Blumenkrantz's recent improvements (many thanks for those
 again!).

 I've uploaded a screenshot of the VS profiler showing the hot path at
 https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts
 on this. Thanks once more for your time.

 Best regards,
 George

>>>


Re: Lavapipe performance question during interactive drawing

2023-05-05 Thread Mike Blumenkrantz
Can you provide a gfxreconstruct of the scenario?

On Fri, May 5, 2023 at 10:32 AM George Karpathios  wrote:

> Hi Mike,
>
> Thanks for responding. I commented the call
> to lvp_find_inlinable_uniforms() in lvp_pipeline.c but unfortunately it
> didn't help this time. It may have gotten a bit worse actually.
>
> Best regards,
> George
>
>
> On Fri, May 5, 2023 at 3:08 PM Mike Blumenkrantz <
> michael.blumenkra...@gmail.com> wrote:
>
>> Hi,
>>
>> Can you try commenting out the same lines from last time and see whether
>> that affects anything?
>>
>>
>> Mike
>>
>> On Fri, May 5, 2023 at 7:30 AM George Karpathios 
>> wrote:
>>
>>> Hi list,
>>>
>>> I'm using Lavapipe for Vulkan software rendering support in a modeling
>>> application. I notice a large performance hit (with any Mesa version) in
>>> the following scenario: The user clicks & drags the mouse in order to
>>> create a simple shape (e.g. plane, cube, sphere) dynamically and the result
>>> is being rendered (basic gray shading) in real-time alongside the movement
>>> of the mouse. Lavapipe seems to be struggling a bit to keep up with this
>>> action as the frame time goes up to over 1 second. On the other hand, on a
>>> more "static" scene I can get great fps (30-60) while panning/rotating a
>>> scene, after Mike Blumenkrantz's recent improvements (many thanks for those
>>> again!).
>>>
>>> I've uploaded a screenshot of the VS profiler showing the hot path at
>>> https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts
>>> on this. Thanks once more for your time.
>>>
>>> Best regards,
>>> George
>>>
>>


Re: Lavapipe performance question during interactive drawing

2023-05-05 Thread George Karpathios
Hi Mike,

Thanks for responding. I commented the call
to lvp_find_inlinable_uniforms() in lvp_pipeline.c but unfortunately it
didn't help this time. It may have gotten a bit worse actually.

Best regards,
George


On Fri, May 5, 2023 at 3:08 PM Mike Blumenkrantz <
michael.blumenkra...@gmail.com> wrote:

> Hi,
>
> Can you try commenting out the same lines from last time and see whether
> that affects anything?
>
>
> Mike
>
> On Fri, May 5, 2023 at 7:30 AM George Karpathios 
> wrote:
>
>> Hi list,
>>
>> I'm using Lavapipe for Vulkan software rendering support in a modeling
>> application. I notice a large performance hit (with any Mesa version) in
>> the following scenario: The user clicks & drags the mouse in order to
>> create a simple shape (e.g. plane, cube, sphere) dynamically and the result
>> is being rendered (basic gray shading) in real-time alongside the movement
>> of the mouse. Lavapipe seems to be struggling a bit to keep up with this
>> action as the frame time goes up to over 1 second. On the other hand, on a
>> more "static" scene I can get great fps (30-60) while panning/rotating a
>> scene, after Mike Blumenkrantz's recent improvements (many thanks for those
>> again!).
>>
>> I've uploaded a screenshot of the VS profiler showing the hot path at
>> https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts on
>> this. Thanks once more for your time.
>>
>> Best regards,
>> George
>>
>


Re: Lavapipe performance question during interactive drawing

2023-05-05 Thread Mike Blumenkrantz
Hi,

Can you try commenting out the same lines from last time and see whether
that affects anything?


Mike

On Fri, May 5, 2023 at 7:30 AM George Karpathios  wrote:

> Hi list,
>
> I'm using Lavapipe for Vulkan software rendering support in a modeling
> application. I notice a large performance hit (with any Mesa version) in
> the following scenario: The user clicks & drags the mouse in order to
> create a simple shape (e.g. plane, cube, sphere) dynamically and the result
> is being rendered (basic gray shading) in real-time alongside the movement
> of the mouse. Lavapipe seems to be struggling a bit to keep up with this
> action as the frame time goes up to over 1 second. On the other hand, on a
> more "static" scene I can get great fps (30-60) while panning/rotating a
> scene, after Mike Blumenkrantz's recent improvements (many thanks for those
> again!).
>
> I've uploaded a screenshot of the VS profiler showing the hot path at
> https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts on
> this. Thanks once more for your time.
>
> Best regards,
> George
>


Lavapipe performance question during interactive drawing

2023-05-05 Thread George Karpathios
Hi list,

I'm using Lavapipe for Vulkan software rendering support in a modeling
application. I notice a large performance hit (with any Mesa version) in
the following scenario: The user clicks & drags the mouse in order to
create a simple shape (e.g. plane, cube, sphere) dynamically and the result
is being rendered (basic gray shading) in real-time alongside the movement
of the mouse. Lavapipe seems to be struggling a bit to keep up with this
action as the frame time goes up to over 1 second. On the other hand, on a
more "static" scene I can get great fps (30-60) while panning/rotating a
scene, after Mike Blumenkrantz's recent improvements (many thanks for those
again!).

I've uploaded a screenshot of the VS profiler showing the hot path at
https://imgur.com/a/qZBkB51  and I'd appreciate hearing your thoughts on
this. Thanks once more for your time.

Best regards,
George