Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On 06/16/2017 06:25 AM, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by freedreno at least for GLES3 support. >>> >>> See docs/patents.txt for information about turning this on for s/w >>> renderers. >>> >> I'm inclined to agree with Tapani. We're not lawyers and with the >> patent expiring in half a year, I think we can defer this toggle to >> builders and their legal teams ;-) >> > > Not really sure what msg from Tapani you are referring to. But tbh, > what we really want is a separate option for sw renderers. As far as I'm aware, when SGI still existed, their position was that the patent didn't even apply to software renderers. I *thought* Dave added the option because he didn't want Red Hat to be exposed if whoever owned the IP got sue happy about enabling a hardware implementation (i.e., contributory infringement). > I'm not sure if there is any use to build swrast/llvmpipe for android > build, so maybe the thing to do is remove them (if they are built for > android currently), and then enable texture-float. > BR, > -R > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On 06/15/2017 01:47 PM, Robert Foss wrote: > From: Rob Herring > > This is required by freedreno at least for GLES3 support. > > See docs/patents.txt for information about turning this on for s/w > renderers. If I'm not mistaken (I'm not a lawyer, and I don't play one on TV), that patent is going to expire at about this time next year! > Signed-off-by: Rob Herring > --- > Android.common.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Android.common.mk b/Android.common.mk > index 6bd30816bc..6f93c828b0 100644 > --- a/Android.common.mk > +++ b/Android.common.mk > @@ -67,6 +67,7 @@ LOCAL_CFLAGS += \ > -DHAVE_DLOPEN \ > -DHAVE_DL_ITERATE_PHDR \ > -DMAJOR_IN_SYSMACROS \ > + -DTEXTURE_FLOAT_ENABLED \ > -fvisibility=hidden \ > -Wno-sign-compare > > ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On 16 June 2017 at 15:45, Matt Turner wrote: > On Fri, Jun 16, 2017 at 6:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by freedreno at least for GLES3 support. >>> >>> See docs/patents.txt for information about turning this on for s/w >>> renderers. >>> >> I'm inclined to agree with Tapani. We're not lawyers and with the >> patent expiring in half a year, I think we can defer this toggle to >> builders and their legal teams ;-) > > It's not expiring in half a year. > > ARB_texture_float references US Patent #6,650,327 [1]: which was filed > June 16 1998. > > According to [2], the patent expires 20 years from the filing date, > giving an expiration of June 17 2018. So, 1 year and 1 day. > > And for good measure, the patent on S3TC [3] expires Oct 2 2017. I > think we should have a party :) > Apologies for the mix up and thanks for the correction Matt. A S3TC goodbye party sounds like a plan ;-) -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On Fri, Jun 16, 2017 at 6:18 AM, Emil Velikov wrote: > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> This is required by freedreno at least for GLES3 support. >> >> See docs/patents.txt for information about turning this on for s/w >> renderers. >> > I'm inclined to agree with Tapani. We're not lawyers and with the > patent expiring in half a year, I think we can defer this toggle to > builders and their legal teams ;-) It's not expiring in half a year. ARB_texture_float references US Patent #6,650,327 [1]: which was filed June 16 1998. According to [2], the patent expires 20 years from the filing date, giving an expiration of June 17 2018. So, 1 year and 1 day. And for good measure, the patent on S3TC [3] expires Oct 2 2017. I think we should have a party :) [1] https://www.google.com/patents/US6650327 [2] https://en.wikipedia.org/wiki/Term_of_patent_in_the_United_States [3] https://www.google.com/patents/US6775417 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On 16 June 2017 at 15:30, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:49 AM, Emil Velikov > wrote: >> On 16 June 2017 at 14:25, Rob Clark wrote: >>> On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov >>> wrote: On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > This is required by freedreno at least for GLES3 support. > > See docs/patents.txt for information about turning this on for s/w > renderers. > I'm inclined to agree with Tapani. We're not lawyers and with the patent expiring in half a year, I think we can defer this toggle to builders and their legal teams ;-) >>> >>> Not really sure what msg from Tapani you are referring to. But tbh, >>> what we really want is a separate option for sw renderers. >>> >> This quote from the cover letter >> "I'm not sure about patch to enable texture-float, should this be left >> as a 'policy decision' for end distribution, it's not enabled by >> default on desktop?" > > I think the only reason it isn't enabled by default is because > (currently) the same option covers both hw drivers and sw drivers. > Otoh, i965 ignores this option and always advertised texture-float. > > Anyways, if android has some way to conditionalize this based on some > var set in board file, that might be an option. Ideally I think we > want to get to the point where we can build android with upstream > mesa, without having to carry patches. > Fully support the zero patches topic. Yet since none of us is a lawyer so it's understandable to be cautious ;-) If people agree to enable it for non SW drivers, be that like i965 or otherwise, let's have that consistent across Mesa. Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On Fri, Jun 16, 2017 at 9:49 AM, Emil Velikov wrote: > On 16 June 2017 at 14:25, Rob Clark wrote: >> On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov >> wrote: >>> On 15 June 2017 at 21:47, Robert Foss wrote: From: Rob Herring This is required by freedreno at least for GLES3 support. See docs/patents.txt for information about turning this on for s/w renderers. >>> I'm inclined to agree with Tapani. We're not lawyers and with the >>> patent expiring in half a year, I think we can defer this toggle to >>> builders and their legal teams ;-) >>> >> >> Not really sure what msg from Tapani you are referring to. But tbh, >> what we really want is a separate option for sw renderers. >> > This quote from the cover letter > "I'm not sure about patch to enable texture-float, should this be left > as a 'policy decision' for end distribution, it's not enabled by > default on desktop?" I think the only reason it isn't enabled by default is because (currently) the same option covers both hw drivers and sw drivers. Otoh, i965 ignores this option and always advertised texture-float. Anyways, if android has some way to conditionalize this based on some var set in board file, that might be an option. Ideally I think we want to get to the point where we can build android with upstream mesa, without having to carry patches. BR, -R >> I'm not sure if there is any use to build swrast/llvmpipe for android >> build, so maybe the thing to do is remove them (if they are built for >> android currently), and then enable texture-float. >> > There was a similar idea on the autotools side, but it never really > got finished/ack/merged. > > I realise it's a tad annoying, but I'd just give it until the patent > expires and enable it everywhere - we could even fold the s3tc code > within mesa. > > -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On 16 June 2017 at 14:25, Rob Clark wrote: > On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov > wrote: >> On 15 June 2017 at 21:47, Robert Foss wrote: >>> From: Rob Herring >>> >>> This is required by freedreno at least for GLES3 support. >>> >>> See docs/patents.txt for information about turning this on for s/w >>> renderers. >>> >> I'm inclined to agree with Tapani. We're not lawyers and with the >> patent expiring in half a year, I think we can defer this toggle to >> builders and their legal teams ;-) >> > > Not really sure what msg from Tapani you are referring to. But tbh, > what we really want is a separate option for sw renderers. > This quote from the cover letter "I'm not sure about patch to enable texture-float, should this be left as a 'policy decision' for end distribution, it's not enabled by default on desktop?" > I'm not sure if there is any use to build swrast/llvmpipe for android > build, so maybe the thing to do is remove them (if they are built for > android currently), and then enable texture-float. > There was a similar idea on the autotools side, but it never really got finished/ack/merged. I realise it's a tad annoying, but I'd just give it until the patent expires and enable it everywhere - we could even fold the s3tc code within mesa. -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On Fri, Jun 16, 2017 at 9:18 AM, Emil Velikov wrote: > On 15 June 2017 at 21:47, Robert Foss wrote: >> From: Rob Herring >> >> This is required by freedreno at least for GLES3 support. >> >> See docs/patents.txt for information about turning this on for s/w >> renderers. >> > I'm inclined to agree with Tapani. We're not lawyers and with the > patent expiring in half a year, I think we can defer this toggle to > builders and their legal teams ;-) > Not really sure what msg from Tapani you are referring to. But tbh, what we really want is a separate option for sw renderers. I'm not sure if there is any use to build swrast/llvmpipe for android build, so maybe the thing to do is remove them (if they are built for android currently), and then enable texture-float. BR, -R ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Re: [Mesa-dev] [PATCH v1 5/7] android: enable texture-float
On 15 June 2017 at 21:47, Robert Foss wrote: > From: Rob Herring > > This is required by freedreno at least for GLES3 support. > > See docs/patents.txt for information about turning this on for s/w > renderers. > I'm inclined to agree with Tapani. We're not lawyers and with the patent expiring in half a year, I think we can defer this toggle to builders and their legal teams ;-) -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
