[meta-xilinx] microblazev8 tune problems

2017-04-28 Thread Mills, William
Hello,

I have been looking at microblaze as an example of how to add a new 
architecture to OE-core.
Right now I am on master for bitbake, oe-core, and meta-xilinx.

I have tried multiple MACHINEs but right now I am working with 
MACHINE=ml605-qemu-microblazeel
In this combination and others, I could not get the below code to work.

At first I thought it was because it used the older syntax but I tried changing 
w/o luck.
I then explored switching the 3 git repos to morty (bitbake 1.32) or krogoth 
(bitbake 1.30) and I could not 
find a winning combination.

As shown below I worked around it by just disabling this python fragment as it 
is not important to what I am doing.  
(And the existing "tune"'s enable both options anyway). 

I would be interested to understand what I was doing wrong anyway.

BTW: The comment above the code does not match what the code does IMHO.

Thanks,
Bill

diff --git a/conf/machine/include/microblaze/feature-microblaze-v8.inc 
b/conf/machine/include/microblaze/feature-microblaze-v8.inc
index 46a11cf..0251439 100644
--- a/conf/machine/include/microblaze/feature-microblaze-v8.inc
+++ b/conf/machine/include/microblaze/feature-microblaze-v8.inc
@@ -16,30 +16,30 @@ MBCCARGSVERSION += "${@bb.utils.contains("TUNE_FEATURES", 
"v8.20", "-mcpu=v8.20.
 MBPKGVERSION .= "${@bb.utils.contains("TUNE_FEATURES", "v8.20", "-v8.20", "" 
,d)}"
 
 TUNEVALID[v8.10] = "Use Microblaze version 8.10"
 MBCCARGSVERSION += "${@bb.utils.contains("TUNE_FEATURES", "v8.10", 
"-mcpu=v8.10.a", "" ,d)}"
 MBPKGVERSION .= "${@bb.utils.contains("TUNE_FEATURES", "v8.10", "-v8.10", "" 
,d)}"
 
 TUNEVALID[v8.00] = "Use Microblaze version 8.00"
 MBCCARGSVERSION += "${@bb.utils.contains("TUNE_FEATURES", "v8.00", 
"-mcpu=v8.00.a", "" ,d)}"
 MBPKGVERSION .= "${@bb.utils.contains("TUNE_FEATURES", "v8.00", "-v8.00", "" 
,d)}"
 
 TUNECONFLICTS[v8.00] += "reorder"
 TUNECONFLICTS[v8.10] += "reorder"
 TUNECONFLICTS[v8.20] += "reorder"
 
 # Perform some additional sanity checking
-python __anonymous () {
+python dontdo_this__anonymous () {
 import bb
 tune_features = bb.data.getVar('TUNE_FEATURES', d, 1)
 tuneslist = tune_features.split()
 
 #
 # GCC will fail on v8.30 if reorder and pattern-compare are not 
 # both in ccflags
 # -mxl-reorder requires -mxl-pattern-compare for -mcpu=v8.30.a
 # Check if either one exists alone and if so, add the other
 #
 if 'v8.30' in tuneslist:
 if 'reorder' in tuneslist and 'pattern-compare' not in tuneslist:
 d.setVar("TUNE_FEATURES", "%s pattern-compare" % tune_features)
 }
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx


Re: [meta-xilinx] [PATCH] machine-xilinx-default.inc: Default to u-boot for Zynq

2017-04-28 Thread Nathan Rossi
On 28 April 2017 at 05:13, Philip Balister  wrote:
> On 04/27/2017 12:59 PM, Mike Looijmans wrote:
>> On 27-04-17 16:11, Nathan Rossi wrote:
>> ...
>>> Looking at the differences, ignoring the obvious zynqmp/microblaze
>>> changes there are only a few features that are available in
>>> u-boot-xlnx that are not in mainline:
>>>  * partial bitstream loading support
>>>  * secure/encrypted bitstream loading support
>>>  * support for rsa verification of images
>>>  * board configs/devicetrees for various Xilinx internal boards
>>
>> You missed one: Dual-QSPI flash support. That only exists on
>> u-boot-xlnx, it never got implemented in a way acceptable to upstream.

Ah yes I did miss that, my bad. Fooled myself thinking it was working
when testing u-boot on a zc706.

>>
>> The same goes for the kernel. The only way to get dual-qspi flash to
>> work is to use the xlnx bootloader and kernel.
>
> But surely this could be handled as patches adding this feature to
> mainline, and not carrying a custom u-boot source tree forever.

There was a series sent for u-boot that adds this support, so applying
that series would work (even though the changes were not accepted).
(https://patchwork.ozlabs.org/patch/650100/)

Regards,
Nathan
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx