Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-29 Thread Manjukumar Harthikote Matha 
Hi Nathan,

> -Original Message-
> From: Nathan Rossi [mailto:nat...@nathanrossi.com]
> Sent: Thursday, April 19, 2018 5:04 AM
> To: Manjukumar Harthikote Matha 
> Cc: meta-xilinx@yoctoproject.org; Jeegar Patel ; Devarsh
> Thakkar 
> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] 
> recipes-multimedia/vcu/*.bb:
> Introduce hwcodec and required firmware, ko and software libraries for VCU
> 
> On 14 April 2018 at 06:20, Manjukumar Matha  ma...@xilinx.com> wrote:
> > From: Devarsh Thakkar 
> >
> > Add new recipes for the following:
> >
> > vcu-firmware_git.bb: Add a new recipe to fetch the required firmware
> > binaries for VCU
> >
> > kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module
> > required for VCU decoder, encoder. This is applicable to MPSoC EV
> > devices which support Video Codec Unit
> >
> > libvcu-xlnx_git.bb: Add a new recipe for control software libraries,
> > test applications and headers for VCU
> >
> > libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX
> > libraries, test applications and headers for VCU
> >
> > Signed-off-by: Devarsh Thakkar 
> > Signed-off-by: Jeegar Patel 
> > Tested-by: Maulik Desai 
> > Acked-by: Varunkumar Allagadapa 
> > Reviewed-by: Bhargava Sreekantappa Gayathri
> > 
> > Signed-off-by: Manjukumar Matha
> > 
> > ---
> >  .../vcu/kernel-module-vcu_git.bb   | 26 +
> >  .../recipes-multimedia/vcu/libomxil-xlnx_git.bb| 45 
> > ++
> >  .../recipes-multimedia/vcu/libvcu-xlnx_git.bb  | 37 ++
> >  .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++
> >  4 files changed, 145 insertions(+)
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb
> >
> > diff --git
> > a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > new file mode 100644
> > index 000..cfd99d9
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > @@ -0,0 +1,26 @@
> > +SUMMARY = "Linux kernel module for Video Code Unit"
> > +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel
> modules provider for MPSoC EV devices"
> > +SECTION = "kernel/modules"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM =
> "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a"
> > +
> > +XILINX_VCU_VERSION = "1.0.0"
> > +PV = "${XILINX_VCU_VERSION}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +BRANCH ?= "master"
> 
> Same comment as with the v2018.1 updates, avoid setting the branch unless it 
> is
> specifically needed.
> 
> > +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https"
> > +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e"
> 
> So I noticed most of these repos have the standard Xilinx release versioning, 
> e.g.
> xilinx-v201... tags. Should these recipes follow the same convention as the 
> other
> Xilinx trees? e.g. _2018.1.bb and have the PV =
> "${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just
> "${XILINX_RELEASE_VERSION}").
> 

The more I think about it, it is better to stick with recipes saying _git.bb 
and having PV = "${XILINX_VCU_VERSION} 
-xilinx-${XILINX_RELEASE_VERSION}+git${SRCPV}". This also follows upstream 
nomenclature of having recipes which use git as _git.bb 

I am also planning to change other recipes as well, no reason to deviate from 
upstream.

Thanks,
Manju
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Re: [meta-xilinx] Is qspi-nor flash broken in meta-xilinx layer for zcu102-zynqmp?

2018-04-29 Thread Mike Looijmans 
There were quite a few bugs in the QSPI support last year, I've sent 
patches to fix the ones I found on the 'regular' Zynq to Xilinx. Since 
the ZynqMP has a different controller than the Zynq, there may some 
similar leftover bugs in there as well.


The QSPI driver still has not been submitted into Linux mainline, which 
indicates the poor attention the driver has been receiving.


Side note: There's no point running both flash_erase and flashcp. The 
flashcp command will also erase before writing (otherwise, you wouln't 
need the command...). Either use flashcp, or use flash_erase followed by dd.


On 25-04-18 09:04, Martin Lund wrote:

Hi,

Is the qspi-nor flash feature broken in the meta-xilinx layer for zcu102-zynqmp 
?

We've been trying to test and verify the qspi-nor flash feature on a ZynqMP 
zcu102 rev 1.0 development board only to find out that basic reading/writing to 
the qspi-nor flash is failing.

We are building and testing with core-image-minimal on latest rocko branch 
(commit 7935ef724c, stock/clean meta-xilinx, no petalinux) with the following 
patch/fix added to avoid the zynqmp_clk_get_periphial_rate error which prevents 
the u-boot SPL from booting:
https://lists.yoctoproject.org/pipermail/meta-xilinx/2017-December/003464.html

This is how we test and see the qspi-flash fail:

root@zcu102-zynqmp:~# cat /proc/mtd
dev:size   erasesize  name
mtd0: 0010 2000 "qspi-fsbl-uboot"
mtd1: 0050 2000 "qspi-linux"
mtd2: 0002 2000 "qspi-device-tree"
mtd3: 005e 2000 "qspi-rootfs"

root@zcu102-zynqmp:~# flash_erase /dev/mtd3 0 0
Erasing 8 Kibyte @ 2000 --  0 % complete [  103.966880] random: crng init done
Erasing 8 Kibyte @ 5de000 -- 100 % complete

root@zcu102-zynqmp:~# dd if=/dev/urandom of=./sample.bin bs=1024 count=4096
4096+0 records in
4096+0 records out

root@zcu102-zynqmp:~# flashcp -v ./sample.bin /dev/mtd3
Erasing blocks: 512/512 (100%)
Writing data: 4096k/4096k (100%)
Verifying data: 10k/4096k (0%)File does not seem to match flash data. First 
mismatch at 0x-0x2800

Any ideas what might be wrong in the meta-xilinx layer that would make the 
qpsi-nor flash fail like that?

Thanks.

/Martin




--
Mike Looijmans


Kind regards,

Mike Looijmans
System Expert

TOPIC Products
Materiaalweg 4, NL-5681 RJ Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijm...@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail



--
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx