Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-30 Thread Jean-Francois Dagenais

> On Apr 30, 2018, at 3:30 AM, Nathan Rossi  wrote:
> 
> At the end of the day the filename matters very little assuming the PV
> is set in the recipe as that is the important value, especially for
> these recipes since its very likely there will only be one version
> available at a time. So you could just leave the version part of the
> recipe filename off entirely and just use e.g. "kernel-module-vcu.bb"
> (like kernel-module-mali).


I agree completely with Nathan here. Over time, we have also come to this exact
conclusion for our own private layers. Since we only carry one version at a time
of each of our recipes, and we set PV explicitly within each one, we keep the
_version.bb part completely out and only use recipe-name.bb.

Cheers!


-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx


Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-30 Thread Nathan Rossi
On 30 April 2018 at 14:36, Manjukumar Harthikote Matha
<manju...@xilinx.com> wrote:
> Hi Nathan,
>
>> -Original Message-
>> From: Nathan Rossi [mailto:nat...@nathanrossi.com]
>> Sent: Thursday, April 19, 2018 5:04 AM
>> To: Manjukumar Harthikote Matha <manju...@xilinx.com>
>> Cc: meta-xilinx@yoctoproject.org; Jeegar Patel <jeeg...@xilinx.com>; Devarsh
>> Thakkar <devar...@xilinx.com>
>> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] 
>> recipes-multimedia/vcu/*.bb:
>> Introduce hwcodec and required firmware, ko and software libraries for VCU
>>
>> On 14 April 2018 at 06:20, Manjukumar Matha > ma...@xilinx.com> wrote:
>> > From: Devarsh Thakkar <devar...@xilinx.com>
>> >
>> > Add new recipes for the following:
>> >
>> > vcu-firmware_git.bb: Add a new recipe to fetch the required firmware
>> > binaries for VCU
>> >
>> > kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module
>> > required for VCU decoder, encoder. This is applicable to MPSoC EV
>> > devices which support Video Codec Unit
>> >
>> > libvcu-xlnx_git.bb: Add a new recipe for control software libraries,
>> > test applications and headers for VCU
>> >
>> > libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX
>> > libraries, test applications and headers for VCU
>> >
>> > Signed-off-by: Devarsh Thakkar <devar...@xilinx.com>
>> > Signed-off-by: Jeegar Patel <jeegar.pa...@xilinx.com>
>> > Tested-by: Maulik Desai <maulik.de...@xilinx.com>
>> > Acked-by: Varunkumar Allagadapa <varun...@xilinx.com>
>> > Reviewed-by: Bhargava Sreekantappa Gayathri
>> > <bhargava.sreekantappa-gayat...@xilinx.com>
>> > Signed-off-by: Manjukumar Matha
>> > <manjukumar.harthikote-ma...@xilinx.com>
>> > ---
>> >  .../vcu/kernel-module-vcu_git.bb   | 26 +
>> >  .../recipes-multimedia/vcu/libomxil-xlnx_git.bb| 45 
>> > ++
>> >  .../recipes-multimedia/vcu/libvcu-xlnx_git.bb  | 37 ++
>> >  .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++
>> >  4 files changed, 145 insertions(+)
>> >  create mode 100644
>> > meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
>> >  create mode 100644
>> > meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
>> >  create mode 100644
>> > meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
>> >  create mode 100644
>> > meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb
>> >
>> > diff --git
>> > a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
>> > b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
>> > new file mode 100644
>> > index 000..cfd99d9
>> > --- /dev/null
>> > +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
>> > @@ -0,0 +1,26 @@
>> > +SUMMARY = "Linux kernel module for Video Code Unit"
>> > +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel
>> modules provider for MPSoC EV devices"
>> > +SECTION = "kernel/modules"
>> > +LICENSE = "GPLv2"
>> > +LIC_FILES_CHKSUM =
>> "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a"
>> > +
>> > +XILINX_VCU_VERSION = "1.0.0"
>> > +PV = "${XILINX_VCU_VERSION}"
>> > +
>> > +S = "${WORKDIR}/git"
>> > +
>> > +BRANCH ?= "master"
>>
>> Same comment as with the v2018.1 updates, avoid setting the branch unless it 
>> is
>> specifically needed.
>>
>> > +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https"
>> > +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e"
>>
>> So I noticed most of these repos have the standard Xilinx release 
>> versioning, e.g.
>> xilinx-v201... tags. Should these recipes follow the same convention as the 
>> other
>> Xilinx trees? e.g. _2018.1.bb and have the PV =
>> "${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just
>> "${XILINX_RELEASE_VERSION}").
>>
>
> The more I think about it, it is better to stick with recipes saying _git.bb 
> and having PV = "${XILINX_VCU_VERSION} 
> -xilinx-${XILINX_RELEASE_VERSION}+git${SRCPV}". This also follows upstream 
> nomenclature of hav

Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-29 Thread Manjukumar Harthikote Matha
Hi Nathan,

> -Original Message-
> From: Nathan Rossi [mailto:nat...@nathanrossi.com]
> Sent: Thursday, April 19, 2018 5:04 AM
> To: Manjukumar Harthikote Matha <manju...@xilinx.com>
> Cc: meta-xilinx@yoctoproject.org; Jeegar Patel <jeeg...@xilinx.com>; Devarsh
> Thakkar <devar...@xilinx.com>
> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] 
> recipes-multimedia/vcu/*.bb:
> Introduce hwcodec and required firmware, ko and software libraries for VCU
> 
> On 14 April 2018 at 06:20, Manjukumar Matha  ma...@xilinx.com> wrote:
> > From: Devarsh Thakkar <devar...@xilinx.com>
> >
> > Add new recipes for the following:
> >
> > vcu-firmware_git.bb: Add a new recipe to fetch the required firmware
> > binaries for VCU
> >
> > kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module
> > required for VCU decoder, encoder. This is applicable to MPSoC EV
> > devices which support Video Codec Unit
> >
> > libvcu-xlnx_git.bb: Add a new recipe for control software libraries,
> > test applications and headers for VCU
> >
> > libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX
> > libraries, test applications and headers for VCU
> >
> > Signed-off-by: Devarsh Thakkar <devar...@xilinx.com>
> > Signed-off-by: Jeegar Patel <jeegar.pa...@xilinx.com>
> > Tested-by: Maulik Desai <maulik.de...@xilinx.com>
> > Acked-by: Varunkumar Allagadapa <varun...@xilinx.com>
> > Reviewed-by: Bhargava Sreekantappa Gayathri
> > <bhargava.sreekantappa-gayat...@xilinx.com>
> > Signed-off-by: Manjukumar Matha
> > <manjukumar.harthikote-ma...@xilinx.com>
> > ---
> >  .../vcu/kernel-module-vcu_git.bb   | 26 +
> >  .../recipes-multimedia/vcu/libomxil-xlnx_git.bb| 45 
> > ++
> >  .../recipes-multimedia/vcu/libvcu-xlnx_git.bb  | 37 ++
> >  .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++
> >  4 files changed, 145 insertions(+)
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb
> >
> > diff --git
> > a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > new file mode 100644
> > index 000..cfd99d9
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > @@ -0,0 +1,26 @@
> > +SUMMARY = "Linux kernel module for Video Code Unit"
> > +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel
> modules provider for MPSoC EV devices"
> > +SECTION = "kernel/modules"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM =
> "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a"
> > +
> > +XILINX_VCU_VERSION = "1.0.0"
> > +PV = "${XILINX_VCU_VERSION}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +BRANCH ?= "master"
> 
> Same comment as with the v2018.1 updates, avoid setting the branch unless it 
> is
> specifically needed.
> 
> > +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https"
> > +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e"
> 
> So I noticed most of these repos have the standard Xilinx release versioning, 
> e.g.
> xilinx-v201... tags. Should these recipes follow the same convention as the 
> other
> Xilinx trees? e.g. _2018.1.bb and have the PV =
> "${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just
> "${XILINX_RELEASE_VERSION}").
> 

The more I think about it, it is better to stick with recipes saying _git.bb 
and having PV = "${XILINX_VCU_VERSION} 
-xilinx-${XILINX_RELEASE_VERSION}+git${SRCPV}". This also follows upstream 
nomenclature of having recipes which use git as _git.bb 

I am also planning to change other recipes as well, no reason to deviate from 
upstream.

Thanks,
Manju
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx


Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-19 Thread Manjukumar Harthikote Matha
Hi Nathan,

> -Original Message-
> From: Nathan Rossi [mailto:nat...@nathanrossi.com]
> Sent: Thursday, April 19, 2018 5:04 AM
> To: Manjukumar Harthikote Matha <manju...@xilinx.com>
> Cc: meta-xilinx@yoctoproject.org; Jeegar Patel <jeeg...@xilinx.com>; Devarsh
> Thakkar <devar...@xilinx.com>
> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] 
> recipes-multimedia/vcu/*.bb:
> Introduce hwcodec and required firmware, ko and software libraries for VCU
> 
> On 14 April 2018 at 06:20, Manjukumar Matha  ma...@xilinx.com> wrote:
> > From: Devarsh Thakkar <devar...@xilinx.com>
> >
> > Add new recipes for the following:
> >
> > vcu-firmware_git.bb: Add a new recipe to fetch the required firmware
> > binaries for VCU
> >
> > kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module
> > required for VCU decoder, encoder. This is applicable to MPSoC EV
> > devices which support Video Codec Unit
> >
> > libvcu-xlnx_git.bb: Add a new recipe for control software libraries,
> > test applications and headers for VCU
> >
> > libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX
> > libraries, test applications and headers for VCU
> >
> > Signed-off-by: Devarsh Thakkar <devar...@xilinx.com>
> > Signed-off-by: Jeegar Patel <jeegar.pa...@xilinx.com>
> > Tested-by: Maulik Desai <maulik.de...@xilinx.com>
> > Acked-by: Varunkumar Allagadapa <varun...@xilinx.com>
> > Reviewed-by: Bhargava Sreekantappa Gayathri
> > <bhargava.sreekantappa-gayat...@xilinx.com>
> > Signed-off-by: Manjukumar Matha
> > <manjukumar.harthikote-ma...@xilinx.com>
> > ---
> >  .../vcu/kernel-module-vcu_git.bb   | 26 +
> >  .../recipes-multimedia/vcu/libomxil-xlnx_git.bb| 45
> ++
> >  .../recipes-multimedia/vcu/libvcu-xlnx_git.bb  | 37 ++
> >  .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++
> >  4 files changed, 145 insertions(+)
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
> >  create mode 100644
> > meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb
> >
> > diff --git
> > a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > new file mode 100644
> > index 000..cfd99d9
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> > @@ -0,0 +1,26 @@
> > +SUMMARY = "Linux kernel module for Video Code Unit"
> > +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel
> modules provider for MPSoC EV devices"
> > +SECTION = "kernel/modules"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM =
> "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a"
> > +
> > +XILINX_VCU_VERSION = "1.0.0"
> > +PV = "${XILINX_VCU_VERSION}"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +BRANCH ?= "master"
> 
> Same comment as with the v2018.1 updates, avoid setting the branch unless it 
> is
> specifically needed.
> 
> > +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https"
> > +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e"
> 
> So I noticed most of these repos have the standard Xilinx release versioning, 
> e.g.
> xilinx-v201... tags. Should these recipes follow the same convention as the 
> other
> Xilinx trees? e.g. _2018.1.bb and have the PV =
> "${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just
> "${XILINX_RELEASE_VERSION}").
> 


Will send a V2

Thanks,
Manju
-- 
___
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx


Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-19 Thread Nathan Rossi
On 14 April 2018 at 06:20, Manjukumar Matha
 wrote:
> From: Devarsh Thakkar 
>
> Add new recipes for the following:
>
> vcu-firmware_git.bb: Add a new recipe to fetch the required firmware
> binaries for VCU
>
> kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module
> required for VCU decoder, encoder. This is applicable to MPSoC EV
> devices which support Video Codec Unit
>
> libvcu-xlnx_git.bb: Add a new recipe for control software libraries,
> test applications and headers for VCU
>
> libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX
> libraries, test applications and headers for VCU
>
> Signed-off-by: Devarsh Thakkar 
> Signed-off-by: Jeegar Patel 
> Tested-by: Maulik Desai 
> Acked-by: Varunkumar Allagadapa 
> Reviewed-by: Bhargava Sreekantappa Gayathri 
> 
> Signed-off-by: Manjukumar Matha 
> ---
>  .../vcu/kernel-module-vcu_git.bb   | 26 +
>  .../recipes-multimedia/vcu/libomxil-xlnx_git.bb| 45 
> ++
>  .../recipes-multimedia/vcu/libvcu-xlnx_git.bb  | 37 ++
>  .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++
>  4 files changed, 145 insertions(+)
>  create mode 100644 
> meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
>  create mode 100644 
> meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
>  create mode 100644 meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
>  create mode 100644 meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb
>
> diff --git a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb 
> b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> new file mode 100644
> index 000..cfd99d9
> --- /dev/null
> +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
> @@ -0,0 +1,26 @@
> +SUMMARY = "Linux kernel module for Video Code Unit"
> +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel modules 
> provider for MPSoC EV devices"
> +SECTION = "kernel/modules"
> +LICENSE = "GPLv2"
> +LIC_FILES_CHKSUM = "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a"
> +
> +XILINX_VCU_VERSION = "1.0.0"
> +PV = "${XILINX_VCU_VERSION}"
> +
> +S = "${WORKDIR}/git"
> +
> +BRANCH ?= "master"

Same comment as with the v2018.1 updates, avoid setting the branch
unless it is specifically needed.

> +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https"
> +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e"

So I noticed most of these repos have the standard Xilinx release
versioning, e.g. xilinx-v201... tags. Should these recipes follow the
same convention as the other Xilinx trees? e.g. _2018.1.bb
and have the PV =
"${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just
"${XILINX_RELEASE_VERSION}").

Regards,
Nathan

> +
> +BRANCHARG = "${@['nobranch=1', 'branch=${BRANCH}'][d.getVar('BRANCH', True) 
> != '']}"
> +SRC_URI = "${REPO};${BRANCHARG}"
> +
> +inherit module
> +
> +EXTRA_OEMAKE += "O=${STAGING_KERNEL_BUILDDIR}"
> +
> +RDEPENDS_${PN} = "vcu-firmware"
> +
> +COMPATIBLE_MACHINE = "^$"
> +COMPATIBLE_MACHINE_zynqmp = "zynqmp"
> diff --git a/meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb 
> b/meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
> new file mode 100644
> index 000..0c5e5d4
> --- /dev/null
> +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
> @@ -0,0 +1,45 @@
> +SUMMARY = "OpenMAX Integration layer for VCU"
> +DESCRIPTION = "OMX IL Libraries,test applications and headers for VCU"
> +LICENSE = "Proprietary"
> +LIC_FILES_CHKSUM = "file://LICENSE.md;md5=03a7aef7e6f6a76a59fd9b8ba450b493"
> +
> +BRANCH ?= "master"
> +REPO   ?= "git://github.com/xilinx/vcu-omx-il.git;protocol=https"
> +SRCREV ?= "68e385ace99ab699feaa50f24b7a78680c411f75"
> +
> +BRANCHARG = "${@['nobranch=1', 'branch=${BRANCH}'][d.getVar('BRANCH', True) 
> != '']}"
> +SRC_URI = "${REPO};${BRANCHARG}"
> +
> +S  = "${WORKDIR}/git"
> +
> +COMPATIBLE_MACHINE = "^$"
> +COMPATIBLE_MACHINE_zynqmp = "zynqmp"
> +
> +DEPENDS = "libvcu-xlnx"
> +RDEPENDS_${PN} = "kernel-module-vcu libvcu-xlnx"
> +
> +EXTERNAL_INCLUDE="${STAGING_INCDIR}/vcu-ctrl-sw/include"
> +
> +EXTRA_OEMAKE = " \
> +CC='${CC}' CXX='${CXX} ${CXXFLAGS}' \
> +EXTERNAL_INCLUDE='${EXTERNAL_INCLUDE}' \
> +"
> +
> +do_install() {
> +install -d ${D}${libdir}
> +install -d ${D}${includedir}/vcu-omx-il
> +
> +install -m 0644 ${S}/omx_header/*.h ${D}${includedir}/vcu-omx-il
> +
> +install -Dm 0755 ${S}/bin/omx_decoder.exe ${D}/${bindir}/omx_decoder.exe
> +install -Dm 0755 ${S}/bin/omx_encoder.exe ${D}/${bindir}/omx_encoder.exe
> +
> +oe_libinstall -C ${S}/bin/ -so libOMX.allegro.core ${D}/${libdir}/
> +oe_libinstall -C ${S}/bin/ 

[meta-xilinx] [meta-xilinx-bsp][PATCH] recipes-multimedia/vcu/*.bb: Introduce hwcodec and required firmware, ko and software libraries for VCU

2018-04-13 Thread Manjukumar Matha
From: Devarsh Thakkar 

Add new recipes for the following:

vcu-firmware_git.bb: Add a new recipe to fetch the required firmware
binaries for VCU

kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module
required for VCU decoder, encoder. This is applicable to MPSoC EV
devices which support Video Codec Unit

libvcu-xlnx_git.bb: Add a new recipe for control software libraries,
test applications and headers for VCU

libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX
libraries, test applications and headers for VCU

Signed-off-by: Devarsh Thakkar 
Signed-off-by: Jeegar Patel 
Tested-by: Maulik Desai 
Acked-by: Varunkumar Allagadapa 
Reviewed-by: Bhargava Sreekantappa Gayathri 

Signed-off-by: Manjukumar Matha 
---
 .../vcu/kernel-module-vcu_git.bb   | 26 +
 .../recipes-multimedia/vcu/libomxil-xlnx_git.bb| 45 ++
 .../recipes-multimedia/vcu/libvcu-xlnx_git.bb  | 37 ++
 .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++
 4 files changed, 145 insertions(+)
 create mode 100644 
meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
 create mode 100644 meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
 create mode 100644 meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
 create mode 100644 meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb

diff --git a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb 
b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
new file mode 100644
index 000..cfd99d9
--- /dev/null
+++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb
@@ -0,0 +1,26 @@
+SUMMARY = "Linux kernel module for Video Code Unit"
+DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel modules 
provider for MPSoC EV devices"
+SECTION = "kernel/modules"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a"
+
+XILINX_VCU_VERSION = "1.0.0"
+PV = "${XILINX_VCU_VERSION}"
+
+S = "${WORKDIR}/git"
+
+BRANCH ?= "master"
+REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https"
+SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e"
+
+BRANCHARG = "${@['nobranch=1', 'branch=${BRANCH}'][d.getVar('BRANCH', True) != 
'']}"
+SRC_URI = "${REPO};${BRANCHARG}"
+
+inherit module
+
+EXTRA_OEMAKE += "O=${STAGING_KERNEL_BUILDDIR}"
+
+RDEPENDS_${PN} = "vcu-firmware"
+
+COMPATIBLE_MACHINE = "^$"
+COMPATIBLE_MACHINE_zynqmp = "zynqmp"
diff --git a/meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb 
b/meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
new file mode 100644
index 000..0c5e5d4
--- /dev/null
+++ b/meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb
@@ -0,0 +1,45 @@
+SUMMARY = "OpenMAX Integration layer for VCU"
+DESCRIPTION = "OMX IL Libraries,test applications and headers for VCU"
+LICENSE = "Proprietary"
+LIC_FILES_CHKSUM = "file://LICENSE.md;md5=03a7aef7e6f6a76a59fd9b8ba450b493"
+
+BRANCH ?= "master"
+REPO   ?= "git://github.com/xilinx/vcu-omx-il.git;protocol=https"
+SRCREV ?= "68e385ace99ab699feaa50f24b7a78680c411f75"
+
+BRANCHARG = "${@['nobranch=1', 'branch=${BRANCH}'][d.getVar('BRANCH', True) != 
'']}"
+SRC_URI = "${REPO};${BRANCHARG}"
+
+S  = "${WORKDIR}/git"
+
+COMPATIBLE_MACHINE = "^$"
+COMPATIBLE_MACHINE_zynqmp = "zynqmp"
+
+DEPENDS = "libvcu-xlnx"
+RDEPENDS_${PN} = "kernel-module-vcu libvcu-xlnx"
+
+EXTERNAL_INCLUDE="${STAGING_INCDIR}/vcu-ctrl-sw/include"
+
+EXTRA_OEMAKE = " \
+CC='${CC}' CXX='${CXX} ${CXXFLAGS}' \
+EXTERNAL_INCLUDE='${EXTERNAL_INCLUDE}' \
+"
+
+do_install() {
+install -d ${D}${libdir}
+install -d ${D}${includedir}/vcu-omx-il
+
+install -m 0644 ${S}/omx_header/*.h ${D}${includedir}/vcu-omx-il
+
+install -Dm 0755 ${S}/bin/omx_decoder.exe ${D}/${bindir}/omx_decoder.exe
+install -Dm 0755 ${S}/bin/omx_encoder.exe ${D}/${bindir}/omx_encoder.exe
+
+oe_libinstall -C ${S}/bin/ -so libOMX.allegro.core ${D}/${libdir}/
+oe_libinstall -C ${S}/bin/ -so libOMX.allegro.video_decoder ${D}/${libdir}/
+oe_libinstall -C ${S}/bin/ -so libOMX.allegro.video_encoder ${D}/${libdir}/
+}
+
+# These libraries shouldn't get installed in world builds unless something
+# explicitly depends upon them.
+
+EXCLUDE_FROM_WORLD = "1"
diff --git a/meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb 
b/meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
new file mode 100644
index 000..ea8b994
--- /dev/null
+++ b/meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb
@@ -0,0 +1,37 @@
+SUMMARY = "Control Software for VCU"
+DESCRIPTION = "Control software libraries, test applications and headers 
provider for VCU"
+LICENSE = "Proprietary"
+LIC_FILES_CHKSUM =