Re: [meta-xilinx] Generation of psu_init files
Hi, both ways are working. For upstreaming I have cleanup that files a little bit to contain only parts which are necessary. Thanks, Michal > > Thanks again for responding Luca. > > > Relating to zcu102, it turns out related to the integration of init files - I > was originally overwriting the 'new' header file > 'arch/arm/include/asm/arch-zynqmp/psu_init_gpl.h'. However, simply adding the > Vivado exported header file to > 'board/xilinx/zynqmp/zynqmp-zcu102-rev1.0/psu_init_gpl.h' and overwriting the > associated existing 'psu_init_gpl.c' yields the SPL generation to succeed. > > > Thanks, > > Martin > > > From: Luca Ceresoli > Sent: Thursday, June 14, 2018 11:16:21 PM > To: Martin Siegumfeldt; meta-xilinx@yoctoproject.org > Cc: Michal Simek > Subject: Re: [meta-xilinx] Generation of psu_init files > > Hi Martin, > > On 14/06/2018 21:40, Martin Siegumfeldt wrote: >> Thanks Luca, >> >> >> Michal, Manju I appreciate if you could provide some insight into the >> plan forward here. On the zcu102 board we are seeing a much improved >> QSPI NOR / UBI stack from what is planned to go into the Sumo release. >> Unfortunately we can not integrate the init code for our custom board as >> exported by any current Vivado version. Is this new structure exported >> by an upcoming Vivado release, or how do you expect us to handle this? > > Strange. I just tried to build the xilinx_zynqmp_zcu106_revA_defconfig > config on a mainline U-Boot (v2018.07-rc1-132-g606fddd76c7a), using the > psu_init_gpl files from [0] and they built fine. I tried both the latest > files (2018.2) and the 2017.1 version. > > I tried also on current u-boot-xlnx master, it works too. > > This is expected since the "new format" is nothing but the "old format", > which I would rather call the "format produced by Vivado", stripped down > of unneeded things such as comments, unused function definitions etc. > > Can you give some more detail on what you are doing and what happens? > What error message do you obtain? Which version of U-Boot? Can you > provide your psu_ini_gpl.* files? Your defconfig? > > [0] https://github.com/Xilinx/hdf-examples > > Regards, > -- > Luca > > -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx
Re: [meta-xilinx] Generation of psu_init files
Thanks again for responding Luca. Relating to zcu102, it turns out related to the integration of init files - I was originally overwriting the 'new' header file 'arch/arm/include/asm/arch-zynqmp/psu_init_gpl.h'. However, simply adding the Vivado exported header file to 'board/xilinx/zynqmp/zynqmp-zcu102-rev1.0/psu_init_gpl.h' and overwriting the associated existing 'psu_init_gpl.c' yields the SPL generation to succeed. Thanks, Martin From: Luca Ceresoli Sent: Thursday, June 14, 2018 11:16:21 PM To: Martin Siegumfeldt; meta-xilinx@yoctoproject.org Cc: Michal Simek Subject: Re: [meta-xilinx] Generation of psu_init files Hi Martin, On 14/06/2018 21:40, Martin Siegumfeldt wrote: > Thanks Luca, > > > Michal, Manju I appreciate if you could provide some insight into the > plan forward here. On the zcu102 board we are seeing a much improved > QSPI NOR / UBI stack from what is planned to go into the Sumo release. > Unfortunately we can not integrate the init code for our custom board as > exported by any current Vivado version. Is this new structure exported > by an upcoming Vivado release, or how do you expect us to handle this? Strange. I just tried to build the xilinx_zynqmp_zcu106_revA_defconfig config on a mainline U-Boot (v2018.07-rc1-132-g606fddd76c7a), using the psu_init_gpl files from [0] and they built fine. I tried both the latest files (2018.2) and the 2017.1 version. I tried also on current u-boot-xlnx master, it works too. This is expected since the "new format" is nothing but the "old format", which I would rather call the "format produced by Vivado", stripped down of unneeded things such as comments, unused function definitions etc. Can you give some more detail on what you are doing and what happens? What error message do you obtain? Which version of U-Boot? Can you provide your psu_ini_gpl.* files? Your defconfig? [0] https://github.com/Xilinx/hdf-examples Regards, -- Luca -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx
Re: [meta-xilinx] Generation of psu_init files
Hi Martin, On 14/06/2018 21:40, Martin Siegumfeldt wrote: > Thanks Luca, > > > Michal, Manju I appreciate if you could provide some insight into the > plan forward here. On the zcu102 board we are seeing a much improved > QSPI NOR / UBI stack from what is planned to go into the Sumo release. > Unfortunately we can not integrate the init code for our custom board as > exported by any current Vivado version. Is this new structure exported > by an upcoming Vivado release, or how do you expect us to handle this? Strange. I just tried to build the xilinx_zynqmp_zcu106_revA_defconfig config on a mainline U-Boot (v2018.07-rc1-132-g606fddd76c7a), using the psu_init_gpl files from [0] and they built fine. I tried both the latest files (2018.2) and the 2017.1 version. I tried also on current u-boot-xlnx master, it works too. This is expected since the "new format" is nothing but the "old format", which I would rather call the "format produced by Vivado", stripped down of unneeded things such as comments, unused function definitions etc. Can you give some more detail on what you are doing and what happens? What error message do you obtain? Which version of U-Boot? Can you provide your psu_ini_gpl.* files? Your defconfig? [0] https://github.com/Xilinx/hdf-examples Regards, -- Luca -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx
Re: [meta-xilinx] Generation of psu_init files
Thanks Luca, Michal, Manju I appreciate if you could provide some insight into the plan forward here. On the zcu102 board we are seeing a much improved QSPI NOR / UBI stack from what is planned to go into the Sumo release. Unfortunately we can not integrate the init code for our custom board as exported by any current Vivado version. Is this new structure exported by an upcoming Vivado release, or how do you expect us to handle this? Thanks, Martin From: Luca Ceresoli Sent: Thursday, June 7, 2018 6:10:38 PM To: Martin Siegumfeldt; meta-xilinx@yoctoproject.org Cc: Michal Simek Subject: Re: [meta-xilinx] Generation of psu_init files Hi Martin, On 04/06/2018 21:45, Martin Siegumfeldt wrote: > Hi, > > Since > https://github.com/Xilinx/u-boot-xlnx/commit/a38ad86e46b940dd53cb328ed19761dbb084d6e5#diff-ff33c47fd7e88097b7ebeba1d14fe072 > / > https://github.com/Xilinx/u-boot-xlnx/commit/9fd6056f5329d2d1178ef675f53641461c2e183d#diff-7f268ae597d9cb8d64ad0d46931fdb1b > the psu_init files have changed format. AFAICS, Vivado 2018.1 still outputs > the old format which is also the case for > https://github.com/Xilinx/hdf-examples. What is the process for generating > the files in the new format? I added in Cc Michal Simek who did the commits you mentioned. I think he has a script to convert the "old format" (generated by Vivado) to the "new format", which is basically the same file, with comments and other unneeded code removed. Michal, do you think that script could be published, maybe in mainline U-Boot? Regards, -- Luca -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx
Re: [meta-xilinx] Generation of psu_init files
Hi Martin, On 04/06/2018 21:45, Martin Siegumfeldt wrote: > Hi, > > Since > https://github.com/Xilinx/u-boot-xlnx/commit/a38ad86e46b940dd53cb328ed19761dbb084d6e5#diff-ff33c47fd7e88097b7ebeba1d14fe072 > / > https://github.com/Xilinx/u-boot-xlnx/commit/9fd6056f5329d2d1178ef675f53641461c2e183d#diff-7f268ae597d9cb8d64ad0d46931fdb1b > the psu_init files have changed format. AFAICS, Vivado 2018.1 still outputs > the old format which is also the case for > https://github.com/Xilinx/hdf-examples. What is the process for generating > the files in the new format? I added in Cc Michal Simek who did the commits you mentioned. I think he has a script to convert the "old format" (generated by Vivado) to the "new format", which is basically the same file, with comments and other unneeded code removed. Michal, do you think that script could be published, maybe in mainline U-Boot? Regards, -- Luca -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx
Re: [meta-xilinx] Generation of psu_init files
Hi Manju, any clues here? The newly pushed 2018.2 release of https://github.com/Xilinx/hdf-examples still seems to describe the init code in the "old format"? Br, Martin From: meta-xilinx-boun...@yoctoproject.org on behalf of Martin Siegumfeldt Sent: Monday, June 4, 2018 9:45:02 PM To: meta-xilinx@yoctoproject.org Subject: [meta-xilinx] Generation of psu_init files Hi, Since https://github.com/Xilinx/u-boot-xlnx/commit/a38ad86e46b940dd53cb328ed19761dbb084d6e5#diff-ff33c47fd7e88097b7ebeba1d14fe072 / https://github.com/Xilinx/u-boot-xlnx/commit/9fd6056f5329d2d1178ef675f53641461c2e183d#diff-7f268ae597d9cb8d64ad0d46931fdb1b the psu_init files have changed format. AFAICS, Vivado 2018.1 still outputs the old format which is also the case for https://github.com/Xilinx/hdf-examples. What is the process for generating the files in the new format? Thanks, Martin -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx -- ___ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx