Re: [Mimedefang] SpamAssassin Code Quality (was Re: Mimedefang 2.56 and SA 3.1.1 - Idle slaves)
David: I fear you've gone over my head with this comment. Is there an easy fix you can point me in the direction and I can look at changing it? I've looked at the current source code as of 1:51PM and I show that leave_helper_run_mode is in DNS.pm and Reporter.pm has a stub function for it as well. Would adding a stub function like Report.pm has into PerMsgStatus.pm point this function to DNS alleviate your concerns? Regards, KAM Martin Blapp wrote: package Mail::SpamAssassin::Dns; 1; package Mail::SpamAssassin::PerMsgStatus; I see. What is the impact of this ? Return value always true ? The impact of this is that if you're looking for the definition of the subroutine Mail::SpamAssassin::PerMsgStatus::leave_helper_run_mode, you can tear your hair out looking in PerMsgStatus.pm only to discover that it *actually* lives in Dns.pm. The impact is unmaintainable code, frustration, and irritation. :-) ___ NOTE: If there is a disclaimer or other legal boilerplate in the above message, it is NULL AND VOID. You may ignore it. Visit http://www.mimedefang.org and http://www.roaringpenguin.com MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com http://lists.roaringpenguin.com/mailman/listinfo/mimedefang
Re: [Mimedefang] SpamAssassin Code Quality (was Re: Mimedefang 2.56 and SA 3.1.1 - Idle slaves)
Kevin A. McGrail wrote: I fear you've gone over my head with this comment. Is there an easy fix you can point me in the direction and I can look at changing it? It's not really a bug, it's just bad style. Perl best practices dictate that a file called Foo/Bar/Quux.pm should only add to the namespace of the Foo::Bar::Quux package, or perhaps some package under Foo::Bar::Quux. For a file called Mail/SpamAssassin/Dns.pm to decide to create subroutines in the Mail::SpamAssassin::PerMsgStatus package is... well... smelly. :-) I would guess that if you filed a bug with the SpamAssassin developers about this issue, it wouldn't get very far because of backward compatibility concerns. Regards, David. ___ NOTE: If there is a disclaimer or other legal boilerplate in the above message, it is NULL AND VOID. You may ignore it. Visit http://www.mimedefang.org and http://www.roaringpenguin.com MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com http://lists.roaringpenguin.com/mailman/listinfo/mimedefang
[Mimedefang] SpamAssassin Code Quality (was Re: Mimedefang 2.56 and SA 3.1.1 - Idle slaves)
Martin Blapp wrote: package Mail::SpamAssassin::Dns; 1; package Mail::SpamAssassin::PerMsgStatus; I see. What is the impact of this ? Return value always true ? The impact of this is that if you're looking for the definition of the subroutine Mail::SpamAssassin::PerMsgStatus::leave_helper_run_mode, you can tear your hair out looking in PerMsgStatus.pm only to discover that it *actually* lives in Dns.pm. The impact is unmaintainable code, frustration, and irritation. :-) Regards, David. ___ NOTE: If there is a disclaimer or other legal boilerplate in the above message, it is NULL AND VOID. You may ignore it. Visit http://www.mimedefang.org and http://www.roaringpenguin.com MIMEDefang mailing list MIMEDefang@lists.roaringpenguin.com http://lists.roaringpenguin.com/mailman/listinfo/mimedefang
