Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-21 Thread Mateusz Mikuła 
 Sorry for the delay but I spent almost whole day in college.

Thank you for adding it, here comes small patch to test it.


-- Original Message --
Subject: Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const
LPVOID' for VerQueryValue
Date: Mon, 20 Mar 2017 21:19:05 -0500
To: Mingw-w64-public
From: Nightstrike
> On Mon, Mar 20, 2017 at 9:34 AM, Mateusz Mikuła <mati...@gmail.com> wrote:
>>  It explains why my patches created with `git format-patch` couldn't
>> make it.
>>
>> Their mime type is `text/x-diff`.
> I added text/x-diff to the list.  Give it a shot.
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

From 180bffbe07c0c43e7f103debc8d8d777cb027096 Mon Sep 17 00:00:00 2001
From: Mateusz Mikula <mati...@gmail.com>
Date: Thu, 2 Feb 2017 12:21:45 +0100
Subject: [PATCH 3/9] fix libclang name for mingw

---
 tools/libclang/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libclang/CMakeLists.txt b/tools/libclang/CMakeLists.txt
index 477e53dd15..dc2e3538fa 100644
--- a/tools/libclang/CMakeLists.txt
+++ b/tools/libclang/CMakeLists.txt
@@ -78,7 +78,7 @@ if((NOT LLVM_ENABLE_PIC OR LIBCLANG_BUILD_STATIC) AND (NOT 
MSVC))
   set(ENABLE_STATIC STATIC)
 endif()
 
-if(WIN32)
+if(MSVC)
   set(output_name "libclang")
 else()
   set(output_name "clang")
-- 
2.12.0



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-21 Thread David Wohlferd 

> We have text/x-patch, not application/x-patch.  I don't understand the
> difference.  Do you?

The problem with mime types is that anyone can use any string they want 
and it means whatever they want it to mean.  Of course to be "generally 
useful" the meaning must be "generally agreed upon."

It looks like you have already hit most of the "generally agreed upon" 
mime types for patches.  While there are a few places that use 
application/x-patch, it doesn't appear to be common.

Too bad SF doesn't log the mime types it has eaten.  There can't be that 
many that people are actually trying to send to this list.

dw

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread NightStrike 
On Mon, Mar 20, 2017 at 9:42 PM, David Wohlferd  wrote:
>
>> I don't think application/octet-stream is something we would want to
>> enable.  Doesn't that sound like something that would be abused?
>
> I suppose application/octet-stream might be useful if we commonly worked
> with binary files for patches.  But I agree with you, don't do it.
>
> A google search turned up a few other hits:
>
>   * text/x-diff
>   * application/x-patch

text/x-diff is there as of 36 minutes ago.

We have text/x-patch, not application/x-patch.  I don't understand the
difference.  Do you?

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread David Wohlferd 

> I don't think application/octet-stream is something we would want to
> enable.  Doesn't that sound like something that would be abused?

I suppose application/octet-stream might be useful if we commonly worked 
with binary files for patches.  But I agree with you, don't do it.

A google search turned up a few other hits:

  * text/x-diff
  * application/x-patch

These aren't a problem for me, but while we're thinking about it.

dw

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread NightStrike 
On Mon, Mar 20, 2017 at 9:34 AM, Mateusz Mikuła  wrote:
>  It explains why my patches created with `git format-patch` couldn't
> make it.
>
> Their mime type is `text/x-diff`.

I added text/x-diff to the list.  Give it a shot.

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread NightStrike 
On Mon, Mar 20, 2017 at 9:23 AM, David Grayson  wrote:
> Oops, that was the problem then.  It was "application/octet-stream" because
> I was constructing the email with the Ruby "mail" gem that doesn't
> recognize ".patch" files as being text.  I'll use better methods in the
> future.

I don't think application/octet-stream is something we would want to
enable.  Doesn't that sound like something that would be abused?

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread Mateusz Mikuła 
 I checked it with `file --mime-type something.patch` in MSYS2 shell;
something.patch was generated by git.



-- Original Message --
Subject: Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const
LPVOID' for VerQueryValue
Date: Mon, 20 Mar 2017 23:15:21 +0800
To: Mingw-w64-public
From: Liu Hao
> On 2017/3/20 22:34, Mateusz Mikuła wrote:
>>  It explains why my patches created with `git format-patch` couldn't
>> make it.
>>
>> Their mime type is `text/x-diff`.
> Isn't it our mail clients that guess MIME types of attachments? The diff 
> file doesn't have any MIME type information stored with it.
>



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread Liu Hao 
On 2017/3/20 22:34, Mateusz Mikuła wrote:
>  It explains why my patches created with `git format-patch` couldn't
> make it.
>
> Their mime type is `text/x-diff`.
Isn't it our mail clients that guess MIME types of attachments? The diff 
file doesn't have any MIME type information stored with it.

-- 
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread Mateusz Mikuła 
 It explains why my patches created with `git format-patch` couldn't
make it.

Their mime type is `text/x-diff`.


-- Original Message --
Subject: Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const
LPVOID' for VerQueryValue
Date: Mon, 20 Mar 2017 00:13:44 -0500
To: Mingw-w64-public
From: Nightstrike
> Do you know what content type you attached as?  We have to explicitly
> allow each type.  The current list is:
>
> application/pgp-signature
> multipart/mixed
> multipart/alternative
> multipart/signed
> text/plain
> text/x-patch
>
> If the content type is left unspecified, then the attachment is
> deleted.  I can add anything you like.
>
> On Sun, Mar 19, 2017 at 10:30 PM, David Grayson <davidegray...@gmail.com> 
> wrote:
>> NightStrike,
>>
>> The mailing list swallowed the patch in the message I sent on March 16th.
>> I can see in GMail that I did have a patch attached to my message, but no
>> attachment is visible in the archive here:
>>
>> https://sourceforge.net/p/mingw-w64/mailman/message/35729302/
>>
>> --David Grayson
>>
>> On Sun, Mar 19, 2017 at 7:03 PM, NightStrike <nightstr...@gmail.com> wrote:
>>
>>> On Mar 16, 2017 1:40 PM, "Liu Hao" <lh_mo...@126.com> wrote:
>>>
>>> On 2017/3/17 0:51, David Grayson wrote:
>>>> I was trying to compile Qt and I ran into an error because Qt is
>>>> passing a const pointer to the first argument of VerQueryValue, which
>>>> is not properly marked as const in the mingw-w64 header files.  This
>>>> patch fixes that.
>>> Please send the patch both inline and as an attachment, since SF mailing
>>> lists swallow attachments frequently.
>>>
>>>
>>> It shouldn't. If it does, tell me and I'll address it. I believe I already
>>> fixed one issue you brought up a while ago. I haven't seen any since.
>>> 
>>> --
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> ___
>>> Mingw-w64-public mailing list
>>> Mingw-w64-public@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



signature.asc
Description: OpenPGP digital signature
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-20 Thread David Grayson 
Oops, that was the problem then.  It was "application/octet-stream" because
I was constructing the email with the Ruby "mail" gem that doesn't
recognize ".patch" files as being text.  I'll use better methods in the
future.

--David

On Sun, Mar 19, 2017 at 10:13 PM, NightStrike  wrote:

> Do you know what content type you attached as?  We have to explicitly
> allow each type.  The current list is:
>
> application/pgp-signature
> multipart/mixed
> multipart/alternative
> multipart/signed
> text/plain
> text/x-patch
>
> If the content type is left unspecified, then the attachment is
> deleted.  I can add anything you like.
>
> On Sun, Mar 19, 2017 at 10:30 PM, David Grayson 
> wrote:
> > NightStrike,
> >
> > The mailing list swallowed the patch in the message I sent on March 16th.
> > I can see in GMail that I did have a patch attached to my message, but no
> > attachment is visible in the archive here:
> >
> > https://sourceforge.net/p/mingw-w64/mailman/message/35729302/
> >
> > --David Grayson
> >
> > On Sun, Mar 19, 2017 at 7:03 PM, NightStrike 
> wrote:
> >
> >> On Mar 16, 2017 1:40 PM, "Liu Hao"  wrote:
> >>
> >> On 2017/3/17 0:51, David Grayson wrote:
> >> > I was trying to compile Qt and I ran into an error because Qt is
> >> > passing a const pointer to the first argument of VerQueryValue, which
> >> > is not properly marked as const in the mingw-w64 header files.  This
> >> > patch fixes that.
> >> Please send the patch both inline and as an attachment, since SF mailing
> >> lists swallow attachments frequently.
> >>
> >>
> >> It shouldn't. If it does, tell me and I'll address it. I believe I
> already
> >> fixed one issue you brought up a while ago. I haven't seen any since.
> >> 
> >> --
> >> Check out the vibrant tech community on one of the world's most
> >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> ___
> >> Mingw-w64-public mailing list
> >> Mingw-w64-public@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
> >>
> > 
> --
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > ___
> > Mingw-w64-public mailing list
> > Mingw-w64-public@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-19 Thread NightStrike 
Do you know what content type you attached as?  We have to explicitly
allow each type.  The current list is:

application/pgp-signature
multipart/mixed
multipart/alternative
multipart/signed
text/plain
text/x-patch

If the content type is left unspecified, then the attachment is
deleted.  I can add anything you like.

On Sun, Mar 19, 2017 at 10:30 PM, David Grayson  wrote:
> NightStrike,
>
> The mailing list swallowed the patch in the message I sent on March 16th.
> I can see in GMail that I did have a patch attached to my message, but no
> attachment is visible in the archive here:
>
> https://sourceforge.net/p/mingw-w64/mailman/message/35729302/
>
> --David Grayson
>
> On Sun, Mar 19, 2017 at 7:03 PM, NightStrike  wrote:
>
>> On Mar 16, 2017 1:40 PM, "Liu Hao"  wrote:
>>
>> On 2017/3/17 0:51, David Grayson wrote:
>> > I was trying to compile Qt and I ran into an error because Qt is
>> > passing a const pointer to the first argument of VerQueryValue, which
>> > is not properly marked as const in the mingw-w64 header files.  This
>> > patch fixes that.
>> Please send the patch both inline and as an attachment, since SF mailing
>> lists swallow attachments frequently.
>>
>>
>> It shouldn't. If it does, tell me and I'll address it. I believe I already
>> fixed one issue you brought up a while ago. I haven't seen any since.
>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> ___
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-19 Thread David Grayson 
NightStrike,

The mailing list swallowed the patch in the message I sent on March 16th.
I can see in GMail that I did have a patch attached to my message, but no
attachment is visible in the archive here:

https://sourceforge.net/p/mingw-w64/mailman/message/35729302/

--David Grayson

On Sun, Mar 19, 2017 at 7:03 PM, NightStrike  wrote:

> On Mar 16, 2017 1:40 PM, "Liu Hao"  wrote:
>
> On 2017/3/17 0:51, David Grayson wrote:
> > I was trying to compile Qt and I ran into an error because Qt is
> > passing a const pointer to the first argument of VerQueryValue, which
> > is not properly marked as const in the mingw-w64 header files.  This
> > patch fixes that.
> Please send the patch both inline and as an attachment, since SF mailing
> lists swallow attachments frequently.
>
>
> It shouldn't. If it does, tell me and I'll address it. I believe I already
> fixed one issue you brought up a while ago. I haven't seen any since.
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-19 Thread NightStrike 
On Mar 16, 2017 1:40 PM, "Liu Hao"  wrote:

On 2017/3/17 0:51, David Grayson wrote:
> I was trying to compile Qt and I ran into an error because Qt is
> passing a const pointer to the first argument of VerQueryValue, which
> is not properly marked as const in the mingw-w64 header files.  This
> patch fixes that.
Please send the patch both inline and as an attachment, since SF mailing
lists swallow attachments frequently.


It shouldn't. If it does, tell me and I'll address it. I believe I already
fixed one issue you brought up a while ago. I haven't seen any since.
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-16 Thread Liu Hao 
On 2017/3/17 0:51, David Grayson wrote:
> I was trying to compile Qt and I ran into an error because Qt is
> passing a const pointer to the first argument of VerQueryValue, which
> is not properly marked as const in the mingw-w64 header files.  This
> patch fixes that.
Please send the patch both inline and as an attachment, since SF mailing 
lists swallow attachments frequently.

-- 
Best regards,
LH_Mouse


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

[Mingw-w64-public] [PATCH] Use LPCVOID instead of 'const LPVOID' for VerQueryValue

2017-03-16 Thread David Grayson 
I was trying to compile Qt and I ran into an error because Qt is
passing a const pointer to the first argument of VerQueryValue, which
is not properly marked as const in the mingw-w64 header files.  This
patch fixes that.

Apparently "const LPVOID" is different from "LPCVOID".  You can see
the difference for yourself by trying to compile this small bit of C
code:

#include 
void x(const LPVOID);
void y(LPCVOID);
void test() {
  const char * data;
  x(data);
  y(data);
}

Thanks!

--David Grayson
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public