[Mixxx-devel] Controller scripting
Hi I want to update a controller mapping to 1.12. I noticed that I have to restart mixxx so that changes in the xml file are applied. This makes everything quite cubersome. Didn't we used to reload the mappings automatically when the files change? I can remember something like this for the javascript files. Also there a way to get a list of valid mappable controls from the source code? best Max -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] formating source Code with clang-format
I've created a PR with astyle settings so that everyone can see how the code looks then. It seems to me astyle has less problems with a variable line-length then clang-format. The conversion of the code base could be done piece by piece. We just decide to use the auto-formatter from some point on and provide a git-hook script for new contributors (so git will apply astyle/clang-format before every commit). best Max On 06/11/2015 09:24 PM, Tuukka Pasanen wrote: Hello, With Mixxx I use astyle: astyle --style=java --pad-header -s4 --lineend=linux --max-code-length=80 --break-after-logical --convert-tabs file.cpp it seems that they also have Google style and pico style (what ever that means but I'll start to use it). I prefer 120 because hey it's 2015. I code in nano but I have wider screen! (and that's a fact) Sincerely, Tuukka 2015-06-11 17:16 GMT+03:00 Daniel Schürmann dasch...@mixxx.org: So we have people who prefer 80 columns, and people who prefer unlimited columns. There's not really a compromise position between these two options, so how do we choose? We have people who prefer 80 columns and we have people who prefer more. I prefer 80 columns. So there is no column issue issue to add a .clang-format file to the Mixxx source and ask any contributor to run it if there are style issues. The latest discussion was about the code cluttering produced by a unsupervised run at all Mixxx source. This happens because we allow currently allow more than 80 columns for reasons. Setting the columns to unlimited helps a bit. But there are still other cluttering issues that requires developer attention. Never seen astyle has broke something like code didn't work anymore. Do you have experience with Astyle. Maybe this can be configured to be more temperate than clang-format. It would be also nice if we can do the mass auto-format for single style issues only e.g. the pinter * alignment. 2015-06-11 15:30 GMT+02:00 Owen Williams owilli...@mixxx.org: So we have people who prefer 80 columns, and people who prefer unlimited columns. There's not really a compromise position between these two options, so how do we choose? On Wed, 2015-06-10 at 09:28 -0400, Owen Williams wrote: On Wed, 2015-06-10 at 09:16 -0400, RJ Ryan wrote: The part of clang-format which frees you from having to talk about code style is that there is only one right way to format the code. Letting the developer have any choice in the matter goes against this. Agree. I don't really feel strongly about line length, so 80 is fine with me. -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
[Mixxx-devel] change importance and milestone for bug lp:1464975
Hi, Can anybody change importance to low and milestone to 1.12 for bug lp:1464975 ? I can not do it. Thanks, sb -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] release progress
This isn't critical, but I would expect reviewers to write things like The new key detection is a step forward, but it has some rough edges unless this is fixed: https://bugs.launchpad.net/mixxx/+bug/1435628 I think users will expect meaningful key sorting and those who are used to it in other software such as Traktor will think Mixxx is unpolished. On 06/14/2015 12:33 PM, Sébastien Blaisot wrote: OK, trying to gather what we said about 1.12 release blockers: Done: * skin polish (Jus has an active Deere branch) = PR579 PR608 merged. * (win) installing 1.12 on top of a previous version installation = PR621 waiting for merge * (win) Uninstalling Mixxx leave files behind = PR603 merged * (win) Incorrect preferences folder path = PR606 merged Remaining: * critical Windows bugs = RJ told he will have a look at them. can we list the critical blockers here ? * skin polish (Jus has an active Deere branch) = bug lp:1454649 remaining. Is there other work needed ? * website updates (RJ ryan is working on this). We also need to open more languages for website translation on transifex. it's actually limited to english, german, portuguese and Turkish. I can make french (france) translation. * manual updates = Does somebody work on this actually ? * avoid flanger warning message for shipped with mixxx controller mappings (hack it by making an ignore list) = Does somebody work on this actually ? * XDG folders under Linux : We have to decide if it is a 1.12 issue or if we postpone it. see lp:1463273 and PR622 * Unstable broadcasting stream = lp:1277274 Is there any other blockers ? -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] release progress
In about a month or so I'll be able to actively work on spanish and catalan translations. I might also try to write something for the manual. 2015-06-14 20:07 GMT+02:00 Be b...@gmx.com: I started working on revising chapter 3 of the manual and adding a section describing how use a stereo splitter adapter/cable now that Mixxx can output to single channels. There are still a lot of parts of the manual that need updating. On 06/14/2015 01:04 PM, S.Brandt wrote: On Jun 14, 2015, at 7:33 PM, Sébastien Blaisot mi...@blaisot.org mailto:mi...@blaisot.org wrote: We also need to open more languages for website translation on transifex The available source strings are for the current v1.11. We need to update the website source for 1.12, then make the source strings available for translation. If you translate now, be prepared for additional work once the strings have been updated (This is the reason de_DE translation is incomplete) The current number of available languages reflects the number of requests we got for website translation. Just added fr_FR. Getting a request does not mean someone is doing actual translations, see tr_TR * manual updates = Does somebody work on this actually ? Afaik none -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] release progress
On Jun 14, 2015, at 7:33 PM, Sébastien Blaisot mi...@blaisot.org wrote: We also need to open more languages for website translation on transifex The available source strings are for the current v1.11. We need to update the website source for 1.12, then make the source strings available for translation. If you translate now, be prepared for additional work once the strings have been updated (This is the reason de_DE translation is incomplete) The current number of available languages reflects the number of requests we got for website translation. Just added fr_FR. Getting a request does not mean someone is doing actual translations, see tr_TR * manual updates = Does somebody work on this actually ? Afaik none-- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] mapping file name conventions
Le 14/06/2015 18:24, Be a écrit : What about renaming all the MIDI scripts to end with .midi.js and the HID scripts to .hid.js? On 06/14/2015 11:08 AM, Sébastien Blaisot wrote: Le 14/06/2015 17:59, Be a écrit : Do we really need the word scripts in the script files? Isn't that redundant with .js? We need a way to differentiate from hid.js. What about renaming all the MIDI scripts to end with .midi.js and the HID scripts to .hid.js? Usually, scripts.js are common for midi and hid usage. They are called by both midi.xml file and hid.js file. scripts.js defines functions that are mapped to midi controls by midi.xml file and to hid controls through his.js file. so, technically, scripts.js is in fact common functions. sb -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] release progress
I started working on revising chapter 3 of the manual and adding a section describing how use a stereo splitter adapter/cable now that Mixxx can output to single channels. There are still a lot of parts of the manual that need updating. On 06/14/2015 01:04 PM, S.Brandt wrote: On Jun 14, 2015, at 7:33 PM, Sébastien Blaisot mi...@blaisot.org mailto:mi...@blaisot.org wrote: We also need to open more languages for website translation on transifex The available source strings are for the current v1.11. We need to update the website source for 1.12, then make the source strings available for translation. If you translate now, be prepared for additional work once the strings have been updated (This is the reason de_DE translation is incomplete) The current number of available languages reflects the number of requests we got for website translation. Just added fr_FR. Getting a request does not mean someone is doing actual translations, see tr_TR * manual updates = Does somebody work on this actually ? Afaik none -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] mapping file name conventions
Do we really need the word scripts in the script files? Isn't that
redundant with .js?
On 06/11/2015 02:21 PM, Sébastien Blaisot wrote:
Le 11/06/2015 21:02, Be a écrit :
Mappings included in Mixxx have the XML file named with hyphens
separating words but the script files are named with spaces separating
words. Having two naming conventions gets confusing and annoying,
especially when typing the file names in a shell. I suggest switching
the script files to using hyphens to separate words. Thoughts?
I don't care that much if we use hyphens, spaces or whatever, provided that:
- wherever possible, use the same convention/name for js and xml files
- only use characters that are acceptable for filenames on all OSes
(regardless of OS language)
- resulting filenames are easily human-readable
- It's easy to find all files from the same brand / model (this files
are near each other when alphabetically sorting)
It's probably more readable to have a word separator different from a
brand/model/comment/type/whatever separator.
Something like
brand - model[ - comment].type.{xml,js}
with word separated by space if we have brand or model which contains
several words.
let's try it with an example :
American Audio - RADIUS 2000.hid.js
American Audio - RADIUS 2000.scripts.js
American Audio - RADIUS 2000 - CH1.midi.xml
American Audio - RADIUS 2000 - CH2.midi.xml
This way, all files from the same brand are all together, as well as all
files from the same model adn it's easy to read.
--
___
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
Re: [Mixxx-devel] release progress
OK, trying to gather what we said about 1.12 release blockers: Done: * skin polish (Jus has an active Deere branch) = PR579 PR608 merged. * (win) installing 1.12 on top of a previous version installation = PR621 waiting for merge * (win) Uninstalling Mixxx leave files behind = PR603 merged * (win) Incorrect preferences folder path = PR606 merged Remaining: * critical Windows bugs = RJ told he will have a look at them. can we list the critical blockers here ? * skin polish (Jus has an active Deere branch) = bug lp:1454649 remaining. Is there other work needed ? * website updates (RJ ryan is working on this). We also need to open more languages for website translation on transifex. it's actually limited to english, german, portuguese and Turkish. I can make french (france) translation. * manual updates = Does somebody work on this actually ? * avoid flanger warning message for shipped with mixxx controller mappings (hack it by making an ignore list) = Does somebody work on this actually ? * XDG folders under Linux : We have to decide if it is a 1.12 issue or if we postpone it. see lp:1463273 and PR622 * Unstable broadcasting stream = lp:1277274 Is there any other blockers ? -- Sébastien 圣巴斯弟盎 -- ___ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
