cvs commit: modperl-2.0/t/response/TestCompat conn_authen.pm
geoff 2003/02/19 06:14:36
Modified:.Changes
lib/Apache compat.pm
t/response/TestCompat conn_authen.pm
Log:
fixes to Apache::compat. make $r-connection-auth_type interface
with r-ap_auth_type. make both $r-connection-auth_type and
$r-connection-user writable
Submitted by: geoff
Reviewed by: stas
Revision ChangesPath
1.129 +4 -0 modperl-2.0/Changes
Index: Changes
===
RCS file: /home/cvs/modperl-2.0/Changes,v
retrieving revision 1.128
retrieving revision 1.129
diff -u -r1.128 -r1.129
--- Changes 19 Feb 2003 14:12:01 - 1.128
+++ Changes 19 Feb 2003 14:14:35 - 1.129
@@ -10,6 +10,10 @@
=item 1.99_09-dev
+fixes to Apache::compat. make $r-connection-auth_type interface
+with r-ap_auth_type. make both $r-connection-auth_type and
+$r-connection-user writable. [Geoffrey Young]
+
Open up r-ap_auth_type, making it possible to write custom
authen handlers that don't rely on Basic authentication or
it's associated ap_* functions.
1.80 +2 -2 modperl-2.0/lib/Apache/compat.pm
Index: compat.pm
===
RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
retrieving revision 1.79
retrieving revision 1.80
diff -u -r1.79 -r1.80
--- compat.pm 17 Feb 2003 09:47:31 - 1.79
+++ compat.pm 19 Feb 2003 14:14:36 - 1.80
@@ -538,8 +538,8 @@
# auth_type and user records don't exist in 2.0 conn_rec struct
# 'PerlOptions +GlobalRequest' is required
-sub auth_type { Apache-request-auth_type }
-sub user { Apache-request-user }
+sub auth_type { shift; Apache-request-ap_auth_type(@_) }
+sub user { shift; Apache-request-user(@_) }
1;
__END__
1.2 +33 -5 modperl-2.0/t/response/TestCompat/conn_authen.pm
Index: conn_authen.pm
===
RCS file: /home/cvs/modperl-2.0/t/response/TestCompat/conn_authen.pm,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- conn_authen.pm12 Feb 2003 23:42:23 - 1.1
+++ conn_authen.pm19 Feb 2003 14:14:36 - 1.2
@@ -1,6 +1,6 @@
package TestCompat::conn_authen;
-# simply check that we can retrieve:
+# compat checks for
# $r-connection-auth_type
# $r-connection-user
# both records don't exist in 2.0 conn_rec and therefore require
@@ -16,19 +16,47 @@
use Apache::Constants qw(OK REMOTE_HOST);
sub handler {
+
my $r = shift;
+my $req_auth_type = $r-connection-auth_type || '';
+
+die request auth_type is '$req_auth_type', should be empty
+if $req_auth_type;
+
+# get_basic_auth_pw populates $r-user and $r-ap_auth_type
my($rc, $sent_pw) = $r-get_basic_auth_pw;
return $rc if $rc != Apache::OK;
-my $auth_type = $r-connection-auth_type || '';
-die auth_type is '$auth_type', should be 'Basic'
-unless $auth_type eq 'Basic';
+$req_auth_type = $r-connection-auth_type || '';
+
+die request auth_type is '$req_auth_type', should be 'Basic'
+unless $req_auth_type eq 'Basic';
+
+my $config_auth_type = $r-auth_type || '';
+
+die httpd.conf auth_type is '$config_auth_type', should be 'Basic'
+unless $config_auth_type eq 'Basic';
my $user = $r-connection-user || '';
-die user is '$user', while expecting 'dougm'
+
+die user is '$user', should be 'dougm'
unless $user eq 'dougm';
+
+# make sure we can set both
+$r-connection-auth_type('sailboat');
+$r-connection-user('geoff');
+
+$user = $r-connection-user || '';
+
+die user is '$user', should be 'geoff'
+unless $user eq 'geoff';
+
+$req_auth_type = $r-connection-auth_type || '';
+
+die request auth_type is '$req_auth_type', should be 'sailboat'
+unless $req_auth_type eq 'sailboat';
OK;
}
cvs commit: modperl/lib/Apache PerlRun.pm
geoff 02/05/29 09:52:17
Modified:lib/Apache PerlRun.pm
Log:
PerlRun/RegistryNG errors are now saved in $r-notes('error-notes')
Submitted by: geoff
Reviewed by: dougm
Revision ChangesPath
1.39 +9 -2 modperl/lib/Apache/PerlRun.pm
Index: PerlRun.pm
===
RCS file: /home/cvs/modperl/lib/Apache/PerlRun.pm,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- PerlRun.pm25 Mar 2002 01:59:02 - 1.38
+++ PerlRun.pm29 May 2002 16:52:17 - 1.39
-28,6 +28,12
return bless {r=$r}, $class;
}
+sub xlog_error {
+my($r, $msg) = _;
+$r-log_error($msg);
+$r-notes('error-notes', $msg);
+}
+
sub can_compile {
my($pr) = _;
my $r = $pr-{r};
-52,7 +58,7
$pr-{'mtime'} = -M _;
return wantarray ? (OK, $pr-{'mtime'}) : OK;
}
-$r-log_error($filename not found or unable to stat);
+xlog_error($r, $filename not found or unable to stat);
return NOT_FOUND;
}
-139,7 +145,7
}
if($errsv) {
- $r-log_error($errsv);
+ xlog_error($r, $errsv);
return SERVER_ERROR;
}
-211,6 +217,7
my $pr = shift;
if ($ and substr($,0,4) ne at ) {
$pr-{r}-log_error(PerlRun: `$');
+ $pr-{r}-notes('error-notes', $);
$@{$pr-{r}-uri} = $;
$ = ''; #XXX fix me, if we don't do this Apache::exit() breaks
return SERVER_ERROR;
cvs commit: modperl Changes
geoff 02/05/29 09:56:04
Modified:.Changes
Log:
expand $r-notes('error-notes') to cover PerlRun and RegistryNG
Revision ChangesPath
1.647 +2 -1 modperl/Changes
Index: Changes
===
RCS file: /home/cvs/modperl/Changes,v
retrieving revision 1.646
retrieving revision 1.647
diff -u -r1.646 -r1.647
--- Changes 29 May 2002 16:25:40 - 1.646
+++ Changes 29 May 2002 16:56:04 - 1.647
@@ -14,7 +14,8 @@
thanks to Lyle Brooks for the spot
[Stephen Clouse [EMAIL PROTECTED]]
-Apache::Registry errors are now saved in $r-notes('error-notes')
+Apache::Registry/PerlRun/RegistryNG errors are now saved
+in $r-notes('error-notes')
[Jesse Erlbaum [EMAIL PROTECTED]]
fix Win32 build problems with spaces in shell arguments
cvs commit: modperl STATUS
geoff 02/05/14 04:50:49 Modified:.STATUS Log: added Apache::Status enhancement request (forwarded from Stas) Revision ChangesPath 1.17 +9 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.16 retrieving revision 1.17 diff -u -r1.16 -r1.17 --- STATUS22 Apr 2002 19:50:40 - 1.16 +++ STATUS14 May 2002 11:50:48 - 1.17 -1,5 +1,5 mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/04/22 19:50:40 $] + Last modified at [$Date: 2002/05/14 11:50:48 $] Release: -24,6 +24,14 just not enough things or Registry specific things? --Geoff patch available at http://marc.theaimsgroup.com/?l=apache-modperlm=101862462900504w=2 + +* Apache::Status allows standard keys to be overridden +Report: http://marc.theaimsgroup.com/?l=apache-modperlm=101559176217056w=2 + Status: + I'm not sure I understand this one, since the patch seems to do + the opposite of what the user is asking for --Geoff + patch available at + http://marc.theaimsgroup.com/?l=apache-modperlm=101559176217056w=2 Needs Patch or Further Investigation
cvs commit: modperl STATUS
geoff 02/05/14 11:05:34 Modified:.STATUS Log: more bug reports via stas... Revision ChangesPath 1.18 +10 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- STATUS14 May 2002 11:50:48 - 1.17 +++ STATUS14 May 2002 18:05:34 - 1.18 -1,5 +1,5 mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/05/14 11:50:48 $] + Last modified at [$Date: 2002/05/14 18:05:34 $] Release: -102,6 +102,15 it would be much better if the Apache::Registry will do that Report: ? Status: + +* Apache::DProf seg-fault via Devel::DProf's prof_mark() +Report: http://marc.theaimsgroup.com/?l=apache-modperlm=101923951812332w=2 + Status: + +* collisions between Apache::Status and English.pm +Report: http://marc.theaimsgroup.com/?l=apache-modperlm=102096856215178w=2 + Status: + Open Issues or Core Enhancements:
cvs commit: modperl STATUS
geoff 02/04/22 12:50:40
Modified:.STATUS
Log:
add notes('error-notes') enhancement report and patch to STATUS
Revision ChangesPath
1.16 +10 -1 modperl/STATUS
Index: STATUS
===
RCS file: /home/cvs/modperl/STATUS,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- STATUS14 Apr 2002 17:25:03 - 1.15
+++ STATUS22 Apr 2002 19:50:40 - 1.16
-1,5 +1,5
mod_perl 1.3 STATUS:
- Last modified at [$Date: 2002/04/14 17:25:03 $]
+ Last modified at [$Date: 2002/04/22 19:50:40 $]
Release:
-16,6 +16,15
patch available at
http://marc.theaimsgroup.com/?l=apache-modperlm=101729204503165w=2
+* implement notes('error-notes') in Registry a la mod_cgo
+Report: http://marc.theaimsgroup.com/?l=apache-modperlm=101862462900504w=2
+ Status:
+ I haven't had the chance to investigate this thoroughly, but
+ mod_perl does seem to be setting error-notes for some things. maybe
+ just not enough things or Registry specific things? --Geoff
+ patch available at
+ http://marc.theaimsgroup.com/?l=apache-modperlm=101862462900504w=2
+
Needs Patch or Further Investigation
PDF's [OT I THINK]
not sure where to start looking for some info, so I thought here first I need to be able to print pdf's from an apache webserver using perl... I know usually that just an link to the file is sufficient, but these files are outside of the /var/www/path to webserver. 2 questions really.. 1st - does anyone have any info on this 2nd - could someone point in to a resource.. many thanks geoff
cvs commit: modperl STATUS
geoff 02/04/02 07:10:02 Modified:.STATUS Log: add Win32 specific build problem, with a pointer to Randy's patch Revision ChangesPath 1.14 +8 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- STATUS24 Mar 2002 23:54:32 - 1.13 +++ STATUS2 Apr 2002 15:10:02 - 1.14 -1,5 +1,5 mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/03/24 23:54:32 $] + Last modified at [$Date: 2002/04/02 15:10:02 $] Release: -9,6 +9,13 Available Patches: + +* Win32 build problems with spaces in shell arguments +Report: http://marc.theaimsgroup.com/?l=apache-modperlm=101681938513575w=2 + Status: + patch available at + http://marc.theaimsgroup.com/?l=apache-modperlm=101729204503165w=2 + Needs Patch or Further Investigation
cvs commit: modperl/t/net/perl api.pl
geoff 02/03/24 10:22:56
Modified:.Changes STATUS
src/modules/perl mod_perl.c
t/net/perl api.pl
Log:
make sure PerlSetEnv variables are visible after first access
to each child, and add tests to verify fix
Submitted by: geoff
Reviewed by: doug
Revision ChangesPath
1.628 +3 -0 modperl/Changes
Index: Changes
===
RCS file: /home/cvs/modperl/Changes,v
retrieving revision 1.627
retrieving revision 1.628
diff -u -r1.627 -r1.628
--- Changes 24 Mar 2002 02:07:58 - 1.627
+++ Changes 24 Mar 2002 18:22:56 - 1.628
@@ -10,6 +10,9 @@
=item 1.26_01-dev
+make sure PerlSetEnv variables are visible after first access
+to each child [Geoff Young [EMAIL PROTECTED]]
+
workaround Apache::Constants::AUTOLOAD problem with bleedperl
the first flag argument to perl cannot start with space, since perl tries
1.5 +1 -10 modperl/STATUS
Index: STATUS
===
RCS file: /home/cvs/modperl/STATUS,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- STATUS24 Mar 2002 02:17:09 - 1.4
+++ STATUS24 Mar 2002 18:22:56 - 1.5
@@ -1,5 +1,5 @@
mod_perl 1.3 STATUS:
- Last modified at [$Date: 2002/03/24 02:17:09 $]
+ Last modified at [$Date: 2002/03/24 18:22:56 $]
Release:
@@ -20,15 +20,6 @@
Report: http://marc.theaimsgroup.com/?l=apache-modperlm=97449481013350w=2
Status:
doc patch at
http://marc.theaimsgroup.com/?l=apache-modperlm=97450363501652w=2
-
-* PerlSetEnv scoping
-Report: http://marc.theaimsgroup.com/?l=apache-modperlm=99148497206388w=2
- Status:
- may be fixed here
-http://marc.theaimsgroup.com/?l=apache-modperlm=99473571809129w=2
- but that patch has this issue (I think)
-http://marc.theaimsgroup.com/?l=apache-modperlm=99565226811557w=2
- --Geoff
* %LocationMatch Perl bug
Report: http://marc.theaimsgroup.com/?l=apache-modperlm=98260537428737w=2
1.142 +1 -0 modperl/src/modules/perl/mod_perl.c
Index: mod_perl.c
===
RCS file: /home/cvs/modperl/src/modules/perl/mod_perl.c,v
retrieving revision 1.141
retrieving revision 1.142
diff -u -r1.141 -r1.142
--- mod_perl.c10 Jul 2001 03:30:27 - 1.141
+++ mod_perl.c24 Mar 2002 18:22:56 - 1.142
@@ -1392,6 +1392,7 @@
/* PerlSetEnv
* update only if the table changes across a request
*/
+MP_HASENV_on(cld);
mod_perl_dir_env(r, cld);
cfg-dir_env = cld-env;
}
1.48 +2 -1 modperl/t/net/perl/api.pl
Index: api.pl
===
RCS file: /home/cvs/modperl/t/net/perl/api.pl,v
retrieving revision 1.47
retrieving revision 1.48
diff -u -r1.47 -r1.48
--- api.pl6 Jul 2001 16:09:53 - 1.47
+++ api.pl24 Mar 2002 18:22:56 - 1.48
@@ -16,7 +16,7 @@
my $is_xs = ($r-uri =~ /_xs/);
-my $tests = 74;
+my $tests = 75;
my $is_win32 = WIN32;
$tests += 4 unless $is_win32;
my $test_get_set = Apache-can('set_handlers') ($tests += 4);
@@ -94,6 +94,7 @@
test ++$i, $r-last;
test ++$i, $ENV{GATEWAY_INTERFACE};
+test ++$i, defined $ENV{KeyForPerlSetEnv};
test ++$i, scalar $r-cgi_var('GATEWAY_INTERFACE');
test ++$i, defined($r-seqno);
test ++$i, $r-protocol;
cvs commit: modperl STATUS
geoff 02/03/22 12:03:34 Modified:.STATUS Log: add reference to PERL5LIB patch Revision ChangesPath 1.2 +6 -1 modperl/STATUS Index: STATUS === RCS file: /home/cvs/modperl/STATUS,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- STATUS2 Mar 2002 18:09:54 - 1.1 +++ STATUS22 Mar 2002 20:03:34 - 1.2 -1,5 +1,5 mod_perl 1.3 STATUS: - Last modified at [$Date: 2002/03/02 18:09:54 $] + Last modified at [$Date: 2002/03/22 20:03:34 $] Release: -78,6 +78,11 * Apache::test Report: http://marc.theaimsgroup.com/?l=apache-modperl-devm=98278446807561w=2 Status: + patch available + +* PERL5LIB should unshift INC instead of push +Report: http://marc.theaimsgroup.com/?l=apache-modperl-devm=100434522809036w=2 +Status: patch available
cvs commit: modperl STATUS ToDo
geoff 02/03/02 10:09:54 Added: .STATUS Removed: .ToDo Log: exchanged the old ToDo for the new STATUS file Reviewed by: dougm Revision ChangesPath 1.1 modperl/STATUS Index: STATUS === mod_perl 1.3 STATUS: Last modified at [$Date: 2002/03/02 18:09:54 $] Release: 1.26-dev: In development. 1.25: Released July 11, 2001. Available Patches: * $r-args parsing of one=two=2 Report: http://marc.theaimsgroup.com/?l=apache-modperlm=98018719907031w=2 Status: patch available at http://marc.theaimsgroup.com/?l=apache-modperlm=98048943129379w=2 * two identical directives in Perl configuration Report: http://marc.theaimsgroup.com/?l=apache-modperlm=97449481013350w=2 Status: doc patch at http://marc.theaimsgroup.com/?l=apache-modperlm=97450363501652w=2 * PerlSetEnv scoping Report: http://marc.theaimsgroup.com/?l=apache-modperlm=99148497206388w=2 Status: may be fixed here http://marc.theaimsgroup.com/?l=apache-modperlm=99473571809129w=2 but that patch has this issue (I think) http://marc.theaimsgroup.com/?l=apache-modperlm=99565226811557w=2 --Geoff * %LocationMatch Perl bug Report: http://marc.theaimsgroup.com/?l=apache-modperlm=98260537428737w=2 Status: may be fixed here http://marc.theaimsgroup.com/?l=apache-modperlm=101366182205497w=2 * PVIV issues Report: http://marc.theaimsgroup.com/?l=apache-modperlm=99905070209305w=2 Status: patch available http://marc.theaimsgroup.com/?l=apache-modperlm=9116330145w=2 * mod_perl.h issues for Win32 Report: http://marc.theaimsgroup.com/?l=apache-modperl-devm=101253855721619w=2 Status: patch available * Apache::Utils::escape_html issues Report: http://marc.theaimsgroup.com/?l=apache-modperlm=101180404809059w=2 Status: patch available http://marc.theaimsgroup.com/?l=apache-modperl-devm=101188287032621w=2 * Apache::RegistryNG issues Report: http://marc.theaimsgroup.com/?l=apache-modperl-devm=101240123609773w=2 Status: patch available * vanishing symbol tables Report: http://marc.theaimsgroup.com/?l=apache-modperlm=100820262006934w=2 Status: patch available * $r-finfo problem with HTML::Mason::ApacheHandler Report: http://marc.theaimsgroup.com/?l=apache-modperlm=96854561311519w=2 Status: may be fixed with http://marc.theaimsgroup.com/?l=apache-modperlm=96869790426565w=2 * get/set handlers issues Report: http://marc.theaimsgroup.com/?l=apache-modperlm=95721313917562w=2 Status: patch available http://perl.apache.org/~dougm/set_handlers.pat * Apache::test Report: http://marc.theaimsgroup.com/?l=apache-modperl-devm=98278446807561w=2 Status: patch available Needs Patch or Further Investigation * readdir() broken on linux with glibc 2.2 Report: http://marc.theaimsgroup.com/?l=apache-modperlm=98824089613574w=2 Status: * SERVER_MERGE and DIR_MERGE Report: http://marc.theaimsgroup.com/?l=apache-modperlm=97351976714878w=2 Status: The require() part may be legitimate. personally, I never understood the DIR_CREATE happening before SERVER_CREATE either, but it doesn't seem to affect anything. the double DIR_MERGE is just a misunderstanding on Andy's part and is a result of how Apache handles Location before and after translation. --Geoff * warn() going to the wrong log Report: http://marc.theaimsgroup.com/?l=apache-modperlm=98190005604037w=2 Status: coincidentially, I've noticed that s-error_fname is not populated in a vhost when the vhost relies on the ErrorLog from the main server --Geoff * segfaults with DBI-connect (mysql) Report: http://marc.theaimsgroup.com/?l=apache-modperlm=96392180616185w=2 Status: * revisit send_http_header and r-status Report: http://marc.theaimsgroup.com/?l=apache-modperlm=99063926111686w=2 Status: * Apache-server-register_cleanup Report: ? Status: * bleedperl TIEHANDLE issues? Report: http://marc.theaimsgroup.com/?l=apache-modperl-devm=99909095916498w=2 Status: * bleedperl AUTOLOAD XSUB issues Report: http://marc.theaimsgroup.com/?l=apache-modperl
Re: mod_perl Programmers demand is going up...
I might as well pile on :-) At TimeBills.com (www.timebills.com) we are looking for smart, talented mod_perl/perl developers to help us build a complete suite of small business applications. We are location in Boston (Back bay for now, moving to South Station in January). Seed funded and in the final throes of a solid first round of VC funding. Open Source shop as much as possible, Linux, Apache, Mod_perl, CVS, Emacs etc. We have a really good, fun crew, good option packages, experienced management, lots of upside etc. Check out our web site, play with the application and if you are interested drop me an email. -- Geoff Crawshaw CTO TimeBills.com Inc. [EMAIL PROTECTED] http://www.timebills.com Andy Pruitt - Fri, Dec 03, 1999 at 07:38:46PM -0600 Me too Yet Another Well Funded Startup Company: DigitalWork.com location: Chicago, IL company: E-Commere B2B startup, probably largest true startup in Chicago assets: 4 rounds of funding, VC's include Draper, Fisher Jurvetson culture: startup -- stock options, pool table, stock options, playstation, stock options, free drinks, smart folks, stock options, etc hardware: Sun, Linux farm software: apache 1.3.9/mod_perl 1.2.1 HTML::Mason Oracle8i We're looking to hire as many folks as we can. We really are pre-IPO, but only are recruiters and PR people can talk about that part. /Me too From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Kreimendahl, Chad J Sent: Friday, December 03, 1999 9:51 AM To: '[EMAIL PROTECTED]'; mod_perl list Subject: RE: mod_perl Programmers demand is going up... I can describe what I mean when I say "mod_perl experience". I think that to most it means this as well. mod_perl experience is just a nifty word to aid in the finding of someone who has the style of perl which fits the requirements of mod_perl. The ability to keep everything within scope; ability to write modular code; an overall c programming style to perl. Whether or not you've actually written anything for to be run under a mod_perl apache doesn't really mean much. If someone familiar with programming for mod_perl were to look at your code, it would be fairly easy for me to see if you had the ability to be a mod_perl developer. In fact... if anyone is interested in a job using mod_perl... I need 3 people by the end of this month. a little background on the company, project and group. Company: location: Kansas city, mo company: financial institution assets: 7+ billion culture: suits (overall bank culture) Group: Internet services culture: laid back, open environment, no real dress code, flexible time, smart people Project: business to business e-commerce site hardware: Sun Cluster software: apache 1.3.9/stronghold/mod_perl 1.2.1 (Solaris 2.6) CVS Oracle 8i The money is very good for the region... email me if you're interested From: Scott Chapman [mailto:[EMAIL PROTECTED]] Sent: Friday, December 03, 1999 9:35 AM To: mod_perl list Subject: Re: mod_perl Programmers demand is going up... I am new to Mod_Perl. I don't know what all it's good for. My question is, what do they mean by "mod_perl experience". I can compile Apache with mod_perl and make emb_perl work correctly but I highly doubt that is all they are after. Being new to this, I'd like some perspective from those more experienced.
Stop stat() of script
Any pointers on how to stop apache from stat()'ing and reloading a script (running under mod_perl) that has changed on disk? -- Geoff Crawshaw TimeBills.com Inc. [EMAIL PROTECTED] http://www.timebills.com
