Re: Apache::PerlRun - Constant subroutine redefined

2004-10-19 Thread David Radunz
Philippe I know your buisy with mod_perl 2 stuff at the moment, but I
hope you get a chance to look at this when your free - unless the author
of the code is someone else and you just recommended it?

Anyway, Let me know.

David

On Mon, 2004-10-11 at 12:25, David Radunz wrote:
> Further to that - I just tested with an even bigger string and this one
> did get cleared fine, so it musnt be the size :(
> 
> Not sure what the problem is,
> 
> DJ
> 
> On Mon, 2004-10-11 at 12:13, David Radunz wrote:
> > Hey,
> > 
> >   Thanks for your help. I tried using Devel::Unload to see how it works
> > and encountered something unexpected. Basically I put the
> > 'unload_package_xs' call just above the 'flush_namespace' call. Then I
> > printed from within the namespace clearing loop (expecting nothing to be
> > printed), yet something did get printed..
> > 
> > Flushing
> > Apache::ROOTsmog_2edev_2enetspace_2enet_2eau::client_2dinfo_2dpr::chargespage_2ecgi::qs
> > Flushing
> > Apache::ROOTsmog_2edev_2enetspace_2enet_2eau::client_2dinfo_2dpr::paymentspage_2ecgi::qs
> > Flushing
> > Apache::ROOTsmog_2edev_2enetspace_2enet_2eau::client_2dinfo_2dpr::homeadslclientpage_2ecgi::qs
> > 
> > Which isnt that bad, because the rest of the namespace had been cleared,
> > except this lonley scalar - I printed it to see if it contained anything
> > and got the following:
> > 
> >   Scalar = SELECT DECODE (i wont paste the whole scalar here, its
> > basically a huge SQL statement, about 2000 characters).
> > 
> > Perhaps the scalar was too big to be cleared?
> > 
> > Cheers,
> > 
> > DJ
> > 
> > 
> > On Sat, 2004-10-09 at 09:08, Philippe M. Chiasson wrote:
> > > Stas Bekman wrote:
> > > 
> > > > David Radunz wrote:
> > > >
> > > >> Hi All,
> > > >>
> > > >>   I have looked high and low to work out how to avoid the 'Constant
> > > >> subroutine redefined' warnings in the error log, followed by the
> > > >> 'Prototype missmatch:' error upon subsequent hits to the apache child
> > > >> process - but, I have not been able to find an easy solution. The
> > > >> warnings are caused by the 'flush_namespace' routine of Apache::PerlRun
> > > >> which attempts to reset/nullify everything - including constants. When a
> > > >> constant is redefined it causes a warning in the error_log, and when the
> > > >> constant gets reset upon the next run of the script the prototype doesnt
> > > >> match as its reset incorrectly.
> > > >
> > > >
> > > > David, take a look at the ModPerl::PerlRun which now 
> > > > http://cvs.apache.org/viewcvs.cgi/modperl-2.0/ModPerl-Registry/lib/ModPerl/RegistryCooker.pm?r1=1.50&r2=1.51&diff_format=h
> > > >
> > > > uses:
> > > > http://perl.apache.org/docs/2.0/api/ModPerl/Util.html#C_unload_package_
> > > > which Philippe has just added recently. (you will need the current mp2 
> > > > cvs to see it at works). It solves all these problems in a much 
> > > > cleaner way. It's still too new to new to be sure that it doesn't have 
> > > > side-effects, but once it's proved to be good by users, we can just 
> > > > port it back to mp1.
> > > 
> > > It's also available as a yet to be released on CPAN module 
> > > (Devel::Unload) here: http://svn.ectoplasm.org/projects/perl/Devel-Unload/
> > > 
> > > You might just try installing Devel::Unload and plugging it into 
> > > PerlRun.pm and see if it works
> > > 
> > > (untested patch)
> > > 
> > > Index: lib/Apache/PerlRun.pm
> > > ===
> > > RCS file: /home/cvs/modperl/lib/Apache/PerlRun.pm,v
> > > retrieving revision 1.41
> > > diff -u -I$Id -r1.41 PerlRun.pm
> > > --- lib/Apache/PerlRun.pm   8 Mar 2003 04:11:09 -   1.41
> > > +++ lib/Apache/PerlRun.pm   8 Oct 2004 23:08:02 -
> > > @@ -118,6 +118,8 @@
> > >  $_r->clear_rgy_endav;
> > >  $_r->log_error("Apache::PerlRun->compile") if $Debug && $Debug & 4;
> > >  Apache->untaint($$eval);
> > > +use Devel::Unload;
> > > +Devel::Unload::unload_package_xs($pr->namespace);
> > >  {
> > > no strict; #so eval'd code doesn't inherit our bits
> > > eval $$eval;
> > > 
> > > > If you want to look at the C code that does that, it's 
> > > > modperl_package_unload in:
> > > > http://cvs.apache.org/viewcvs.cgi/modperl-2.0/src/modules/perl/modperl_util.c?view=markup
> > > >
> > > >
> > -- 
> > David Radunz,
> > Developer / Programmer
> > 
> > Netspace Online Systems Pty Ltd
> > Ground Floor, 293 Camberwell Road
> > Camberwell, Victoria 3124
> > Ph:  +613 9811 0087
> > Fx:  +613 9811 0044
> > Mo:  +614 0549 9719
> > Em:  [EMAIL PROTECTED]
> > 
> > This email and any files transmitted with it are confidential and intended solely 
> > for the 
> > use of the individual or entity to whom they are addressed. Please notify the 
> > sender 
> > immediately by email if you have received this email by mistake and delete this 
> > email 
> > from your system. Please note that any views or opinions presented in this email 
> > are

Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Randy Kobes
On Tue, 19 Oct 2004, Philippe M. Chiasson wrote:

> a release candidate for mod_perl 1.99_17 is now available for testing.

On Win32 (ActivePerl 810, based on perl 5.8.4), with
Apache/2.0.50, there's a couple of (minor) issues:

- the last test of directive/setupenv.t fails: this tests
that $ENV{HOME} doesn't exist. For me (and I have $ENV{HOME}
set), the test does see the set value of $ENV{HOME}.

- the last test of protocol/echo_nonblock.t failed when
the full test suite was run, but passes individually,
and also passes when the t/protocol/*.t set is run.
I'll try t/SMOKE to see if it can find a minimal
combination that fails, but for now, I don't think
this is a showstopper (and probably neither is the
$ENV{HOME} issue).

-- 
best regards,
randy

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Re: [mp2] a content filter was added without a request: includes

2004-10-19 Thread Stas Bekman
Torsten Förtsch wrote:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
I am getting such errors:
[Tue Oct 19 18:36:28 2004] [error] a content filter was added without a 
request: includes

for _every_ request when using PerlSetOutputFilter instead of SetOutputFilter
[...]
The PerlSetOutputFilter directive is placed in a  block but 
outside of any  or .

Placing it into a  block makes the messages disappear.
In both cases the filter does work.
Can you please show the relevant configuration parts?
--
__
Stas BekmanJAm_pH --> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com
--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html


Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Philippe M. Chiasson
Stas Bekman wrote:
Carl Brewer wrote:
*** The httpd binary was not found
Please ignore that. It's a bug in Apache-Test that I've introduced and I 
know that I need to fix that. It's just far from being trivial. I'm still 
sleeping on it. It has nothing to do with mod_perl...
Sure, as I think I also know what's involved here, I am more than happy to
know it's someone else's problem. Thanks stas!

--

Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5


signature.asc
Description: OpenPGP digital signature


Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Stas Bekman
Carl Brewer wrote:
*** The httpd binary was not found
Please ignore that. It's a bug in Apache-Test that I've introduced and I 
know that I need to fix that. It's just far from being trivial. I'm still 
sleeping on it. It has nothing to do with mod_perl...

--
__
Stas BekmanJAm_pH --> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com
--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html


Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Philippe M. Chiasson

Carl Brewer wrote:
Philippe M. Chiasson wrote:
a release candidate for mod_perl 1.99_17 is now available for testing.

Compiled & works like a charm on NetBSD 1.6.2/i386
with normal (BSD) make even.  mp2bug can't find the
httpd binaryu though, but that's pretty minor.
Did you run bin/mp2bug from the mod_perl build directory, or from it's installed
location ?
>
> [...]
--

Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5


signature.asc
Description: OpenPGP digital signature


Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Carl Brewer
Philippe M. Chiasson wrote:
Could you post your /data/src/modperl-2.0/bin/../lib/Apache/BuildConfig.pm
in it's entirety ?

steel1: {23} cat /data/src/modperl-2.0/bin/../lib/Apache/BuildConfig.pm
#
# /*
#  * *** WARNING **
#  * This file generated by Apache::Build/0.01
#  * Any changes made here will be lost
#  * ***
#  * 01: lib/ModPerl/Code.pm:702
#  * 02: lib/Apache/Build.pm:810
#  * 03: lib/Apache/Build.pm:827
#  * 04: Makefile.PL:326
#  * 05: Makefile.PL:92
#  */
#
package Apache::BuildConfig;
use Apache::Build ();
sub new {
bless( {
 'MODPERL_AR' => 'ar',
 'MODPERL_OBJ_EXT' => '.o',
 'ap_includedir' => '/usr/local/apache2/include',
 'MODPERL_O_FILES' => 'mod_perl.o modperl_interp.o 
modperl_tipool.o modperl_log.o modperl_config.o modperl_cmd.o 
modperl_options.o modperl_callback.o modperl_handler.o modperl_gtop.o 
modperl_util.o modperl_io.o modperl_io_apache.o modperl_filter.o 
modperl_bucket.o modperl_mgv.o modperl_pcw.o modperl_global.o 
modperl_env.o modperl_cgi.o modperl_perl.o modperl_perl_global.o 
modperl_perl_pp.o modperl_sys.o modperl_module.o modperl_svptr_table.o 
modperl_const.o modperl_constants.o modperl_apache_compat.o 
modperl_error.o modperl_debug.o modperl_common_util.o 
modperl_common_log.o modperl_hooks.o modperl_directives.o 
modperl_flags.o modperl_xsinit.o modperl_exports.o',
 'MP_USE_DSO' => 1,
 'MODPERL_O_PIC_FILES' => 'mod_perl.lo 
modperl_interp.lo modperl_tipool.lo modperl_log.lo modperl_config.lo 
modperl_cmd.lo modperl_options.lo modperl_callback.lo modperl_handler.lo 
modperl_gtop.lo modperl_util.lo modperl_io.lo modperl_io_apache.lo 
modperl_filter.lo modperl_bucket.lo modperl_mgv.lo modperl_pcw.lo 
modperl_global.lo modperl_env.lo modperl_cgi.lo modperl_perl.lo 
modperl_perl_global.lo modperl_perl_pp.lo modperl_sys.lo 
modperl_module.lo modperl_svptr_table.lo modperl_const.lo 
modperl_constants.lo modperl_apache_compat.lo modperl_error.lo 
modperl_debug.lo modperl_common_util.lo modperl_common_log.lo 
modperl_hooks.lo modperl_directives.lo modperl_flags.lo 
modperl_xsinit.lo modperl_exports.lo',
 'MP_APXS' => '/usr/local/apache2/bin/apxs',
 'MODPERL_AP_INCLUDEDIR' => '/usr/local/apache2/include',
 'apr_bindir' => '/usr/local/apache2/bin',
 'APXS_INCLUDEDIR' => '/usr/local/apache2/include',
 'MODPERL_RM' => 'rm',
 'file_ldopts' => 'src/modules/perl/ldopts',
 'MODPERL_CPPRUN' => 'cc -E',
 'cwd' => '/data/src/modperl-2.0',
 'MODPERL_RANLIB' => ':',
 'MP_GENERATE_XS' => 1,
 'APXS_APU_BINDIR' => '/usr/local/apache2/bin',
 'MODPERL_ARCHLIBEXP' => 
'/usr/local/perl-5.8.5/lib/5.8.5/i386-netbsd',
 'MODPERL_LIB_DSO' => 'mod_perl.so',
 'APXS_BINDIR' => '/usr/local/apache2/bin',
 'MODPERL_XSUBPP' => '$(MODPERL_PERLPATH) 
$(MODPERL_PRIVLIBEXP)/ExtUtils/xsubpp -typemap 
$(MODPERL_PRIVLIBEXP)/ExtUtils/typemap -typemap 
/data/src/modperl-2.0/lib/typemap',
 'MODPERL_PRIVLIBEXP' => '/usr/local/perl-5.8.5/lib/5.8.5',
 'MODPERL_LIB_STATIC' => 'mod_perl.a',
 'MODPERL_RM_F' => 'rm -f',
 'MODPERL_MAKEFILE' => 'Makefile',
 'MODPERL_CCOPTS' => ' -fno-strict-aliasing -pipe 
-I/usr/pkg/include -I/usr/local/perl-5.8.5/lib/5.8.5/i386-netbsd/CORE 
-DMOD_PERL -DMP_COMPAT_1X -DNETBSD',
 'MODPERL_LDDLFLAGS' => '--whole-archive -shared 
-L/usr/pkg/lib -L/usr/local/lib',
 'MODPERL_INC' => 
'-I/data/src/modperl-2.0/src/modules/perl -I/data/src/modperl-2.0/xs 
-I/usr/local/apache2/include -I /usr/local/apache2/include 
-I/usr/local/apache2/include',
 'file_build_config' => 'lib/Apache/BuildConfig.pm',
 'XS' => {},
 'httpd_version' => {
  '/usr/local/apache2/include' => 
'2.0.52'
},
 'MP_COMPAT_1X' => 1,
 'apr_config' => {
   'HAS_FORK' => '1',
   'HAS_THREADS' => '0',
   'HAS_MMAP' => '1',
   'HAS_RANDOM' => '1',
   'HAS_DSO' => '1',
   'HAS_SENDFILE' => '0',
   'HAS_LARGE_FILES' => '0',
   'HAS_INLINE' => '1'
 },
 'MODPERL_LIBNAME' => 'mod_perl',
 'apr_config_path' => '/usr/local/apache2/bin/apr-config',
 'MODPERL_LIB_EXT' => '.a',
 'MODPERL_C_FILES' => 'mod_perl.c modperl_interp.c 
modperl_tipool.c modperl_log.c m

Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Philippe M. Chiasson

Carl Brewer wrote:
Philippe M. Chiasson wrote:
a release candidate for mod_perl 1.99_17 is now available for testing.
Compiled & works like a charm on NetBSD 1.6.2/i386
with normal (BSD) make even.
Great!
mp2bug can't find the
httpd binaryu though, but that's pretty minor.
Could you post your /data/src/modperl-2.0/bin/../lib/Apache/BuildConfig.pm
in it's entirety ?
steel1: {15} perl mp2bug
-8<-- Start Bug Report 8<--
1. Problem Description:
   [DESCRIBE THE PROBLEM HERE]
[...]
*** The httpd binary was not found 
--

Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5


signature.asc
Description: OpenPGP digital signature


Re: [RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Carl Brewer
Philippe M. Chiasson wrote:
a release candidate for mod_perl 1.99_17 is now available for testing.
Compiled & works like a charm on NetBSD 1.6.2/i386
with normal (BSD) make even.  mp2bug can't find the
httpd binaryu though, but that's pretty minor.
steel1: {15} perl mp2bug
-8<-- Start Bug Report 8<--
1. Problem Description:
  [DESCRIBE THE PROBLEM HERE]
2. Used Components and their Configuration:
*** mod_perl version 1.9917
*** using /data/src/modperl-2.0/bin/../lib/Apache/BuildConfig.pm
*** Makefile.PL options:
  MP_APR_LIB => aprext
  MP_APXS=> /usr/local/apache2/bin/apxs
  MP_COMPAT_1X   => 1
  MP_GENERATE_XS => 1
  MP_LIBNAME => mod_perl
  MP_USE_DSO => 1
*** The httpd binary was not found
*** (apr|apu)-config linking info
 -L/usr/local/apache2/lib -lapr-0 -lm -lcrypt -lresolv
 -L/usr/local/apache2/lib -laprutil-0 -lexpat

*** /usr/local/perl-5.8.5/bin/perl -V
Summary of my perl5 (revision 5 version 8 subversion 5) configuration:
  Platform:
osname=netbsd, osvers=1.6.2, archname=i386-netbsd
uname='netbsd steel1.stealstopper.com 1.6.2 netbsd 1.6.2 (generic) 
#0: tue feb 10 21:53:10 utc 2004 
[EMAIL PROTECTED]:autobuildnetbsd-1-6-patch002i386objautobuildnetbsd-1-6-patch002srcsysarchi386compilegeneric 
i386 '
config_args=''
hint=recommended, useposix=true, d_sigaction=define
usethreads=undef use5005threads=undef useithreads=undef 
usemultiplicity=undef
useperlio=define d_sfio=undef uselargefiles=define usesocks=undef
use64bitint=undef use64bitall=undef uselongdouble=undef
usemymalloc=y, bincompat5005=undef
  Compiler:
cc='cc', ccflags ='-fno-strict-aliasing -pipe -I/usr/pkg/include',
optimize='-O',
cppflags='-fno-strict-aliasing -pipe -I/usr/pkg/include'
ccversion='', gccversion='2.95.3 20010315 (release) (NetBSD nb3)', 
gccosandvers=''
intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', 
lseeksize=8
alignbytes=4, prototype=define
  Linker and Libraries:
ld='cc', ldflags =' -Wl,-rpath,/usr/pkg/lib 
-Wl,-rpath,/usr/local/lib -L/usr/pkg/lib -L/usr/local/lib'
libpth=/usr/pkg/lib /usr/local/lib /usr/lib
libs=-lm -lcrypt -lutil -lc -lposix
perllibs=-lm -lcrypt -lutil -lc -lposix
libc=/usr/lib/libc.so, so=so, useshrplib=true, libperl=libperl.so
gnulibc_version=''
  Dynamic Linking:
dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E 
-Wl,-R/usr/local/perl-5.8.5/lib/5.8.5/i386-netbsd/CORE'
cccdlflags='-DPIC -fPIC ', lddlflags='--whole-archive -shared 
-L/usr/pkg/lib -L/usr/local/lib'

Characteristics of this binary (from libperl):
  Compile-time options: USE_LARGE_FILES
  Built under netbsd
  Compiled at Aug 25 2004 14:17:37
  %ENV:
PERL_LWP_USE_HTTP_10="1"
  @INC:
/usr/local/perl-5.8.5/lib/5.8.5/i386-netbsd
/usr/local/perl-5.8.5/lib/5.8.5
/usr/local/perl-5.8.5/lib/site_perl/5.8.5/i386-netbsd
/usr/local/perl-5.8.5/lib/site_perl/5.8.5
/usr/local/perl-5.8.5/lib/site_perl
/usr/local/perl-5.8.4
/usr/local/perl-5.8.1
.
*** Packages of interest status:
Apache::Request: -
CGI: 3.05
LWP: 5.800
mod_perl   : 1.9917
3. This is the core dump trace: (if you get a core dump):
  [CORE TRACE COMES HERE]
This report was generated by mp2bug on Tue Oct 19 22:37:48 2004 GMT.
-8<-- End Bug Report --8<--
steel1: {20} /usr/local/apache2/bin/httpd -V
Server version: Apache/2.0.52
Server built:   Sep 29 2004 08:31:16
Server's Module Magic Number: 20020903:9
Architecture:   32-bit
Server compiled with
 -D APACHE_MPM_DIR="server/mpm/prefork"
 -D APR_HAS_MMAP
 -D APR_HAVE_IPV6 (IPv4-mapped addresses disabled)
 -D APR_USE_SYSVSEM_SERIALIZE
 -D SINGLE_LISTEN_UNSERIALIZED_ACCEPT
 -D APR_HAS_OTHER_CHILD
 -D AP_HAVE_RELIABLE_PIPED_LOGS
 -D HTTPD_ROOT="/usr/local/apache2"
 -D SUEXEC_BIN="/usr/local/apache2/bin/suexec"
 -D DEFAULT_PIDLOG="logs/httpd.pid"
 -D DEFAULT_SCOREBOARD="logs/apache_runtime_status"
 -D DEFAULT_LOCKFILE="logs/accept.lock"
 -D DEFAULT_ERRORLOG="logs/error_log"
 -D AP_TYPES_CONFIG_FILE="conf/mime.types"
 -D SERVER_CONFIG_FILE="conf/httpd.conf"
--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html


[RELEASE CANDIDATE] mod_perl-1.99_17 RC1

2004-10-19 Thread Philippe M. Chiasson
a release candidate for mod_perl 1.99_17 is now available for testing.
please grab the candidate from
  http://www.apache.org/~gozer/mp2/mod_perl-1.99_17/mod_perl-1.99_17-RC1.tar.gz 
and report back successes or failures.  when reporting failures, please see
the bug reporting guidelines at
  http://perl.apache.org/bugs/
so your report can get the best attention possible.
--The mod_perl Development Team
Changes since the previous release:
Implement Apache->unescape_url_info in Apache::compat and drop it
from the official API for CGI::Util::unescape() as a suggested
replacement [Gozer]
fix xs_generate to croak on duplicate entries in xs/maps files
[Christian Krause ]
Workaround a possible bug in Perl_load_module() [Gozer]
Fix a problem building with non-GNU make (can't make target dynamic
in xs/APR/aprext) [Gozer]
escape HTML in dumped variables by Apache::Status [Markus Wichitill
<[EMAIL PROTECTED]>]
$r->document_root can now be changed when safe to do so [Gozer]
APR::Bucket->new now requires an APR::BucketAlloc as its first argument.
New subs added: APR::Bucket::setaside, APR::Bucket::alloc_create,
APR::Bucket::alloc_destroy, APR::Brigade::bucket_alloc. [joes]
reimplement APR::Pool life-scope handling, (the previous
implementation had problems) [joes]
make sure that Apache::Filter::read, APR::Socket::recv,
Apache::RequestIO::read, APR::Brigade::flatten, and APR::Bucket::read
all return tainted data under -T [Stas]
tag the custom pools created by mod_perl for easier pools debug [Joe
Orton]
fix a bug in non-ithreaded-perl implementation where the cached
compiled CODE refs of httpd.conf-inlined one-liner handlers like:
PerlFixupHandler 'sub { use Apache::Const qw(DECLINED); DECLINED }'
didn't have the reference count right. [Stas]
per-server PerlSetEnv and PerlPassEnv values are properly added
to %ENV when only a per-directory handler is configured.
[Geoffrey Young]
resolve several 'Use of uninitialized value in...' warnings in
Apache::Status [Stas].
make install and static build now correctly installs mod_perl as
well as the statically built apache [Gozer]
if some code changes the current interpreter's tainted state to on,
the return value from the handler callback will be tainted, and we
fail to deal with that. So revert to coercing any return value, but
undef (a special case for exit()). to IV, so that tainted values are
handled correctly as well. [Stas]
make sure that each handler callback starts with a pristine
tainted-ness state, so that previous callback calls won't affect the
consequent ones. Without this change any handler triggering eval or
another function call, that checks TAINT_PROPER, will crash mod_perl
with: "Insecure dependency in eval while running setgid. Callback
called exit." farewell message [Stas]
make sure that 'make distclean' cleans all the autogenerated files
[Stas]
$r->log_reason has been ported and moved out of Apache::compat
[Gozer]
APR::OS::thread_current renamed APR::OS::current_thread_id and
now returns the actual thread_id instead of an object that
needed to be dereferenced to get at the thread_id [Gozer]
change a bunch of the APR:: constants to have a better prefix
(APR::FILETYPE_* and APR::FILEPROT_). libapr will be changed soon too
[Stas]
Generate modperl_exports.c for static builds to prevent the
linker from stripping needed but unused symbols [Gozer]
Add .libs/ as part of the library search path when building
against httpd's source tree [Gozer]
In the static build, run make in httpd's srclib/ early to have
generated files present at mod_perl configure time [Gozer]
When searching for ap(r|u)-config in httpd's source tree, search
into srclib/apr-util as well as srclib/apr [Gozer]
Remove APR::Finfo::pool as it has no use to us [Stas]
get PerlSetVar and PerlAddVar multi-level merges to (finally) work
properly.  [Rici Lake ]
MP_AP_BUILD configure option removed. Now implicit when MP_USE_STATIC
is specified [Gozer]
Apache::Module $mod->version() and $mod->minor_version() renamed
to $mod->ap_api_major_version() and $mod->ap_api_minor_version
for clarity [Gozer]
Apache::Log changes: [Stas]
  - moved to compat: Apache::warn, Apache->warn, Apache::Server->warn,
Apache::Server::warn
  - re-enabled $r->warn
  - removed support for Apache::ServerRec->warn
(Apache::ServerRec::warn is still there)
Apache::Directive conftree() changed from class method to
regular subroutine [Gozer]
Apache::Module top_module() and get_config() as class methods
added to Apache::compat for backwards compatibility [Gozer]
Apache::Module top_module() and get_config() changed from class
methods to regular subroutines [Gozer]
Added Apache::CmdParms::add_config() to work around a memory
leak discovered with  sections in .htaccess files [Gozer]
Added ModPerl::Util::unload_package() to remove a loaded package
as thoroughly as possible by clearing it's stash. [Gozer]
fix Apache->request($r) to be set-able even w/: PerlOptions
-GlobalRequest [Stas]
Add Apache::Reload->unregister_module() to explicitely remo

Re: [mp1] Bug - version listed as 1.27 instead of 1.29. Patch included

2004-10-19 Thread Geoffrey Young


Max Baker wrote:
> I found a typo where version 1.27 is hardcoded into version 1.29 and so if
> you do a 
> 
> perl -MApache -e 'print $Apache::VERSION' you get 1.27 instead of 1.29.


this number is internal to Apache.pm and isn't intended to match the release
version.  you can see where doug last bumped $Apache::VERSION, October 3, 2000.

  http://cvs.apache.org/viewcvs.cgi/modperl/Apache/Apache.pm?r1=1.54&r2=1.55

which was in preparation for mod_perl release 1.24_01 on October 10, 2000.

the only official place to check for the mod_perl version is mod_perl.pm via
$mod_perl::VERSION.

> -#define MP_APACHE_VERSION "1.27"
> +#define MP_APACHE_VERSION "1.29"

this is intended to match $Apache::VERSION in order to make sure that the
proper Apache.xs is being used, I suspect due to binary compatibility
issues, which is really what doug looked like he was trying to track.

HTH

--Geoff

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



[mp2] a content filter was added without a request: includes

2004-10-19 Thread Torsten Förtsch
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

I am getting such errors:

[Tue Oct 19 18:36:28 2004] [error] a content filter was added without a 
request: includes

for _every_ request when using PerlSetOutputFilter instead of SetOutputFilter

I am using apache 2.0.52 with mp 1.99_16.

The message comes from server/util_filter.c:

if (frec->ftype < AP_FTYPE_PROTOCOL) {
if (r) {
outf = r_filters;
}
else {
ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
  "a content filter was added without a request: %s", 
frec->name);
return NULL;
}
}
else if (frec->ftype < AP_FTYPE_CONNECTION) {
if (r) {
outf = p_filters;
}
else {
ap_log_error(APLOG_MARK, APLOG_ERR, 0, NULL,
 "a protocol filter was added without a request: %s", 
frec->name);
return NULL;
}
}
else {
outf = c_filters;
}

The PerlSetOutputFilter directive is placed in a  block but 
outside of any  or .

Placing it into a  block makes the messages disappear.

In both cases the filter does work.

Torsten
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBdVjOwicyCTir8T4RAg4rAJ48qAwm5QM0GnEG3FKcF/nPp+PlNgCfSoC8
Y28icyrRRKacwmG2WGgxKrU=
=5eeJ
-END PGP SIGNATURE-

--
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Re: Apache::Singleton

2004-10-19 Thread Frank Wiles
On Tue, 19 Oct 2004 10:02:06 -0700
Kevin Spencer <[EMAIL PROTECTED]> wrote:

> On Mon, 18 Oct 2004 12:34:28 -0500, Frank Wiles <[EMAIL PROTECTED]>
> wrote:
> > 
> >   Hi Everyone,
> > 
> >   I've been trying to reach the maintainer of Apache::Singleton with
> >   very little success.  His name is Tatsuhiko Miyagawa
> >   <[EMAIL PROTECTED]> I supplied him with a patch that makes the
> >   module work under both mp1 and mp2 back in April and haven't been
> >   able to contact him since. Nor has there been any updated version
> >   posted to CPAN. I'm posting here as a last ditch attempt at
> >   reaching him.
> > 
> >   If anyone knows him or a better way to contact him please pass
> >   this along to him.  I'd be more than willing to take over these
> >   modules if he is no longer interested in maintaining them.
> 
> According to his use.perl journal, he released a new version of
> Apache::Singleton today.
> 
> http://use.perl.org/~miyagawa/journal/21404

  Yes I was able to contact him off list with the E-mail address Stas
  was able to find.  Thanks Stas! 

 -
   Frank Wiles <[EMAIL PROTECTED]>
   http://www.wiles.org
 -


-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



Re: Apache::Singleton

2004-10-19 Thread Kevin Spencer
On Mon, 18 Oct 2004 12:34:28 -0500, Frank Wiles <[EMAIL PROTECTED]> wrote:
> 
>   Hi Everyone,
> 
>   I've been trying to reach the maintainer of Apache::Singleton with
>   very little success.  His name is Tatsuhiko Miyagawa
>   <[EMAIL PROTECTED]> I supplied him with a patch that makes the
>   module work under both mp1 and mp2 back in April and haven't been
>   able to contact him since. Nor has there been any updated version
>   posted to CPAN. I'm posting here as a last ditch attempt at reaching
>   him.
> 
>   If anyone knows him or a better way to contact him please pass
>   this along to him.  I'd be more than willing to take over these
>   modules if he is no longer interested in maintaining them.

According to his use.perl journal, he released a new version of
Apache::Singleton today.

http://use.perl.org/~miyagawa/journal/21404

--
Kev.

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html



[mp1] Bug - version listed as 1.27 instead of 1.29. Patch included

2004-10-19 Thread Max Baker
I found a typo where version 1.27 is hardcoded into version 1.29 and so if
you do a 

perl -MApache -e 'print $Apache::VERSION' you get 1.27 instead of 1.29.

Attached is a patch.
-m
diff -ruN mod_perl-1.29/Apache/Apache.pm mod_perl-1.29.fixed/Apache/Apache.pm
--- mod_perl-1.29/Apache/Apache.pm  Wed Feb 19 22:54:23 2003
+++ mod_perl-1.29.fixed/Apache/Apache.pmTue Oct 19 09:49:37 2004
@@ -20,7 +20,7 @@
 
 {
 no strict;
-$VERSION = "1.27";
+$VERSION = "1.29";
 __PACKAGE__->mod_perl::boot($VERSION);
 }
 
diff -ruN mod_perl-1.29/src/modules/perl/mod_perl.c 
mod_perl-1.29.fixed/src/modules/perl/mod_perl.c
--- mod_perl-1.29/src/modules/perl/mod_perl.c   Thu Oct  2 14:30:35 2003
+++ mod_perl-1.29.fixed/src/modules/perl/mod_perl.c Tue Oct 19 09:49:20 2004
@@ -502,7 +502,7 @@
 if(!PERL_IS_DSO) \
 register_cleanup(p, NULL, mp_server_notstarting, mod_perl_noop) 
 
-#define MP_APACHE_VERSION "1.27"
+#define MP_APACHE_VERSION "1.29"
 
 void mp_check_version(void)
 {

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html