cvs commit: modperl-2.0/todo api.txt
stas2003/02/18 20:07:17 Modified:todo api.txt Log: $uri-rpath is missing from APR::URI Revision ChangesPath 1.33 +3 -0 modperl-2.0/todo/api.txt Index: api.txt === RCS file: /home/cvs/modperl-2.0/todo/api.txt,v retrieving revision 1.32 retrieving revision 1.33 diff -u -r1.32 -r1.33 --- api.txt 17 Feb 2003 09:03:17 - 1.32 +++ api.txt 19 Feb 2003 04:07:17 - 1.33 @@ -28,6 +28,9 @@ needs to default to current pool (pconf at startup, r-pool at request time) +APR::URI +missing $uri-rpath + Apache::Util::* escape_path() - (was escape_uri) can be changed in apache not to require a pool
cvs commit: modperl-2.0/todo api.txt
dougm 2002/06/03 17:44:24
Modified:lib/Apache compat.pm
t/response/TestApache compat2.pm
todo api.txt
Log:
add Apache-define compat method
Revision ChangesPath
1.60 +5 -0 modperl-2.0/lib/Apache/compat.pm
Index: compat.pm
===
RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
retrieving revision 1.59
retrieving revision 1.60
diff -u -r1.59 -r1.60
--- compat.pm 3 Jun 2002 18:27:03 - 1.59
+++ compat.pm 4 Jun 2002 00:44:23 - 1.60
-99,6 +99,11
return Symbol::gensym();
}
+sub define {
+shift if _ == 2;
+exists_config_define(_);
+}
+
package Apache::Constants;
use Apache::Const ();
1.16 +5 -1 modperl-2.0/t/response/TestApache/compat2.pm
Index: compat2.pm
===
RCS file: /home/cvs/modperl-2.0/t/response/TestApache/compat2.pm,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- compat2.pm3 Jun 2002 18:27:03 - 1.15
+++ compat2.pm4 Jun 2002 00:44:23 - 1.16
-24,7 +24,7
sub handler {
my $r = shift;
-plan $r, tests = 46;
+plan $r, tests = 47;
$r-send_http_header('text/plain');
-233,6 +233,10
ok t_cmp(!$r-main, $r-is_main,
'$r-is_main');
+
+ok t_cmp(Apache::exists_config_define('MODPERL2'),
+ Apache-define('MODPERL2'),
+ 'Apache-define');
#note these are not actually part of the tests
#since i think on platforms where crypt is not supported,
1.24 +0 -4 modperl-2.0/todo/api.txt
Index: api.txt
===
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- api.txt 25 May 2002 17:49:03 - 1.23
+++ api.txt 4 Jun 2002 00:44:23 - 1.24
-40,10 +40,6
1.x ht_time compat. should we just leave as is or see if ht_time can
be changed to not require a pool?
-Apache-define:
-exists as Apache::exists_config_define, which should stay,
-Apache::compat could implement a wrapper.
-
$r-document_root:
cannot currently be modified. requires locking since it is part of
the per-server config structure which is shared between threads
cvs commit: modperl-2.0/todo api.txt
stas02/01/28 21:41:59
Modified:todo api.txt
Log:
- no need to implement the interface for apr_array_header as there is no
use for it in mod_perl
Revision ChangesPath
1.20 +0 -3 modperl-2.0/todo/api.txt
Index: api.txt
===
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- api.txt 23 Dec 2001 04:30:28 - 1.19
+++ api.txt 29 Jan 2002 05:41:59 - 1.20
@@ -102,9 +102,6 @@
Apache-unescape_url{_info}:
not yet implemented. should be moved to Apache::Util
-apr_array_header_t:
-needs an interface, either methods and/or tied array interface
-
Apache::perl_hook:
should have this or something check if PerlOptions allows the given
handler/feature to be used.
cvs commit: modperl-2.0/todo api.txt
stas01/12/22 20:30:28
Modified:todo api.txt
Log:
- updates to the todo issue with send_fd.
Revision ChangesPath
1.19 +3 -1 modperl-2.0/todo/api.txt
Index: api.txt
===
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- api.txt 2001/12/20 18:12:15 1.18
+++ api.txt 2001/12/23 04:30:28 1.19
@@ -52,7 +52,9 @@
at the moment $r-send_fd is implement in Apache::compat, functions,
but does not have the performance benefits of ap_send_fd()
however, $r-sendfile is a new function that opens the file for you
-and calls ap_send_fd() underneath.
+and calls ap_send_fd() underneath. ap_send_fd() in APR doesn't work
+with fd's which aren't files and of unknown length, therefore it cannot
+be used for implementing 1.x compatible send_fd.
$r-{hard,reset,soft,kill}_timeout:
do not exist in 2.0. should be deprecated. consider adding noops in
cvs commit: modperl-2.0/todo api.txt
dougm 01/10/08 11:41:10
Modified:todo api.txt
Log:
2.0 has removed r-content_language
Revision ChangesPath
1.10 +0 -4 modperl-2.0/todo/api.txt
Index: api.txt
===
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- api.txt 2001/10/08 18:40:34 1.9
+++ api.txt 2001/10/08 18:41:10 1.10
@@ -112,10 +112,6 @@
Apache-unescape_url{_info}:
not yet implemented. should be moved to Apache::Util
-$r-content_language:
-deprecate in favor of $r-content_languages?
-would require that apache-2.0 is also rid of r-content_language usage
-
apr_array_header_t:
needs an interface, either methods and/or tied array interface
cvs commit: modperl-2.0/todo api.txt missing_old_features.txt
stas01/10/02 06:36:10
Modified:todo api.txt missing_old_features.txt
Log:
- Perl{Set|Add}Var and dir_config are implemented
Revision ChangesPath
1.7 +0 -3 modperl-2.0/todo/api.txt
Index: api.txt
===
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- api.txt 2001/09/28 13:51:57 1.6
+++ api.txt 2001/10/02 13:36:10 1.7
@@ -92,9 +92,6 @@
need to deal properly with modification of the current handler phase
we're running.
-$r-dir_config:
-depends on Perl{Set,Add}Var
-
Apache-httpd_conf:
depends on Perl sections
1.10 +1 -3 modperl-2.0/todo/missing_old_features.txt
Index: missing_old_features.txt
===
RCS file: /home/cvs/modperl-2.0/todo/missing_old_features.txt,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- missing_old_features.txt 2001/09/28 19:29:53 1.9
+++ missing_old_features.txt 2001/10/02 13:36:10 1.10
@@ -6,11 +6,9 @@
- PerlCleanupHandler
-- Perl{Set,Add}Var
-
- PerlSetEnv, PerlPassEnv
-- PerlModule, PerlRequire: missing support for .htaccess as 1.x does.
+- PerlModule, PerlRequire, Perl{Set,Add}Var in .htacess is missing
- pod directives (=pod,=back,=cut) and __END__
cvs commit: modperl-2.0/todo api.txt
dougm 01/09/28 06:51:57
Modified:lib/Apache compat.pm
todo api.txt
Log:
add $r-header_(in/out)() to Apache::compat
Submitted by: Philippe M . Chiasson [EMAIL PROTECTED]
Reviewed by: dougm
Revision ChangesPath
1.13 +29 -0 modperl-2.0/lib/Apache/compat.pm
Index: compat.pm
===
RCS file: /home/cvs/modperl-2.0/lib/Apache/compat.pm,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- compat.pm 2001/09/15 17:57:25 1.12
+++ compat.pm 2001/09/28 13:51:57 1.13
@@ -57,6 +57,35 @@
package Apache::RequestRec;
+sub table_set_get {
+my($r, $table) = (shift, shift);
+my($key, $value) = @_;
+
+if (1 == @_) {
+return $table-{$key};
+}
+elsif (2 == @_) {
+return $table-{$key} = $value;
+}
+elsif (0 == @_) {
+return $table;
+}
+else {
+my $name = (caller(1))[3];
+warn Usage: $name([key [,val]]);
+}
+}
+
+sub header_out {
+my $r = shift;
+return $r-table_set_get(scalar $r-headers_out, @_);
+}
+
+sub header_in {
+my $r = shift;
+return $r-table_set_get(scalar $r-headers_in, @_);
+}
+
sub register_cleanup {
shift-pool-cleanup_register(@_);
}
1.6 +0 -3 modperl-2.0/todo/api.txt
Index: api.txt
===
RCS file: /home/cvs/modperl-2.0/todo/api.txt,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- api.txt 2001/09/25 19:44:03 1.5
+++ api.txt 2001/09/28 13:51:57 1.6
@@ -9,9 +9,6 @@
need apr_finfo_t - struct stat conversion (might already be there,
haven't looked close enough yet)
-$r-header_{in,out}:
-deprecated, but should be included in Apache::compat
-
$r-pnotes:
not yet implemented
Re: cvs commit: modperl-2.0/todo api.txt
On Fri, 28 Sep 2001, Philippe M . Chiasson wrote: Aie ! There is a slight problem with this patch, as was pointed out by Stas a while ago. Blame it on the annoying TZ lag introduced in e-mail when living in Singapore ;-) This patch works, but doesn't preserve ARRAY context, thus: ok. could probably just pass wantarray to table_get_set and do: return $wantarray ? ($table-get($key)) : scalar $table-get($key)
