Re: [Mono-dev] Removing NET_2_0 define
On 18/10/13 14:58, Jonathan Pryor wrote: On Oct 16, 2013, at 10:00 AM, Alexander Köplinger wrote: Wouldn’t it make sense to remove the #if NET_2_0 checks in the codebase as those are now unnecessary (every profile is now 2.0 or later)? Or are they actually required for something? If not, I’d provide a pull request to clean up those checks. They are not required, but removing them would add extra "commit noise", which isn't necessary. Current "policy" (as it were) is to remove "nearby" `#if`s when modifying nearby code, so things can be improved in an ongoing basis without littering commit history. WRT git-blame, changing whitespace in existing code clutters commit history, but removing code doesn't. ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Removing NET_2_0 define
On Oct 16, 2013, at 10:00 AM, Alexander Köplinger wrote: > Wouldn’t it make sense to remove the #if NET_2_0 checks in the codebase as > those are now unnecessary (every profile is now 2.0 or later)? > Or are they actually required for something? If not, I’d provide a pull > request to clean up those checks. They are not required, but removing them would add extra "commit noise", which isn't necessary. Current "policy" (as it were) is to remove "nearby" `#if`s when modifying nearby code, so things can be improved in an ongoing basis without littering commit history. - Jon ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
Re: [Mono-dev] Removing NET_2_0 define
It can be removed. It wasn't done out of laziness. On Wed, Oct 16, 2013 at 10:00 AM, Alexander Köplinger < alex.koeplin...@outlook.com> wrote: > As far as I understand it, Mono now only supports the 2.0 and later > profiles. > > ** ** > > Wouldn’t it make sense to remove the #if NET_2_0 checks in the codebase as > those are now unnecessary (every profile is now 2.0 or later)? > > Or are they actually required for something? If not, I’d provide a pull > request to clean up those checks. > > ** ** > > Alex > > ** ** > > ___ > Mono-devel-list mailing list > Mono-devel-list@lists.ximian.com > http://lists.ximian.com/mailman/listinfo/mono-devel-list > > ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
[Mono-dev] Removing NET_2_0 define
As far as I understand it, Mono now only supports the 2.0 and later profiles. Wouldnt it make sense to remove the #if NET_2_0 checks in the codebase as those are now unnecessary (every profile is now 2.0 or later)? Or are they actually required for something? If not, Id provide a pull request to clean up those checks. Alex ___ Mono-devel-list mailing list Mono-devel-list@lists.ximian.com http://lists.ximian.com/mailman/listinfo/mono-devel-list
