Re: [Mono-winforms-list] [PATCH] Patch forSystem.Windows.Forms.Application to match MSDN specificationsfor Application Data

2008-02-13 Thread Justin Cherniak
Also note, I filed this bug (and my fix and testcase) as bug
361709
.

Thanks,
Justin Cherniak

On Wed, Feb 13, 2008 at 8:00 PM, Justin Cherniak <[EMAIL PROTECTED]>
wrote:

> Gert,
>
> Seemingly this passed under my radar and I forgot to submit my changes.
> Attached is the updated patch with the modified test cases.  If there is any
> way this could be committed to 1.9 (since in some cases its a showstopper
> bug), it would be much appreciated.
>
> Thanks,
> Justin Cherniak
>
>
> On Nov 3, 2007 8:22 PM, Gert Driesen <[EMAIL PROTECTED]> wrote:
>
> >  Justin,
> >
> > A few "small" remarks:
> >
> > 1) Your test should first verify that these directories do not exist
> > before the test is run, or perhaps remove them if they do exist.
> > 2) Your should add a TearDown in which you remove the directories that
> > were created by the unit test.
> > 3) Use tabs instead of spaces.
> > 4) It would also be nice if you could add tests that verify whether the
> > registry keys are in fact created (same principle here, ensure they do not
> > exist before your run the test to avoid false positives).
> >
> > I'd be happy to take care of these if you want.
> >
> > Gert
> >
> >  --
> > *From:* [EMAIL PROTECTED] [mailto:
> > [EMAIL PROTECTED] *On Behalf Of *Justin
> > Cherniak
> > *Sent:* zaterdag 3 november 2007 22:17
> > *To:* mono-winforms-list@lists.ximian.com
> > *Subject:* Re: [Mono-winforms-list] [PATCH] Patch
> > forSystem.Windows.Forms.Application to match MSDN specificationsfor
> > Application Data
> >
> > OK, Attached is the updates patch with new tests and ChangeLog entries.
> > Can I commit?
> >
> > Thanks,
> > Justin
> >
> > On Oct 31, 2007 9:33 AM, Andreia Gaita < [EMAIL PROTECTED]> wrote:
> >
> > > On 10/31/07, Justin Cherniak < [EMAIL PROTECTED]> wrote:
> > > > Let me ask, is there any documentation on writing tests, I'm a
> > > little
> > > > unclear on how/where to do this?
> > >
> > > Take a look at the Managed.Windows.Forms/Test/System.Windows.Forms
> > > directory, it has all the unit tests for mwf.  You basically set
> > > properties and Assert() them, look at ButtonTest, for instance, to see
> > >
> > > extensive property testing. ApplicationTest has the Application type
> > > tests, so your tests should go in there. Just create a new public void
> > > Method() marked with [Test], and add your tests. You can then run them
> > > with make run-test on MWF.
> > >
> > > andreia gaita
> > >
> >
> >
>
>
___
Mono-winforms-list maillist  -  Mono-winforms-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list


Re: [Mono-winforms-list] [PATCH] Patch forSystem.Windows.Forms.Application to match MSDN specificationsfor Application Data

2008-02-13 Thread Justin Cherniak
Gert,

Seemingly this passed under my radar and I forgot to submit my changes.
Attached is the updated patch with the modified test cases.  If there is any
way this could be committed to 1.9 (since in some cases its a showstopper
bug), it would be much appreciated.

Thanks,
Justin Cherniak


On Nov 3, 2007 8:22 PM, Gert Driesen <[EMAIL PROTECTED]> wrote:

>  Justin,
>
> A few "small" remarks:
>
> 1) Your test should first verify that these directories do not exist
> before the test is run, or perhaps remove them if they do exist.
> 2) Your should add a TearDown in which you remove the directories that
> were created by the unit test.
> 3) Use tabs instead of spaces.
> 4) It would also be nice if you could add tests that verify whether the
> registry keys are in fact created (same principle here, ensure they do not
> exist before your run the test to avoid false positives).
>
> I'd be happy to take care of these if you want.
>
> Gert
>
>  --
> *From:* [EMAIL PROTECTED] [mailto:
> [EMAIL PROTECTED] *On Behalf Of *Justin
> Cherniak
> *Sent:* zaterdag 3 november 2007 22:17
> *To:* mono-winforms-list@lists.ximian.com
> *Subject:* Re: [Mono-winforms-list] [PATCH] Patch
> forSystem.Windows.Forms.Application to match MSDN specificationsfor
> Application Data
>
> OK, Attached is the updates patch with new tests and ChangeLog entries.
> Can I commit?
>
> Thanks,
> Justin
>
> On Oct 31, 2007 9:33 AM, Andreia Gaita < [EMAIL PROTECTED]> wrote:
>
> > On 10/31/07, Justin Cherniak < [EMAIL PROTECTED]> wrote:
> > > Let me ask, is there any documentation on writing tests, I'm a little
> > > unclear on how/where to do this?
> >
> > Take a look at the Managed.Windows.Forms/Test/System.Windows.Forms
> > directory, it has all the unit tests for mwf.  You basically set
> > properties and Assert() them, look at ButtonTest, for instance, to see
> > extensive property testing. ApplicationTest has the Application type
> > tests, so your tests should go in there. Just create a new public void
> > Method() marked with [Test], and add your tests. You can then run them
> > with make run-test on MWF.
> >
> > andreia gaita
> >
>
>


ApplicationData.patch
Description: Binary data
___
Mono-winforms-list maillist  -  Mono-winforms-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list


Re: [Mono-winforms-list] PropertyGrid testing aims?

2008-02-13 Thread Ivan N. Zlatev
Andy Hume wrote:
> Hi Ivan
> 
> Andy Hume, logger of Mono bug reports here. :-,)
> 
> Just thought I'd drop you a note to see what your aims are for the 
> PropertyGrid in the short and longer term.  I'm guite willing to bang away on 
> it in my spare time and log bugs if that's useful to you.  Or maybe you're 
> working away on it yourself and will find the bugs anyway, and other bugs 
> would just get in the way. :-)  Let me know.
> 
> Andy
> 
> 

Hey Andy,

For the past two weeks I rewrote most of PropertyGrid and its 
components, so we have support for a lot of things now and better 
improved support for others. I hope you have noticed that during your 
testing. (We will ship the PropertyGrid with major improvements in 1.9 
hurray!)

Huge thanks for your bug reports and please keep them coming! I really 
appreciate your time and effort.

Short-term goals are:

  * Fix layout issues related to the scrollbar. They cause your bug 
#359199 and a couple of others with recursive collapse/expand.
  * Fix TypeDescriptor's Editors table and GetEditor to fix #358332 and 
a few others non-filed ones.
  * Fix the rest of the reported bugs.

Long-term goals are:

  * Implement PropertyTab support, so I can implement EventsTab.
  * Implement TypeDescriptor Associations and Providers.
  * Bugfix and implement Editors and Converters --> BTW, if you feel 
like coding those might be a quick and easy start.
  * Fix bugs, implement missing features, etc.

P.S: I CCed the mono-winforms list, so the information will be available 
for others as well. I hope you won't mind.

-- 
Ivan N. Zlatev

Web: http://www.i-nZ.net
"It's all some kind of whacked out conspiracy."
___
Mono-winforms-list maillist  -  Mono-winforms-list@lists.ximian.com
http://lists.ximian.com/mailman/listinfo/mono-winforms-list