Re: [Musicpd-dev-team] ncmpc updates
On 2009/03/13 04:59, Jeffrey Middleton jefr...@gmail.com wrote: Ready for pull: git pull git://git.musicpd.org/jefromi/ncmpc.git master Commit summaries: - Improved lyrics plugin handling: - try plugins in order of filename (previously by inode or whatever g_dir_read_name reads by) - prefix names with 01, 02, 03 to make the sorting obvious - correctly check if lyricswiki lyrics were found - Center the cursor on a second Ctrl-L - Switch save lyrics to CMD_SAVE_PLAYLIST (default S, more intuitive). Hopefully changing keys for a screen that's still default disabled is ok. - Turn off visual selection in keydef screen (no use currently) - Added option to control how long status messages are displayed (I get fidgety waiting three seconds) All of them merged! By the way, git helps you with writing this summary: try git shortlog origin.. I've also been thinking of having a look at mpc's options someday - maybe adding -q to mean fully quiet (e.g. mpc ls | mpc add produces a ton of output), implementing the --host and --port options... SInce mpc's option-handling isn't really set up well for short options yet this will require some changes. I could start from scratch with glib's fancy option functions, or since mpc doesn't have a heavy dependence on glib, I could bring over code from ncmpc (with credit of course) - would one of these be preferred over the other? First: libmpdclient and mpc should not have the heavy GLib dependency. People on embedded machines will hate us if we add GLib there. I'm used to the comfort of having GLib, but these two projects should be based on raw C99/POSIX. In general, there's a rule for Unix command line tools: if there's nothing to say, don't say anything at all. If adding succeeds, don't say a word (that's the standard, the expected result) - only if it fails. We can always have --verbose for those who prefer a talkative program. I'd say: use getopt() (and getopt_long() if available) to parse command line options. I have created a mpc repository for you. Max -- Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] [git pull] copyright header updates
On Fri, Mar 13, 2009 at 11:06 AM, Avuton Olrich avu...@gmail.com wrote: To those that were CCd: Please read the following, this may affect you. Max, Please pull from my tree. This commit updates every single source file for consistancy and update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Daemon Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy. I have ommitted the diff as it would be pretty large and touches a large amount of the files. I don't have a real name for fluffy, so for now I have not added that author but it can easily be added at a later date. If you as an author disagree and want it your name and email readded to the source file, just say the word, I will make it happen. Amended and forced for AudioCompress stuff. To pull: git://git.musicpd.org/avuton/mpd.git To view: http://git.musicpd.org/cgit/avuton/mpd.git/commit/?id=a811195379235cf4ec129b43354a65ed77d3caf6 -- AUTHORS |4 src/ack.h| 13 +++-- src/aiff.c |7 --- src/aiff.h |7 --- src/archive/bz2_plugin.c | 13 +++-- src/archive/iso_plugin.c | 13 +++-- src/archive/zip_plugin.c | 13 +++-- src/archive_api.c| 14 +++--- src/archive_api.h| 13 +++-- src/archive_internal.h | 13 +++-- src/archive_list.c | 13 +++-- src/archive_list.h | 13 +++-- src/audio.c | 13 +++-- src/audio.h | 13 +++-- src/audioOutput.c| 13 +++-- src/audioOutput.h| 13 +++-- src/audio_format.h | 13 +++-- src/audio_parser.c |7 --- src/audio_parser.h |7 --- src/buffer.c |7 --- src/buffer.h |7 --- src/buffer2array.c | 13 +++-- src/buffer2array.h | 13 +++-- src/chunk.c |7 --- src/chunk.h |7 --- src/client.c | 13 +++-- src/client.h | 13 +++-- src/cmdline.c|9 + src/cmdline.h|9 + src/command.c| 13 +++-- src/command.h| 13 +++-- src/compress.c | 19 ++- src/compress.h | 19 ++- src/conf.c | 13 +++-- src/conf.h | 13 +++-- src/crossfade.c | 14 +++--- src/crossfade.h | 14 +++--- src/daemon.c |9 + src/daemon.h |9 + src/database.c | 14 +++--- src/database.h | 14 +++--- src/dbUtils.c| 13 +++-- src/dbUtils.h| 13 +++-- src/decoder/_flac_common.c | 20 +++- src/decoder/_flac_common.h | 20 +++- src/decoder/_ogg_common.c| 20 +++- src/decoder/_ogg_common.h| 20 +++- src/decoder/audiofile_plugin.c | 17 - src/decoder/faad_plugin.c| 15 --- src/decoder/ffmpeg_plugin.c | 13 +++-- src/decoder/flac_plugin.c| 13 +++-- src/decoder/fluidsynth_plugin.c |7 --- src/decoder/mad_plugin.c | 13 +++-- src/decoder/mikmod_plugin.c | 15 --- src/decoder/modplug_plugin.c | 13 +++-- src/decoder/mp4ff_plugin.c | 13 +++-- src/decoder/mpcdec_plugin.c | 13 +++-- src/decoder/oggflac_plugin.c | 20 +++- src/decoder/sidplay_plugin.cxx |7 --- src/decoder/vorbis_plugin.c | 13 +++-- src/decoder/wavpack_plugin.c | 15 +++ src/decoder/wildmidi_plugin.c|7 --- src/decoder_api.c| 14 +++--- src/decoder_api.h| 14 +++--- src/decoder_buffer.c |7 --- src/decoder_buffer.h |7 --- src/decoder_command.h|7 --- src/decoder_control.c| 13 +++-- src/decoder_control.h| 14 +++--- src/decoder_internal.c |7 --- src/decoder_internal.h | 13 +++-- src/decoder_list.c | 13 +++-- src/decoder_list.h | 13
Re: [Musicpd-dev-team] [git pull] copyright header updates
Avuton Olrich wrote: To those that were CCd: Please read the following, this may affect you. Max, Please pull from my tree. This commit updates every single source file for consistancy and update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Daemon Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy. I have ommitted the diff as it would be pretty large and touches a large amount of the files. I don't have a real name for fluffy, so for now I have not added that author but it can easily be added at a later date. If you as an author disagree and want it your name and email readded to the source file, just say the word, I will make it happen. If you absolutely must credit me under a real name, j. shagam is fine. Incidentally, I didn't even know AudioCompress was being used in MPD (or even of MPD's existence). It's always great to see it being used. I do notice that it's the older 1.5.x codebase instead of the (somewhat cleaner) v2.0. Is there any reason for this? I don't think there's any functional or performance difference, although 2.0 is a bit more modular (I dusted it off after seeing complaints about that on a thread about xmms-normalize2, which for some reason they never considered contacting me about). Now that I know about MPD I will definitely be trying it out. It looks like a pretty useful project, especially since I'm always getting irritated by iTunes and its brokenness. -- Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
