Re: [Musicpd-dev-team] Support for parsing/tagging flac files according to embedded cuesheets
On 2009/03/20 18:19, Jochen Keil jochen.k...@gmail.com wrote: The clean way to do it would be to create one commit which adds the original sources, and another commit edits them and adds them to the build system (Makefile.am). That'll be some work.. It's important to document what was written by the original author and what was modified by you. Media players are a dangerous area (regarding copyright and patents), and we need to have a reliable audit trail of everything, just in case. What's this for? It's for the one who is interested to build the lexer/parser himself. You don't need it though, so leave it out if you want to. I have to admit that i don't know enough about automake/autoconf to add a build lexer/parser command or so.. If you don't manage to write it, I can help you with that (when I return from vacation). Who's the author? Why does it include cd.h? Why do we need cd.h at all? Looks like it's dealing with information for compact discs, but MPD doesn't handle CDs. The author of the original cuetools package is Svend Sorensen. cd.h contains the methods for accessing the struct which holds the information from the parsed cuesheet. Svend called that struct Cd, thus cd.h/.c. I have no problem with that but if you'd like a different name for it i can change that.. as i said i wanted to rework the api anyway. I don't care much about the name, I was just questioning if you added it for a good reason. Don't create a separate commit for each and every source file you import. cd.h is nothing without cd.c. Should i add them all at once or cd.h + cd.c, cue.h + cue.c, etc.? If you need all of them at once, import all of them (the original sources) in one commit (without Makefile.am), with correct author information. Then do another commit (the integration commit), which modifies them (fix warnings? do whatever is required to get them compiled cleanly with --enable-werror), and adds them to the Makefile.am. You're the author of this commit. If you need to do API changes, you can do it in the following commits. Each commit which adds a new source must add it to Makefile.am. Each commit must not fail during build. make distcheck should always work, too. So it should be like this: new file (e.g. cd.c) + add to Makefile.am = one commit? In short, yes. See above for more detailed explanation. For commiting will it suffice to set user.name and user.email to Svend's contact information? git commit --author=Foo Bar f...@bar.org With stgit, you can easily change that information at any time with stg edit. Should i also add the files from cuetools i removed (and remove them again from git)? No. Import only the sources you need for your work. If you need more at a later time, you can make another import commit. Max -- Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] concerns about wakeups
On 2009/03/21 14:20, Kodest kod...@gmail.com wrote: I took a look at powertop yesterday, and found that mpd has begun to generate many wakeups (much more than it used to do before, ~950 per sec). So, I did a bisect and I think I have found the guilty commit: 3291666b570b1d20f59db42936eaa37dbeb9ca65 As far as I see, this is a reorganization in the output system. Please look at this. You're talking about MPD while playing, aren't you? How many wakeups before that commit (while playing)? I know that it's a bit inefficient right now, and the code has several comments XXX synchronize in a better way. I will work on that before the 0.15 release (and before the beta test, that's important). Max -- Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] concerns about wakeups
Hi Max, 2009/3/22 Max Kellermann m...@duempel.org: On 2009/03/21 14:20, Kodest kod...@gmail.com wrote: I took a look at powertop yesterday, and found that mpd has begun to generate many wakeups (much more than it used to do before, ~950 per sec). So, I did a bisect and I think I have found the guilty commit: 3291666b570b1d20f59db42936eaa37dbeb9ca65 As far as I see, this is a reorganization in the output system. Please look at this. You're talking about MPD while playing, aren't you? Yes, i measured wakeups while mpd was playing mp3s. (Actually mp3s are irrelevant, flac does the same; the problem is not at the input/decoder parts.) How many wakeups before that commit (while playing)? Last good commit (commit ab3d7c29dae44f39df28c85e26b108c44fdbc4bf): mpd doesn't even come up. Only the interrupts can be seen in powertop generated by the sound hw (only ~2-3 per sec, because i use large alsa buffer). I think this is quite good! First bad commit (commit 3291666b570b1d20f59db42936eaa37dbeb9ca65) 95.6% (947.0) mpd : do_nanosleep (hrtimer_wakeup) Last commit at the moment (commit 71cd24954a34bc9fb0fdf6505616ba79b8320a5a) 95.6% (948.3) mpd : do_nanosleep (hrtimer_wakeup) I know that it's a bit inefficient right now, and the code has several comments XXX synchronize in a better way. I will work on that before the 0.15 release (and before the beta test, that's important). Just tell me when i can check the wakeups again :) Is there any docs on how the output mechanism works? I would be interested in how the audio chunks travel among the different threads at the output subsystem, but the code is quite complex. Maybe I can help if i understand this one. (Only maybe because my time is really limited nowadays.) Regards, Kodest -- Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
