Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3
On Mon, 2012-04-23 at 19:09 +0200, Max Kellermann wrote: On 2012/04/21 13:29, Jurgen Kramer gtmkra...@xs4all.nl wrote: - Adhered to max 80 colom width This is not doxygen syntax, and is barely readable. Please use doxygen syntax for documenting struct attributes. - Fixed indents (hopefully correctly) What did you fix? Indentation dsdiff_read_metadata() is still all wrong. I took a stab a changing the loop part. Please check, it probably needs some more work. I don't see what you changed. There are 17 whitespace errors in your patch according to git. Please show me how I can check myself. It is getting a bit tiresome to hear about wrong tabs/indents. Jurgen -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] [PATCH] Add support for DSF files to DSDIFF decoder - v3
On 2012/04/21 13:29, Jurgen Kramer gtmkra...@xs4all.nl wrote: - Adhered to max 80 colom width This is not doxygen syntax, and is barely readable. Please use doxygen syntax for documenting struct attributes. - Fixed indents (hopefully correctly) What did you fix? Indentation dsdiff_read_metadata() is still all wrong. I took a stab a changing the loop part. Please check, it probably needs some more work. I don't see what you changed. There are 17 whitespace errors in your patch according to git. -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] [PATCH/RFC] Fix DSD-over-USB playback
On 2012/04/06 12:52, Jurgen Kramer gtmkra...@xs4all.nl wrote: The attached patch fixes playback for DSD-over-USB. Without this patch MPD uses a frame size of 2 (stereo files) while the actual needed frame size for the used output sample format is 8 (sample formats S24_P32 and S32). Maybe this is not the proper/complete solution but will at least allow users to test the current DSD-over-USB code and hopefully provides some clues for the actual fixes (if needed). Below some more background info. I have pushed a better solution for this problem to git master. I don't have DSD hardware yet, please verify if this works. Max -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] [PATCH/RFC] Fix DSD-over-USB playback
On 23/4/2012 10:56 μμ, Max Kellermann wrote: On 2012/04/06 12:52, Jurgen Kramergtmkra...@xs4all.nl wrote: The attached patch fixes playback for DSD-over-USB. Without this patch MPD uses a frame size of 2 (stereo files) while the actual needed frame size for the used output sample format is 8 (sample formats S24_P32 and S32). Maybe this is not the proper/complete solution but will at least allow users to test the current DSD-over-USB code and hopefully provides some clues for the actual fixes (if needed). Below some more background info. I have pushed a better solution for this problem to git master. I don't have DSD hardware yet, please verify if this works. Max It works fine here. -- For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
