Re: [Musicpd-dev-team] Fwd: hively decoder patch
On 2009/08/13 17:41, Max Kellermann m...@duempel.org wrote: However, I see compiler warnings errors, see attached log file. Could you fix all of those, please? Hi Tony, any updates on your hively code? Max -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Fwd: hively decoder patch
On 2009/08/07 22:19, Tony Miller mcfiredr...@gmail.com wrote: The author has replied to me in this thread: http://hivelytracker.com/forum.php?action=viewthreadid=153 He simply says Credit is fine. Apparently the issue has come up before in this thread: http://hivelytracker.com/forum.php?action=viewthreadid=114 In this thread the author states The freely available replay code is public domain. The replay code is what I used. Thanks for checking, sounds good. This means we can merge your patch. However, I see compiler warnings errors, see attached log file. Could you fix all of those, please? Max make all-am make[1]: Entering directory `/home/max/git/mpd' gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I./src -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DSYSTEM_CONFIG_FILE_LOCATION='/usr/local/stow/mpd/etc/mpd.conf' -I/usr/include/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include-I/usr/include/libmodplug-I/usr/include/ffmpeg -I/usr/local/stow/libcue/include/libcue-0.0 -I/usr/local/stow/libcue/lib/libcue-0.0/include -I/usr/local/stow/mpd/include -I/usr/include/alsa-D_REENTRANT -pthread -I/usr/include/ffmpeg -Wall -Wextra -Wno-deprecated-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wshadow -Wpointer-arith -Wstrict-prototypes -Wcast-qual -Wwrite-strings -pedantic -D_REENTRANT -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -O0 -ggdb -MT src_mpd-hvl_replay.o -MD -MP -MF .deps/src_mpd-hvl_replay.Tpo -c -o src_mpd-hvl_replay.o `test -f 'src/decoder/hvl_replay.c' || echo './'`src/decoder/hvl_replay.c src/decoder/hvl_replay.c:70: warning: no previous prototype for 'hvl_GenPanningTables' src/decoder/hvl_replay.c:91: warning: no previous prototype for 'hvl_GenSawtooth' src/decoder/hvl_replay.c:103: warning: no previous prototype for 'hvl_GenTriangle' src/decoder/hvl_replay.c: In function 'hvl_GenTriangle': src/decoder/hvl_replay.c:116: warning: comparison between signed and unsigned src/decoder/hvl_replay.c:126: warning: comparison between signed and unsigned src/decoder/hvl_replay.c:134: warning: comparison between signed and unsigned src/decoder/hvl_replay.c:140: warning: overflow in implicit constant conversion src/decoder/hvl_replay.c: At top level: src/decoder/hvl_replay.c:148: warning: no previous prototype for 'hvl_GenSquare' src/decoder/hvl_replay.c: In function 'hvl_GenSquare': src/decoder/hvl_replay.c:155: warning: overflow in implicit constant conversion src/decoder/hvl_replay.c: At top level: src/decoder/hvl_replay.c:170: warning: no previous prototype for 'hvl_GenFilterWaves' src/decoder/hvl_replay.c:221: warning: no previous prototype for 'hvl_GenWhiteNoise' src/decoder/hvl_replay.c: In function 'hvl_GenWhiteNoise': src/decoder/hvl_replay.c:235: warning: overflow in implicit constant conversion src/decoder/hvl_replay.c: At top level: src/decoder/hvl_replay.c:256: warning: no previous prototype for 'hvl_reset_some_stuff' src/decoder/hvl_replay.c:365: warning: no previous prototype for 'hvl_load_ahx' src/decoder/hvl_replay.c: In function 'hvl_load_ahx': src/decoder/hvl_replay.c:449: warning: passing argument 1 of 'strncpy' discards qualifiers from pointer target type src/decoder/hvl_replay.c:507: warning: passing argument 1 of 'strncpy' discards qualifiers from pointer target type src/decoder/hvl_replay.c:510: error: assignment of read-only location '(ht-ht_Instruments + (long unsigned int)((long unsigned int)i * 176ul))-ins_Name[0]' src/decoder/hvl_replay.c:542: warning: comparison between signed and unsigned src/decoder/hvl_replay.c: In function 'hvl_LoadTune': src/decoder/hvl_replay.c:717: warning: passing argument 1 of 'strncpy' discards qualifiers from pointer target type src/decoder/hvl_replay.c:786: warning: passing argument 1 of 'strncpy' discards qualifiers from pointer target type src/decoder/hvl_replay.c:789: error: assignment of read-only location '(ht-ht_Instruments + (long unsigned int)((long unsigned int)i * 176ul))-ins_Name[0]' src/decoder/hvl_replay.c:821: warning: comparison between signed and unsigned src/decoder/hvl_replay.c: At top level: src/decoder/hvl_replay.c:845: warning: no previous prototype for 'hvl_process_stepfx_1' src/decoder/hvl_replay.c:911: warning: no previous prototype for 'hvl_process_stepfx_2' src/decoder/hvl_replay.c:911: warning: unused parameter 'ht' src/decoder/hvl_replay.c:944: warning: no previous prototype for 'hvl_process_stepfx_3' src/decoder/hvl_replay.c:1038: warning: no previous prototype for 'hvl_process_step' src/decoder/hvl_replay.c:1205: warning: no previous prototype for 'hvl_plist_command_parse' src/decoder/hvl_replay.c:1205: warning: unused parameter 'ht' src/decoder/hvl_replay.c:1349: warning: no previous prototype for 'hvl_process_frame' src/decoder/hvl_replay.c: In function 'hvl_process_frame': src/decoder/hvl_replay.c:1654: warning: comparison between signed and unsigned src/decoder/hvl_replay.c: At
Re: [Musicpd-dev-team] Fwd: hively decoder patch
The author has replied to me in this thread: http://hivelytracker.com/forum.php?action=viewthreadid=153 He simply says Credit is fine. Apparently the issue has come up before in this thread: http://hivelytracker.com/forum.php?action=viewthreadid=114 In this thread the author states The freely available replay code is public domain. The replay code is what I used. -Tony On Tue, Jul 28, 2009 at 11:23 AM, Tony Miller mcfiredr...@gmail.com wrote: I posted the question to them on their forum. That is indeed where the code came from. Peter does appear to be the author of hively tracker. If the forums do not respond soon I'll just email him directly. There are more tunes here: http://amigascne.org/abyss/ahx/tunes.html -Tony On Tue, Jul 28, 2009 at 8:44 AM, Jeffrey Middleton jefr...@gmail.comwrote: Max, It looks like there are some samples available from the tunes section of the website - http://hivelytracker.com/tunes/ Tony, I'm guessing the source code you used came from here: http://www.petergordon.org.uk/files/replayer_linux.tgz This is linked from the download section of the website, where it says the port is by Christopher O'Neill, but the readme says (and hosting suggests) it's by Peter Gordon (p...@petergordon.org.uk). There's also a forum you could post in to ask. It really does look like none of these people ever bothered to think about applying a license to their code, but given the number of ports and informality of the website it seems like they might be amenable to a GPL so it could go into MPD... good luck. Jeffrey On Tue, Jul 28, 2009 at 10:31 AM, Max Kellermann m...@duempel.org wrote: On 2009/07/25 19:32, Tony Miller mcfiredr...@gmail.com wrote: Subject: [PATCH] This is my patch for my hively/ahx decoder plugin. This allows you to playback .ahx and .hvl files. There is no library for this format, just hvl_replay.c and hvl_replay.h which are distributed by hivelytracker.com. This code does not appear to have any license. If this is merged, it should be a configure option, something like, --enable-hively. If the code does not have any license, who allowed you to copy it then? Without explicit permission (usually given by the license), we're not allowed to use it. Please tell me where to download sample files in that format. I've never heard of it, but I'm always happy to get new decoders into MPD (once the copyright issue is solved). Max -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Fwd: hively decoder patch
On 2009/07/25 19:32, Tony Miller mcfiredr...@gmail.com wrote: Subject: [PATCH] This is my patch for my hively/ahx decoder plugin. This allows you to playback .ahx and .hvl files. There is no library for this format, just hvl_replay.c and hvl_replay.h which are distributed by hivelytracker.com. This code does not appear to have any license. If this is merged, it should be a configure option, something like, --enable-hively. If the code does not have any license, who allowed you to copy it then? Without explicit permission (usually given by the license), we're not allowed to use it. Please tell me where to download sample files in that format. I've never heard of it, but I'm always happy to get new decoders into MPD (once the copyright issue is solved). Max -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
Re: [Musicpd-dev-team] Fwd: hively decoder patch
Max, It looks like there are some samples available from the tunes section of the website - http://hivelytracker.com/tunes/ Tony, I'm guessing the source code you used came from here: http://www.petergordon.org.uk/files/replayer_linux.tgz This is linked from the download section of the website, where it says the port is by Christopher O'Neill, but the readme says (and hosting suggests) it's by Peter Gordon (p...@petergordon.org.uk). There's also a forum you could post in to ask. It really does look like none of these people ever bothered to think about applying a license to their code, but given the number of ports and informality of the website it seems like they might be amenable to a GPL so it could go into MPD... good luck. Jeffrey On Tue, Jul 28, 2009 at 10:31 AM, Max Kellermann m...@duempel.org wrote: On 2009/07/25 19:32, Tony Miller mcfiredr...@gmail.com wrote: Subject: [PATCH] This is my patch for my hively/ahx decoder plugin. This allows you to playback .ahx and .hvl files. There is no library for this format, just hvl_replay.c and hvl_replay.h which are distributed by hivelytracker.com. This code does not appear to have any license. If this is merged, it should be a configure option, something like, --enable-hively. If the code does not have any license, who allowed you to copy it then? Without explicit permission (usually given by the license), we're not allowed to use it. Please tell me where to download sample files in that format. I've never heard of it, but I'm always happy to get new decoders into MPD (once the copyright issue is solved). Max -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july___ Musicpd-dev-team mailing list Musicpd-dev-team@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team
