Re: [Musicpd-dev-team] [PATCH] some libflac's cpu_info makes a SIGILL, so ignore it

2008-11-01 Thread Alam Arias 
On Fri, 31 Oct 2008 17:12:30 +0100
Max Kellermann [EMAIL PROTECTED] wrote:

 I won't merge this patch, because I think this must be fixed in
 libflac.

Yea, after a nap and downloading FLAC source code, it does setup to
handle SIGILL and set the EIP ahead of SSE instruction.

Now here the thing, it does uses CPUID but if there FXSR(yes), SSE (no)
or SSE2 (no) support, it will try to see if the OS support SSE
instructions, now that is where it goes wrong.

I do not see why in libFLAC's cpu.c that if CPUID says that if the CPU
supports FXSR that it should test SEE support so I just compiled libFLAC
with -DFLAC__NO_SSE_OS and now see MPD will still crash with crossfade
off. It just that with crossfade on, the music still stops t-crossfade/2


-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team

Re: [Musicpd-dev-team] [PATCH] some libflac's cpu_info makes a SIGILL, so ignore it

2008-10-31 Thread Max Kellermann 
On 2008/10/31 16:55, Alam Arias [EMAIL PROTECTED] wrote:
 I noticed on my Debian Lenny/Sid system that libflac8 1.2.1-1.2
 package's libFLAC.so.8 raises SIGILL in FLAC__cpu_info()
 
 so this patch setups to ignore SIGILL when we do flac(_ogg)_init and
 restore the old signal handler after the init

I won't merge this patch, because I think this must be fixed in
libflac.  The SIG_IGN approach is problematic (not thread safe,
ignores the mask and flags, may ignore real errors), and it's not
MPD's task to work around this kind of bug.

Max

-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK  win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team