Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository)

2009-03-17 Thread Max Kellermann
On 2009/03/16 22:06, Mario Lenz m...@riolenz.de wrote:
 On 2009/03/16 19:40, Max Kellermann m...@duempel.org wrote:
 
  There's one issue: if there is a TITLE tag before TITLE1,
  then MPD will use both.
 
 Yep, I know. This is true for every other tag, too. But I thought a
 quick'n'dirty hack *now* would be better than a proper solution some
 vague time in the future :-)

Agree.  Your patch is an improvement, and this problem is not a
regression - it will not break older setups.

  Which other projects do use this method?
 
 I've just started to archive some of my music this way, that is one big
 flac file with an embedded cue sheet per CD. When I was looking for a
 tagging scheme, I found one with the track number directly attached
 (TITLE1) and one written like an array (TITLE[1]).
 
 Now that I'm looking for it, I can't find the scheme I've used. Probably
 it's been used by some project that isn't active any more :-/
 
 Anyway, the $TAGNAME[$TRACKNUMBER] scheme seems to be supported by at
 least two relatively well-known programs, foobar2000 and SlimServer. 
 If you want me to, I'll send you another patch to make mpd support this
 scheme instead of the other one.

There doesn't seem to be an official standard.  I'd say: search for
TITLE[1] first (the most explicit form), then TITLE1, and finally fall
back to TITLE.  This makes sure MPD supports every possible standard,
without breaking.

Max

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository)

2009-03-17 Thread Mario Lenz
Jochen Keil wrote:

 So i'd say let's got for the cuesheet option as it is at least
 defined (though there is no real standard too).

So a non- standard solution involving a complex task like developing a
cuesheet parser is superior to another non- standard solution that
simply changes a handfull of lines in your code?

 What will be there the next few days though is support for embedded
 cuesheets with cdtext info.

Talking about getting lost in adding every possible way of tagging this
stuff: What other players support parsing this CUESHEET tag? The
$TAGNAME[$TRACKNUMBER] scheme seems to be supported by at least
SqueezeCenter (formerly SlimServer) and foobar2000.

 metaflac --import-cuesheet-from=file will not only import the
 seekpoints but also add the whole cuesheet with cdtext infos as
 CUESHEET=file vorbis comment.

metaflac 1.2.1 doesn't.

Anyway: My changes shouldn't break anything, so I would like to see them
stay there. However, since I didn't find any other player using the
$TAGNAME$TRACKNUMBER scheme I suggested first, I don't object to
removing it.

cu

   Mario


--
In a world without walls and fences, who needs Windows and Gates?


--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository)

2009-03-17 Thread Max Kellermann
On 2009/03/17 14:20, Mario Lenz m...@riolenz.de wrote:
 Jochen Keil wrote:
 
  So i'd say let's got for the cuesheet option as it is at least
  defined (though there is no real standard too).
 
 So a non- standard solution involving a complex task like developing a
 cuesheet parser is superior to another non- standard solution that
 simply changes a handfull of lines in your code?

Yes, definitely.  Only standards guarantee good interoperability.  And
I'm not talking about interoperability with software which doesn't
follow the standard.  I don't care much about that.

 Anyway: My changes shouldn't break anything

That's important.  Until we have full cuesheet support, I don't object
having a hack (which is supported by at least one other major media
player).

Mario, your patch is useful for some people, this is why I merged it.
But since it's non-standard, we may decide to remove it at any time,
when we have a better solution.

Max

--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team


Re: [Musicpd-dev-team] embedded cue sheets in flac files (recently added to repository)

2009-03-17 Thread Jochen Keil
Hi

Mario Lenz wrote:
 So a non- standard solution involving a complex task like developing a
 cuesheet parser is superior to another non- standard solution that
 simply changes a handfull of lines in your code?
If you consider this a complex task than this must not mean that it's a
difficult job for someone else. Writing a parser in lex/yacc is far
superior and easier to do than a bunch of strcmp's nested in if statements.
Despite that you might want to take a look at this:
http://digitalx.org/cuesheetsyntax.php
and
http://developer.berlios.de/docman/display_doc.php?docid=517group_id=2130
This may not be a defined standard but it's well documented, on a common
base and everybody sticks to it.

 What other players support parsing this CUESHEET tag?
foobar2000

 metaflac 1.2.1 doesn't.
$ metaflac --version
metaflac 1.2.1

You should check your installation.

Regards,

Jochen



signature.asc
Description: OpenPGP digital signature
--
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com___
Musicpd-dev-team mailing list
Musicpd-dev-team@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/musicpd-dev-team