Re: MySQL 5.1.21 won't build on OpenBSD unless...

2007-09-30 Thread Joerg Bruehe

Hi !

Dan Nelson wrote:

In the last episode (Sep 27), Jake Conk said:

Not sure if this is known or not but I just wanted to let you guys
know that MySQL 5.1.21 fails the make. I've never had this problem on
other versions of mysql. It looks like GNU make worked all the way
through but why won't regular make work anymore?


You didn't give much useful information in your message (not even a
line number!), but I bet I found the problem.

Lines 149 and 150 of Makefile.am have spaces instead of tabs as
indentation characters.  Even the documentation for GNU make says that
A tab character must come at the beginning of every command line to
distinguish command lines from other lines in the makefile., so it
really should have failed too.  Fix those two lines before running
./configure and your build should run okay.


If you refer to the Makefile in the root directory of the MySQL 
sources: This has been spotted and fixed, 5.1.22 sources do not contain 
it any more.


I fully agree to requiring tab characters for indenting actions in 
Makefiles. Sorry for it ever appearing in published sources !



Joerg

--
Joerg Bruehe, Senior Production Engineer
MySQL AB, www.mysql.com

--
MySQL General Mailing List
For list archives: http://lists.mysql.com/mysql
To unsubscribe:http://lists.mysql.com/[EMAIL PROTECTED]



Re: MySQL 5.1.21 won't build on OpenBSD unless...

2007-09-28 Thread Joerg Bruehe

Hi Jake !


Jake Conk wrote:

Hello,

Not sure if this is known or not but I just wanted to let you guys
know that MySQL 5.1.21 fails the make. I've never had this problem on
other versions of mysql. It looks like GNU make worked all the way
through but why won't regular make work anymore?


Thanks for the info !

The MySQL sources use the autotools (autoconf, automake etc) for 
building, so the Makefiles you see in the source tarball are really 
generated from Makefile.am when the source tarball is created.


It is easily possible that automake will create a Makefile which can be 
handled by GNU make, but not by some others - on our build hosts, we 
install GNU make if needed. We did so on our FreeBSD 6.0 host.


I cannot say which change made the Makefiles unusable for BSD make, 
but most likely using GNU make is easier for you than trying to work 
around that change.


As we use GNU make (almost ?) everywhere, changes in the fitness for 
other variants will go by unnoticed for the MySQL build team.



Sorry I cannot offer you any other hint,
Joerg

--
Joerg Bruehe, Senior Production Engineer
MySQL AB, www.mysql.com

--
MySQL General Mailing List
For list archives: http://lists.mysql.com/mysql
To unsubscribe:http://lists.mysql.com/[EMAIL PROTECTED]



Re: MySQL 5.1.21 won't build on OpenBSD unless...

2007-09-28 Thread Dan Nelson
In the last episode (Sep 27), Jake Conk said:
 Not sure if this is known or not but I just wanted to let you guys
 know that MySQL 5.1.21 fails the make. I've never had this problem on
 other versions of mysql. It looks like GNU make worked all the way
 through but why won't regular make work anymore?

You didn't give much useful information in your message (not even a
line number!), but I bet I found the problem.

Lines 149 and 150 of Makefile.am have spaces instead of tabs as
indentation characters.  Even the documentation for GNU make says that
A tab character must come at the beginning of every command line to
distinguish command lines from other lines in the makefile., so it
really should have failed too.  Fix those two lines before running
./configure and your build should run okay.

-- 
Dan Nelson
[EMAIL PROTECTED]

-- 
MySQL General Mailing List
For list archives: http://lists.mysql.com/mysql
To unsubscribe:http://lists.mysql.com/[EMAIL PROTECTED]



Re: MySQL 5.1.21 won't build on OpenBSD unless...

2007-09-28 Thread Dan Nelson
In the last episode (Sep 28), Dan Nelson said:
 In the last episode (Sep 27), Jake Conk said:
  Not sure if this is known or not but I just wanted to let you guys
  know that MySQL 5.1.21 fails the make. I've never had this problem on
  other versions of mysql. It looks like GNU make worked all the way
  through but why won't regular make work anymore?
 
 You didn't give much useful information in your message (not even a
 line number!), but I bet I found the problem.
 
 Lines 149 and 150 of Makefile.am have spaces instead of tabs as
 indentation characters.  Even the documentation for GNU make says that
 A tab character must come at the beginning of every command line to
 distinguish command lines from other lines in the makefile., so it
 really should have failed too.  Fix those two lines before running
 ./configure and your build should run okay.

You may also need to fix Makefile.in if you don't want to rerun
automake...

-- 
Dan Nelson
[EMAIL PROTECTED]

-- 
MySQL General Mailing List
For list archives: http://lists.mysql.com/mysql
To unsubscribe:http://lists.mysql.com/[EMAIL PROTECTED]



MySQL 5.1.21 won't build on OpenBSD unless...

2007-09-27 Thread Jake Conk
Hello,

Not sure if this is known or not but I just wanted to let you guys
know that MySQL 5.1.21 fails the make. I've never had this problem on
other versions of mysql. It looks like GNU make worked all the way
through but why won't regular make work anymore?

- Jake

-- 
MySQL General Mailing List
For list archives: http://lists.mysql.com/mysql
To unsubscribe:http://lists.mysql.com/[EMAIL PROTECTED]