Re: [nant-dev] license task broken
Hi,
It seems I found two bugs. One is in the licese task itself.
It can happen (actually it does on one of my systems),
thatasmLoaded.Location is either an empty string or null. If
so, Path.GetFullPath(...) throws an exception. The attached
diff files addesses this issue.
The second thing seems to be in Directory scanner (I'm not
sure, cause I have not much time to dive into this yet). If
I give something like D:\licensed_components\*.dll as
includes in the nested assembly, he tries to load dlls
without the ending. Eg A file name assembly.dll gets only
assembly .
HTH,
-sa
--
sa at programmers-world dot com
http://www.livingit.de
Bookmarks online: http://www.mobile-bookmarks.info
Soon available in english
Es brilig war. Die schlichte Toven
Wirrten und wimmelten in Waben;
Und aller-mumsige Burggoven
Dir mohmen Rath ausgraben.
-- Lewis Carrol, Through the Looking Glass
151c151,153
alAssemblyFilesLoaded.Add(Path.GetFullPath(asmLoaded.Location).ToLower(CultureInfo.InvariantCulture));
---
if (asmLoaded.Location.TrimEnd().TrimStart()
!= asmLoaded.Location != null) {
alAssemblyFilesLoaded.Add(Path.GetFullPath(asmLoaded.Location).ToLower(CultureInfo.InvariantCulture));
}
Re: [nant-dev] license task broken
Yet another bug is that the License task loads assemblies (as far as I can remember) into the main AppDomain. It needs to have code to load these assemblies in a separate AppDomain, like the NUnit tasks have. Matt. On Sun, 2003-09-14 at 11:46, Sascha Andres wrote: Hi, It seems I found two bugs. One is in the licese task itself. It can happen (actually it does on one of my systems), thatasmLoaded.Location is either an empty string or null. If so, Path.GetFullPath(...) throws an exception. The attached diff files addesses this issue. The second thing seems to be in Directory scanner (I'm not sure, cause I have not much time to dive into this yet). If I give something like D:\licensed_components\*.dll as includes in the nested assembly, he tries to load dlls without the ending. Eg A file name assembly.dll gets only assembly . HTH, -sa -- Matthew Mastracci [EMAIL PROTECTED] --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
Re: [nant-dev] license task broken
Hi, * Matthew Mastracci wrote on 14.09.2003 (12:45): Yet another bug is that the License task loads assemblies (as far as I can remember) into the main AppDomain. It needs to have code to load these assemblies in a separate AppDomain, like the NUnit tasks have. You're right. It does that way. But this is a minor problem as long as other bugs prevent using the license task at all. And this could be considered as 'by design'. Something to the found problems: Even a full path (no placeholders) don't make the license task running. -sa -- sa at programmers-world dot com http://www.livingit.de Bookmarks online: http://www.mobile-bookmarks.info Soon available in english Electrocution, n.: Burning at the stake with all the modern improvements. --- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf ___ nant-developers mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/nant-developers
