Re: RFR: 8280494: (D)TLS signature schemes [v5]
On Sun, 30 Jan 2022 03:06:35 GMT, Bernd wrote: >> Yes. Array copy is a concern of mine, too. Hopefully, the frozen array >> feature could help address the array copy issues in the future. > > Hmm.. I guess the different packages make it really hard to have an internal > optimized getter. What about a single concatenated string, it would be > immutable „sig1,sig2“.. It's an interesting idea. I would like to choose simple API, in an affordable performance impact. I don't worry a lot if considering the frozen array enhancement. - PR: https://git.openjdk.java.net/jdk/pull/7252
Re: RFR: 8280494: (D)TLS signature schemes [v5]
On Sun, 30 Jan 2022 03:03:37 GMT, Bernd wrote: >> If we want to reuse the result, we may have to cache something. It is not >> good to me. The parsing of the signature scheme names actually depends on >> the provider. So at this point, in the Java SE API specification, it is not >> easy to know how to parse the strings to me. > > Yes you are right, it would require a setter where the provider can register > the resolved array into the parameter instance (if we need to support > multiple providers). But it would be a good optimization assuming clients > keep the parameters around in a frequent Connection scenario. I see your point. The API default implementation could be complicated, if considering loading and unloading providers at runtime. I agree with you about the potential performance impact (minimal, but we may want to optimizing), and let's see if we could have a solution later. Since it is a common issue, I will not address it in this PR. - PR: https://git.openjdk.java.net/jdk/pull/7252
Re: RFR: 8280494: (D)TLS signature schemes [v5]
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision: Less objects construction - Changes: - all: https://git.openjdk.java.net/jdk/pull/7252/files - new: https://git.openjdk.java.net/jdk/pull/7252/files/922f..b8ed2506 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=7252&range=04 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=7252&range=03-04 Stats: 13 lines in 2 files changed: 10 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7252.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7252/head:pull/7252 PR: https://git.openjdk.java.net/jdk/pull/7252
