Re: reviews for 7200720 and 8003948 [7u-dev]

2012-12-11 Thread Michael McMahon

On 10/12/12 20:48, Dmitry Samersoff wrote:

Michael,

On 2012-12-10 23:35, Michael McMahon wrote:

Could I get the following webrevs reviewed please?
They are identical changes (except for one small change suggested by
Dmitry)
to what was done in 8 for the same issues

http://cr.openjdk.java.net/~michaelm/7200720.7u-dev/webrev.1/

I see a comment // MMM 7200720 ??

at ll:  202 of  NTLMAuthentication.java
- Does it make sense  to change it to something more verbose?

Otherwise looks good for me.


Yes, I'll change that Dmitry. Thanks!

Michael


http://cr.openjdk.java.net/~michaelm/8003948.7u-dev/webrev.1/

Looks good for me.

-Dmitry





Re: reviews for 7200720 and 8003948 [7u-dev]

2012-12-10 Thread Dmitry Samersoff
Michael,

On 2012-12-10 23:35, Michael McMahon wrote:
> Could I get the following webrevs reviewed please?
> They are identical changes (except for one small change suggested by
> Dmitry)
> to what was done in 8 for the same issues
> 
> http://cr.openjdk.java.net/~michaelm/7200720.7u-dev/webrev.1/

I see a comment // MMM 7200720 ??

at ll:  202 of  NTLMAuthentication.java
- Does it make sense  to change it to something more verbose?

Otherwise looks good for me.

> http://cr.openjdk.java.net/~michaelm/8003948.7u-dev/webrev.1/

Looks good for me.

-Dmitry

-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* Give Rabbit time, and he'll always get the answer


reviews for 7200720 and 8003948 [7u-dev]

2012-12-10 Thread Michael McMahon

Could I get the following webrevs reviewed please?
They are identical changes (except for one small change suggested by Dmitry)
to what was done in 8 for the same issues

http://cr.openjdk.java.net/~michaelm/7200720.7u-dev/webrev.1/

http://cr.openjdk.java.net/~michaelm/8003948.7u-dev/webrev.1/

Thanks
Michael