Unstable tests

2018-03-21 Thread Eric S. Raymond
Ian and I note that the test suite seems a bit compromised.

On current Ubuntu, Intel x86_64, stock build, two tests - 1 and 31
fail out of the box.

We see those same failures on ARM (a RasPi 3).

But Ian's laptop gives a diffeent and larger list of errors.

Are there known pastform dependencies in the tests?  Is it known that
1 and 31 can fail on a stock build?
-- 
http://www.catb.org/~esr/;>Eric S. Raymond

All forms of government are pernicious, including good government.
-- Edward Abbey

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Patch for build instructions

2018-03-21 Thread Eric S. Raymond
>From 2ffbdd9e8f15eb3e3dc985ab3aa0a12d798e4b78 Mon Sep 17 00:00:00 2001
From: "Eric S. Raymond" 
Date: Wed, 21 Mar 2018 20:24:40 -0400
Subject: [PATCH] INSTALL: Fix for build instructions.

Mention a prerequisite that will trip people up under Ubuntu.
---
 INSTALL | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/INSTALL b/INSTALL
index 24f8d6c..aad9099 100644
--- a/INSTALL
+++ b/INSTALL
@@ -27,7 +27,8 @@ QUICK INSTRUCTIONS
  (due to prompting done by the configure script, this is very rarely
   necessary.)
 
-  3) make
+  3) Run make.  If the build fails with a complaint that it can't resolve
+ -lperl, install libperl-dev and try again.
 
   4) Run the next command as root:
   5) make install
-- 
2.7.4




-- 
http://www.catb.org/~esr/;>Eric S. Raymond

  "You have taught us much. Come with us and join the movement."
  "This movement of yours, does it have slogans?" inquired the Chink.
  "Right on!" they cried. And they quoted him some.
  "Your movement, does it have a flag?" asked the Chink.
  "You bet!" and they described their emblem.
  "And does your movement have leaders?"
  "Great leaders."
  "Then shove it up your butts," said the Chink. "I have taught you nothing."

-- Tom Robbins, "Even Cowgirls Get The Blues"

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Fix patch for SF bug 2833

2018-03-21 Thread Eric S. Raymond
>From 54e79ba66327bdb54f97f457d76531f657ec546d Mon Sep 17 00:00:00 2001
From: "Eric S. Raymond" 
Date: Wed, 21 Mar 2018 22:22:29 -0400
Subject: [PATCH] include/net-snmp/agent/{snmp_vars.h,var_struct.h}: address SF
 bug 2833.

Tests pass,
---
 include/net-snmp/agent/snmp_vars.h  |  2 +-
 include/net-snmp/agent/var_struct.h | 12 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/include/net-snmp/agent/snmp_vars.h 
b/include/net-snmp/agent/snmp_vars.h
index bd27eeb..b2f2f8f 100644
--- a/include/net-snmp/agent/snmp_vars.h
+++ b/include/net-snmp/agent/snmp_vars.h
@@ -101,7 +101,7 @@ PERFORMANCE OF THIS SOFTWARE.
 #define INST   0x  /* used to fill out the instance field of the 
variables table */
 
 struct variable {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 chartype;   /* type of variable */
 /*
  * See important comment in snmp_vars.c relating to acl 
diff --git a/include/net-snmp/agent/var_struct.h 
b/include/net-snmp/agent/var_struct.h
index 15b5770..10bf4ae 100644
--- a/include/net-snmp/agent/var_struct.h
+++ b/include/net-snmp/agent/var_struct.h
@@ -52,7 +52,7 @@ typedef struct netsnmp_subtree_s {
  * application.  The first 5 elements of the structure must remain constant.
  */
 struct variable1 {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 u_char  type;   /* type of variable */
 u_short acl;/* access control list for variable */
 FindVarMethod  *findVar;/* function that finds variable */
@@ -61,7 +61,7 @@ struct variable1 {
 };
 
 struct variable2 {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 u_char  type;   /* type of variable */
 u_short acl;/* access control list for variable */
 FindVarMethod  *findVar;/* function that finds variable */
@@ -79,7 +79,7 @@ struct variable3 {
 };
 
 struct variable4 {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 u_char  type;   /* type of variable */
 u_short acl;/* access control list for variable */
 FindVarMethod  *findVar;/* function that finds variable */
@@ -88,7 +88,7 @@ struct variable4 {
 };
 
 struct variable7 {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 u_char  type;   /* type of variable */
 u_short acl;/* access control list for variable */
 FindVarMethod  *findVar;/* function that finds variable */
@@ -97,7 +97,7 @@ struct variable7 {
 };
 
 struct variable8 {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 u_char  type;   /* type of variable */
 u_short acl;/* access control list for variable */
 FindVarMethod  *findVar;/* function that finds variable */
@@ -106,7 +106,7 @@ struct variable8 {
 };
 
 struct variable13 {
-u_char  magic;  /* passed to function as a hint */
+u_short magic;  /* passed to function as a hint */
 u_char  type;   /* type of variable */
 u_short acl;/* access control list for variable */
 FindVarMethod  *findVar;/* function that finds variable */
-- 
2.7.4


-- 
http://www.catb.org/~esr/;>Eric S. Raymond

As war and government prove, insanity is the most contagious of
diseases.   -- Edward Abbey

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: ICEI asks what help you need

2018-03-21 Thread Eric S. Raymond
Bart Van Assche :
> Thank you for reaching out. There is a huge backlog w.r.t. addressing bug
> reports and the patch tracker. Help with reviewing and addressing all these
> tickets would definitely be welcome.

Wow.  722 open bugs.  OK, we'll get on that.

Expect some MRs soon.
-- 
http://www.catb.org/~esr/;>Eric S. Raymond

My work is funded by the Internet Civil Engineering Institute: https://icei.org
Please visit their site and donate: the civilization you save might be your own.



--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: ICEI asks what help you need

2018-03-21 Thread Bart Van Assche

On 03/21/18 11:21, Ian Bruene wrote:

On 03/20/2018 05:46 PM, Eric S. Raymond wrote:

I've been asked to approach the net-snmp dev team on behalf of the
Internet Civil Engneering Institute. ICEI tries to identify important
infrastructure that is undermaintained and help out.

What does your project need?  Where we can find a match between your
needs and the skills of our staff and volunteers, we'll cheerfully
pitch in.


Just posting here to note that I am one of the ICEI people.


Hello Eric and Ian,

Thank you for reaching out. There is a huge backlog w.r.t. addressing 
bug reports and the patch tracker. Help with reviewing and addressing 
all these tickets would definitely be welcome.


Bart.


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


var_vacm_access() question

2018-03-21 Thread Keith Mendoza
Hi,
I'm one of the volunteer developers with ICEI (please see email with
subject "ICEI asks what help you need" for details). I was attempting
to compile net-snmp code with -std=c99 compiler option, and the
compiler failed with "error: overflow in implicit constant conversion
[-Werror=overflow] on the following lines in
net-snmp-code/agent/mibII/vacm_vars.c: 382, 397, and 593. These 3
locations have *cp++ = 255;

So, my question is where can I get more information on
var_vacm_access(). It appears to me it has something to do with
determining group access control for a MIB group. Specifically, what
is the rational for incrementing, then basically setting the location
pointed by "cp" to 255 given the if logic above each of the 3
locations where *cp++ = 255 is set.

Thanks,
Keith

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


Re: ICEI asks what help you need

2018-03-21 Thread Ian Bruene



On 03/20/2018 05:46 PM, Eric S. Raymond wrote:

I've been asked to approach the net-snmp dev team on behalf of the
Internet Civil Engneering Institute. ICEI tries to identify important
infrastructure that is undermaintained and help out.

What does your project need?  Where we can find a match between your
needs and the skills of our staff and volunteers, we'll cheerfully
pitch in.


Just posting here to note that I am one of the ICEI people.

--
/"In the end; what separates a Man, from a Slave? Money? Power? No. A 
Man Chooses, a Slave Obeys."/ -- Andrew Ryan


/"Utopia cannot precede the Utopian. It will exist the moment we are fit 
to occupy it."/ -- Sophia Lamb


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders


net-snmp 5.8: "unknown snmp version 193" from agentx subagent

2018-03-21 Thread Bill Fenner
The new code in net-snmp 5.8 that tries to account for v1 or v2 trap
sessions logs an error from an agentx subagent, since the agentx code
registers the session as being AGENTX_VERSION_1.  This constant is only
defined in the agentx code, so agent_trap.c doesn't know what it is.

I suspect that this code, which is trying to avoid calling callbacks when
there aren't any sessions of the given version, is irrelevant when using
the built in list of sinks (i.e., when there is no snmp_callback_available(
..., SNMPD_CALLBACK_REGISTER_NOTIFICATIONS ).  However, I don't have a
brilliant idea about how to avoid this error.

1. Change it to a DEBUGMSG. Obviously makes the apparent error not very
visible, but, I don't know if it needs visibility.
2. Register the agentx session using SNMP_VERSION_2c. I assume something
else will break if we pretend it's an SNMP session and not AgentX, but I
haven't tried this.
3. Teach agent_trap.c about AGENTX_VERSION_ numbers.  I don't think anyone
wants to do this, since otherwise the agentx code is encapsulated in
mibgroup/agentx/

Any other ideas?

Thanks,
  Bill
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders