Re: [net-snmp:code] 4 new commits to Code

[Bill Fenner via Net-snmp-coders]

On Tue, May 7, 2019 at 7:41 PM Bart Van Assche  wrote:

> On 5/7/19 9:42 AM, Bill Fenner wrote:
> > I was hoping you might have an idea of a more graceful solution that
> > allows keeping const'ness.  If not, I can check in my change.
>
> Hi Bill,
>
> Please have a look at commit 068b4686739c ("libsnmp: Rework the
> MDblock() implementation").
>

Yes, this is great, thanks!

  Bill
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Re: [net-snmp:code] 4 new commits to Code

[Bart Van Assche]

On 5/7/19 9:42 AM, Bill Fenner wrote:
> I was hoping you might have an idea of a more graceful solution that
> allows keeping const'ness.  If not, I can check in my change.

Hi Bill,

Please have a look at commit 068b4686739c ("libsnmp: Rework the
MDblock() implementation").

Thanks,

Bart.


___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Re: [net-snmp:code] 4 new commits to Code

[Bill Fenner via Net-snmp-coders]

On Mon, Apr 29, 2019 at 7:10 PM Bart Van Assche  wrote:

> On Mon, 2019-04-29 at 17:19 -0400, Bill Fenner wrote:
>
> On Sun, Apr 28, 2019 at 7:52 PM net-snmp Git repository <
> nore...@code.net-snmp.p.re.sourceforge.net> wrote:
>
> Branch: V5-8-patches
>
> configure: Determine endianness at compile time instead of at configure
> time
>
> The new test supports cross-compilation. In other words, --with-endianness
> no longer has to be specified during cross-compilation.
>
> By Bart Van Assche on 04/28/2019 20:40
> *View Changes*
> 
>
>
> Hi Bart,
>
> This change exposes md5.c's "big lie" of const-ness.  Before, it was
> hidden behind #if BIG_ENDIAN, so I never saw it - now, it's exposed since
> MDReverse(X) can be called at runtime.  Obviously, MDReverse(X) can modify
> the value that's passed throughout as const.
>
> For now I've patched my local copy to eliminate the const lie throughout
> md5.[ch].
>
>
> Hi Bill,
>
> Do you plan to check in your patch or do you perhaps prefer that I look
> further into this?
>

I was hoping you might have an idea of a more graceful solution that allows
keeping const'ness.  If not, I can check in my change.

  Bill
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Re: [net-snmp:code] 4 new commits to Code

[Bart Van Assche]

On Mon, 2019-04-29 at 17:19 -0400, Bill Fenner wrote:
> On Sun, Apr 28, 2019 at 7:52 PM net-snmp Git repository 
>  wrote:
> > Branch: V5-8-patches
> > 
> > 
> > configure: Determine endianness at compile time instead of at configure time
> > 
> > The new test supports cross-compilation. In other words, --with-endianness
> > 
> > no longer has to be specified during cross-compilation.
> > 
> > 
> > By Bart Van Assche on 04/28/2019 20:40
> > 
> > View Changes
> > 
> > 
> > 
> Hi Bart,
> 
> This change exposes md5.c's "big lie" of const-ness.  Before, it was hidden 
> behind #if BIG_ENDIAN, so I never saw it - now, it's exposed since 
> MDReverse(X) can be called at runtime.  Obviously,
> MDReverse(X) can modify the value that's passed throughout as const.
> 
> For now I've patched my local copy to eliminate the const lie throughout 
> md5.[ch].

Hi Bill,

Do you plan to check in your patch or do you perhaps prefer that I look further 
into this?

Bart.___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Re: [net-snmp:code] 4 new commits to Code

[Bill Fenner via Net-snmp-coders]

On Sun, Apr 28, 2019 at 7:52 PM net-snmp Git repository <
nore...@code.net-snmp.p.re.sourceforge.net> wrote:

> Branch: V5-8-patches
>
> configure: Determine endianness at compile time instead of at configure
> time
>
> The new test supports cross-compilation. In other words, --with-endianness
> no longer has to be specified during cross-compilation.
>
> By Bart Van Assche on 04/28/2019 20:40
> *View Changes*
> 
>
> Hi Bart,

This change exposes md5.c's "big lie" of const-ness.  Before, it was hidden
behind #if BIG_ENDIAN, so I never saw it - now, it's exposed since
MDReverse(X) can be called at runtime.  Obviously, MDReverse(X) can modify
the value that's passed throughout as const.

For now I've patched my local copy to eliminate the const lie throughout
md5.[ch].

  Bill
___
Net-snmp-coders mailing list
Net-snmp-coders@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders