Re: [patch 1/1] r8169 driver: corega support
I demand that Francois Romieu may or may not have written... Darren Salt [EMAIL PROTECTED] : [...] It does, but the patch causes the module to report that the reset failed even after reporting that it's done. A fix for this is attached. Oops. Ok with the one below? Yes. [snip patch] -- | Darren Salt| linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | + Output less CO2 = avoid massive flooding.TIME IS RUNNING OUT *FAST*. Wagner's music is better than it sounds. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch 1/1] r8169 driver: corega support
I demand that Francois Romieu may or may not have written...
[EMAIL PROTECTED] [EMAIL PROTECTED] :
[Corega adapter support]
It's queued in the r8169 branch at:
git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169
I have sent Jeff a pull request for it (and I'll probably send one
more for the patch below).
Darren, can you check if the patch below fixes you link detection
issue ?
It does, but the patch causes the module to report that the reset failed even
after reporting that it's done. A fix for this is attached.
--
| Darren Salt| linux or ds at | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| + Generate power using sun, wind, water, nuclear. FORGET COAL AND OIL.
Life is what happens when you're busy making other plans.
Avoid reporting that the PHY reset has failed when it's just succeeded.
Signed-off-by: Darren Salt [EMAIL PROTECTED]
diff a/drivers/net/r8169.c b/drivers/net/r8169.c
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -1452,7 +1452,7 @@ static void rtl8169_release_board(struct
for (i = 0; i 100; i++) {
if (!tp-phy_reset_pending(ioaddr)) {
printk(KERN_INFO %s: PHY reset done.\n, dev-name);
- break;
+ return;
}
msleep(1);
}
Re: RTL8136
I demand that Francois Romieu may or may not have written...
Darren Salt [EMAIL PROTECTED] :
[...]
Whoops. I'd not noticed the -rc4 patches...
These seem to help a little: mii-tool can reset it and bring the link up
regardless of RTL_CFG_{1,2}. After that, RTL_CFG_1 allows sending to work,
and RTL_CFG_2 allows both sending and receiving to work (tested by trying
to get an IP address via DHCP).
Did you need to play with mii-tool to have DHCP working or did it work
automagically (assuming the -rc4 patches + the RTL_CFG_2 change of course)?
The former. Without that, the connection is persistently re-negotiated
(though, according to the switch's LEDs, it's fine before the module is
loaded).
--
| Darren Salt| linux or ds at | nr. Ashington, | Toon
| RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army
| Say NO to UK ID cards. http://www.no2id.net/
Experience is something you don't get until just after you need it.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: RTL8136
I demand that Francois Romieu may or may not have written... Darren Salt [EMAIL PROTECTED] : In case you don't yet have an lspci dump for an RTL8136, here's one for a device which is working with the r1000 driver which is supplied with Ubuntu dapper (though the machine in question - a Toshiba Equium A110-233 - is actually running Debian testing.) Thanks. The MM region was correctly guessed. If the driver does not work, ... which it doesn't - the connection is lost, and the hardware continually tries and fails to re-establish it. I can at least get a 10baseT/full connection with help from ethtool, but trying to send anything over it fails; switching back to r1000 (and forcing the connection speed) gets things working again, though a reboot seems to be needed to get auto-negotiation of higher speeds working again (note that it's limited to 100baseT/full; I have nothing else capable of 1000baseT). you can try to s/RTL_CFG_1/RTL_CFG_2/ for the 0x8136 entry in the rtl8169_pci_tbl array. That appears to make no difference. -- | Darren Salt| linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | Kill all extremists! The universe is a spheroid region 705m in diameter. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RTL8136
In case you don't yet have an lspci dump for an RTL8136, here's one for a device which is working with the r1000 driver which is supplied with Ubuntu dapper (though the machine in question - a Toshiba Equium A110-233 - is actually running Debian testing.) I _should_ be able to test your patches once I've got a locally-compiled kernel working for it. [M-F-T set; not subscribed.] -- | Darren Salt| linux or ds at | nr. Ashington, | Toon | RISC OS, Linux | youmustbejoking,demon,co,uk | Northumberland | Army | + At least 4000 million too many people. POPULATION LEVEL IS UNSUSTAINABLE. If no one uses it, there's a reason. 05:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. Unknown device 8136 (rev 01) Subsystem: Toshiba America Info Systems Unknown device ff00 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort- TAbort- MAbort- SERR- PERR- Latency: 0, Cache Line Size: 64 bytes Interrupt: pin A routed to IRQ 185 Region 0: I/O ports at 4000 [size=256] Region 2: Memory at da00 (64-bit, non-prefetchable) [size=4K] [virtual] Expansion ROM at d400 [disabled] [size=64K] Capabilities: [40] Power Management version 2 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0-,D1+,D2+,D3hot+,D3cold+) Status: D0 PME-Enable- DSel=0 DScale=0 PME+ Capabilities: [48] Vital Product Data Capabilities: [50] Message Signalled Interrupts: 64bit+ Queue=0/1 Enable- Address: Data: Capabilities: [60] Express Endpoint IRQ 0 Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag+ Device: Latency L0s 1us, L1 unlimited Device: AtnBtn+ AtnInd+ PwrInd+ Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported- Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop- Device: MaxPayload 128 bytes, MaxReadReq 128 bytes Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s, Port 0 Link: Latency L0s unlimited, L1 unlimited Link: ASPM Disabled RCB 64 bytes CommClk+ ExtSynch- Link: Speed 2.5Gb/s, Width x1 Capabilities: [84] Vendor Specific Information Capabilities: [100] Advanced Error Reporting Capabilities: [12c] Virtual Channel Capabilities: [148] Device Serial Number 36-81-ec-10-00-00-10-01 Capabilities: [154] Power Budgeting
