Re: [PATCH net 0/3] mlx4 fixes for 4.20-rc
From: Tariq Toukan Date: Thu, 15 Nov 2018 18:05:12 +0200 > This patchset includes small fixes for mlx4_core driver. Series applied.
Re: [Patch net-next] net: remove unused skb_send_sock()
From: Cong Wang Date: Mon, 12 Nov 2018 18:05:24 -0800 > Signed-off-by: Cong Wang John, any plans to use this? Looks like only skb_send_sock_lock() currently has a user.
Re: [PATCH][net-next] net: slightly optimize eth_type_trans
From: Li RongQing Date: Tue, 13 Nov 2018 09:34:31 +0800 > netperf udp stream shows that eth_type_trans takes certain cpu, > so adjust the mac address check order, and firstly check if it > is device address, and only check if it is multicast address > only if not the device address. > > After this change: > To unicast, and skb dst mac is device mac, this is most of time > reduce a comparision > To unicast, and skb dst mac is not device mac, nothing change > To multicast, increase a comparision > > Before: > 1.03% [kernel] [k] eth_type_trans > > After: > 0.78% [kernel] [k] eth_type_trans > > Signed-off-by: Zhang Yu > Signed-off-by: Li RongQing Applied.
Re: [PATCH][net-next][v2] net: remove BUG_ON from __pskb_pull_tail
From: Li RongQing Date: Tue, 13 Nov 2018 09:16:52 +0800 > if list is NULL pointer, and the following access of list > will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.
Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2018-11-14
From: Jeff Kirsher Date: Wed, 14 Nov 2018 15:10:18 -0800 > This series contains updates to i40e and virtchnl. Pulled, thanks Jeff.
Re: [PATCH net-next 00/11] mlxsw: spectrum: acl: Introduce ERP sharing by multiple masks
From: Ido Schimmel
Date: Wed, 14 Nov 2018 08:22:25 +
> Jiri says:
>
> The Spectrum-2 hardware has limitation number of ERPs per-region. In
> order to accommodate more masks than number of ERPs, the hardware
> supports to insert rules with delta bits. By that, the rules with masks
> that differ in up-to 8 consecutive bits can share the same ERP.
>
> Patches 1 and 2 fix couple of issues that would appear in existing
> selftests after adding delta support
>
> Patch 3 introduces a generic object aggregation library. Now it is
> static, but it will get extended for recalculation of aggregations in
> the future in order to reach more optimal aggregation.
>
> Patch 4 just simply converts existing ERP code to use the objagg library
> instead of a rhashtable.
>
> Patches 5-9 do more or less small changes to prepare ground for the last
> patch.
>
> Patch 10 fills-up delta callbacks of objagg library and utilizes the
> delta bits for rule insertion.
>
> The last patch adds selftest to test the mlxsw Spectrum-2 delta flows.
Series applied, but I had to fix the following warning:
[PATCH] test_objagg: Fix warning.
lib/test_objagg.c: In function ‘test_delta_action_item’:
./include/linux/printk.h:308:2: warning: ‘errmsg’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
Signed-off-by: David S. Miller
---
lib/test_objagg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/test_objagg.c b/lib/test_objagg.c
index aac5d8e8800c..ab57144bb0cd 100644
--- a/lib/test_objagg.c
+++ b/lib/test_objagg.c
@@ -769,6 +769,7 @@ static int test_delta_action_item(struct world *world,
if (err)
goto errout;
+ errmsg = NULL;
err = check_expect_stats(objagg, _item->expect_stats, );
if (err) {
pr_err("Key %u: Stats: %s\n", action_item->key_id, errmsg);
--
2.19.1
Re: [PATCH net] net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows
From: Eric Dumazet
Date: Mon, 12 Nov 2018 16:17:16 -0800
> When EDT conversion happened, fq lost the ability to enfore a maxrate
> for all flows. It kept it for non EDT flows.
>
> This commit restores the functionality.
>
> Tested:
>
> tc qd replace dev eth0 root fq maxrate 500Mbit
> netperf -P0 -H host -- -O THROUGHPUT
> 489.75
>
> Fixes: ab408b6dc744 ("tcp: switch tcp and sch_fq to new earliest departure
> time model")
> Signed-off-by: Eric Dumazet
Applied, thanks Eric.
Re: [net-next PATCH v4] net: sched: cls_flower: Classify packets using port ranges
From: Amritha Nambiar Date: Mon, 12 Nov 2018 16:15:55 -0800 > Added support in tc flower for filtering based on port ranges. > > Example: ... > v4: > 1. Added condition before setting port key. > 2. Organized setting and dumping port range keys into functions >and added validation of input range. > > v3: > 1. Moved new fields in UAPI enum to the end of enum. > 2. Removed couple of empty lines. > > v2: > Addressed Jiri's comments: > 1. Added separate functions for dst and src comparisons. > 2. Removed endpoint enum. > 3. Added new bit TCA_FLOWER_FLAGS_RANGE to decide normal/range > lookup. > 4. Cleaned up fl_lookup function. > > Signed-off-by: Amritha Nambiar Applied.
Re: [Patch net-next v2] net: dump more useful information in netdev_rx_csum_fault()
From: Cong Wang Date: Mon, 12 Nov 2018 14:47:18 -0800 > Currently netdev_rx_csum_fault() only shows a device name, > we need more information about the skb for debugging csum > failures. > > Sample output: > > ens3: hw csum failure > dev features: 0x00014b89 > skb len=84 data_len=0 pkt_type=0 gso_size=0 gso_type=0 nr_frags=0 > ip_summed=0 csum=0 csum_complete_sw=0 csum_valid=0 csum_level=0 > > Note, I use pr_err() just to be consistent with the existing one. > > Signed-off-by: Cong Wang Applied, thanks Cong.
Re: [PATCHv2 net-net] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2
From: Andrew Lunn Date: Mon, 12 Nov 2018 18:51:01 +0100 > We already have a workaround for a couple of switches whose internal > PHYs only have the Marvel OUI, but no model number. We detect such > PHYs and give them the 6390 ID as the model number. However the > mv88e6161 has two SERDES interfaces in the same address range as its > internal PHYs. These suffer from the same problem, the Marvell OUI, > but no model number. As a result, these SERDES interfaces were getting > the same PHY ID as the mv88e6390, even though they are not PHYs, and > the Marvell PHY driver was trying to drive them. > > Add a special case to stop this from happen. > > Reported-by: Chris Healy > Signed-off-by: Andrew Lunn Applied to net-next.
Re: [net-next 00/11][pull request] 100GbE Intel Wired LAN Driver Updates 2018-11-13
From: Jeff Kirsher Date: Tue, 13 Nov 2018 10:32:28 -0800 > This series contains updates to the ice driver only. Pulled, thanks Jeff.
Re: [PATCH net V2 0/5] net/smc: fixes 2018-11-12
From: Ursula Braun Date: Thu, 15 Nov 2018 13:11:15 +0100 > v1->v2: >do not define 8-byte alignment for union smcd_cdc_cursor in >patch 4/5 "net/smc: atomic SMCD cursor handling" This is even worse. The atomic64_t must be properly 8 byte aligned, else it will crash the kernel when an atomic operation is attempted on it. You have a situation where your struct attributes are entirely incompatible. If the parent struct is __packed, you absolutely cannot align the atomic64_t in the child structure properly. One more time, __packed makes correctness here impossible. I've warned strongly in the past to avoid __packed. Now you have to untangle this mess somehow.
Re: [PATCH net V2] cxgb4: fix thermal zone build error
From: Ganesh Goudar
Date: Thu, 15 Nov 2018 15:36:21 +0530
> with CONFIG_THERMAL=m and cxgb4 as built-in build fails, and
> 'commit e70a57fa59bb ("cxgb4: fix thermal configuration dependencies")'
> tries to fix it but when cxgb4i is made built-in build fails again,
> use IS_REACHABLE instead of IS_ENABLED to fix the issue.
>
> Fixes: e70a57fa59bb (cxgb4: fix thermal configuration dependencies)
> Reported-by: Randy Dunlap
> Signed-off-by: Ganesh Goudar
> ---
> V2: Fixing spelling mistake and avoid preprocessor conditionals.
Applied.
Re: [PATCHv2] MAINTAINERS: Replace Vince Bridgers as Altera TSE maintainer
From: thor.tha...@linux.intel.com Date: Mon, 12 Nov 2018 11:50:56 -0600 > From: Thor Thayer > > Vince has moved to a different role. Replace him as Altera > TSE maintainer. > > Signed-off-by: Thor Thayer > Acked-by: Vince Bridgers > Acked-by: Alan Tull > --- > v2 Include netdev and David Miller Applied.
Re: [PATCH net 0/6] bnxt_en: Bug fixes.
From: Michael Chan Date: Thu, 15 Nov 2018 03:25:36 -0500 > Most of the bug fixes are related to the new 57500 chips, including some > initialization and counter fixes, disabling RDMA support, and a > workaround for occasional missing interrupts. The last patch from > Vasundhara fixes the year/month parameters for firmware coredump. Series applied, thanks Michael.
Re: [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq
From: Heiner Kallweit Date: Mon, 12 Nov 2018 21:16:06 +0100 > Now that the icplus driver has been fixed all PHY drivers supporting > interrupts have both callbacks (config_intr and ack_interrupt) > implemented - as it should be. Therefore phy_drv_supports_irq() > can be changed now to check for both callbacks being implemented. > > Signed-off-by: Heiner Kallweit Applied, thanks Heiner.
Re: [PATCH net] l2tp: fix a sock refcnt leak in l2tp_tunnel_register
From: Xin Long
Date: Tue, 13 Nov 2018 01:08:25 +0800
> This issue happens when trying to add an existent tunnel. It
> doesn't call sock_put() before returning -EEXIST to release
> the sock refcnt that was held by calling sock_hold() before
> the existence check.
>
> This patch is to fix it by holding the sock after doing the
> existence check.
>
> Fixes: f6cd651b056f ("l2tp: fix race in duplicate tunnel detection")
> Reported-by: Jianlin Shi
> Signed-off-by: Xin Long
Applied and queued up for -stable.
Re: [PATCH net-next 00/13] nfp: abm: track all Qdiscs
From: Jakub Kicinski Date: Mon, 12 Nov 2018 14:58:06 -0800 > Our Qdisc offload so far has been very simplistic. We held > and array of marking thresholds and statistics sized to the > number of PF queues. This was sufficient since the only > configuration we supported was single layer of RED Qdiscs > (on top of MQ or not, but MQ isn't really about queuing). > > As we move to add more Qdiscs it's time to actually try to > track the full Qdisc hierarchy. This allows us to make sure > our offloaded configuration reflects the SW path better. > We add graft notifications to MQ and RED (PRIO already sends > them) to allow drivers offloading those to learn how Qdiscs > are linked. MQ graft gives us the obvious advantage of being > able to track when Qdiscs are shared or moved. It seems > unlikely HW would offload RED's child Qdiscs but since the > behaviour would change based on linked child we should > stop offloading REDs with modified child. RED will also > handle the child differently during reconfig when limit > parameter is set - so we have to inform the drivers about > the limit, and have them reset the child state when > appropriate. > > The NFP driver will now allocate a structure to track each > Qdisc and link it to its children. We will also maintain > a shadow copy of threshold settings - to save device writes > and make it easier to apply defaults when config is > re-evaluated. Series applied, thanks.
Re: [PATCH net-next v2 0/6] net: aquantia: add rx-flow filter support
From: Igor Russkikh Date: Mon, 12 Nov 2018 15:45:56 + > In this patchset the rx-flow filters functionality and vlan filter offloads > are implemented. > > The rules in NIC hardware have fixed order and priorities. > To support this, the locations of filters from ethtool perspective are also > fixed: > > * Locations 0 - 15 for VLAN ID filters > * Locations 16 - 31 for L2 EtherType and PCP filters > * Locations 32 - 39 for L3/L4 5-tuple filters (locations 32, 36 for IPv6) Series applied, thanks.
Re: [PATCH net 4/5] net/smc: atomic SMCD cursor handling
From: Ursula Braun
Date: Mon, 12 Nov 2018 17:01:32 +0100
> +/* SMC-D cursor format */
> +union smcd_cdc_cursor {
...
> +} __aligned(8);
> struct smcd_cdc_msg {
...
> + union smcd_cdc_cursor prod;
> + union smcd_cdc_cursor cons;
> u8 res3[8];
> } __packed;
You're asking for 8-byte alignment of an object you only embed in a
__packed structure, which therefore has arbitary alignment.
It's not going to work.
Re: [PATCH net v2 0/4] qed: Miscellaneous bug fixes
From: Denis Bolotin Date: Mon, 12 Nov 2018 12:50:19 +0200 > This patch series fixes several unrelated bugs across the driver. > Please consider applying to net. > > V1->V2: > --- > Use dma_rmb() instead of rmb(). Series applied, thank you.
Re: pull-request: can 2018-11-09
From: Marc Kleine-Budde Date: Mon, 12 Nov 2018 12:57:08 +0100 > this is a pull request of 20 patches for net/master. Pulled, thanks Marc.
Re: [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue
From: Vlad Buslov
Date: Tue, 13 Nov 2018 13:13:19 +
>
> On Mon 12 Nov 2018 at 17:28, David Miller wrote:
>> From: Vlad Buslov
>> Date: Mon, 12 Nov 2018 09:55:30 +0200
>>
>>> +void mini_qdisc_pair_swap(struct mini_Qdisc_pair *miniqp,
>>> + struct tcf_proto *tp_head)
>>> +{
>>> + xchg(>tp_head, tp_head);
>>
>> If you are not checking the return value of xchg(), then this is
>> simply a store with optionally a memory barrier of some sort
>> either before or after.
>
> That was my intention. What would be a better way to atomically
> reset a pointer? Should I just change this line to explicit
> assignment+barrier?
We have all kinds of helpers in the kernel for doing things like
this, grep for things like "smp_load_acquire", "smp_store_release()"
etc.
Re: [PATCH net-next 17/17] net: sched: unlock rules update API
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:46 +0200 > Register netlink protocol handlers for message types RTM_NEWTFILTER, > RTM_DELTFILTER, RTM_GETTFILTER as unlocked. Set rtnl_held variable that > tracks rtnl mutex state to be false by default. This whole conditional locking mechanism is really not clean and makes this code so much harder to understand and audit. Please improve the code so that this kind of construct is not needed. Thank you.
Re: [PATCH net-next 02/17] net: sched: protect block state with spinlock
From: Vlad Buslov Date: Mon, 12 Nov 2018 09:55:31 +0200 > +#define ASSERT_BLOCK_LOCKED(block) \ > + WARN_ONCE(!spin_is_locked(&(block)->lock), \ > + "BLOCK: assertion failed at %s (%d)\n", __FILE__, __LINE__) spin_is_locked() is not usable for assertions. When SMP=n and DEBUG_SPINLOCK=n, it always returns zero.
Re: [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue
From: Vlad Buslov
Date: Mon, 12 Nov 2018 09:55:30 +0200
> +void mini_qdisc_pair_swap(struct mini_Qdisc_pair *miniqp,
> + struct tcf_proto *tp_head)
> +{
> + xchg(>tp_head, tp_head);
If you are not checking the return value of xchg(), then this is
simply a store with optionally a memory barrier of some sort
either before or after.
Re: [PATCHv2 net-next 0/3] sctp: add support for sk_reuseport
From: Xin Long Date: Mon, 12 Nov 2018 18:27:14 +0800 > sctp sk_reuseport allows multiple socks to listen on the same port and > addresses, as long as these socks have the same uid. This works pretty > much as TCP/UDP does, the only difference is that sctp is multi-homing > and all the bind_addrs in these socks will have to completely matched, > otherwise listen() will return err. > > The below is when 5 sockets are listening on 172.16.254.254:6400 on a > server, 26 sockets on a client connect to 172.16.254.254:6400 and each > may be processed by a different socket on the server which is selected > by hash(lport, pport, paddr) in reuseport_select_sock(): > > # ss --sctp -nn ... Series applied, thanks.
Re: [PATCH][net-next] net: remove BUG_ON from __pskb_pull_tail
From: Li RongQing
Date: Mon, 12 Nov 2018 17:26:13 +0800
> do {
> - BUG_ON(!list);
>
Please get rid of the empty line afterwards as well.
Thank you.
Re: [PATCH net v2 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.
From: Sudarsana Reddy Kalluru Date: Sun, 11 Nov 2018 18:27:34 -0800 > Driver assigns DMAE channel 0 for FW as part of START_RAMROD command. FW > uses this channel for DMAE operations (e.g., TIME_SYNC implementation). > Driver also uses the same channel 0 for DMAE operations for some of the PFs > (e.g., PF0 on Port0). This could lead to concurrent access to the DMAE > channel by FW and driver which is not legal. Hence need to assign unique > DMAE id for FW. > Currently following DMAE channels are used by the clients, > MFW - OCBB/OCSD functionality uses DMAE channel 14/15 > Driver 0-3 and 8-11 (for PF dmae operations) > 4 and 12 (for stats requests) > Assigning unique dmae_id '13' to the FW. > > Changes from previous version: > -- > v2: Incorporated the review comments. > > Signed-off-by: Sudarsana Reddy Kalluru > Signed-off-by: Michal Kalderon Applied.
Re: [PATCH net-next v3] PCI: add USR vendor id and use it in r8169 and w6692 driver
From: Heiner Kallweit Date: Sun, 11 Nov 2018 20:31:21 +0100 > The PCI vendor id of U.S. Robotics isn't defined in pci_ids.h so far, > only ISDN driver w6692 has a private definition. Move the definition > to pci_ids.h and use it in the r8169 driver too. > > Signed-off-by: Heiner Kallweit > --- > v2: > - The original patch caused a build failure in w6692 driver because > it broke the private PCI device id definition. > v3: > - Don't move device id's to pci_ids.h because they are used in > one module only respectively. Yep, that's better. Applied, thanks!
Re: [PATCH net-next] net_sched: sch_fq: add dctcp-like marking
From: Eric Dumazet
Date: Sun, 11 Nov 2018 09:11:31 -0800
> Similar to 80ba92fa1a92 ("codel: add ce_threshold attribute")
>
> After EDT adoption, it became easier to implement DCTCP-like CE marking.
>
> In many cases, queues are not building in the network fabric but on
> the hosts themselves.
>
> If packets leaving fq missed their Earliest Departure Time by XXX usec,
> we mark them with ECN CE. This gives a feedback (after one RTT) to
> the sender to slow down and find better operating mode.
>
> Example :
>
> tc qd replace dev eth0 root fq ce_threshold 2.5ms
>
> Signed-off-by: Eric Dumazet
Applied, thanks Eric.
Re: [PATCH net-next] tcp: tsq: no longer use limit_output_bytes for paced flows
From: Eric Dumazet
Date: Sun, 11 Nov 2018 07:34:28 -0800
> FQ pacing guarantees that paced packets queued by one flow do not
> add head-of-line blocking for other flows.
>
> After TCP GSO conversion, increasing limit_output_bytes to 1 MB is safe,
> since this maps to 16 skbs at most in qdisc or device queues.
> (or slightly more if some drivers lower {gso_max_segs|size})
>
> We still can queue at most 1 ms worth of traffic (this can be scaled
> by wifi drivers if they need to)
>
> Tested:
...
> Signed-off-by: Eric Dumazet
Applied.
Re: [PATCH net-next 0/3] tcp: tso defer improvements
From: Eric Dumazet Date: Sun, 11 Nov 2018 06:41:28 -0800 > This series makes tcp_tso_should_defer() a bit smarter : > > 1) MSG_EOR gives a hint to TCP to not defer some skbs > > 2) Second patch takes into account that head tstamp >can be in the future. > > 3) Third patch uses existing high resolution state variables >to have a more precise heuristic. This stuff is fantastic, series applied.
Re: [PATCH net-next v2] PCI: add USR vendor id and use it in r8169 and w6692 driver
From: Heiner Kallweit Date: Sun, 11 Nov 2018 11:50:08 +0100 > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 69f0abe1b..1fac231fe 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2359,6 +2359,10 @@ > > #define PCI_VENDOR_ID_SYNOPSYS 0x16c3 > > +#define PCI_VENDOR_ID_USR0x16ec > +#define PCI_DEVICE_ID_USR_997902 0x0116 > +#define PCI_DEVICE_ID_USR_6692 0x3409 > + > #define PCI_VENDOR_ID_VITESSE0x1725 > #define PCI_DEVICE_ID_VITESSE_VSC71740x7174 Generally, as I understand the policy for linux/pci_ids.h, we only add things used in multiple locations. So PCI_VENDOR_ID_USR is OK, since it is used in both r8169 and w6692. But the device IDs are not, since only w6692 uses them.
Re: [PATCH net 4/4] qed: Fix reading wrong value in loop condition
From: Denis Bolotin
Date: Sun, 11 Nov 2018 17:05:00 +0200
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c
> b/drivers/net/ethernet/qlogic/qed/qed_int.c
> index 0f0aba7..aa7504a 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_int.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
> @@ -992,6 +992,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
>*/
> do {
> index = p_sb_attn->sb_index;
> + /* finish reading index before the loop condition */
> + rmb();
Please use dma_rmb().
Re: [PATCH net] act_mirred: clear skb->tstamp on redirect
From: Eric Dumazet
Date: Sat, 10 Nov 2018 16:22:29 -0800
> If sch_fq is used at ingress, skbs that might have been
> timestamped by net_timestamp_set() if a packet capture
> is requesting timestamps could be delayed by arbitrary
> amount of time, since sch_fq time base is MONOTONIC.
>
> Fix this problem by moving code from sch_netem.c to act_mirred.c.
>
> Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> Signed-off-by: Eric Dumazet
Applied.
Re: [PATCH net-next] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2
From: Andrew Lunn Date: Sun, 11 Nov 2018 00:50:39 +0100 > We already have a workaround for a couple of switches whose internal > PHYs only have the Marvel OUI, but no model number. We detect such > PHYs and give them the 6390 ID as the model number. However the > mv88e6161 has two SERDES interfaces in the same address range as its > internal PHYs. These suffer from the same problem, the Marvell OUI, > but no model number. As a result, these SERDES interfaces were getting > the same PHY ID as the mv88e6390, even though they are not PHYs, and > the Marvell PHY driver was trying to drive them. > > Add a special case to stop this happen. > > Reported-by: Chris Healy > Signed-off-by: Andrew Lunn Please address Sergei's feedback, thank you.
Re: [patch net] net: dsa: mv88e6xxx: Fix clearing of stats counters
From: Andrew Lunn
Date: Sun, 11 Nov 2018 00:41:10 +0100
> The mv88e6161 would sometime fail to probe with a timeout waiting for
> the switch to complete an operation. This operation is supposed to
> clear the statistics counters. However, due to a read/modify/write,
> without the needed mask, the operation actually carried out was more
> random, with invalid parameters, resulting in the switch not
> responding. We need to preserve the histogram mode bits, so apply a
> mask to keep them.
>
> Reported-by: Chris Healy
> Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
> Signed-off-by: Andrew Lunn
Oops.
Applied and queued up for -stable.
Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: Support more SERDES interfacxes
From: Andrew Lunn Date: Sun, 11 Nov 2018 00:32:13 +0100 > Currently the SERDES interfaces for ports 9 and 10 on the mv88e6390x > are supported, allowing upto 10G. However, when unused, these SERDES > interfaces can be used by some of the lower ports for 1000Base-X. > > The tricky bit here is ordering. The SERDES have to become free from > ports 9 or 10 before they can be used with lower ports. Normally, this > would happen only when these ports would be configured up, which is > too late. So at probe time, defaulting ports 9 and 10 to 1000BaseX > frees them for use with lower ports. If they are actually needed, they > will be taken back when port 9 and 10 goes up. Series applied, thanks Andrew.
Re: [PATCH net-next 0/5] net: phy: convert advertise and supported to linkmode
From: Andrew Lunn Date: Sat, 10 Nov 2018 23:43:32 +0100 > This is the last part in converting phylib to make use of a linux > bitmap, not a u32, to represent links modes. This will allow support > for PHYs > 1Gbps, which need to use link modes represented by a bit > > 32. > > A number of MAC and PHY drivers need changes to support this. However > the previous two patchesets reduced the number somewhat, the helpers > which were introduced have been modified instead of the actual > drivers. > > The follow on patches then make use of the extra bits, adding support > for more link modes. Series applied. > Given how invasive this change is, i expect the build is broken for > some architectures i did not test. I will fixup the breakage as fast > as i can. I will hold you to this :-)
Re: [PATCH net-next] net: phy: remove states PHY_STARTING and PHY_PENDING
From: Heiner Kallweit Date: Sat, 10 Nov 2018 23:40:50 +0100 > Both states aren't used. Most likely they result from an idea that > never materialized. So remove them. > > Signed-off-by: Heiner Kallweit Applied.
Re: [PATCH net-next v2] documentation of some IP/ICMP snmp counters
From: yupeng Date: Sat, 10 Nov 2018 13:38:12 -0800 > The snmp_counter.rst explains the meanings of snmp counters. It also > provides a set of experiments (only 1 for this initial patch), > combines the experiments' resutls and the snmp counters' > meanings. This is an initial path, only explains a part of IP/ICMP > counters and provide a simple ping test. > > Signed-off-by: yupeng Applied.
Re: [PATCH net-next 0/6] net: sched: indirect tc block cb registration
From: Jakub Kicinski Date: Fri, 9 Nov 2018 21:21:25 -0800 > John says: > > This patchset introduces an alternative to egdev offload by allowing a > driver to register for block updates when an external device (e.g. tunnel > netdev) is bound to a TC block. Drivers can track new netdevs or register > to existing ones to receive information on such events. Based on this, > they may register for block offload rules using already existing > functions. > > The patchset also implements this new indirect block registration in the > NFP driver to allow the offloading of tunnel rules. The use of egdev > offload (which is currently only used for tunnel offload) is subsequently > removed. Really nice. Series applied. Can the Mellanox folks use this too so that we can remove egdev altogether? mlx5 is the only remaining user.
Re: [PATCH net-next 0/2] net: phy: add macros for PHYID matching in PHY driver config
From: Heiner Kallweit Date: Sat, 10 Nov 2018 00:37:46 +0100 > Add macros for PHYID matching to be used in PHY driver configs. > By using these macros some boilerplate code can be avoided. > > Use them initially in the Realtek PHY drivers. Series applied.
Re: [PATCH net-next 0/3] net: phy: further phylib simplifications after recent changes to the state machine
From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:54:49 +0100 > After the recent changes to the state machine phylib can be further > simplified (w/o having to make any assumptions). Nothing exemplifies understanding of a piece of code like a patch series like this, nice work. Series applied.
[PATCH net-next] sctp: Fix SKB list traversal in sctp_intl_store_ordered().
Same change as made to sctp_intl_store_reasm().
To be fully correct, an iterator has an undefined value when something
like skb_queue_walk() naturally terminates.
This will actually matter when SKB queues are converted over to
list_head.
Formalize what this code ends up doing with the current
implementation.
Signed-off-by: David S. Miller
---
net/sctp/stream_interleave.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/net/sctp/stream_interleave.c b/net/sctp/stream_interleave.c
index 368d9c33fde1..2b499a85db0e 100644
--- a/net/sctp/stream_interleave.c
+++ b/net/sctp/stream_interleave.c
@@ -390,7 +390,7 @@ static void sctp_intl_store_ordered(struct sctp_ulpq *ulpq,
struct sctp_ulpevent *event)
{
struct sctp_ulpevent *cevent;
- struct sk_buff *pos;
+ struct sk_buff *pos, *loc;
pos = skb_peek_tail(>lobby);
if (!pos) {
@@ -410,18 +410,25 @@ static void sctp_intl_store_ordered(struct sctp_ulpq
*ulpq,
return;
}
+ loc = NULL;
skb_queue_walk(>lobby, pos) {
cevent = (struct sctp_ulpevent *)pos->cb;
- if (cevent->stream > event->stream)
+ if (cevent->stream > event->stream) {
+ loc = pos;
break;
-
+ }
if (cevent->stream == event->stream &&
- MID_lt(event->mid, cevent->mid))
+ MID_lt(event->mid, cevent->mid)) {
+ loc = pos;
break;
+ }
}
- __skb_queue_before(>lobby, pos, sctp_event2skb(event));
+ if (!loc)
+ __skb_queue_tail(>lobby, sctp_event2skb(event));
+ else
+ __skb_queue_before(>lobby, loc, sctp_event2skb(event));
}
static void sctp_intl_retrieve_ordered(struct sctp_ulpq *ulpq,
--
2.19.1
[PATCH net-next] sctp: Fix SKB list traversal in sctp_intl_store_reasm().
To be fully correct, an iterator has an undefined value when something
like skb_queue_walk() naturally terminates.
This will actually matter when SKB queues are converted over to
list_head.
Formalize what this code ends up doing with the current
implementation.
Signed-off-by: David S. Miller
---
net/sctp/stream_interleave.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/net/sctp/stream_interleave.c b/net/sctp/stream_interleave.c
index 0a78cdf86463..368d9c33fde1 100644
--- a/net/sctp/stream_interleave.c
+++ b/net/sctp/stream_interleave.c
@@ -140,7 +140,7 @@ static void sctp_intl_store_reasm(struct sctp_ulpq *ulpq,
struct sctp_ulpevent *event)
{
struct sctp_ulpevent *cevent;
- struct sk_buff *pos;
+ struct sk_buff *pos, *loc;
pos = skb_peek_tail(>reasm);
if (!pos) {
@@ -166,23 +166,30 @@ static void sctp_intl_store_reasm(struct sctp_ulpq *ulpq,
return;
}
+ loc = NULL;
skb_queue_walk(>reasm, pos) {
cevent = sctp_skb2event(pos);
if (event->stream < cevent->stream ||
(event->stream == cevent->stream &&
-MID_lt(event->mid, cevent->mid)))
+MID_lt(event->mid, cevent->mid))) {
+ loc = pos;
break;
-
+ }
if (event->stream == cevent->stream &&
event->mid == cevent->mid &&
!(cevent->msg_flags & SCTP_DATA_FIRST_FRAG) &&
(event->msg_flags & SCTP_DATA_FIRST_FRAG ||
-event->fsn < cevent->fsn))
+event->fsn < cevent->fsn)) {
+ loc = pos;
break;
+ }
}
- __skb_queue_before(>reasm, pos, sctp_event2skb(event));
+ if (!loc)
+ __skb_queue_tail(>reasm, sctp_event2skb(event));
+ else
+ __skb_queue_before(>reasm, loc, sctp_event2skb(event));
}
static struct sctp_ulpevent *sctp_intl_retrieve_partial(
--
2.19.1
[PATCH] iucv: Remove SKB list assumptions.
Eliminate the assumption that SKBs and SKB list heads can
be cast to eachother in SKB list handling code.
This change also appears to fix a bug since the list->next pointer is
sampled outside of holding the SKB queue lock.
Signed-off-by: David S. Miller
---
net/iucv/af_iucv.c | 41 +++--
1 file changed, 15 insertions(+), 26 deletions(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index 0bed4cc20603..78ea5a739d10 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -1873,30 +1873,26 @@ static void iucv_callback_txdone(struct iucv_path *path,
struct sock *sk = path->private;
struct sk_buff *this = NULL;
struct sk_buff_head *list = _sk(sk)->send_skb_q;
- struct sk_buff *list_skb = list->next;
+ struct sk_buff *list_skb;
unsigned long flags;
bh_lock_sock(sk);
- if (!skb_queue_empty(list)) {
- spin_lock_irqsave(>lock, flags);
- while (list_skb != (struct sk_buff *)list) {
- if (msg->tag == IUCV_SKB_CB(list_skb)->tag) {
- this = list_skb;
- break;
- }
- list_skb = list_skb->next;
+ spin_lock_irqsave(>lock, flags);
+ skb_queue_walk(list, list_skb) {
+ if (msg->tag == IUCV_SKB_CB(list_skb)->tag) {
+ this = list_skb;
+ break;
}
- if (this)
- __skb_unlink(this, list);
-
- spin_unlock_irqrestore(>lock, flags);
+ }
+ if (this)
+ __skb_unlink(this, list);
+ spin_unlock_irqrestore(>lock, flags);
- if (this) {
- kfree_skb(this);
- /* wake up any process waiting for sending */
- iucv_sock_wake_msglim(sk);
- }
+ if (this) {
+ kfree_skb(this);
+ /* wake up any process waiting for sending */
+ iucv_sock_wake_msglim(sk);
}
if (sk->sk_state == IUCV_CLOSING) {
@@ -2284,11 +2280,7 @@ static void afiucv_hs_callback_txnotify(struct sk_buff
*skb,
list = >send_skb_q;
spin_lock_irqsave(>lock, flags);
- if (skb_queue_empty(list))
- goto out_unlock;
- list_skb = list->next;
- nskb = list_skb->next;
- while (list_skb != (struct sk_buff *)list) {
+ skb_queue_walk_safe(list, list_skb, nskb) {
if (skb_shinfo(list_skb) == skb_shinfo(skb)) {
switch (n) {
case TX_NOTIFY_OK:
@@ -2321,10 +2313,7 @@ static void afiucv_hs_callback_txnotify(struct sk_buff
*skb,
}
break;
}
- list_skb = nskb;
- nskb = nskb->next;
}
-out_unlock:
spin_unlock_irqrestore(>lock, flags);
if (sk->sk_state == IUCV_CLOSING) {
--
2.19.1
Re: [PATCH net-next] OVS: remove VLAN_TAG_PRESENT - fixup
From: Michał Mirosław
Date: Sat, 10 Nov 2018 19:55:34 +0100
> It turns out I missed one VLAN_TAG_PRESENT in OVS code while rebasing.
> This fixes it.
>
> Fixes: 9df46aefafa6 ("OVS: remove use of VLAN_TAG_PRESENT")
> Signed-off-by: Michał Mirosław
Applied, thanks.
Re: [PATCH net v2] net: sched: cls_flower: validate nested enc_opts_policy to avoid warning
From: Jakub Kicinski
Date: Fri, 9 Nov 2018 21:06:26 -0800
> TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
> currently contain further nested attributes, which are parsed by
> hand, so the policy is never actually used resulting in a W=1
> build warning:
>
> net/sched/cls_flower.c:492:1: warning: ‘enc_opts_policy’ defined but not used
> [-Wunused-const-variable=]
> enc_opts_policy[TCA_FLOWER_KEY_ENC_OPTS_MAX + 1] = {
>
> Add the validation anyway to avoid potential bugs when other
> attributes are added and to make the attribute structure slightly
> more clear. Validation will also set extact to point to bad
> attribute on error.
>
> Signed-off-by: Jakub Kicinski
> Acked-by: Simon Horman
Applied and queued up for -stable.
Re: [PATCH net-next] udp6: cleanup stats accounting in recvmsg()
From: Paolo Abeni Date: Fri, 9 Nov 2018 15:52:45 +0100 > In the udp6 code path, we needed multiple tests to select the correct > mib to be updated. Since we touch at least a counter at each iteration, > it's convenient to use the recently introduced __UDPX_MIB() helper once > and remove some code duplication. > > Signed-off-by: Paolo Abeni Applied, thanks.
Re: [PATCH net-next v2 0/2] dpaa2-eth: defer probe on object allocate
From: Ioana Ciornei Date: Fri, 9 Nov 2018 15:26:45 + > Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator > after the first attempts of other drivers to use them. Defer the probe when > this situation happens. > > Changes in v2: > - proper handling of IS_ERR_OR_NULL Series applied.
Re: [PATCH net] flow_dissector: do not dissect l4 ports for fragments
From: Eric Dumazet
Date: Fri, 9 Nov 2018 16:53:06 -0800
> From: 배석진
>
> Only first fragment has the sport/dport information,
> not the following ones.
>
> If we want consistent hash for all fragments, we need to
> ignore ports even for first fragment.
>
> This bug is visible for IPv6 traffic, if incoming fragments
> do not have a flow label, since skb_get_hash() will give
> different results for first fragment and following ones.
>
> It is also visible if any routing rule wants dissection
> and sport or dport.
>
> See commit 5e5d6fed3741 ("ipv6: route: dissect flow
> in input path if fib rules need it") for details.
>
> [edumazet] rewrote the changelog completely.
>
> Fixes: 06635a35d13d ("flow_dissect: use programable dissector in
> skb_flow_dissect and friends")
> Signed-off-by: 배석진
> Signed-off-by: Eric Dumazet
Applied and queued up for -stable.
Re: [PATCH net] net: sched: cls_flower: validate nested enc_opts_policy to avoid build warning
From: Jakub Kicinski
Date: Fri, 9 Nov 2018 14:41:22 -0800
> TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
> currently contain further nested attributes, which are parsed by
> hand, so the policy is never actually used. Add the validation
> anyway to avoid potential bugs when other attributes are added
> and to make the attribute structure slightly more clear. Validation
> will also set extact to point to bad attribute on error.
>
> Fixes: 0a6e77784f49 ("net/sched: allow flower to match tunnel options")
> Signed-off-by: Jakub Kicinski
> Acked-by: Simon Horman
If this fixes a build warning, please include the build warning
message in your commit log.
Thanks!
[PATCH] infiniband: nes: Fix more direct skb list accesses.
The following: skb = skb->next; ... if (skb == (struct sk_buff *)queue) is transformed into: skb = skb_peek_next(skb, queue); ... if (!skb) Signed-off-by: David S. Miller --- drivers/infiniband/hw/nes/nes_mgt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_mgt.c b/drivers/infiniband/hw/nes/nes_mgt.c index e9661c3a..fc0c191014e9 100644 --- a/drivers/infiniband/hw/nes/nes_mgt.c +++ b/drivers/infiniband/hw/nes/nes_mgt.c @@ -223,11 +223,11 @@ static struct sk_buff *nes_get_next_skb(struct nes_device *nesdev, struct nes_qp } old_skb = skb; - skb = skb->next; + skb = skb_peek_next(skb, >pau_list); skb_unlink(old_skb, >pau_list); nes_mgt_free_skb(nesdev, old_skb, PCI_DMA_TODEVICE); nes_rem_ref_cm_node(nesqp->cm_node); - if (skb == (struct sk_buff *)>pau_list) + if (!skb) goto out; } return skb; -- 2.19.1
Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault()
From: Cong Wang
Date: Fri, 9 Nov 2018 11:43:33 -0800
> diff --git a/net/core/datagram.c b/net/core/datagram.c
> index 57f3a6fcfc1e..d8f4d55cd6c5 100644
> --- a/net/core/datagram.c
> +++ b/net/core/datagram.c
> @@ -736,7 +736,7 @@ __sum16 __skb_checksum_complete_head(struct sk_buff *skb,
> int len)
> if (likely(!sum)) {
> if (unlikely(skb->ip_summed == CHECKSUM_COMPLETE) &&
> !skb->csum_complete_sw)
> - netdev_rx_csum_fault(skb->dev);
> + netdev_rx_csum_fault(skb->dev, skb);
> }
> if (!skb_shared(skb))
> skb->csum_valid = !sum;
Didn't you move this function into net/core/skbuff.c? :-)
Please respin.
Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling
From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:35:52 +0100 > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with this member in a way that it's clear we're > dealing with a bool value. > > Signed-off-by: Heiner Kallweit > --- > v2: > - use false/true instead of 0/1 for the constants Applied.
Re: [PATCH net-next] nfp: use the new __netdev_tx_sent_queue() BQL optimisation
From: Jakub Kicinski
Date: Fri, 9 Nov 2018 18:50:00 -0800
> __netdev_tx_sent_queue() was added in commit e59020abf0f
> ("net: bql: add __netdev_tx_sent_queue()") and allows for
> better GSO performance.
>
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Dirk van der Merwe
> Reviewed-by: Simon Horman
Applied.
Re: [PATCH net] net: qualcomm: rmnet: Fix incorrect assignment of real_dev
From: Subash Abhinov Kasiviswanathan
Date: Fri, 9 Nov 2018 18:56:27 -0700
> A null dereference was observed when a sysctl was being set
> from userspace and rmnet was stuck trying to complete some actions
> in the NETDEV_REGISTER callback. This is because the real_dev is set
> only after the device registration handler completes.
...
> Fixes: b752eff5be24 ("net: qualcomm: rmnet: Implement ndo_get_iflink")
> Signed-off-by: Sean Tranchetti
> Signed-off-by: Subash Abhinov Kasiviswanathan
Applied and queued up for -stable, thanks.
Re: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization
From: Richard Cochran Date: Fri, 9 Nov 2018 17:44:31 -0800 > On Fri, Nov 09, 2018 at 03:28:46PM -0800, David Miller wrote: >> This series looks good to me but I want to give Richard an opportunity to >> review it first. > > The series is good to go. > > Acked-by: Richard Cochran Great, series applied to net-next, thanks everyone.
Re: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization
From: Jeff Kirsher Date: Fri, 09 Nov 2018 15:33:10 -0800 > On Fri, 2018-11-09 at 15:28 -0800, David Miller wrote: >> From: Miroslav Lichvar >> Date: Fri, 9 Nov 2018 11:14:41 +0100 >> >> > RFC->v1: >> > - added new patches >> > - separated PHC timestamp from ptp_system_timestamp >> > - fixed memory leak in PTP_SYS_OFFSET_EXTENDED >> > - changed PTP_SYS_OFFSET_EXTENDED to work with array of arrays >> > - fixed PTP_SYS_OFFSET_EXTENDED to break correctly from loop >> > - fixed timecounter updates in drivers >> > - split gettimex in igb driver >> > - fixed ptp_read_* functions to be available without >> > CONFIG_PTP_1588_CLOCK >> > >> > This series enables a more accurate synchronization between PTP >> > hardware >> > clocks and the system clock. >> ... >> >> This series looks good to me but I want to give Richard an opportunity to >> review it first. > > Dave, I also do not want to hold this series up by picking up patches 5, 6 > and 7 (Intel drivers) so please apply the entire series after Richard > provides his review. Ok, will do.
Re: [PATCH net 0/5] net: aquantia: 2018-11 bugfixes
From: Igor Russkikh Date: Fri, 9 Nov 2018 11:53:54 + > The patchset fixes a number of bugs found in various areas after > driver validation. Series applied, thank you. Please, when you provide a Fixes: tag, do not separate it with the other Signed-off-by: and Acked-by: etc. tags with an empty line. It is just another tag, so keep them all together without any kind of separation like that. A lot of people seem to do this, I wonder why :-) Thank you.
Re: [PATCH net-next 0/8] More accurate PHC<->system clock synchronization
From: Miroslav Lichvar Date: Fri, 9 Nov 2018 11:14:41 +0100 > RFC->v1: > - added new patches > - separated PHC timestamp from ptp_system_timestamp > - fixed memory leak in PTP_SYS_OFFSET_EXTENDED > - changed PTP_SYS_OFFSET_EXTENDED to work with array of arrays > - fixed PTP_SYS_OFFSET_EXTENDED to break correctly from loop > - fixed timecounter updates in drivers > - split gettimex in igb driver > - fixed ptp_read_* functions to be available without > CONFIG_PTP_1588_CLOCK > > This series enables a more accurate synchronization between PTP hardware > clocks and the system clock. ... This series looks good to me but I want to give Richard an opportunity to review it first.
Re: [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.
From: Sudarsana Reddy Kalluru Date: Fri, 9 Nov 2018 02:10:43 -0800 > +/* Following is the DMAE channel number allocation for the clients. > + * MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively. > + * Driver: 0-3 and 8-11 (for PF dmae operations) > + * 4 and 12 (for stats requests) > + */ > +#define BNX2X_FW_DMAE_C 13 /* Channel for FW DMAE operations > */ ... > + start_params->dmae_cmd_id = BNX2X_FW_DMAE_C; Why do you need this, it never changes, and: > + rdata->dmae_cmd_id = start_params->dmae_cmd_id; It always is the same value here in the one place it is used. Just assign BNX2X_FW_DMAE_C directly to rdata->dmae_cmd_id please.
Re: [PATCH net-next] cxgb4vf: free mac_hlist properly
From: Arjun Vynipadath Date: Fri, 9 Nov 2018 14:52:53 +0530 > The locally maintained list for tracking hash mac table was > not freed during driver remove. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applied.
Re: [PATCH net-next] cxgb4vf: fix memleak in mac_hlist initialization
From: Arjun Vynipadath Date: Fri, 9 Nov 2018 14:52:01 +0530 > mac_hlist was initialized during adapter_up, which will be called > every time a vf device is first brought up, or every time when device > is brought up again after bringing all devices down. This means our > state of previous list is lost, causing a memleak if entries are > present in the list. To fix that, move list init to the condition > that performs initial one time adapter setup. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applied.
Re: [PATCH net-next] cxgb4: free mac_hlist properly
From: Arjun Vynipadath Date: Fri, 9 Nov 2018 14:50:25 +0530 > The locally maintained list for tracking hash mac table was > not freed during driver remove. > > Signed-off-by: Arjun Vynipadath > Signed-off-by: Ganesh Goudar Applied.
Re: [PATCH][net-next] net: tcp: remove BUG_ON from tcp_v4_err
From: Li RongQing Date: Fri, 9 Nov 2018 17:04:51 +0800 > if skb is NULL pointer, and the following access of skb's > skb_mstamp_ns will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.
Re: [PATCH net-next 0/7] nfp: abm: move code and improve parameter validation
From: Jakub Kicinski Date: Thu, 8 Nov 2018 19:50:32 -0800 > This set starts by separating Qdisc handling code into a new file. > Next two patches allow early access to TLV-based capabilities during > probe, previously the capabilities were parsed just before netdevs > were registered, but its cleaner to do some basic validation earlier > and avoid cleanup work. > > Next three patches improve RED's parameter validation. First we provide > a more precise message about why offload failed (and move the parameter > validation to a helper). Next we make sure we don't set the top bit > in the 32 bit max RED threshold value. Because FW is treating the value > as signed it reportedly causes slow downs (unnecessary queuing and > marking) when top bit is set with recent firmwares. Last (and perhaps > least importantly) we offload the harddrop parameter of the Qdisc. > We don't plan to offload harddrop RED, but it seems prudent to make > sure user didn't set that flag as device behaviour would have differed. Series applied, thanks Jakub.
Re: [PATCH net-next] tcp_bbr: update comments to reflect pacing_margin_percent
From: Neal Cardwell
Date: Thu, 8 Nov 2018 21:54:00 -0500
> Recently, in commit ab408b6dc744 ("tcp: switch tcp and sch_fq to new
> earliest departure time model"), the TCP BBR code switched to a new
> approach of using an explicit bbr_pacing_margin_percent for shaving a
> pacing rate "haircut", rather than the previous implict
> approach. Update an old comment to reflect the new approach.
>
> Signed-off-by: Neal Cardwell
> Signed-off-by: Yuchung Cheng
> Signed-off-by: Soheil Hassas Yeganeh
> Signed-off-by: Eric Dumazet
Applied.
Re: [Patch net-next v2] net: move __skb_checksum_complete*() to skbuff.c
From: Cong Wang Date: Thu, 8 Nov 2018 14:05:42 -0800 > __skb_checksum_complete_head() and __skb_checksum_complete() > are both declared in skbuff.h, they fit better in skbuff.c > than datagram.c. > > Cc: Stefano Brivio > Signed-off-by: Cong Wang Applied.
Re: [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation
From: Edward Cree
Date: Thu, 8 Nov 2018 19:47:19 +
> As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which
> see for performance rationale.
>
> Signed-off-by: Edward Cree
Applied.
Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers
From: Michał Mirosław Date: Thu, 08 Nov 2018 18:44:46 +0100 > This series removes VLAN_TAG_PRESENT use from network drivers in > preparation to removing its special meaning. Series applied, thank you.
Re: [net-next, PATCH 1/2] net: socionext: different approach on DMA
From: Ilias Apalodimas Date: Thu, 8 Nov 2018 17:19:54 +0200 > Current driver dynamically allocates an skb and maps it as DMA Rx > buffer. In order to prepare for upcoming XDP changes, let's introduce a > different allocation scheme. > Buffers are allocated dynamically and mapped into hardware. > During the Rx operation the driver uses build_skb() to produce the > necessary buffers for the network stack. > This change increases performance ~15% on 64b packets with smmu disabled > and ~5% with smmu enabled > > Signed-off-by: Ilias Apalodimas Applied.
Re: [net-next, PATCH 2/2] net: socionext: refactor netsec_alloc_dring()
From: Ilias Apalodimas Date: Thu, 8 Nov 2018 17:19:55 +0200 > return -ENOMEM directly instead of assigning it in a variable > > Signed-off-by: Ilias Apalodimas Applied.
Re: [PATCH net-next] net: qca_spi: Add available buffer space verification
From: Stefan Wahren Date: Thu, 8 Nov 2018 14:38:21 +0100 > Interferences on the SPI line could distort the response of > available buffer space. So at least we should check that the > response doesn't exceed the maximum available buffer space. > In error case increase a new error counter and retry it later. > This behavior avoids buffer errors in the QCA7000, which > results in an unnecessary chip reset including packet loss. > > Signed-off-by: Stefan Wahren Applied.
Re: [PATCH net 0/4] Slowpath Queue bug fixes
From: Denis Bolotin Date: Thu, 8 Nov 2018 16:46:07 +0200 > This patch series fixes several bugs in the SPQ mechanism. > It deals with SPQ entries management, preventing resource leaks, memory > corruptions and handles error cases throughout the driver. > Please consider applying to net. Series applied, thanks.
Re: [PATCH v3 net-next] sock: Reset dst when changing sk_mark via setsockopt
From: David Barmann Date: Thu, 8 Nov 2018 08:13:35 -0600 > When setting the SO_MARK socket option, if the mark changes, the dst > needs to be reset so that a new route lookup is performed. > > This fixes the case where an application wants to change routing by > setting a new sk_mark. If this is done after some packets have already > been sent, the dst is cached and has no effect. > > Signed-off-by: David Barmann Applied.
Re: [PATCH net-next 0/2] dpaa2-eth: defer probe on object allocate
From: David Miller Date: Thu, 08 Nov 2018 19:28:57 -0800 (PST) > From: Ioana Ciornei > Date: Thu, 8 Nov 2018 13:17:46 + > >> Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator >> after the first attempts of other drivers to use them. Defer the probe when >> this situation happens. > > Series applied, thanks. Whoops, I just saw Andrew Lunn's feedback. I reverted your changes, please address his concerns and resubmit. Thank you.
Re: [PATCH net-next 0/2] dpaa2-eth: defer probe on object allocate
From: Ioana Ciornei Date: Thu, 8 Nov 2018 13:17:46 + > Allocatable objects on the fsl-mc bus may be probed by the fsl_mc_allocator > after the first attempts of other drivers to use them. Defer the probe when > this situation happens. Series applied, thanks.
Re: [PATCH net-next] dpaa2-eth: Introduce TX congestion management
From: Ioana Ciocoi Radulescu Date: Thu, 8 Nov 2018 20:21:15 + > Today I tried to further coalesce the confirmation frames such that I call > netdev_tx_completed_queue() only at the end of the NAPI poll, once for each > confirmation queue that was serviced during that NAPI. That sounds like exactly what you should do given your design description. > I need to do more testing, but so far it performs *almost* on par > with the non-BQL driver version. But it does complicate the fastpath > code and feels somewhat unnatural. Well, this is exactly what should happen with BQL and as a result you will get much better TCP queue utilization and avoidance of bufferbloat.
Re: [PATCH ipsec-next 00/11] xfrm: policy: add inexact policy search tree
From: Florian Westphal Date: Wed, 7 Nov 2018 23:00:30 +0100 > This series attempts to improve xfrm policy lookup performance when > a lot of (several hundred or even thousands) inexact policies exist > on a system. > > On insert, a policy is either placed in hash table (all direct (/32 for > ipv4, /128 policies, or all policies matching a user-configured threshold). > All other policies get inserted into inexact list as per priority. > > Lookup then scans inexact list for first matching entry. > > This series instead makes it so that inexact policy is added to exactly > one of four different search list classes. > > 1. "Any:Any" list, containing policies where both saddr and daddr are >wildcards or have very coarse prefixes, e.g. 10.0.0.0/8 and the like. > 2. "saddr:any" list, containing policies with a fixed saddr/prefixlen, >but without destination restrictions. >These lists are stored in rbtree nodes; each node contains those >policies matching saddr/prefixlen. > 3. "Any:daddr" list. Similar to 2), except for policies where only the >destinations are specified. > 4. "saddr:daddr" lists, containing policies that match the given >source/destination network. > >The root of the saddr/daddr tree is stored in the nodes of the >'daddr' tree. ... > Comments or questions welcome. Acked-by: David S. Miller This looks really great. Nice work Florian.
Re: [PATCH v2 net] inet: frags: better deal with smp races
From: Eric Dumazet
Date: Thu, 8 Nov 2018 17:34:27 -0800
> Multiple cpus might attempt to insert a new fragment in rhashtable,
> if for example RPS is buggy, as reported by 배석진 in
> https://patchwork.ozlabs.org/patch/994601/
>
> We use rhashtable_lookup_get_insert_key() instead of
> rhashtable_insert_fast() to let cpus losing the race
> free their own inet_frag_queue and use the one that
> was inserted by another cpu.
>
> Fixes: 648700f76b03 ("inet: frags: use rhashtables for reassembly units")
> Signed-off-by: Eric Dumazet
> Reported-by: 배석진
Applied and queued up for -stable, thanks.
Re: [PATCH net-next 0/8] s390/qeth: updates 2018-11-08
From: Julian Wiedmann Date: Thu, 8 Nov 2018 15:06:14 +0100 > please apply the following qeth patches to net-next. > > The first patch allows one more device type to query the FW for a MAC address, > the others are all basically just removal of duplicated or unused code. Series applied, thanks.
Re: [PATCH][net-next] openvswitch: remove BUG_ON from get_dpdev
From: Li RongQing Date: Thu, 8 Nov 2018 20:40:20 +0800 > if local is NULL pointer, and the following access of local's > dev will trigger panic, which is same as BUG_ON > > Signed-off-by: Li RongQing Applied.
Re: [PATCH net-next v2 00/11] ICMP error handling for UDP tunnels
From: Stefano Brivio Date: Thu, 8 Nov 2018 12:19:13 +0100 > This series introduces ICMP error handling for UDP tunnels and > encapsulations and related selftests. We need to handle ICMP errors to > support PMTU discovery and route redirection -- this support is entirely > missing right now: > > - patch 1/11 adds a socket lookup for UDP tunnels that use, by design, > the same destination port on both endpoints -- i.e. VXLAN and GENEVE > - patches 2/11 to 7/11 are specific to VxLAN and GENEVE > - patches 8/11 and 9/11 add infrastructure for lookup of encapsulations > where sent packets cannot be matched via receiving socket lookup, i.e. > FoU and GUE > - patches 10/11 and 11/11 are specific to FoU and GUE > > v2: changes are listed in the single patches Series applied, thanks Stefano.
Re: [PATCH net-next] cxgb4: Add new T6 PCI device ids 0x608a
From: Ganesh Goudar Date: Thu, 8 Nov 2018 14:21:07 +0530 > Signed-off-by: Ganesh Goudar Applied.
Re: [PATCH][net-next][v2] net/ipv6: compute anycast address hash only if dev is null
From: Li RongQing Date: Thu, 8 Nov 2018 14:58:07 +0800 > avoid to compute the hash value if dev is not null, since > hash value is not used > > Signed-off-by: Li RongQing Applied.
Re: [PATCH net] inet: frags: better deal with smp races
From: Eric Dumazet
Date: Wed, 7 Nov 2018 22:10:53 -0800
> @@ -204,22 +205,22 @@ static struct inet_frag_queue *inet_frag_create(struct
> netns_frags *nf,
> /* TODO : call from rcu_read_lock() and no longer use
> refcount_inc_not_zero() */
> struct inet_frag_queue *inet_frag_find(struct netns_frags *nf, void *key)
> {
> - struct inet_frag_queue *fq;
> + struct inet_frag_queue *fq, *prev;
>
> if (!nf->high_thresh || frag_mem_limit(nf) > nf->high_thresh)
> return NULL;
>
> rcu_read_lock();
>
> - fq = rhashtable_lookup(>rhashtable, key, nf->f->rhash_params);
> - if (fq) {
> + prev = rhashtable_lookup(>rhashtable, key, nf->f->rhash_params);
> + if (!prev)
> + fq = inet_frag_create(nf, key, );
> + if (prev && !IS_ERR(prev)) {
> + fq = prev;
> if (!refcount_inc_not_zero(>refcnt))
> fq = NULL;
> - rcu_read_unlock();
> - return fq;
> }
> rcu_read_unlock();
> -
> - return inet_frag_create(nf, key);
> + return fq;
GCC is unwilling to see that all paths leading to that final return
statement do in fact set 'fq' one way or another:
net/ipv4/inet_fragment.c: In function ‘inet_frag_find’:
net/ipv4/inet_fragment.c:224:9: warning: ‘fq’ may be used uninitialized in this
function [-Wmaybe-uninitialized]
This is with:
gcc (GCC) 8.2.1 20181011 (Red Hat 8.2.1-4)
Please adjust your patch so that the warning is eliminated.
Thanks.
Re: [PATCH net-next] net: bcmgenet: return correct value 'ret' from bcmgenet_power_down
From: YueHaibing
Date: Thu, 8 Nov 2018 02:08:43 +
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function
> 'bcmgenet_power_down':
> drivers/net/ethernet/broadcom/genet/bcmgenet.c:1136:6: warning:
> variable 'ret' set but not used [-Wunused-but-set-variable]
>
> bcmgenet_power_down should return 'ret' instead of 0.
>
> Fixes: ca8cf341903f ("net: bcmgenet: propagate errors from
> bcmgenet_power_down")
> Signed-off-by: YueHaibing
Applied, thanks.
Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads
From: Jakub Kicinski Date: Wed, 7 Nov 2018 17:33:33 -0800 > This series refactors the "switchdev" Qdisc offloads a little. We have > a few Qdiscs which can be fully offloaded today to the forwarding plane > of switching devices. > > First patch adds a helper for handing statistic dumps, the code seems > to be copy pasted between PRIO and RED. Second patch removes unnecessary > parameter from RED offload function. Third patch makes the MQ offload > use the dump helper which helps it behave much like PRIO and RED when > it comes to the TCQ_F_OFFLOADED flag. Patch 4 adds a graft helper, > similar to the dump helper. > > Patch 5 is unrelated to offloads, qdisc_graft() code seemed ripe for a > small refactor - no functional changes there. > > Last two patches move the qdisc_put() call outside of the sch_tree_lock > section for RED and PRIO. The child Qdiscs will get removed from the > hierarchy under the lock, but having the put (and potentially destroy) > called outside of the lock helps offload which may choose to sleep, > and it should generally lower the Qdisc change impact. Series applied, thanks Jakub.
Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges
From: Amritha Nambiar
Date: Wed, 07 Nov 2018 13:22:42 -0800
> diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h
> index 401d0c1..b63c3cf 100644
> --- a/include/uapi/linux/pkt_cls.h
> +++ b/include/uapi/linux/pkt_cls.h
> @@ -405,6 +405,11 @@ enum {
> TCA_FLOWER_KEY_UDP_SRC, /* be16 */
> TCA_FLOWER_KEY_UDP_DST, /* be16 */
>
> + TCA_FLOWER_KEY_PORT_SRC_MIN,/* be16 */
> + TCA_FLOWER_KEY_PORT_SRC_MAX,/* be16 */
> + TCA_FLOWER_KEY_PORT_DST_MIN,/* be16 */
> + TCA_FLOWER_KEY_PORT_DST_MAX,/* be16 */
> +
> TCA_FLOWER_FLAGS,
> TCA_FLOWER_KEY_VLAN_ID, /* be16 */
> TCA_FLOWER_KEY_VLAN_PRIO, /* u8 */
> @@ -518,6 +523,8 @@ enum {
I don't think you can do this without breaking UAPI, this changes the
value of TCA_FLOWER_FLAGS and all subsequent values in this
enumeration.
Re: [PATCH net-next 0/2] net: phy: use phy_id_mask value zero for exact match
From: Heiner Kallweit Date: Wed, 7 Nov 2018 21:52:31 +0100 > A phy_id_mask value zero means every PHYID matches, therefore > value zero isn't used. So we can safely redefine the semantics > of value zero to mean "exact match". This allows to avoid some > boilerplate code in PHY driver configs. > > Realtek PHY driver is the first user of this change. It looks like there will be some changes to this series, so I will wait for the next version.
Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine
From: Florian Fainelli Date: Thu, 8 Nov 2018 15:00:01 -0800 > On 11/8/18 2:58 PM, David Miller wrote: >> From: Heiner Kallweit >> Date: Wed, 7 Nov 2018 20:41:52 +0100 >> >>> This patch series is based on two axioms: >>> >>> - During autoneg a PHY always reports the link being down >>> >>> - Info in clause 22/45 registers doesn't allow to differentiate between >>> these two states: >>> 1. Link is physically down >>> 2. A link partner is connected and PHY is autonegotiating >>> In both cases "link up" and "aneg finished" bits aren't set. >>> One consequence is that having separate states PHY_NOLINK and PHY_AN >>> isn't needed. >>> >>> By using these two axioms the state machine can be significantly >>> simplified. >> >> So how are we going to move forward on this? >> >> Maybe we can apply this series and just watch carefully for any >> problems that get reported or are found? > > Given Heiner is always responsive and taking care of fixing what might > be/have broken, no objections with me on that. Great, I've applied this series to net-next then. Thanks.
Re: [PATCH net-next 0/5] net: phy: improve and simplify phylib state machine
From: Heiner Kallweit Date: Wed, 7 Nov 2018 20:41:52 +0100 > This patch series is based on two axioms: > > - During autoneg a PHY always reports the link being down > > - Info in clause 22/45 registers doesn't allow to differentiate between > these two states: > 1. Link is physically down > 2. A link partner is connected and PHY is autonegotiating > In both cases "link up" and "aneg finished" bits aren't set. > One consequence is that having separate states PHY_NOLINK and PHY_AN > isn't needed. > > By using these two axioms the state machine can be significantly > simplified. So how are we going to move forward on this? Maybe we can apply this series and just watch carefully for any problems that get reported or are found?
Re: [PATCH 04/20] octeontx2-af: NPC MCAM entry alloc/free support
From: sunil.kovv...@gmail.com Date: Fri, 9 Nov 2018 00:05:45 +0530 > +int rvu_mbox_handler_NPC_MCAM_ALLOC_ENTRY(struct rvu *rvu, > + struct npc_mcam_alloc_entry_req *req, > + struct npc_mcam_alloc_entry_rsp *rsp); > +int rvu_mbox_handler_NPC_MCAM_FREE_ENTRY(struct rvu *rvu, > + struct npc_mcam_free_entry_req *req, > + struct msg_rsp *rsp); Please don't use capitalized letters or StUdLyCaPs for function and variable names. Keep capitalized letters for CPP macros. This is how programmers visually can see if something is a real C declaration or some CPP stuff.
Re: [PATCH net] ipv6/mcast: update mc_qrv when join new group
From: Hangbin Liu Date: Thu, 8 Nov 2018 15:44:10 +0800 > On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote: >> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we >> change sysctl_mld_qrv after interface up, it will has no effect. >> >> Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group. >> >> Reported-by: Ying Xu >> Signed-off-by: Hangbin Liu > > Hi David, > > Any comments for this patch? I did give you feedback and you never responded: https://patchwork.ozlabs.org/patch/989422/ So I tossed your patch.
Re: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-11-07
From: Jeff Kirsher Date: Wed, 7 Nov 2018 14:48:18 -0800 > This series contains updates to almost all of the Intel wired LAN > drivers. ... > The following are changes since commit > 7c588c7468ea3f9b2fc8fa6840bed6262b5d1b00: > Merge branch 'net-systemport-Unmap-queues-upon-DSA-unregister-event' > and are available in the git repository at: > git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue 1GbE Pulled, thanks Jeff.
Re: [PATCH net-next 0/3] nfp: add and use tunnel netdev helpers
From: John Hurley Date: Wed, 7 Nov 2018 18:32:47 + > A recent patch introduced the function netif_is_vxlan() to verify the > tunnel type of a given netdev as vxlan. > > Add a similar function to detect geneve netdevs and make use of this > function in the NFP driver. Also make use of the vxlan helper where > applicable. Series applied.
Re: [PATCH net-next] sfc: add missing NVRAM partition types for EF10
From: Edward Cree Date: Wed, 7 Nov 2018 18:12:42 + > Expose the MUM/SUC Firmware, UEFI Expansion ROM and MC Status partitions > of the NIC's NVRAM as MTDs if found on the NIC. The first two are needed > in order to properly update them when performing firmware updates; the MC > Status partition is used to determine whether a signed firmware image was > accepted or rejected by a Secure NIC. > > Signed-off-by: Edward Cree Applied, thanks.
