Re: [PATCH v3 00/18] wcn36xx fixes

[Kalle Valo]

Bjorn Andersson <bjorn.anders...@linaro.org> writes:

> The bulk of the following patches have been sitting in Eugene's Github tree 
> for
> quite some time. They fix various issues existing in the mainline drivers, so
> they should be merged there too.
>
> Also included are two new fixes, of my own; the important one being the
> reordering of deletion of the bss, as this crashes the firmware on the
> Dragonbaord 410c (apq8016 with pronto & wcn3620).
>
> Lastly is a patch that adds a bunch of new capabilities found in the 
> downstream
> driver.
>
> Changes since v2:
> - Restore BEACON_TEMPLATE_SIZE to not break UPDATE_PROBE_RSP_TEMPLATE_REQ
> - Added patch to correct WCN36XX_HAL_RMV_BSSKEY_RSP decoder
> - Added patch with missing capabilities from downstream
>
> Changes since v1:
> - Reorder patch 6 and 7 to not break the build temporarily
> - Inline fix from Jason Mobarak in the TIM PVM padding
>
> Bjorn Andersson (3):
>   wcn36xx: Delete BSS before idling link
>   wcn36xx: Correct remove bss key response encoding
>   wcn36xx: Fill in capability list
>
> Pontus Fuchs (15):
>   wcn36xx: Clean up wcn36xx_smd_send_beacon
>   wcn36xx: Pad TIM PVM if needed
>   wcn36xx: Add helper macros to cast vif to private vif and vice versa
>   wcn36xx: Use consistent name for private vif
>   wcn36xx: Use define for invalid index and fix typo
>   wcn36xx: Add helper macros to cast sta to priv
>   wcn36xx: Fetch private sta data from sta entry instead of from vif
>   wcn36xx: Remove sta pointer in private vif struct
>   wcn36xx: Parse trigger_ba response properly
>   wcn36xx: Copy all members in config_sta v1 conversion
>   wcn36xx: Use allocated self sta index instead of hard coded
>   wcn36xx: Clear encrypt_type when deleting bss key
>   wcn36xx: Track association state
>   wcn36xx: Implement multicast filtering
>   wcn36xx: Use correct command struct for EXIT_BMPS_REQ

All applied, thanks.

-- 
Kalle Valo

pull-request: wireless-drivers 2016-04-25

[Kalle Valo]

Hi Dave,

few fixes for 4.6, more info in the signed tag below. I'm hoping this to
be the final pull request for 4.6 but let's see how it goes. Please let
me know if there are any problems.

Kalle

The following changes since commit 15da5d11040c636cddf85bd93fd4abe85f02fc9f:

  Merge tag 'iwlwifi-for-kalle-2016-03-30' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-04-02 17:59:57 +0300)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 
tags/wireless-drivers-for-davem-2016-04-25

for you to fetch changes up to e2841ea91611622370f66b4dfaa62599e8850d48:

  Merge tag 'iwlwifi-for-kalle-2016-04-12_2' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-04-21 15:40:13 +0300)



wireless-drivers fixes for 4.6

ath9k

* fix a couple release old throughput regression on ar9281

iwlwifi

* add new device IDs for 8265
* fix a NULL pointer dereference when paging firmware asserts
* remove a WARNING on gscan capabilities
* fix MODULE_FIRMWARE for 8260


Ayala Beker (1):
  iwlwifi: mvm: avoid to WARN about gscan capabilities

Kalle Valo (1):
  Merge tag 'iwlwifi-for-kalle-2016-04-12_2' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-fixes

Matti Gottlieb (1):
  iwlwifi: mvm: fix accessing Null pointer during fw dump collection

Oleksij Rempel (1):
  ath9k: ar5008_hw_cmn_spur_mitigate: add missing mask_m & mask_p 
initialisation

Oren Givon (1):
  iwlwifi: add device IDs for the 8265 device

Sara Sharon (1):
  iwlwifi: 8000: fix MODULE_FIRMWARE input

 drivers/net/wireless/ath/ath9k/ar5008_phy.c |8 +++
 drivers/net/wireless/ath/ath9k/ar9002_phy.c |5 -
 drivers/net/wireless/intel/iwlwifi/iwl-8000.c   |2 +-
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c|   26 +--
 drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c |6 --
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c |2 ++
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c   |   10 +
 7 files changed, 30 insertions(+), 29 deletions(-)

Re: [PATCH v3] prism54: isl_38xx: Replace 'struct timeval'

[Kalle Valo]

Johannes Berg <johan...@sipsolutions.net> writes:

> On Mon, 2016-04-18 at 00:10 +0200, Arnd Bergmann wrote:
>> On Sunday 17 April 2016 14:42:33 Johannes Berg wrote:
>> > 
>> > I was thinking more restrictively of just the stuff that can't even
>> > be built without modifying the sources - like the "#if VERBOSE"
>> > thing.
>>
>> All the DEBUG() statements are inside of this kind of check, so if we
>> remove the #ifdefs, it would be logical to remove the rest of the
>> debugging infrastructure (DEBUG() macros, SHOW_*, pc_debug, maybe
>> more) as well.
>
> Seems reasonable.
>
> Maybe we should Cc the maintainer, but I suspect that since the driver
> is marked Obsolete anyway Luis won't care either :)

I'm planning to apply this patch anyway, the debugging infrastructure
removal can be a followup patch. But please let me know if I should drop
this instead.

-- 
Kalle Valo

Re: rtl8xxxu: hide unused tables

[Kalle Valo]

> The references to some arrays in the rtl8xxxu driver were moved inside
> of an #ifdef, but the symbols remain outside, resulting in build warnings:
> 
> rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' 
> defined but not used
> rtl8xxxu/rtl8xxxu.c:1431:33: error: 'rtl8192cu_radioa_1t_init_table' defined 
> but not used
> rtl8xxxu/rtl8xxxu.c:1407:33: error: 'rtl8192cu_radiob_2t_init_table' defined 
> but not used
> rtl8xxxu/rtl8xxxu.c:1332:33: error: 'rtl8192cu_radioa_2t_init_table' defined 
> but not used
> rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not used
> rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not used
> 
> This adds an extra #ifdef around them to shut up the warnings.
> 
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts")
> Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific 
> functions")

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

[Kalle Valo]

Christian Lamparter <chunk...@googlemail.com> writes:

> On Monday, April 18, 2016 07:42:05 PM Kalle Valo wrote:
>> Christian Lamparter <chunk...@googlemail.com> writes:
>> 
>> > On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote:
>> >
>> >> Why even mention anything about a "special firmware" as the firmware is
>> >> already available from linux-firmware.git? 
>> >
>> > Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too
>> > but that failed.
>> > <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639>
>> 
>> Rick's comment makes sense to me, better just to provide the latest
>> version. No need to unnecessary confuse the users. And if someone really
>> wants to use an older version that she can retrieve it from the git
>> history.
>
> Part of the fun here is that firmware is GPLv2. The linux-firmware.git has
> to point to or add the firmware source to their tree. They have added every
> single source file to it instead of "packaging" it in a tar.bz2/gz/xz
> like you normally do for release sources.
>
> If you want to read more about it:
> <http://www.spinics.net/lists/linux-wireless/msg101868.html>

Yeah, that's more work. I get that. But I'm still not understanding
what's the actual problem which prevents us from updating carl9170
firmware in linux-firmware.

-- 
Kalle Valo

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

[Kalle Valo]

Colin King <colin.k...@canonical.com> writes:

> From: Colin Ian King <colin.k...@canonical.com>
>
> ah is written twice with the same value, remove one of the
> redundant assignments to ah.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Applied, thanks.

-- 
Kalle Valo

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

[Kalle Valo]

Julian Calaby <julian.cal...@gmail.com> writes:

> On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring
> <elfr...@users.sourceforge.net> wrote:
>> From: Markus Elfring <elfr...@users.sourceforge.net>
>> Date: Fri, 1 Jan 2016 19:09:32 +0100
>>
>> Replace an explicit initialisation for one local variable at the beginning
>> by a conditional assignment.
>>
>> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
>
> This looks sane to me.
>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Applied, thanks.

-- 
Kalle Valo

Re: [PATCH] rtl8xxxu: hide unused tables

[Kalle Valo]

Jes Sorensen <jes.soren...@redhat.com> writes:

> Arnd Bergmann <a...@arndb.de> writes:
>> The references to some arrays in the rtl8xxxu driver were moved inside
>> of an #ifdef, but the symbols remain outside, resulting in build warnings:
>>
>> rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' 
>> defined but not used
>> rtl8xxxu/rtl8xxxu.c:1431:33: error: 'rtl8192cu_radioa_1t_init_table' defined 
>> but not used
>> rtl8xxxu/rtl8xxxu.c:1407:33: error: 'rtl8192cu_radiob_2t_init_table' defined 
>> but not used
>> rtl8xxxu/rtl8xxxu.c:1332:33: error: 'rtl8192cu_radioa_2t_init_table' defined 
>> but not used
>> rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not used
>> rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not used
>>
>> This adds an extra #ifdef around them to shut up the warnings.
>>
>> Signed-off-by: Arnd Bergmann <a...@arndb.de>
>> Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts")
>> Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device specific 
>> functions")
>> ---
>>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 
>>  1 file changed, 4 insertions(+)
>
> I'll apply it to my tree!

Actually I would prefer to apply this directly to wireless-drivers-next
so that the warnings are quickly fixed.

-- 
Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

[Kalle Valo]

Christian Lamparter <chunk...@googlemail.com> writes:

> On Monday, April 18, 2016 06:45:09 PM Kalle Valo wrote:
>> Lauri Kasanen <c...@gmx.com> writes:
>> 
>> > --- a/drivers/net/wireless/ath/carl9170/Kconfig
>> > +++ b/drivers/net/wireless/ath/carl9170/Kconfig
>> > @@ -5,12 +5,10 @@ config CARL9170
>> >select FW_LOADER
>> >select CRC32
>> >help
>> > -This is another driver for the Atheros "otus" 802.11n USB devices.
>> > +This is the mainline driver for the Atheros "otus" 802.11n USB 
>> > devices.
>> >  
>> > -This driver provides more features than the original,
>> > -but it needs a special firmware (carl9170-1.fw) to do that.
>> > -
>> > -The firmware can be downloaded from our wiki here:
>> > +It needs a special firmware (carl9170-1.fw), which can be downloaded
>> > +from our wiki here:
>> >  <http://wireless.kernel.org/en/users/Drivers/carl9170>
>> 
>> Why even mention anything about a "special firmware" as the firmware is
>> already available from linux-firmware.git? 
>
> Yes and no. 1.9.6 is in linux-firmware.git. I've tried to add 1.9.9 too
> but that failed.
> <http://comments.gmane.org/gmane.linux.kernel.wireless.general/114639>

Rick's comment makes sense to me, better just to provide the latest
version. No need to unnecessary confuse the users. And if someone really
wants to use an older version that she can retrieve it from the git
history.

>> That's default location for all firmware images and I think most, if not all,
>> distros should have it available. So wouldn't it be better not to mention 
>> anything about firmware at all?
>
> Sure, but this could be a different patch then. I think Intel devices 
> (iwlwifi, iwlegacy and ipw2x00) have a similar text about "download
> firmware from this device from our homepage here" too. So if we want,
> we can remove them altogether?

So iwlwifi now has:

  In order to use this driver, you will need a firmware
  image for it. You can obtain the microcode from:

  <http://wireless.kernel.org/en/users/Drivers/iwlwifi>.

Maybe that could be changed to mention about the wiki page in general:

  The driver has a wiki page at:

  <http://wireless.kernel.org/en/users/Drivers/iwlwifi>.

But I know iwlwifi updates the firmware images pretty often so Emmanuel
might see this differently.

-- 
Kalle Valo

Re: [PATCH v2] carl9170: Clarify kconfig text

[Kalle Valo]

Lauri Kasanen <c...@gmx.com> writes:

> The previous text was confusing, leading readers to think this
> driver was a duplicate, and so didn't need to be enabled.
>
> After the removal of the older staging driver, this is the only
> driver in mainline for these devices.
>
> Signed-off-by: Lauri Kasanen <c...@gmx.com>
> ---
> v2: Remove the mention of the previous driver, suggested by Christian.
>
>  drivers/net/wireless/ath/carl9170/Kconfig | 8 +++-
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/Kconfig 
> b/drivers/net/wireless/ath/carl9170/Kconfig
> index 1a796e5..2e34bae 100644
> --- a/drivers/net/wireless/ath/carl9170/Kconfig
> +++ b/drivers/net/wireless/ath/carl9170/Kconfig
> @@ -5,12 +5,10 @@ config CARL9170
>   select FW_LOADER
>   select CRC32
>   help
> -   This is another driver for the Atheros "otus" 802.11n USB devices.
> +   This is the mainline driver for the Atheros "otus" 802.11n USB 
> devices.
>  
> -   This driver provides more features than the original,
> -   but it needs a special firmware (carl9170-1.fw) to do that.
> -
> -   The firmware can be downloaded from our wiki here:
> +   It needs a special firmware (carl9170-1.fw), which can be downloaded
> +   from our wiki here:
> <http://wireless.kernel.org/en/users/Drivers/carl9170>

Why even mention anything about a "special firmware" as the firmware is
already available from linux-firmware.git? That's default location for
all firmware images and I think most, if not all, distros should have it
available. So wouldn't it be better not to mention anything about
firmware at all?

-- 
Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

[Kalle Valo]

Julian Calaby <julian.cal...@gmail.com> writes:

> Hi Kalle,
>
> On Sat, Apr 16, 2016 at 4:25 AM, Kalle Valo <kv...@codeaurora.org> wrote:
>> Byeoungwook Kim <quddnr...@gmail.com> writes:
>>
>>> rtl_*_delay() functions were reused same codes about addr variable.
>>> So i have converted to rtl_addr_delay() from code about addr variable.
>>>
>>> Signed-off-by: Byeoungwook Kim <quddnr...@gmail.com>
>>> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
>>
>> Doesn't apply:
>>
>> Applying: rtlwifi: Fix reusable codes in core.c
>> fatal: sha1 information is lacking or useless 
>> (drivers/net/wireless/realtek/rtlwifi/core.c).
>> Repository lacks necessary blobs to fall back on 3-way merge.
>> Cannot fall back to three-way merge.
>> Patch failed at 0001 rtlwifi: Fix reusable codes in core.c
>>
>> Please rebase and resend.
>
> This one is already applied in some form. I thought I'd listed it in
> my big list of superseded patches, however I must have missed it.

Or I missed it :) But good to know, so no actions needed anymore.

-- 
Kalle Valo

Re: [PATCH 2/2] rtlwifi: Fix reusable codes in core.c

[Kalle Valo]

Byeoungwook Kim <quddnr...@gmail.com> writes:

> rtl_*_delay() functions were reused same codes about addr variable.
> So i have converted to rtl_addr_delay() from code about addr variable.
>
> Signed-off-by: Byeoungwook Kim <quddnr...@gmail.com>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Doesn't apply:

Applying: rtlwifi: Fix reusable codes in core.c
fatal: sha1 information is lacking or useless 
(drivers/net/wireless/realtek/rtlwifi/core.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 rtlwifi: Fix reusable codes in core.c

Please rebase and resend.

-- 
Kalle Valo

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

[Kalle Valo]

Bjorn Andersson <bjorn.anders...@linaro.org> writes:

> On Sun 03 Apr 15:16 PDT 2016, Bjorn Andersson wrote:
>
>> From: Pontus Fuchs <pontus.fu...@gmail.com>
>> 
>> Needed for coming improvements. No functional changes.
>> 
>
> Kalle, Eugene,
>
> Have you picked up these patches yet?
>
> As I was debugging a firmware crash when trying to start hostap on the
> DragonBoard410c I found an issue with this patch, would like to know if
> I should send an incremental patch or resend this one.

I haven't applied these yet, so please resend the whole series as v3.

-- 
Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

[Kalle Valo]

Eliad Peller <el...@wizery.com> writes:

> On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches <j...@perches.com> wrote:
>> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote:
>>> Joe Perches <j...@perches.com> writes:
>>> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
>>> > > Joe Perches <j...@perches.com> writes:
>>> > > >
>>> > > > Using the normal kernel logging mechanisms makes this code
>>> > > > a bit more like other wireless drivers.
>>> > > Personally I don't see the point but I don't have any strong opinions. A
>>> > > bigger problem is that TI drivers are not really in active development
>>> > > and that's I'm not thrilled to take big patches like this for dormant
>>> > > drivers.
>>> > Not very dormant.
>>> >
>>> > 35 patches in the last year, most of them adding functionality.
>>> Oh, I didn't realise it had that many patches. But the driver is
>>> orphaned and doesn't have a maintainer so could I then have an ack from
>>> one of the active contributors that this ok?
>>
>> Fine by me.
>>
>> $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/
>>
>> Kalle Valo <kv...@codeaurora.org> (maintainer:NETWORKING DRIVERS 
>> (WIRELESS),commit_signer:27/35=77%)
>> Eliad Peller <el...@wizery.com> (commit_signer:9/35=26%,authored:7/35=20%)
>> Guy Mishol <g...@ti.com> (commit_signer:6/35=17%,authored:5/35=14%)
>> Johannes Berg <johannes.b...@intel.com> 
>> (commit_signer:6/35=17%,authored:3/35=9%)
>> Uri Mashiach <uri.mashi...@compulab.co.il> 
>> (commit_signer:4/35=11%,authored:4/35=11%)
>>
>> For those people now added to the cc list,
>> here's the original patch thread:
>>
>> https://lkml.org/lkml/2016/3/7/1099
>
> I don't have a strong opinion here either.
> (I do like the trailing newline being added automatically, but that's
> hardly an issue...)

Ok, I didn't get any objections so I'm planning to this set. If someone
thinks this is a bad idea speak up now.

-- 
Kalle Valo

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

[Kalle Valo]

Julian Calaby <julian.cal...@gmail.com> writes:

> Hi Kalle,
>
> On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring
> <elfr...@users.sourceforge.net> wrote:
>> From: Markus Elfring <elfr...@users.sourceforge.net>
>> Date: Fri, 1 Jan 2016 19:09:32 +0100
>>
>> Replace an explicit initialisation for one local variable at the beginning
>> by a conditional assignment.
>>
>> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
>
> This looks sane to me.
>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Before I commit I'll just change the commit title to:

ath9k_htc: Replace a variable initialisation by an assignment in 
ath9k_htc_set_channel()

-- 
Kalle Valo

pull-request: wireless-drivers 2016-04-13

[Kalle Valo]

Hi Dave,

few very small fixes for 4.6. All but one are either build fixes or
memory leaks. More info in the signed tag below.

Please let me know if there are any problems.

Kalle

The following changes since commit 9a3492194eca6253ae7ba93c7a402cecad7f1c94:

  Merge branch 'AF_VSOCK-missed-wakeups' (2016-03-22 16:18:42 -0400)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 
tags/wireless-drivers-for-davem-2016-04-13

for you to fetch changes up to 15da5d11040c636cddf85bd93fd4abe85f02fc9f:

  Merge tag 'iwlwifi-for-kalle-2016-03-30' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-04-02 17:59:57 +0300)



wireless-drivers fixes for 4.6

b43

* fix memory leaks when removing the device

bcma

* fix building without OF_IRQ

rtlwifi

* fix gcc-6 indentation warning

iwlwifi

* lower the debug level of a benign print
* fix a memory leak


Arnd Bergmann (2):
  bcma: fix building without OF_IRQ
  rtlwifi: fix gcc-6 indentation warning

Emmanuel Grumbach (1):
  iwlwifi: pcie: lower the debug level for RSA semaphore access

Jia-Ju Bai (1):
  b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

Kalle Valo (1):
  Merge tag 'iwlwifi-for-kalle-2016-03-30' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-fixes

Matti Gottlieb (1):
  iwlwifi: mvm: fix memory leak in paging

 drivers/bcma/main.c|   17 -
 drivers/net/wireless/broadcom/b43/main.c   |6 --
 drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c  |2 ++
 drivers/net/wireless/intel/iwlwifi/mvm/ops.c   |2 --
 drivers/net/wireless/intel/iwlwifi/pcie/trans.c|4 ++--
 .../net/wireless/realtek/rtlwifi/rtl8821ae/dm.c|6 +++---
 6 files changed, 15 insertions(+), 22 deletions(-)

pull-request: wireless-drivers-next 2016-04-11

[Kalle Valo]

Hi Dave,

here's a pull request for 4.7. More features, but nothing really
standing out. Please let me know if you have any problems.

Kalle


The following changes since commit 4da46cebbd3b4dc445195a9672c99c1353af5695:

  net/core/dev: Warn on a too-short GRO frame (2016-04-05 19:58:39 -0400)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git 
tags/wireless-drivers-next-for-davem-2016-04-11

for you to fetch changes up to 20ac1b325d8d526211b1276ecf9b64b7e8369f50:

  Merge ath-next from ath.git (2016-04-07 21:44:37 +0300)



wireless-drivers patches for 4.7

Major changes:

iwlwifi

* support for Link Quality measurement
* more work 9000 devices and MSIx
* continuation of the Dynamic Queue Allocation work
* make the paging less memory hungry
* 9000 new Rx path
* removal of IWLWIFI_UAPSD Kconfig option

ath10k

* implement push-pull tx model using mac80211 software queuing support
* enable scan in AP mode (NL80211_FEATURE_AP_SCAN)

wil6210

* add basic PBSS (Personal Basic Service Set) support
* add initial P2P support
* add oob_mode module parameter


Amitkumar Karwar (2):
  mwifiex: fix Tx timeout issue during suspend test
  mwifiex: advertise low priority scan feature

Anilkumar Kolli (1):
  ath10k: fix debugfs pktlog_filter write

Aviya Erenfeld (2):
  iwlwifi: mvm: add LQM vendor command and notification
  iwlwifi: add a debugfs hook for LQM

Ayala Beker (1):
  iwlwifi: mvm: update GSCAN capabilities

Bob Copeland (3):
  ath5k: fix incorrect indentation
  ath9k: fix a misleading indentation
  ath9k_htc: fix up indents with spaces

Chaya Rachel Ivgi (2):
  iwlwifi: mvm: handle async temperature notification with unlocked mutex
  iwlwifi: mvm: remove uneeded D0I3 checking

Colin Ian King (4):
  iwlwifi: pcie: remove duplicate assignment of variable isr_stats
  wl12xx: remove redundant null check on wl->scan.ssid
  brcmfmac: sdio: remove unused variable retry_limit
  mwifiex: ie_list is an array, so no need to check if NULL

Dan Carpenter (1):
  brcmfmac: uninitialized "ret" variable

David Spinadel (1):
  iwlwifi: mvm: set aux STA ID in scan config

Dedy Lansky (1):
  wil6210: p2p initial support

Emmanuel Grumbach (6):
  iwlwifi: pcie: print error value as signed int
  iwlwifi: mvm: modify the max SP to infinite
  iwlwifi: add missing mutex_destroy statements
  iwlwifi: make uapsd_disable module param a bitmap
  iwlwifi: remove IWLWIFI_UAPSD Kconfig
  iwlwifi: remove IWL_*_UCODE_API_OK

Eva Rachel Retuya (1):
  iwlwifi: dvm: use alloc_ordered_workqueue()

Ganapathi Bhat (2):
  mwifiex: add support for GTK rekey offload
  mwifiex: add support for wakeup on GTK rekey failure

Geert Uytterhoeven (1):
  mwifiex: Spelling s/minmum/minimum/, s/bandwidth/bandwith/

Geliang Tang (4):
  ipw2x00: use to_pci_dev()
  wlcore: use to_delayed_work()
  wl1251: use to_delayed_work()
  rtlwifi: use to_delayed_work()

Golan Ben-Ami (2):
  iwlwifi: mvm: support dumping UMAC internal txfifos
  iwlwifi: store fw memory segments length and addresses in run-time

Grzegorz Bajorski (1):
  ath10k: deliver mgmt frames from htt to monitor vifs only

Haim Dreyfuss (2):
  iwlwifi: 9000: update device id and FW serial number
  iwlwifi: pcie: Fix index iteration on free_irq in MSIX mode

Hamad Kadmany (1):
  wil6210: Set permanent MAC address to wiphy

Ivan Safonov (1):
  ath9k: Remove unnecessary ?: operator

Jes Sorensen (10):
  rtl8xxxu: Change name of struct tx_desc to be more decriptive
  rtl8xxxu: Rename TX descriptor bits to map them to 32/40 byte descriptors
  rtl8xxxu: Correct txdesc40 gid definition
  rtl8xxxu: TXDESC_SHORT_GI is txdesc32 only
  rtl8xxxu: 8192eu uses txdesc40
  rtl8xxxu: Update some register definitions
  rtl8xxxu: Use enums for chip version numbers
  rtl8xxxu: Identify 8192eu rev A/B parts correctly
  rtl8xxxu: Use correct H2C calls for 8192eu
  rtl8xxxu: Do not set LDOA15 / LDOV12 on 8192eu

Jia-Ju Bai (4):
  iwl4965: Fix a null pointer dereference in il_tx_queue_free and 
il_cmd_queue_free
  b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init
  rtl818x_pci: Disable pci device in error handling code
  iwl4965: Fix a memory leak in error handling code of __il4965_up

Joe Perches (1):
  rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

Johannes Berg (1):
  iwlwifi: mvm: remove is_data_qos variable in TX

Joseph Salisbury (1):
  ath5k: Change led pin configuration for compaq c700 laptop

Julian Calaby (1):
  iwl4965: Fix more memory leaks in __il4965_up()

Kalle Valo (2):
  Merge tag 'iwlwifi-next-for-kalle-2016-03-30' of 
https://git.kernel.or

Re: mwifiex: ie_list is an array, so no need to check if NULL

[Kalle Valo]

> From: Colin Ian King <colin.k...@canonical.com>
> 
> ap_ie->ie_list is an array of struct mwifiex_ie and can never
> be null, so the null check on this array is redundant and can
> be removed.
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

[Kalle Valo]

"Reizer, Eyal" <ey...@ti.com> writes:

>> >  static const struct of_device_id wlcore_spi_of_match_table[] = {
>> > -  { .compatible = "ti,wl1271" },
>> > +  { .compatible = "ti,wl1271", .data = _data},
>> > +  { .compatible = "ti,wl1273", .data = _data},
>> > +  { .compatible = "ti,wl1281", .data = _data},
>> > +  { .compatible = "ti,wl1283", .data = _data},
>> > +  { .compatible = "ti,wl1801", .data = _data},
>> > +  { .compatible = "ti,wl1805", .data = _data},
>> > +  { .compatible = "ti,wl1807", .data = _data},
>> > +  { .compatible = "ti,wl1831", .data = _data},
>> > +  { .compatible = "ti,wl1835", .data = _data},
>> > +  { .compatible = "ti,wl1837", .data = _data},
>> >{ }
>> 
>> Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now it 
>> only
>> mentions about ti,wl1271 and not anything about the rest.
>
> You are right! Will be fixed in v2

Thanks. Also remember to CC devicetree list.

-- 
Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

[Kalle Valo]

Eyal Reizer <eyalrei...@gmail.com> writes:

> Add support for using with both wl12xx and wl18xx.
>
> - all wilink family needs special init command for entering wspi mode.
>   extra clock cycles should be sent after the spi init command while the
>   cs pin is high.
> - switch to controling the cs pin from the spi driver for achieveing the
>   above.
> - the selected cs gpio is read from the spi device-tree node using the
>   cs-gpios field and setup as a gpio.
> - See the example below for specifying the cs gpio using the cs-gpios entry
>
>  {
>   status = "okay";
>   pinctrl-names = "default";
>   pinctrl-0 = <_pins>;
>   cs-gpios = < 5 0>;
>   #address-cells = <1>;
>   #size-cells = <0>;
>   wlcore: wlcore@0 {
>   compatible = "ti,wl1835";
>   vwlan-supply = <_en_reg>;
>   spi-max-frequency = <4800>;
>   reg = <0>;  /* chip select 0 on spi0, ie spi0.0 */
>   interrupt-parent = <>;
>   interrupts = <27 IRQ_TYPE_EDGE_RISING>;
>   };
> };
>
> Signed-off-by: Eyal Reizer <ey...@ti.com>

[...]

>  static const struct of_device_id wlcore_spi_of_match_table[] = {
> - { .compatible = "ti,wl1271" },
> + { .compatible = "ti,wl1271", .data = _data},
> + { .compatible = "ti,wl1273", .data = _data},
> + { .compatible = "ti,wl1281", .data = _data},
> + { .compatible = "ti,wl1283", .data = _data},
> + { .compatible = "ti,wl1801", .data = _data},
> + { .compatible = "ti,wl1805", .data = _data},
> + { .compatible = "ti,wl1807", .data = _data},
> + { .compatible = "ti,wl1831", .data = _data},
> +     { .compatible = "ti,wl1835", .data = _data},
> + { .compatible = "ti,wl1837", .data = _data},
>   { }

Shouldn't you also update bindings/net/wireless/ti,wlcore,spi.txt? Now
it only mentions about ti,wl1271 and not anything about the rest.

Adding devicetree list for further comments.

-- 
Kalle Valo

Re: [PATCH] wlcore: spi: add wl18xx support

[Kalle Valo]

"Reizer, Eyal" <ey...@ti.com> writes:

> Ping on this patch
>
>> -Original Message-
>> From: Eyal Reizer [mailto:eyalrei...@gmail.com]
>> Sent: Wednesday, March 30, 2016 4:07 PM
>> To: kv...@codeaurora.org; linux-wirel...@vger.kernel.org;
>> netdev@vger.kernel.org; linux-ker...@vger.kernel.org
>> Cc: Reizer, Eyal
>> Subject: [PATCH] wlcore: spi: add wl18xx support

Please edit your quotes and don't top most. A oneliner and then followed
by almost 400 lines unnecessary text for example makes it harder to use
patchwork:

https://patchwork.kernel.org/patch/8696181/

-- 
Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

[Kalle Valo]

"Machani, Yaniv" <yani...@ti.com> writes:

> More than that, wl1251 family is not officially supported via the
> mainline Linux.

I guess you mean not officially supported by TI? Because wl1251 driver
has been in mainline for ages and reportedly working.

-- 
Kalle Valo

Re: [v2] mwifiex: advertise low priority scan feature

[Kalle Valo]

> From: Amitkumar Karwar <akar...@marvell.com>
> 
> Low priority scan handling code which delays or aborts scan
> operation based on Tx traffic is removed recently. The reason
> is firmware already takes care of it in our new feature scan
> channel gap. Hence we should advertise low priority scan
> support to cfg80211.
> 
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
> 
> Signed-off-by: Amitkumar Karwar <akar...@marvell.com>
> Signed-off-by: Wei-Ning Huang <wnhu...@chromium.org>
> Tested-by: Wei-Ning Huang <wnhu...@chromium.org>
> Acked-by: Amitkumar Karwar <akar...@marvell.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: brcmfmac: sdio: remove unused variable retry_limit

[Kalle Valo]

> From: Colin Ian King <colin.k...@canonical.com>
> 
> retry_limit has never been used during the life of this driver, so
> we may as well remove it as it is redundant.
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: wl12xx: remove redundant null check on wl->scan.ssid

[Kalle Valo]

> From: Colin Ian King <colin.k...@canonical.com>
> 
> ssid is an array of u8, so it can never be null, so the null check on
> wl->scan.ssid is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

[Kalle Valo]

> Use a more common logging style.
> 
> Miscellanea:
> 
> o Add specific logging macros for ALGORITHM and INTERFACE types
> o Output the messages at KERN_DEBUG
> o Coalesce formats
> o Align arguments
> o Whitespace style adjustments for only these changes
> 
> Signed-off-by: Joe Perches <j...@perches.com>

Thanks, applied to wireless-drivers-next.git. There were some conflicts but
3-way merge was able to fix them. Please double check still.

Applying: rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.h
Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
Auto-merging drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b2ant.c

Kalle Valo

Re: [PATCH] ath5k: Change led pin configuration for compaq c700 laptop

[Kalle Valo]

Joseph Salisbury <joseph.salisb...@canonical.com> writes:

> BugLink: http://bugs.launchpad.net/bugs/972604
>
> Commit 09c9bae26b0d3c9472cb6ae45010460a2cee8b8d ("ath5k: add led pin 
> configuration for compaq c700 laptop") added a pin configuration for the 
> Compaq 
> c700 laptop.  However, the polarity of the led pin is reversed.  It should be 
> red for wifi off and blue for wifi on, but it is the opposite.  This bug was 
> reported in the following bug report: 
> http://pad.lv/972604
>
>
> Fixes: 09c9bae26b0d3c9472cb6ae45010460a2cee8b8d ("ath5k: add led pin 
> configuration for compaq c700 laptop")
>
> Signed-off-by: Joseph Salisbury <joseph.salisb...@canonical.com>
> Cc: sta...@vger.kernel.org

Applied to ath.git, thanks.

I just fixed the Fixes line to be one continuous line.

-- 
Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

[Kalle Valo]

Joe Perches <j...@perches.com> writes:

> On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote:
>> Joe Perches <j...@perches.com> writes:
>> > Using the normal kernel logging mechanisms makes this code
>> > a bit more like other wireless drivers.
>> Personally I don't see the point but I don't have any strong opinions. A
>> bigger problem is that TI drivers are not really in active development
>> and that's I'm not thrilled to take big patches like this for dormant
>> drivers.
>
> Not very dormant.
>
> 35 patches in the last year, most of them adding functionality.

Oh, I didn't realise it had that many patches. But the driver is
orphaned and doesn't have a maintainer so could I then have an ack from
one of the active contributors that this ok?

-- 
Kalle Valo

Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style

[Kalle Valo]

Joe Perches <j...@perches.com> writes:

> Using the normal kernel logging mechanisms makes this code
> a bit more like other wireless drivers.

Personally I don't see the point but I don't have any strong opinions. A
bigger problem is that TI drivers are not really in active development
and that's I'm not thrilled to take big patches like this for dormant
drivers.

-- 
Kalle Valo

Re: [PATCH 06/16] wcn36xx: Fetch private sta data from sta entry instead of from vif

[Kalle Valo]

Bjorn Andersson <bjorn.anders...@linaro.org> writes:

>> All error/warnings (new ones prefixed by >>):
>> 
>>drivers/net/wireless/ath/wcn36xx/main.c: In function 'wcn36xx_set_key':
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:9: error: implicit 
>> >> declaration of function 'wcn36xx_sta_to_priv' 
>> >> [-Werror=implicit-function-declaration]
>>  struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>> ^
>> >> drivers/net/wireless/ath/wcn36xx/main.c:389:33: warning: initialization 
>> >> makes pointer from integer without a cast
>>  struct wcn36xx_sta *sta_priv = wcn36xx_sta_to_priv(sta);
>> ^
>>cc1: some warnings being treated as errors
>
> This should have been reordered with patch 7, that introduces this
> helper function. Do you want me to resend, or can you apply the patches
> out of order?

It's better that you resend the whole patchset as v2.

-- 
Kalle Valo

Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call

[Kalle Valo]

Wei-Ning Huang <wnhu...@chromium.org> writes:

> "single skb allocation failure" happens when system is under heavy
> memory pressure.  Add __GFP_REPEAT to skb allocation call so kernel
> attempts to reclaim pages and retry the allocation.
>
> Signed-off-by: Wei-Ning Huang <wnhu...@chromium.org>

Is this really a proper way to fix the issue? This is the first time I'm
hearing about the flag and there isn't even a single user in
drivers/net. I would like to get confirmation from others that
__GFP_REPEAT is really ok to use in a wireless driver before I can take
this.

-- 
Kalle Valo

Re: rtlwifi: fix gcc-6 indentation warning

[Kalle Valo]

> The rtl8821ae_dm_txpower_tracking_callback_thermalmeter function
> contains a call to RT_TRACE() that is indented in a misleading
> way, as pointed out by a gcc-6 warning:
> 
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function 
> 'rtl8821ae_dm_txpower_tracking_callback_thermalmeter':
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2491:4: error: statement 
> is indented as if it were guarded by...
> RT_TRACE(rtlpriv, COMP_POWER_TRACKING, DBG_LOUD,
> ^~~~
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c:2488:3: note: ...this 
> 'for' clause, but it is not
>for (p = RF90_PATH_A; p < MAX_PATH_NUM_8821A; p++)
>^~~
> 
> It is clear from the context that the call was not meant to be
> part of the loop and only the indentation is wrong, so this
> removes the extra tabs.
> 
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Acked-by: Larry Finger <larry.fin...@lwfinger.net>

Thanks, applied to wireless-drivers.git.

Kalle Valo

Re: b43: Fix memory leaks in b43_bus_dev_ssb_init andb43_bus_dev_bcma_init

[Kalle Valo]

> From: Jia-Ju Bai <baijiaju1...@163.com>
> 
> The memory allocated by kzalloc in b43_bus_dev_ssb_init and
> b43_bus_dev_bcma_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove,
> b43_bcma_remove and error handling code of b43_bcma_probe.
> 
> Thanks Michael for his suggestion.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com>
> Acked-by: Michael Büsch <m...@bues.ch>
> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk>

Thanks, applied to wireless-drivers.git.

Kalle Valo

Re: [PATCH 4/5] ath9k: fix misleading indentation

[Kalle Valo]

Arnd Bergmann <a...@arndb.de> writes:

> A cleanup patch in linux-3.18 moved around some code in the ath9k
> driver and left some code to be indented in a misleading way,
> made worse by the addition of some new code for p2p mode, as
> discovered by a new gcc-6 warning:
>
> drivers/net/wireless/ath/ath9k/init.c: In function 'ath9k_set_hw_capab':
> drivers/net/wireless/ath/ath9k/init.c:851:4: warning: statement is indented 
> as if it were guarded by... [-Wmisleading-indentation]
> hw->wiphy->iface_combinations = if_comb;
> ^~
> drivers/net/wireless/ath/ath9k/init.c:847:3: note: ...this 'if' clause, but 
> it is not
>if (ath9k_is_chanctx_enabled())
>^~
>
> The code is in fact correct, but the indentation is not, so I'm
> reformatting it as it should have been after the original cleanup.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Fixes: 499afaccf6f3 ("ath9k: Isolate ath9k_use_chanctx module parameter")
> Fixes: eb61f9f623f7 ("ath9k: advertise p2p dev support when chanctx")

Dave already applied this so I can skip this.

-- 
Kalle Valo

Re: [PATCH 3/5] ath9k: fix buffer overrun for ar9287

[Kalle Valo]

Arnd Bergmann <a...@arndb.de> writes:

> Code that was added back in 2.6.38 has an obvious overflow
> when accessing a static array, and at the time it was added
> only a code comment was put in front of it as a reminder
> to have it reviewed properly.
>
> This has not happened, but gcc-6 now points to the specific
> overflow:
>
> drivers/net/wireless/ath/ath9k/eeprom.c: In function 
> 'ath9k_hw_get_gain_boundaries_pdadcs':
> drivers/net/wireless/ath/ath9k/eeprom.c:483:44: error: array subscript is 
> above array bounds [-Werror=array-bounds]
>  maxPwrT4[i] = data_9287[idxL].pwrPdg[i][4];
>~^~~
>
> It turns out that the correct array length exists in the local
> 'intercepts' variable of this function, so we can just use that
> instead of hardcoding '4', so this patch changes all three
> instances to use that variable. The other two instances were
> already correct, but it's more consistent this way.
>
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Fixes: 940cd2c12ebf ("ath9k_hw: merge the ar9287 version of 
> ath9k_hw_get_gain_boundaries_pdadcs")

Dave already applies this so I can skip this.

-- 
Kalle Valo

Re: AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

[Kalle Valo]

Pali Rohár <pali.ro...@gmail.com> writes:

> In linux-firmware repository [1] is missing AP firmware for TI wl1251 
> chip. There is only STA firmware wl1251-fw.bin which supports managed 
> and ad-hoc modes.
>
> For other TI wilink chips there are -ap.bin firmware files 
> (wl1271-fw-ap.bin and wl128x-fw-ap.bin) which support AP mode. But for 
> wl1251 firmware file with guessed name "wl1251-fw-ap.bin" is missing.
>
> Do you have any idea what happened with AP firmware for ti wilink4 
> wl1251 wifi chip? Or where can be found? Guys from TI, can you help?

It's a long time ago but IIRC wl1251 has not ever supported AP mode and
wl1271 was the first one to support it. But I might be wrong of course.

-- 
Kalle Valo

Re: [PATCH] mwifiex: advertise low priority scan feature

[Kalle Valo]

Wei-Ning Huang <wnhu...@chromium.org> writes:

> From: Amitkumar Karwar <akar...@marvell.com>
>
> Low priority scan handling code which delays or aborts scan
> operation based on Tx traffic is removed recently. The reason
> is firmware already takes care of it in our new feature scan
> channel gap. Hence we should advertise low priority scan
> support to cfg80211.
>
> This patch fixes a problem in which OBSS scan request from
> wpa_supplicant was being rejected by cfg80211.
>
> Signed-off-by: Wei-Ning Huang <wnhu...@chromium.org>

The From line states that this is written by Amitkumar but there's no
Signed-off-By line from him. I can't take this without that, please
resend.

(Wei-Ning's s-o-b line is correct, I just need also Amitkumar's line.)

-- 
Kalle Valo

Re: [PATCH] rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

[Kalle Valo]

Joe Perches <j...@perches.com> writes:

> On Thu, 2016-03-17 at 21:54 -0500, Larry Finger wrote:
>> On 03/17/2016 07:00 PM, Joe Perches wrote:
>> > Use a more common logging style.
>
> [ 300K+ quote without comment ]

Yeah, please try to avoid that. For example this makes the patchwork
page for the patch really hard to read:

https://patchwork.kernel.org/patch/8615131/

-- 
Kalle Valo

Re: pull-request: wireless-drivers-next 2016-03-14

[Kalle Valo]

David Miller <da...@davemloft.net> writes:

> From: Kalle Valo <kv...@codeaurora.org>
> Date: Mon, 14 Mar 2016 10:31:48 +0200
>
>> I know I'm late now that merge window was opened yesterday but here's
>> one more set of patches I would like to get to 4.6 still. There isn't
>> anything controversial so I hope this should be still safe to pull. The
>> patches have been in linux-next since Friday and I haven't seen any
>> reports about issues. But if you think it's too late just let me know
>> and I'll resubmit these for 4.7.
>> 
>> The most notable part here of course is rtl8xxxu with over 100 patches.
>> As the driver is new and under heavy development I think they are ok to
>> take still. Otherwise there are mostly fixes with an exception of adding
>> a new debugfs file to wl18xx.
>> 
>> Please let me know if you have any problems.
>
> Pulled, thanks.

Great, thanks a lot.

> I really like Jes's work and I wish you had integrated it several
> months ago, instead of sloshing him needlessly through a non-stop
> cycle of very nit-picky issues, just FYI.

I also like his work and I'm sorry for being too nit-picky. I have tried
to be extra careful with the patches I send to you, especially with new
drivers, and I guess I have been too pedantic. I'll try to lower the bar
to a more reasonable level.

But I actually started to wonder what you actually mean and checked the
dates of initial rtl8xxxu submission from patchwork:

2015-08-29 v1
2015-08-30 v2
2015-10-15 v3
2015-10-21 applied 26f1fad29ad9 to w-d-next for v4.4

Two months is quite long for a good driver like this but IIRC the
initial commit was pending wireless-drivers directory reorganisation,
and that just took too long on my side.

-- 
Kalle Valo

pull-request: wireless-drivers-next 2016-03-14

[Kalle Valo]

 used
  rtl8xxxu: Initial implementation of rtl8723bu_config_channel()
  rtl8xxxu: Initial rtl8723bu_init_bt() code
  rtl8xxxu: Remove unused variable
  rtl8xxxu: Improve 8723bu init code
  rtl8xxxu: Do not ignore wlan activity on 8723bu
  rtl8xxxu: Set the right type for ps tdma on 8723bu
  rtl8xxxu: Add rtl8723bu (nextgen) rx descriptor definition
  rtl8xxxu: Handle 8723bu style rx descriptors
  rtl8xxxu: Initial functionality to handle C2H events for 8723bu
  rtl8xxxu: Handle BT register writes and MP_OPER events
  rtl8xxxu: Issue BT_INFO command
  rtl8xxxu: Do not set REG_AFE_XTAL_CTRL on 8723bu
  rtl8xxxu: Implement 8723bu power on sequence
  rtl8xxxu: Setup LLT before downloading firmware
  rtl8xxxu: Additional fixes for 8723bu
  rtl8xxxu: Handle XTAL_K value in efuse specific location
  rtl8xxxu: Another 8723bu patch for rtl8xxxu_init_phy_bb()
  rtl8xxxu: Another 8723bu magic register set during init
  rtl8xxxu: Init H2C command register for 8723bu
  rtl8xxxu: 80M spur hack is for 8723au only
  rtl8xxxu: Do queue init in same order as 8723bu vendor driver
  rtl8xxxu: Do not set FPGA0_TX_INFO for 8723bu and use a larger PBP page 
size
  rtl8xxxu: Set RX boundary for 8723bu
  rtl8xxxu: Initialize burst parameters for 8723bu
  rtl8xxxu: Call device specific _config_channel()
  rtl8xxxu: 8723bu lock phy after RF init
  rtl8xxxu: Add REG_DWBCN1_CTRL_8723B define
  rtl8xxxu: Group chip quirks together
  rtl8xxxu: Setup RX aggregation
  rtl8xxxu: Add missing blank space in front of bracket
  rtl8xxxu: Implement init_statistics for 8723bu
  rtl8xxxu: RF_T_METER is different on the newer chips
  rtl8xxxu: Set WLAN_ACT_CONTROL per vendor driver setting
  rtl8xxxu: 8723bu: REG_BT_COEX_TABLE4 is only 8 bits
  rtl8xxxu: Use name for REG_RFE_BUFFER rather than hard coded value
  rtl8xxxu: Use REG_RFE_CTRL_ANTA_SRC rather than hard coded value
  rtl8xxxu: Setup coex table correctly (hopefully)
  rtl8xxxu: Do not use hard-wired RF enable settings for 8723bu
  rtl8xxxu: Correct struct rtl8723bu_efuse to list power bases correctly
  rtl8xxxu: Introduce set_tx_power() fileop and a new 8723b dummy derivative
  rtl8xxxu: Use size of source pointer when copying efuse data
  rtl8xxxu: Bump TX power arrays to handle larger channel groups
  rtl8xxxu: Parse efuse power indices for 8723bu
  rtl8xxxu: Set 8723bu TX power for CCK and OFDM rates
  rtl8xxxu: Set 8723bu MCS TX power
  rtl8xxxu: Set the correct thermal meter register for 8723bu
  rtl8xxxu: Add definition for 8723bu tx descriptor
  rtl8xxxu: Handle 40 byte TX descriptors for rtl8723bu
  rtl8xxxu: Do not unconditionally print debug info in 
rtl8723bu_handle_c2h()
  rtl8xxxu: Add additional tx descriptor bits for data word 0
  rtl8xxxu: Add more 40 byte TX desc bit definitions
  rtl8xxxu: Set the correct TX descriptor bits for agg and break on 8723b
  rtl8xxxu: Set sequence number correctly for 40 byte TX descriptors
  rtl8723au: Update TX descriptor words 4 and 5 definitions
  rtl8xxxu: TX RTS rate is word 4 for 8723a
  rtl8xxxu: Improve handling of txdesc32 vs txdesc40 handling
  rtl8xxxu: Do not parse RX descriptor info for C2H packets
  rtl8xxxu: Define 8723b H2C ramask command structure
  rtl8xxxu: Implement basic 8723b specific update_rate_mask() function
  rtl8xxxu: Report media status using the correct H2C command for 8723bu
  rtl8xxxu: Dump contents of unhandled C2H events
  rtl8xxxu: Process C2H RA_REPORT events for 8723bu
  rtl8xxxu: Pass RX rate to rx_parse_phystats and enable phystats for 
rtl8723bu
  rtl8xxxu: Remove unncessary semicolon
  rtl8xxxu: convert rtl8723bu_init_bt() into rtl8723b_enable_rf()
  rtl8xxxu: Use define for REG_PWR_DATA bits
  rtl8xxxu: Implement 8723bu specific disable_rf() function
  rtl8xxxu: Implement device specific power_off function
  rtl8xxxu: Flush FIFO before powering down devices
  rtl8xxxu: Print a warning if flushing the FIFO fails
  rtl8xxxu: Use correct 8051 reset function for 8723b parts
  rtl8xxxu: Temporarily disable 8192eu device init

Johannes Berg (1):
  iwlwifi: mvm: don't try to offload AES-CMAC in AP/IBSS modes

Kalle Valo (1):
  Merge tag 'iwlwifi-next-for-kalle-2016-03-09_2' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-next

Luca Coelho (1):
  iwlwifi: pcie: forbid RTPM on device removal

Matti Gottlieb (1):
  iwlwifi: mvm: ROC: cleanup time event info on FW failure

Sara Sharon (8):
  iwlwifi: pcie: refactor RXBs reclaiming code
  iwlwifi: pcie: set RB chunk size back to 64
  iwlwifi: refactor the code that reads the MAC address from the NVM
  iwlwifi: mvm: set the correct amsdu enum values
  iwlwifi: mvm: extend time event duration
  iwlwifi: mvm: turn off AMSDU bit in QoS control

Re: [PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

[Kalle Valo]

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:

> From: Jia-Ju Bai <baijiaju1...@163.com>
>
> The memory allocated by kzalloc in b43_bus_dev_ssb_init and
> b43_bus_dev_bcma_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove,
> b43_bcma_remove and error handling code of b43_bcma_probe.
>
> Thanks Michael for his suggestion.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com>
> Acked-by: Michael Büsch <m...@bues.ch>
> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk>

If no objections I'm planning to queue this to 4.6-rc2.

-- 
Kalle Valo

Re: libertas: fix an error code in probe

[Kalle Valo]

> We accidentally return success instead of a negative error code.
> 
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

pull-request: wireless-drivers-next 2016-03-09

[Kalle Valo]

Hi Dave,

here's a pull request for 4.6. I'm planning to send one more but I'm not
sure if it will make it in time, we'll see.

Here notable changes are refactoring in bcma to create a common flash
driver, brcmfmac platform data improvements in include/linux and
beginning of AHB bus support for ath10k along with device tree binding
update. More info in the signed tag below.

Oh, and I just noticed that weirdly my name appeared in author field on
one of Janusz' ath9k patches. But I didn't consider this bad enough to
rebase everything so I let it be. Sorry Janusz :)

commit b9a9693fd9aea43f50b107dfc8cbaea317f95a79
Author: Kalle Valo <janusz.dzied...@tieto.com>
Date:   Fri Nov 27 09:37:14 2015 +0100

ath9k: request NOA update when chanctx active

Please let me know if you have any problems.

Kalle

The following changes since commit 00a1f0a93dea3cf1c141df79bfd06e7c9ee54162:

  Merge branch 'reset_mac_header' (2016-03-04 22:45:14 -0500)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git 
tags/wireless-drivers-next-for-davem-2016-03-09

for you to fetch changes up to 836856e3bd61d0644e5178a2c1b51d90459e2788:

  wireless: cw1200: use __maybe_unused to hide pm functions_ (2016-03-08 
12:32:52 +0200)


wireless-drivers patches for 4.6

Major changes:

ath10k

* dt: add bindings for ipq4019 wifi block
* start adding support for qca4019 chip

ath9k

* add device ID for Toshiba WLM-20U2/GN-1080
* allow more than one interface on DFS channels

bcma

* move flash detection code to ChipCommon core driver

brcmfmac

* IPv6 Neighbor discovery offload
* driver settings that can be populated from different sources
* country code setting in firmware
* length checks to validate firmware events
* new way to determine device memory size needed for BCM4366
* various offloads during Wake on Wireless LAN (WoWLAN)
* full Management Frame Protection (MFP) support

iwlwifi

* add support for thermal device / cooling device
* improvements in scheduled scan without profiles
* new firmware support (-21.ucode)
* add MSIX support for 9000 devices
* enable MU-MIMO and take care of firmware restart
* add support for large SKBs in mvm to reach A-MSDU
* add support for filtering frames from a BA session
* start implementing the new Rx path for 9000 devices
* enable the new Radio Resource Management (RRM) nl80211 feature flag
* add a new module paramater to disable VHT
* build infrastructure for Dynamic Queue Allocation


Alexander Tsoy (1):
  ath9k_htc: add device ID for Toshiba WLM-20U2/GN-1080

Alexey Khoroshilov (1):
  at76c50x-usb: avoid double usb_put_dev() after downloading internal 
firmware in at76_probe()

Amitkumar Karwar (1):
  mwifiex: fix corner case association failure

Amitoj Kaur Chawla (1):
  mwifiex: Use to_delayed_work()

Andrei Otcheretianski (1):
  iwlwifi: add disable_11ac module param

Anilkumar Kolli (1):
  ath10k: reduce number of peers to support peer stats feature

Anthony Wong (1):
  rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

Anton Protopopov (1):
  ath10k: fix erroneous return value

Arend van Spriel (1):
  brcmfmac: change function name for brcmf_cfg80211_wait_vif_event_timeout()

Arnd Bergmann (2):
  ath9k: reduce stack usage in ar9003_aic_cal_post_process
  wireless: cw1200: use __maybe_unused to hide pm functions_

Ashok Raj Nagarajan (2):
  ath10k: fix pktlog in QCA99X0
  ath10k: add hw_rev to trace events to support pktlog

Avri Altman (2):
  iwlwifi: mvm: forbid U-APSD for P2P Client if the firmware doesn't 
support it
  iwlwifi: mvm: Send power command on BSS_CHANGED_BEACON_INFO if needed

Beni Lev (1):
  iwlwifi: mvm: Set global RRM capability

Bruno Randolf (3):
  rtl8xxxu: Enable monitor mode by handling filters
  rtl8xxxu: Document REG_RXFLTMAP registers
  rtl8xxxu: Enable data frame reception in rtl8xxxu_start

Chaya Rachel Ivgi (4):
  iwlwifi: mvm: add CT-KILL notification
  iwlwifi: mvm: add registration to thermal zone
  iwlwifi: mvm: add registration to cooling device
  iwlwifi: mvm: update ucode status before stopping device

Christian Lamparter (1):
  carl9170: import 1.9.9 firmware headers

Colin Ian King (2):
  rtlwifi: pass struct rtl_stats by reference as it is more efficient
  mt7601u: do not free dma_buf when ivp allocation fails

Dan Carpenter (1):
  mwifiex: fix an indenting mistake

Emmanuel Grumbach (15):
  Merge tag 'mac80211-next-for-davem-2016-02-26' into next2
  Merge tag 'iwlwifi-for-kalle-2016-02-15' into HEAD
  iwlwifi: mvm: bump firmware API to 21
  iwlwifi: pcie: aggregate Flow Handler configuration writes
  iwlwifi: pcie: fix identation in trans.c
  iwlwifi: mvm: send large SKBs to the transport
  iwlwifi: mvm: add Tx 

Re: [RFC 5/7] wlcore: avoid fragile snprintf use

[Kalle Valo]

Rasmus Villemoes <li...@rasmusvillemoes.dk> writes:

> Appending to a buffer like this is not guaranteed to work (passing
> overlapping src and dst buffers to snprintf is undefined
> behaviour). The standard and safe idiom is to keep track of the
> current string length.
>
> Signed-off-by: Rasmus Villemoes <li...@rasmusvillemoes.dk>

Should I take this or what's the plan?

-- 
Kalle Valo

Re: [10/14] wireless: cw1200: use __maybe_unused to hide pm functions_

[Kalle Valo]

> The cw1200 uses #ifdef to check for CONFIG_PM, but then
> uses SIMPLE_DEV_PM_OPS, which leaves the references out when
> CONFIG_PM_SLEEP is not defined, so we get a warning with
> PM=y && PM_SLEEP=n:
> 
> drivers/net/wireless/st/cw1200/cw1200_spi.c:450:12: error: 
> 'cw1200_spi_suspend' defined but not used [-Werror=unused-function]
> 
> This removes the incorrect #ifdef and instead uses a __maybe_unused
> annotation to let the compiler know it can silently drop
> the function definition.
> 
> For the DEV_PM_OPS definition, we can use an IS_ENABLED() check
> to avoid defining the structure when CONFIG_PM is not set without
> the #ifdef.
> 
> Signed-off-by: Arnd Bergmann <a...@arndb.de>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [V3] mt7601u: do not free dma_buf when ivp allocation fails

[Kalle Valo]

> From: Colin Ian King <colin.k...@canonical.com>
> 
> If the allocation of ivp fails the error handling attempts to
> free an uninitialized dma_buf; this data structure just contains
> garbage on the stack, so the freeing will cause issues when the
> urb, buf and dma fields are free'd. Fix this by not free'ing the
> dma_buf if the ivp allocation fails.
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: rt2x00: add new rt2800usb device Buffalo WLI-UC-G450

[Kalle Valo]

> Add USB ID 0411:01fd for Buffalo WLI-UC-G450 wireless adapter,
> RT chipset 3593
> 
> Signed-off-by: Anthony Wong <anthony.w...@ubuntu.com>
> Cc: sta...@vger.kernel.org
> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [V2] rtlwifi: pass struct rtl_stats by reference as it is moreefficient

[Kalle Valo]

> From: Colin Ian King <colin.k...@canonical.com>
> 
> passing rtl_stats by value is inefficient; the structure is over 300
> bytes in size and generally just one field (packet_report_type)
> is being accessed, so the pass by value is a relatively large overhead.
> This change just affects just the rx_command_packet calls.
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> Acked-by: Larry Finger <larry.fin...@lwfinger.net>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: mwifiex: Use to_delayed_work()

[Kalle Valo]

> Introduce the use of to_delayed_work() helper function instead of open
> coding it with container_of()
> 
> A simplified version of the Coccinelle semantic patch used to make
> this change is:
> 
> //
> @@
> expression a;
> symbol work;
> @@
> - container_of(a, struct delayed_work, work)
> + to_delayed_work(a)
> //
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

pull-request: wireless-drivers 2016-03-04

[Kalle Valo]

Hi Dave,

three more fixes I would like to get to 4.5 still. It's getting late but
I think these are still justified and these have been in linux-next
almost a week. But if you think otherwise please let me know and I'll
pull these to wireless-drivers-next instead.

Kalle

The following changes since commit c699404db182836498bd9d9a36ef044de2cab4fd:

  Merge tag 'iwlwifi-for-kalle-2016-02-15' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-02-16 17:58:30 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 
tags/wireless-drivers-for-davem-2016-03-04

for you to fetch changes up to 10da848f67a7e7152bf7cbe332e4c92d71a990d2:

  ssb: host_soc depends on sprom (2016-02-26 12:47:32 +0200)


wireless-drivers fixes for 4.5

iwlwifi

* free firmware paging memory when the module is unloaded or device removed
* fix pending frames counter to fix an issue when removing stations

ssb

* fix a build problem related to ssb_fill_sprom_with_fallback()


Arnd Bergmann (1):
  ssb: host_soc depends on sprom

Kalle Valo (1):
  Merge tag 'iwlwifi-for-kalle-2016-02-25' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-fixes

Liad Kaufman (1):
  iwlwifi: mvm: inc pending frames counter also when txing non-sta

Matti Gottlieb (1):
  iwlwifi: mvm: Fix paging memory leak

 drivers/net/wireless/intel/iwlwifi/mvm/fw.c  |4 +++-
 drivers/net/wireless/intel/iwlwifi/mvm/mvm.h |3 +++
 drivers/net/wireless/intel/iwlwifi/mvm/ops.c |2 ++
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c  |9 +
 drivers/ssb/Kconfig  |1 +
 5 files changed, 18 insertions(+), 1 deletion(-)

Re: pull-request: wireless-drivers 2016-02-18

[Kalle Valo]

(Adding Larry)

Geert Uytterhoeven <ge...@linux-m68k.org> writes:

> On Thu, Feb 18, 2016 at 4:28 PM, Kalle Valo <kv...@codeaurora.org> wrote:
>
>> rtlwifi
>>
>> * fix broken VHT (802.11ac) support, reported by Linus
>
> That's commit d76d65fd26951498144029c24852c4d54ee512d9
>
> drivers/net/wireless/realtek/rtlwifi/rc.c: In function
> ‘_rtl_rc_rate_set_series’:
> drivers/net/wireless/realtek/rtlwifi/rc.c:144: warning: comparison is
> always false due to limited range of data type
>
> if (sta && sta->vht_cap.vht_supported &&
> (wireless_mode == WIRELESS_MODE_AC_5G ||
>  wireless_mode == WIRELESS_MODE_AC_24G ||
>  wireless_mode == WIRELESS_MODE_AC_ONLY))
> rate->flags |= IEEE80211_TX_RC_VHT_MCS;
>
> u8 wireless_mode = 0;
>
> enum wireless_mode {
> ...
> WIRELESS_MODE_AC_ONLY = 0x100,
>
> How is that supposed to work?

I have no idea what could be the difference, for example, between AC_5G
and AC_ONLY. Maybe AC_ONLY mode is not really used in normal setups and
that's why the bug doesn't break anything? Larry, do you know?

Anyway, Larry has a patch for this but I'm planning to send it to 4.6 as
I didn't think it as that urgent:

rtlwifi: Fix size of wireless mode variable

https://patchwork.kernel.org/patch/8425191/

-- 
Kalle Valo

Re: [PATCH RFC/RFT 1/2] ath9k: rename struct ath_txq to struct ath_hwq

[Kalle Valo]

Tim Shepard <s...@alum.mit.edu> writes:

> Also use hwq instead of txq to refer to it throughout ath9k/*.  This
> is prep work for using mac80211's new intermediate queues, which are
> called txq, and it would be too confusing if both are called txq.

You should add Signed-off-by to both patches in case someone else wants
to work with these.

-- 
Kalle Valo

Re: [PATCH] b43: fix memory leak

[Kalle Valo]

Michael Büsch <m...@bues.ch> writes:

> On Thu, 18 Feb 2016 18:04:36 +0530
> Sudip Mukherjee <sudipm.mukher...@gmail.com> wrote:
>
>> From: Sudip Mukherjee <su...@vectorindia.org>
>> 
>> On error we jumped to the label bcma_out and returned the error code but
>> we missed freeing dev.
>> 
>> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
>> ---
>>  drivers/net/wireless/broadcom/b43/main.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/net/wireless/broadcom/b43/main.c 
>> b/drivers/net/wireless/broadcom/b43/main.c
>> index c279211..78f670a 100644
>> --- a/drivers/net/wireless/broadcom/b43/main.c
>> +++ b/drivers/net/wireless/broadcom/b43/main.c
>> @@ -5671,6 +5671,7 @@ static int b43_bcma_probe(struct bcma_device *core)
>>  wl = b43_wireless_init(dev);
>>  if (IS_ERR(wl)) {
>>  err = PTR_ERR(wl);
>> +kfree(dev);
>>  goto bcma_out;
>>  }
>>  
>
> We recently had a patch that fixes this, among more leaks. Subject:
> [PATCH v2 resend] b43: Fix memory leaks in b43_bus_dev_ssb_init and
> b43_bus_dev_bcma_init
>
> Please test that patch instead, so we can finally apply it.
>
> It needs to be tested on both ssb and bcma. Come on. This isn't too
> hard. :) Please somebody with any hardware test it. (I currently don't
> have any b43 hardware)

And the patch can be downloaded from patchwork:

https://patchwork.kernel.org/patch/8049041/

-- 
Kalle Valo

pull-request: wireless-drivers 2016-02-18

[Kalle Valo]

Hi Dave,

I have some important fixes I would like to get 4.5 still, more info in
the signed tag. Please let me know if you have problems.

Kalle

The following changes since commit f9ead9beef3f44be0db4b542a8c2ce698fb1530e:

  Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-01-27 14:19:18 +0200)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 
tags/wireless-drivers-for-davem-2016-02-18

for you to fetch changes up to c699404db182836498bd9d9a36ef044de2cab4fd:

  Merge tag 'iwlwifi-for-kalle-2016-02-15' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-02-16 17:58:30 +0200)



rtlwifi

* fix broken VHT (802.11ac) support, reported by Linus

wlcore

* fix firmware initialisation regression on wl1271

iwlwifi

* fix a race that users reported when we try to load the firmware
  and the hardware rfkill interrupt triggers at the same time
* fix a very visible bug in scheduled scan: the firmware
  doesn't support scheduled scan with no profile configured and
  the supplicant sometimes requests such scheduled scans
* build system fix to be able to link iwlwifi statically into kernel
* firmware name update for 8265
* typo fix in return value


Anton Protopopov (1):
  iwlwifi: pcie: fix erroneous return value

Emil Goode (1):
  wlcore: Fix regression in wlcore_set_partition()

Emmanuel Grumbach (2):
  iwlwifi: dvm: remove a wrong dependency on m
  iwlwifi: pcie: fix RF-Kill vs. firmware load race

Kalle Valo (1):
  Merge tag 'iwlwifi-for-kalle-2016-02-15' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-fixes

Larry Finger (1):
  rtlwifi: fix broken VHT support

Luca Coelho (1):
  iwlwifi: mvm: don't allow sched scans without matches to be started

Oren Givon (1):
  iwlwifi: fix name of ucode loaded for 8265 series

 drivers/net/wireless/intel/iwlwifi/Kconfig |1 -
 drivers/net/wireless/intel/iwlwifi/iwl-8000.c  |   42 -
 drivers/net/wireless/intel/iwlwifi/iwl-drv.c   |6 +-
 drivers/net/wireless/intel/iwlwifi/mvm/scan.c  |4 +
 drivers/net/wireless/intel/iwlwifi/pcie/internal.h |9 +
 drivers/net/wireless/intel/iwlwifi/pcie/rx.c   |8 +-
 drivers/net/wireless/intel/iwlwifi/pcie/trans.c|  188 
 drivers/net/wireless/realtek/rtlwifi/rc.c  |5 +
 drivers/net/wireless/ti/wlcore/io.c|8 +-
 drivers/net/wireless/ti/wlcore/io.h|4 +-
 10 files changed, 175 insertions(+), 100 deletions(-)

-- 
Kalle Valo

Re: wlcore: Fix regression in wlcore_set_partition()

[Kalle Valo]

Ross Green <rgker...@gmail.com> writes:

> On Fri, Feb 12, 2016 at 8:45 PM, Kalle Valo <kv...@codeaurora.org> wrote:
>>
>>> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
>>> regression causing the wlcore to time out and go into recovery. Reverting 
>>> the
>>> changes regarding write of the last partition size brings the module back to
>>> it's functional state.
>>>
>>> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
>>> Reported-by: Ross Green <rgker...@gmail.com>
>>> Signed-off-by: Emil Goode <emil@goode.io>
>>> [kv...@codeaurora.org: improved commit log]
>>
>> Thanks, applied to wireless-drivers.git.
>>
>> Kalle Valo
>
> I just tested linux-4.5-rc4 it appears the above fix missed the release for 
> rc4!
> So the behaviour of firmware reset being called after the access of
> the last partition timesout.
>
> Again tested patch with the new release - 4.5-rc4 and found everything
> to work as expected again.
>
> So Hopefully for rc5 - Please!

It takes some time to get patches into Linus' tree. And being in a
conference and then getting sick is not really helping. I'm not sure if
this patch makes to rc5 on time, but I'll try.

-- 
Kalle Valo

Re: wlcore: Fix regression in wlcore_set_partition()

[Kalle Valo]

> The commit 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") introduced a
> regression causing the wlcore to time out and go into recovery. Reverting the
> changes regarding write of the last partition size brings the module back to
> it's functional state.
> 
> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
> Reported-by: Ross Green <rgker...@gmail.com>
> Signed-off-by: Emil Goode <emil@goode.io>
> [kv...@codeaurora.org: improved commit log]

Thanks, applied to wireless-drivers.git.

Kalle Valo

pull-request: wireless-drivers-next 2016-02-12

[Kalle Valo]

Hi Dave,

here's first pull request for 4.6. We have a new kconfig option
CONFIG_IWLWIFI_PCIE_RTPM for iwlwifi runtime power management. wl12xxx
got device tree support for the spi bus and added a bindings document
for it. More info in the tag below.

Please let me know if you have any problems.

Kalle

The following changes since commit 7a26019fdecdb45ff784ae4e3b7e0cc9045100ca:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-01-15 
18:36:23 -0500)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git 
tags/wireless-drivers-next-for-davem-2016-02-12

for you to fetch changes up to 11e70824e75f2cfbad9ae066ca5b29e1c361f19e:

  mwifiex: firmware dump support for w8997 chipset (2016-02-07 09:15:44 +0200)


Major changes:

wl12xx

* add device tree support for SPI

mwifiex

* add debugfs file to read chip information
* add MSIx support for newer pcie chipsets (8997 onwards)
* add schedule scan support
* add WoWLAN net-detect support
* firmware dump support for w8997 chipset

iwlwifi

* continue the work on multiple Rx queues
* add support for beacon storing used in low power states
* use the regular firmware image of WoWLAN
* fix 8000 devices for Big Endian machines
* more firmware debug hooks
* add support for P2P Client snoozing
* make the beacon filtering for AP mode configurable
* fix transmit queues overflow with LSO

libertas

* add support for setting power save via cfg80211


Amitkumar Karwar (2):
  mwifiex: use SYNC flag for canceling host sleep
  mwifiex: increase the priority of firmware dump message

Andreas Kemnade (6):
  libertas: fix pointer bugs for PS_MODE commands
  libertas: check whether bus can do more than polling
  libertas: do not confirm sleep if commands are pending
  libertas: go back to ps mode without commands pending
  libertas: fix ps-mode related removal problems
  libertas: add an cfg80211 interface for powersaving

Andrei Otcheretianski (1):
  iwlwifi: mvm: allow to disable beacon filtering for AP/GO interface

Andrzej Hajda (1):
  wlcore: fix error handling in wlcore_event_fw_logger

Arnd Bergmann (1):
  hostap: avoid uninitialized variable use in hfa384x_get_rid

Avri Altman (3):
  iwlwifi: mvm: Add P2P client snoozing
  iwlwifi: mvm: Remove bf_vif from iwl_power_vifs
  iwlwifi: mvm: Remove iwl_mvm_update_beacon_abort

Chaya Rachel Ivgi (1):
  iwlwifi: mvm: add support for negative temperatures

Dan Carpenter (1):
  mwifiex: fix a reversed condition

Emmanuel Grumbach (2):
  iwlwifi: pcie: buffer packets to avoid overflowing Tx queues
  iwlwifi: various comments and code cleanups

Ganapathi Bhat (1):
  mwifiex: add RSSI support for net-detect

Golan Ben-Ami (2):
  iwlwifi: mvm: add trigger for firmware dump upon TX response status
  iwlwifi: mvm: make collecting fw debug data optional

Gregory Greenman (1):
  iwlwifi: mvm: rs: fix TPC action decision algorithm

Hubert Tarasiuk (1):
  iwlwifi: dvm: handle zero brightness for wifi LED

Johannes Berg (5):
  iwlwifi: mvm: remove shadowing variable
  iwlwifi: mvm: fix debugfs signedness warning
  iwlwifi: mvm: track low-latency sources separately
  iwlwifi: mvm: support setting minimum quota from debugfs
  iwlwifi: treat iwl_parse_nvm_data() MAC addr as little endian

Kalle Valo (1):
  Merge tag 'iwlwifi-next-for-kalle-2016-01-31_2' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-next

Luca Coelho (1):
  iwlwifi: pcie: add initial RTPM support for PCI

Luciano Coelho (1):
  iwlwifi: pcie: add RTPM support when wifi is enabled

Matti Gottlieb (1):
  iwlwifi: mvm: Do not switch to D3 image on suspend

Max Stepanov (1):
  iwlwifi: mvm: add debug print if scan config is ignored

Nachiket Kukade (1):
  mwifiex: fix bandwidth display problem

Paul Mcquade (3):
  net: wireless: rt2x00: Fixed Spacing issues
  net: wireless: rt2x00: Space issue
  net: wireless: rt2x00: Space Required

Rafał Miłecki (15):
  bcma: support identifying MX25L25635F serial flash
  bcma: identify bus cores (devices) found on BCM47189
  bcma: support chipsets with PMU and GCI cores (devices)
  bcma: use _PMU_ in all names of PMU registers
  bcma: support PMU present as separated bus core
  brcmfmac: fix setting primary channel for 80 MHz width
  bcma: init serial console directly from ChipCommon code
  bcma: add support for BCM47094
  bcma: claim only 14e4:4365 PCI Dell card with SoftMAC BCM43142
  brcmfmac: analyze descriptors of current component only
  brcmfmac: allow storing PMU core without wrapper address
  brcmfmac: read extended capabilities of ChipCommon core
  brcmfmac: access PMU registers using standalone PMU core if available

Re: [PATCH] wlcore: Fix regression in wlcore_set_partition()

[Kalle Valo]

Emil Goode <emil@goode.io> writes:

> The below commit introduced a regression causing the wlcore
> to time out and go into recovery.
>
> commit 3719c17e1816695f415dd3b4ddcb679f7dc617c8
> ("wlcore/wl18xx: fw logger over sdio")
>
> Reverting the changes regarding write of the last partition size
> brings the module back to it's functional state.
>
> Reported-by: Ross Green <rgker...@gmail.com>
> Signed-off-by: Emil Goode <emil@goode.io>

A proper "Fixes:" line is good to have, but I can add it.

I'm planning to queue this to 4.5.

-- 
Kalle Valo

Re: [2/3] net: wireless: rt2x00: Pointer issue

[Kalle Valo]

> Code Style: pointer is declared wrong
> 
> Signed-off-by: Paul McQuade 
> Acked-by: Helmut Schaa 

This patch didn't apply, so please resend.

Kalle

Re: [1/3] net: wireless: rt2x00: Space issue

[Kalle Valo]

> Removed empty spaces before/after parenthesis
> 
> Signed-off-by: Paul McQuade <paulmcq...@gmail.com>
> Acked-by: Helmut Schaa <helmut.sc...@googlemail.com>

Thanks, 2 patches applied to wireless-drivers-next.git:

b2cc2dd8ebb8 net: wireless: rt2x00: Space issue
5b451715e94d net: wireless: rt2x00: Space Required

1 patches skipped:

[2/3] net: wireless: rt2x00: Pointer issue

Kalle Valo

Re: net: wireless: rt2x00: Fixed Spacing issues

[Kalle Valo]

> Removed empty spaces before/after parenthesis
> 
> Signed-off-by: Paul McQuade <paulmcq...@gmail.com>
> Acked-by: Helmut Schaa <helmut.sc...@googlemail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [v2] hostap: avoid uninitialized variable use in hfa384x_get_rid

[Kalle Valo]

> The driver reads a value from hfa384x_from_bap(), which may fail,
> and then assigns the value to a local variable. gcc detects that
> in in the failure case, the 'rlen' variable now contains
> uninitialized data:
> 
> In file included from 
> ../drivers/net/wireless/intersil/hostap/hostap_pci.c:220:0:
> drivers/net/wireless/intersil/hostap/hostap_hw.c: In function 
> 'hfa384x_get_rid':
> drivers/net/wireless/intersil/hostap/hostap_hw.c:842:5: warning: 'rec' may be 
> used uninitialized in this function [-Wmaybe-uninitialized]
>   if (le16_to_cpu(rec.len) == 0) {
> 
> This restructures the function as suggested by Russell King, to
> make it more readable and get more reliable error handling, by
> handling each failure mode using a goto.
> 
> Signed-off-by: Arnd Bergmann <a...@arndb.de>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: brcmfmac: sdio: Increase the default timeouts a bit

[Kalle Valo]

> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems
> the card responds very quickly most of the time, unfortunately during
> initialisation it sometimes seems to take just a bit over 2 seconds to
> respond.
> 
> This results intialization failing with message like:
>   brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52
>   brcmf_bus_start: failed: -52
>   brcmf_sdio_firmware_callback: dongle is not responding
> 
> Increasing the timeout to allow for a bit more headroom allows the
> card to initialize reliably.
> 
> A quick search online after diagnosing/fixing this showed that Google
> has a similar patch in their ChromeOS tree, so this doesn't seem
> specific to the board I'm using.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.sim...@collabora.co.uk>
> Reviewed-by: Julian Calaby <julian.cal...@gmail.com>
> Acked-by: Arend van Spriel <ar...@broadcom.com>
> Reviewed-by: Douglas Anderson <diand...@chromium.org>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [PATCH] mac80211: fix memory leak

[Kalle Valo]

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:

> On Mon, Feb 01, 2016 at 11:03:35AM +1100, Julian Calaby wrote:
>> Hi Sudip,
>> 
>> On Fri, Jan 29, 2016 at 8:49 PM, Sudip Mukherjee
>> <sudipm.mukher...@gmail.com> wrote:
>> > On error we jumped to the error label and returned the error code but we
>> > missed releasing sinfo.
>> >
>> > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
>> 
>> Should the From: and Signed-off-by: email addresses be the same?
>
> I think 2 years back I had a long discussion with Greg about this and
> since then I al submitting patches like this. A small summayg of the
> problem from that discussion:
>
> "we have strict DMARC check for the corporate mail server. DMARC =
> domain based message authentication.
> So the mail i sent reached all the list subscriber from a different
> server than our designated server, and as a result it is marked as spam
> in many places and I have already received a few complaints regarding
> that."

You can add a separate "From:" line to the beginning of the commit log
and git will use it then commiting the patch. I didn't find any
documention but it's easy to do and should solve this.

-- 
Kalle Valo

pull-request: wireless-drivers 2016-01-29

[Kalle Valo]

Hi Dave,

few fixes for 4.5. Nothing really standing out, see the tag for
more info. Please let me know if you have any problems.

Kalle

The following changes since commit a200dcb34693084e56496960d855afdeaaf9578f:

  Merge tag 'for_linus' of 
git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost (2016-01-18 16:44:24 
-0800)

are available in the git repository at:


  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 
tags/wireless-drivers-for-davem-2016-01-29

for you to fetch changes up to f9ead9beef3f44be0db4b542a8c2ce698fb1530e:

  Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2016-01-27 14:19:18 +0200)



iwlwifi

* Fix support for 3168 device:
  * NVM version
  * firmware file name
  * device IDs
* Fix a compilation warning in dvm calibration code
* Fix the TPC (reduced Tx Power) code. This fixes performance issues
* Add device IDs for 8265

rtx2x00

* fix monitor mode regression dating back to 4.1

brcmfmac

* fix sdio initialisation related crash

rtlwifi

* rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

ath9k

* ignore eeprom magic mismatch on flash based devices


Arnd Bergmann (1):
  ssb: mark ssb_bus_register as __maybe_unused

Eli Cooper (1):
  rt2x00: fix monitor mode regression

Felix Fietkau (2):
  brcmfmac: add missing include
  ath9k_hw: ignore eeprom magic mismatch on flash based devices

Gregory Greenman (1):
  iwlwifi: mvm: rs: fix TPC statistics handling

Hante Meuleman (1):
  brcmfmac: fix sdio sg table alloc crash

Kalle Valo (2):
  Merge ath-current from ath.git
  Merge tag 'iwlwifi-for-kalle-2016-01-26_2' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-fixes

Larry Finger (1):
  rtlwifi: rtl8821ae: Fix 5G failure when EEPROM is incorrectly encoded

Michael Buesch (1):
  ssb: Set linux-wireless as MAINTAINERS list

Oren Givon (3):
  iwlwifi: add new 3168 series devices support
  iwlwifi: add device ID for 8265
  iwlwifi: update support for 3168 series firmware and NVM

 MAINTAINERS|2 +-
 drivers/net/wireless/ath/ath9k/eeprom.c|   12 ++--
 .../wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c  |   40 ---
 .../wireless/broadcom/brcm80211/brcmfmac/common.c  |1 +
 .../wireless/broadcom/brcm80211/brcmfmac/sdio.c|5 ++
 .../wireless/broadcom/brcm80211/brcmfmac/sdio.h|1 +
 drivers/net/wireless/intel/iwlwifi/iwl-7000.c  |   23 --
 drivers/net/wireless/intel/iwlwifi/mvm/fw-api-tx.h |6 +-
 drivers/net/wireless/intel/iwlwifi/mvm/rs.c|   74 +---
 drivers/net/wireless/intel/iwlwifi/mvm/tx.c|5 +-
 drivers/net/wireless/intel/iwlwifi/pcie/drv.c  |4 ++
 drivers/net/wireless/ralink/rt2x00/rt2400pci.c |4 +-
 drivers/net/wireless/ralink/rt2x00/rt2500pci.c |4 +-
 drivers/net/wireless/ralink/rt2x00/rt2500usb.c |4 +-
 drivers/net/wireless/ralink/rt2x00/rt2800lib.c |3 +-
 drivers/net/wireless/ralink/rt2x00/rt2x00.h|1 +
 drivers/net/wireless/ralink/rt2x00/rt2x00config.c  |5 ++
 drivers/net/wireless/ralink/rt2x00/rt2x00mac.c |5 --
 drivers/net/wireless/ralink/rt2x00/rt61pci.c   |4 +-
 drivers/net/wireless/ralink/rt2x00/rt73usb.c   |4 +-
 drivers/net/wireless/realtek/rtlwifi/regd.c|2 +-
 drivers/ssb/main.c |7 +-
 22 files changed, 136 insertions(+), 80 deletions(-)

-- 
Kalle Valo

Re: wlcore: fix error handling in wlcore_event_fw_logger

[Kalle Valo]

> wlcore_read/wlcore_write can return negative values so it should
> be assigned to signed variable.
> 
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2120705
> 
> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

Re: [PATCH] ath9k: Drop useless const on chanctx_event_delta() return type

[Kalle Valo]

Geert Uytterhoeven <ge...@linux-m68k.org> writes:

> drivers/net/wireless/ath/ath9k/channel.c:230: warning: type qualifiers 
> ignored on function return type
>
> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>

Applied to ath.git, thanks.

-- 
Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

[Kalle Valo]

Pali Rohár <pali.ro...@gmail.com> writes:

>> >> > Right, bt-coex is not for debugging purpose, but for normal usage, when
>> >> > user want to use together bluetooth and wifi or just one of those.
>> >> 
>> >> I think most of other drivers have a debugfs interface for btcoex, I
>> >> guess mostly for testing purposes. But this really should be added to
>> >> cfg80211.
>> >
>> > All other TI wireless drivers have "bt_coex_state" sysfs node.
>> 
>> Then that's a mistake, they shouldn't have that.
>
> But it is there, wl1251 is also TI wireless driver and for last two
> years there is no interface to deal with this problem...
>
> So as other drivers do, I'm proposing solution which fix bt coex also
> for wl1251 driver need on Nokia N900.

Even if the wlcore sysfs interface fell through the cracks it's no
excuse to add more private interfaces to wireless drivers. We have
cfg80211 and all generic interfaces, like btcoex control, should go
through that subsystem. That way all drivers can share a common
interface and everyone are happy.

What I suggest is that you add this yourself to cfg80211 and mac80211.
It's not that hard and I think you could use NL80211_CMD_SET_POWER_SAVE
as an example.

-- 
Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

[Kalle Valo]

Pali Rohár <pali.ro...@gmail.com> writes:

> Port the bt_coex_mode sysfs interface from wl1251 driver version included
> in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
> This enables userspace applications to set one of the modes
> WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
> The default mode is WL1251_BT_COEX_OFF.
> It should be noted that this driver always enabled bt-coexistence before
> and enabled bt-coexistence directly affects the receiving performance,
> rendering it unusable in some low-signal situations. Especially monitor
> mode is affected very badly with bt-coexistence enabled.
>
> Signed-off-by: David Gnedt <david.gn...@davizone.at>
> Signed-off-by: Pali Rohár <pali.ro...@gmail.com>
> ---
> I'm resending this patch for review again as after two years there is no
> nl80211 interface for bt coex and wl1251 on Nokia N900 needs it. Once
> there will be common interface for bt coex I can rewrite my patches, but
> I do not want to wait another 2 years...

It doesn't work like that. Wireless drivers cannot have custom
interfaces via sysfs, all configuration has to go through cfg80211.
Instead of waiting two years you could have added it yourself.

-- 
Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

[Kalle Valo]

Pali Rohár <pali.ro...@gmail.com> writes:

> On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
>> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
>> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
>> > >Port the bt_coex_mode sysfs interface from wl1251 driver version included
>> > >in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
>> > >This enables userspace applications to set one of the modes
>> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
>> > >The default mode is WL1251_BT_COEX_OFF.
>> > >It should be noted that this driver always enabled bt-coexistence before
>> > >and enabled bt-coexistence directly affects the receiving performance,
>> > >rendering it unusable in some low-signal situations. Especially monitor
>> > >mode is affected very badly with bt-coexistence enabled.
>> > 
>> > So what user-space process will be using this interface. Did you consider
>> > adding debugfs interface? In case of monitor mode you could consider
>> > disabling bt-coex from within the driver itself.
>> 
>> This aint no debugging feature.
>
> Right, bt-coex is not for debugging purpose, but for normal usage, when
> user want to use together bluetooth and wifi or just one of those.

I think most of other drivers have a debugfs interface for btcoex, I
guess mostly for testing purposes. But this really should be added to
cfg80211.

-- 
Kalle Valo

Re: [PATCH v2] wl1251: add sysfs interface for bluetooth coexistence mode configuration

[Kalle Valo]

Pali Rohár <pali.ro...@gmail.com> writes:

> On Thursday 21 January 2016 15:48:14 Kalle Valo wrote:
>> Pali Rohár <pali.ro...@gmail.com> writes:
>> 
>> > On Thursday 14 January 2016 10:16:54 Pavel Machek wrote:
>> >> On Wed 2016-01-13 23:32:47, Arend van Spriel wrote:
>> >> > On 12/26/2015 12:45 PM, Pali Rohár wrote:
>> >> > >Port the bt_coex_mode sysfs interface from wl1251 driver version 
>> >> > >included
>> >> > >in the Maemo Fremantle kernel to allow bt-coexistence mode 
>> >> > >configuration.
>> >> > >This enables userspace applications to set one of the modes
>> >> > >WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
>> >> > >The default mode is WL1251_BT_COEX_OFF.
>> >> > >It should be noted that this driver always enabled bt-coexistence 
>> >> > >before
>> >> > >and enabled bt-coexistence directly affects the receiving performance,
>> >> > >rendering it unusable in some low-signal situations. Especially monitor
>> >> > >mode is affected very badly with bt-coexistence enabled.
>> >> > 
>> >> > So what user-space process will be using this interface. Did you 
>> >> > consider
>> >> > adding debugfs interface? In case of monitor mode you could consider
>> >> > disabling bt-coex from within the driver itself.
>> >> 
>> >> This aint no debugging feature.
>> >
>> > Right, bt-coex is not for debugging purpose, but for normal usage, when
>> > user want to use together bluetooth and wifi or just one of those.
>> 
>> I think most of other drivers have a debugfs interface for btcoex, I
>> guess mostly for testing purposes. But this really should be added to
>> cfg80211.
>
> All other TI wireless drivers have "bt_coex_state" sysfs node.

Then that's a mistake, they shouldn't have that.

-- 
Kalle Valo

Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

[Kalle Valo]

Julia Lawall <julia.law...@lip6.fr> writes:

> On Sat, 2 Jan 2016, SF Markus Elfring wrote:
>
>> >> Move the jump label directly before the desired log statement
>> >> so that the variable "err" will not be checked once more
>> >> after it was determined that a function call failed.
>> >> Use the identifier "report_failure" instead of the label "err".
>> > 
>> >Why?
>> 
>> I suggest to reconsider the places with which such a jump label
>> is connected.
>> 
>> 
>> > The code was smart enough
>> 
>> Which action should really be performed after a failure was detected
>> and handled a bit already?
>> 
>> * Another condition check
>> 
>> * Just additional error logging
>> 
>> 
>> > and you're making it uglier that it needs to be.
>> 
>> I assume that a software development taste can evolve, can't it?
>
> So far, you have gotten several down votes for this kind of change, and no 
> enthusiasm.
>
> Admittedly, this is a trivial case, because there are no local variables, 
> but do you actually know the semantics in C of a jump into a block?  And 
> if you do know, do you think that this semantics is common knowledge?  And 
> do you really think that introducing poorly understandable code is really 
> worth saving an if test of a single variable on a non-critical path?
>
> Most of the kernel code is not performance critical at the level of a 
> single if test.  So the goal should be for the code to be easy to 
> understand and robust to change.  The code that is performance critical, 
> you should probably not touch, ever.  The people who wrote it knew what 
> was important and what was not.

Very well said! Only optimise something you can measure.

I'm dropping this patch.

-- 
Kalle Valo

Re: [PATCH] net: wireless: rt2x00: Fixed Spacing issues

[Kalle Valo]

Helmut Schaa <helmut.sc...@googlemail.com> writes:

> On Thu, Jan 21, 2016 at 5:56 PM, Helmut Schaa
> <helmut.sc...@googlemail.com> wrote:
>> On Sat, Oct 17, 2015 at 10:04 PM, Paul McQuade <paulmcq...@gmail.com> wrote:
>>> Removed empty spaces before/after parenthesis
>>>
>>> Signed-off-by: Paul McQuade <paulmcq...@gmail.com>
>>
>> Just noticed these did not get applied by Kalle yet.
>
> Kalle, can you fix up the path (ralink/rt2x00 instead of rt2x00) when 
> applying?
> Or would you prefer Paul to respin the whole code style cleanup series?

Actually git should be manage that automatically, it's so awesome :)

I can also fix the title and remove the unnecessary "net: wireless:"
prefix.


-- 
Kalle Valo

Re: [v2] mwifiex: correctly handling kzalloc

[Kalle Valo]

> Since kzalloc can be failed in memory pressure,
> it needs to be handled, otherwise NULL dereference could be happened
> 
> Signed-off-by: Insu Yun <wuni...@gmail.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: iwlegacy: 4965-mac: constify il_sensitivity_ranges structure

[Kalle Valo]

> The il_sensitivity_ranges is never modified, so declare it as const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

pull-request: wireless-drivers-next 2016-01-05

[Kalle Valo]

 into next
  iwlwifi: mvm: close the SP if we send fewer frames than expected in SP
  Merge tag 'iwlwifi-for-kalle-2015-12-16' into next
  iwlwifi: change the Intel Wireless email address
  iwlwifi: pcie: allow to pretend to have Tx CSUM for debug
  iwlwifi: mvm: prepare the code towards TSO implementation
  iwlwifi: pcie: re-organize code towards TSO
  iwlwifi: clear ieee80211_tx_info->driver_data in the op_mode
  iwlwifi: pcie: build an A-MSDU using TSO core
  iwlwifi: 9000: increase the number of queues
  iwlwifi: mvm: small update in the firmware API
  iwlwifi: mvm: dump more registers upon error
  iwlwifi: remove unused parameter from grab_nic_access
  iwlwifi: fix printf specifier

Eyal Shapira (1):
  iwlwifi: mvm: rs: fix a potential out of bounds access

Felix Fietkau (1):
  ath10k: do not use coherent memory for allocated device memory chunks

Golan Ben-Ami (2):
  iwlwifi: expose fw usniffer mode to more utilities
  iwlwifi: mvm: support description for user triggered fw dbg collection

Gregory Greenman (1):
  iwlwifi: mvm: add an option to start rs from HT/VHT rates

Guy Mishol (1):
  wlcore: split wl12xx/wl18xx sg parameters

Hante Meuleman (9):
  brcmfmac: Simplify scan timing configuration
  brcmfmac: Use local storage for ssid iovar
  brcmfmac: Remove some redundant cfg80211 data
  brcmfmac: Cleanup pmksa cache handling code
  brcmfmac: Make TDLS a detectable feature
  brcmfmac: Add support for PCIE 4350 revision 5 device
  brcmfmac: Fix IBSS setup
  brcmfmac: Change error print in debug print
  brcmfmac: Move scheduled scan related interface layer structs

Janusz Dziedzic (11):
  ath9k: add debug messages to aggr/chanctx funcs
  ath9k: print real timer value
  ath9k: queue null frames in case of MCC
  ath9k: P2P_CLIENT, send frames after 1ms AP/GO will aprear
  ath9k: use u32 when calculate tsf
  ath9k: setup correct skb priority for nullfunc
  ath9k: MCC enable Opportunistic Power Save
  ath9k: P2P_CLIENT, get/set NOA correctly
  ath9k: MCC, add NOA also in case of an AP
  ath9k: MCC, print time elapsed between events
  ath9k: remove ath9k_mod_tsf64_tu

Johannes Berg (4):
  iwlwifi: mvm: advertise NETIF_F_SG
  iwlwifi: dvm: advertise NETIF_F_SG
  iwlwifi: mvm: change iwl_mvm_get_key_sta_id() to return the station
  iwlwifi: mvm: add 9000 series RX processing

Julia Lawall (4):
  brcm80211: fix compare_const_fl.cocci warnings
  mwifiex: fix semicolon.cocci warnings
  prism54: fix compare_const_fl.cocci warnings
  iwlwifi: dvm: fix compare_const_fl.cocci warnings

Kalle Valo (2):
  Merge ath-next from ath.git
  Merge tag 'iwlwifi-next-for-kalle-2015-12-21' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-next

Kosuke Tatsukawa (1):
  brcmfmac: fix waitqueue_active without memory barrier in brcmfmac driver

Larry Finger (9):
  rtlwifi: rtl8723be: Fix module parameter initialization
  rtlwifi: rtl8723ae: Fix initialization of module parameters
  rtlwifi: rtl8821ae: Fix errors in parameter initialization
  rtlwifi: rtl8188ee: Fix module parameter initialization
  rtlwifi: rtl8192de: Fix incorrect module parameter descriptions
  rtlwifi: rtl8192se: Fix module parameter initialization
  rtlwifi: rtl8192ce: Fix handling of module parameters
  rtlwifi: rtl8192cu: Add missing parameter setup
  rtlwifi: rtl_pci: Fix kernel panic

Liad Kaufman (1):
  iwlwifi: mvm: set default new STA as non-aggregated

Luca Coelho (3):
  iwlwifi: mvm: don't keep an mvm ref when the interface is down
  iwlwifi: replace d0i3_mode and wowlan_d0i3 with more generic variables
  iwlwifi: mvm: refactor the way fw_key_table is handled

Martin Blumenstingl (1):
  ath9k: Simplify and fix eeprom endianness swapping

Maya Erez (1):
  wil6210: prevent external wmi commands during suspend flow

Miaoqing Pan (2):
  ath9k: fix AR_RX_FILTER for ar9462/ar9565 when rx stopped
  ath9k: feeding entropy in kernel from ADC capture

Mohammed Shafi Shajakhan (1):
  ath10k: remove unnecessary amsdu/ampdu assignment in debugfs

Nicholas Mc Guire (2):
  rsi: consolidate kmalloc/memset 0 calls to kzalloc
  rsi: bool tests do not need comparison

Oren Givon (1):
  iwlwifi: Update PCI IDs for 8000 and 9000 series

Peter Oh (1):
  ath10k: allow Mesh Point to install peer security key

Peter Wu (1):
  rtlwifi: fix memory leak for USB device

Rafał Miłecki (2):
  ssb: pick SoC invariants code from MIPS BCM47xx arch
  bcma: use module_init for the main part of bus initialization

Sara Sharon (3):
  iwlwifi: mvm: change protocol offload flows
  iwlwifi: mvm: enable L3 filtering
  iwlwifi: mvm: infrastructure for frame-release message

Shahar Patury (1):
  wlcore/wl18xx: fw logger over sdio

Sharon Dvir (1):
  iwlwifi: update host command messages 

Re: [PATCH 5/9] ipw2x00: sdhci-pci: use to_pci_dev()

[Kalle Valo]

Geliang Tang <geliangt...@163.com> writes:

> Use to_pci_dev() instead of open-coding it.
>
> Signed-off-by: Geliang Tang <geliangt...@163.com>

The title is wrong, it should be just "ipw2x00: use to_pci_dev()".

And please state clearly to what tree you are planning to submit these.
I only saw this patch 5, not rest of the patches, so I have no clue
what's going to happen with this patchset. Please resend.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

[Kalle Valo]

> Fix the below Oops when trying to modprobe wlcore_spi.
> The oops occurs because the wl1271_power_{off,on}()
> function doesn't check the power() function pointer.
> 
> [   23.401447] Unable to handle kernel NULL pointer dereference at
> virtual address 
> [   23.409954] pgd = c0004000
> [   23.412922] [] *pgd=
> [   23.416693] Internal error: Oops: 8007 [#1] SMP ARM
> [   23.422168] Modules linked in: wl12xx wlcore mac80211 cfg80211
> musb_dsps musb_hdrc usbcore usb_common snd_soc_simple_card evdev joydev
> omap_rng wlcore_spi snd_soc_tlv320aic23_i2c rng_core snd_soc_tlv320aic23
> c_can_platform c_can can_dev snd_soc_davinci_mcasp snd_soc_edma
> snd_soc_omap omap_wdt musb_am335x cpufreq_dt thermal_sys hwmon
> [   23.453253] CPU: 0 PID: 36 Comm: kworker/0:2 Not tainted
> 4.2.0-2-g951efee-dirty #233
> [   23.461720] Hardware name: Generic AM33XX (Flattened Device Tree)
> [   23.468123] Workqueue: events request_firmware_work_func
> [   23.473690] task: de32efc0 ti: de4ee000 task.ti: de4ee000
> [   23.479341] PC is at 0x0
> [   23.482112] LR is at wl12xx_set_power_on+0x28/0x124 [wlcore]
> [   23.488074] pc : [<>]lr : []psr: 6013
> [   23.488074] sp : de4efe50  ip : 0002  fp : 
> [   23.500162] r10: de7cdd00  r9 : dc848800  r8 : bf27af00
> [   23.505663] r7 : bf27a1a8  r6 : dcbd8a80  r5 : dce0e2e0  r4 :
> dce0d2e0
> [   23.512536] r3 :   r2 :   r1 : 0001  r0 :
> dc848810
> [   23.519412] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM
> Segment kernel
> [   23.527109] Control: 10c5387d  Table: 9cb78019  DAC: 0015
> [   23.533160] Process kworker/0:2 (pid: 36, stack limit = 0xde4ee218)
> [   23.539760] Stack: (0xde4efe50 to 0xde4f)
> 
> [...]
> 
> [   23.665030] [] (wl12xx_set_power_on [wlcore]) from
> [] (wlcore_nvs_cb+0x118/0xa4c [wlcore])
> [   23.675604] [] (wlcore_nvs_cb [wlcore]) from []
> (request_firmware_work_func+0x30/0x58)
> [   23.685784] [] (request_firmware_work_func) from
> [] (process_one_work+0x1b4/0x4b4)
> [   23.695591] [] (process_one_work) from []
> (worker_thread+0x3c/0x4a4)
> [   23.704124] [] (worker_thread) from []
> (kthread+0xd4/0xf0)
> [   23.711747] [] (kthread) from []
> (ret_from_fork+0x14/0x3c)
> [   23.719357] Code: bad PC value
> [   23.722760] ---[ end trace 981be8510db9b3a9 ]---
> 
> Prevent oops by validationg power() pointer value before
> calling the function.
> 
> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il>
> Cc: sta...@vger.kernel.org
> Acked-by: Igor Grinberg <grinb...@compulab.co.il>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: prism54: fix checks for dma mapping errors

[Kalle Valo]

> prism54 checks for dma mapping errors by comparison returned address
> with zero, while pci_dma_mapping_error() should be used.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ath9k_htc: fix handling return value of ath9k_hw_calibrate

[Kalle Valo]

Andrzej Hajda <a.ha...@samsung.com> writes:

> The function can return negative values in case of error.
> Its result should be then tested for such case.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
>
> Signed-off-by: Andrzej Hajda <a.ha...@samsung.com>

Applied to ath.git, thanks.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mwifiex: correctly handling kzalloc

[Kalle Valo]

Andy Shevchenko <andy.shevche...@gmail.com> writes:

> On Tue, Dec 29, 2015 at 10:17 PM, Insu Yun <wuni...@gmail.com> wrote:
>
> Empty commit message?

Yeah, no empty commit log, please.

And then you submit a new version remember to add v2, v3 and so on:

http://kernelnewbies.org/FirstKernelPatch#head-5c81b3c517a1d0bbc24f92594cb734e155fcbbcb

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] wlcore/wl12xx: spi: fix NULL pointer dereference (Oops)

[Kalle Valo]

Uri Mashiach <uri.mashi...@compulab.co.il> writes:

> Fix the below Oops when trying to modprobe wlcore_spi.
> The oops occurs because the wl1271_power_{off,on}()
> function doesn't check the power() function pointer.
>
> [   23.401447] Unable to handle kernel NULL pointer dereference at
> virtual address 
> [   23.409954] pgd = c0004000
> [   23.412922] [] *pgd=
> [   23.416693] Internal error: Oops: 8007 [#1] SMP ARM
> [   23.422168] Modules linked in: wl12xx wlcore mac80211 cfg80211
> musb_dsps musb_hdrc usbcore usb_common snd_soc_simple_card evdev joydev
> omap_rng wlcore_spi snd_soc_tlv320aic23_i2c rng_core snd_soc_tlv320aic23
> c_can_platform c_can can_dev snd_soc_davinci_mcasp snd_soc_edma
> snd_soc_omap omap_wdt musb_am335x cpufreq_dt thermal_sys hwmon
> [   23.453253] CPU: 0 PID: 36 Comm: kworker/0:2 Not tainted
> 4.2.0-2-g951efee-dirty #233
> [   23.461720] Hardware name: Generic AM33XX (Flattened Device Tree)
> [   23.468123] Workqueue: events request_firmware_work_func
> [   23.473690] task: de32efc0 ti: de4ee000 task.ti: de4ee000
> [   23.479341] PC is at 0x0
> [   23.482112] LR is at wl12xx_set_power_on+0x28/0x124 [wlcore]
> [   23.488074] pc : [<>]lr : []psr: 6013
> [   23.488074] sp : de4efe50  ip : 0002  fp : 
> [   23.500162] r10: de7cdd00  r9 : dc848800  r8 : bf27af00
> [   23.505663] r7 : bf27a1a8  r6 : dcbd8a80  r5 : dce0e2e0  r4 :
> dce0d2e0
> [   23.512536] r3 :   r2 :   r1 : 0001  r0 :
> dc848810
> [   23.519412] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM
> Segment kernel
> [   23.527109] Control: 10c5387d  Table: 9cb78019  DAC: 0015
> [   23.533160] Process kworker/0:2 (pid: 36, stack limit = 0xde4ee218)
> [   23.539760] Stack: (0xde4efe50 to 0xde4f)
>
> [...]
>
> [   23.665030] [] (wl12xx_set_power_on [wlcore]) from
> [] (wlcore_nvs_cb+0x118/0xa4c [wlcore])
> [   23.675604] [] (wlcore_nvs_cb [wlcore]) from []
> (request_firmware_work_func+0x30/0x58)
> [   23.685784] [] (request_firmware_work_func) from
> [] (process_one_work+0x1b4/0x4b4)
> [   23.695591] [] (process_one_work) from []
> (worker_thread+0x3c/0x4a4)
> [   23.704124] [] (worker_thread) from []
> (kthread+0xd4/0xf0)
> [   23.711747] [] (kthread) from []
> (ret_from_fork+0x14/0x3c)
> [   23.719357] Code: bad PC value
> [   23.722760] ---[ end trace 981be8510db9b3a9 ]---
>
> Prevent oops by validationg power() pointer value before
> calling the function.
>
> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il>
> Cc: sta...@vger.kernel.org
> Acked-by: Igor Grinberg <grinb...@compulab.co.il>

Please always provide a changelog when you resend patches, I lost track
what I'm supposed to do with this. Should I apply or drop?

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rsi: consolidate kmalloc/memset 0 calls to kzalloc

[Kalle Valo]

> This is an API consolidation only. The use of kmalloc + memset to 0
> is equivalent to kzalloc.
> 
> Signed-off-by: Nicholas Mc Guire <hof...@osadl.org>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rsi: bool tests do not need comparison

[Kalle Valo]

> This is an API consolidation only. Bool initializations should 
> use true and false thus bool tests don't need an explicit comparison.
> 
> Signed-off-by: Nicholas Mc Guire <hof...@osadl.org>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

pull-request: wireless-drivers 2015-12-28

[Kalle Valo]

Hi Dave,

here's one more pull request, a bit late due to holidays but I hope this
still makes it to 4.4. Just two small fixes to iwlwifi, nothing else.

Kalle

The following changes since commit eeec5d0ef7ee54a75e09e861c3cc44177b8752c7:

  rtlwifi: rtl8821ae: Fix lockups on boot (2015-11-17 15:58:53 +0200)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 
tags/wireless-drivers-for-davem-2015-12-28

for you to fetch changes up to 01d85b9b2b6bec2b0773cf2afc58699dc4b052f8:

  Merge tag 'iwlwifi-for-kalle-2015-12-16' of 
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-fixes 
(2015-12-18 14:57:02 +0200)



iwlwifi

* don't load firmware that won't exist for 7260
* fix RCU splat


Johannes Berg (2):
  iwlwifi: separate firmware version for 7260 devices
  iwlwifi: mvm: protect RCU dereference in iwl_mvm_get_key_sta_id

Kalle Valo (1):
  Merge tag 'iwlwifi-for-kalle-2015-12-16' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-fixes

 drivers/net/wireless/iwlwifi/iwl-7000.c |   49 ++-
 drivers/net/wireless/iwlwifi/mvm/sta.c  |   15 ++
 2 files changed, 44 insertions(+), 20 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ath6kl: Use vmalloc to allocate ar->fw for api1 method

[Kalle Valo]

Souptick Joarder <jrdr.li...@gmail.com> writes:

> Hi Brent,
>
> On Tue, Dec 22, 2015 at 3:23 AM, Brent Taylor <moto...@gmail.com> wrote:
>> On Mon, Dec 21, 2015 at 1:23 PM, Souptick Joarder <jrdr.li...@gmail.com> 
>> wrote:
>>> Hi Brent,
>>>
>>> On Tue, Dec 1, 2015 at 11:11 AM, Brent Taylor <moto...@gmail.com> wrote:
>>>
>>>> --- a/drivers/net/wireless/ath/ath6kl/init.c
>>>> +++ b/drivers/net/wireless/ath/ath6kl/init.c
>>>> @@ -673,10 +673,15 @@ static int ath6kl_get_fw(struct ath6kl *ar, const 
>>>> char *filename,
>>>> return ret;
>>>>
>>>> *fw_len = fw_entry->size;
>>>> -   *fw = kmemdup(fw_entry->data, fw_entry->size, GFP_KERNEL);
>>>> +   if (>fw == fw)
>>>> +   *fw = vmalloc(fw_entry->size);
>>>> +   else
>>>> +   *fw = kmalloc(fw_entry->size, GFP_KERNEL)
>>>
>>>   Why vmalloc and kmalloc both are required? can't use either
>>> vmalloc or kmalloc?
>>
>> My original problem was that kmemdup (which uses kmalloc) could not
>> allocate enough memory
>
> If kmemdump ( which uses kmalloc) could not allocate memory then
> using kmalloc again can lead to same problem.
> I guess it will be correct to use
> *fw = vmalloc(fw_entry->size);
> Correct me if i am wrong.

That sounds best. But remember take into account DMA requirements, IIRC
you cannot DMA from vmalloc memory on all platforms.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v2] wlcore/wl12xx: spi: fix oops on firmware load

[Kalle Valo]

> The maximum chunks used by the function is
> (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE + 1).
> The original commands array had space for
> (SPI_AGGR_BUFFER_SIZE / WSPI_MAX_CHUNK_SIZE) commands.
> When the last chunk is used (len > 4 * WSPI_MAX_CHUNK_SIZE), the last
> command is stored outside the bounds of the commands array.
> 
> Oops 5 (page fault) is generated during current wl1271 firmware load
> attempt:
> 
> root@debian-armhf:~# ifconfig wlan0 up
> [  294.312399] Unable to handle kernel paging request at virtual address
> 00203fc4
> [  294.320173] pgd = de528000
> [  294.323028] [00203fc4] *pgd=
> [  294.326916] Internal error: Oops: 5 [#1] SMP ARM
> [  294.331789] Modules linked in: bnep rfcomm bluetooth ipv6 arc4 wl12xx
> wlcore mac80211 musb_dsps cfg80211 musb_hdrc usbcore usb_common
> wlcore_spi omap_rng rng_core musb_am335x omap_wdt cpufreq_dt thermal_sys
> hwmon
> [  294.351838] CPU: 0 PID: 1827 Comm: ifconfig Not tainted
> 4.2.0-2-g3e9ad27-dirty #78
> [  294.360154] Hardware name: Generic AM33XX (Flattened Device Tree)
> [  294.366557] task: dc9d6d40 ti: de55 task.ti: de55
> [  294.372236] PC is at __spi_validate+0xa8/0x2ac
> [  294.376902] LR is at __spi_sync+0x78/0x210
> [  294.381200] pc : []lr : []psr: 6013
> [  294.381200] sp : de551998  ip : de5519d8  fp : 0020
> [  294.393242] r10: de551c8c  r9 : de5519d8  r8 : de3a9000
> [  294.398730] r7 : de3a9258  r6 : de3a9400  r5 : de551a48  r4 :
> 00203fbc
> [  294.405577] r3 :   r2 :   r1 :   r0 :
> de3a9000
> [  294.412420] Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM
> Segment user
> [  294.419918] Control: 10c5387d  Table: 9e528019  DAC: 0015
> [  294.425954] Process ifconfig (pid: 1827, stack limit = 0xde550218)
> [  294.432437] Stack: (0xde551998 to 0xde552000)
> 
> ...
> 
> [  294.883613] [] (__spi_validate) from []
> (__spi_sync+0x78/0x210)
> [  294.891670] [] (__spi_sync) from []
> (wl12xx_spi_raw_write+0xfc/0x148 [wlcore_spi])
> [  294.901661] [] (wl12xx_spi_raw_write [wlcore_spi]) from
> [] (wlcore_boot_upload_firmware+0x1ec/0x458 [wlcore])
> [  294.914038] [] (wlcore_boot_upload_firmware [wlcore]) from
> [] (wl12xx_boot+0xc10/0xfac [wl12xx])
> [  294.925161] [] (wl12xx_boot [wl12xx]) from []
> (wl1271_op_add_interface+0x5b0/0x910 [wlcore])
> [  294.936364] [] (wl1271_op_add_interface [wlcore]) from
> [] (ieee80211_do_open+0x44c/0xf7c [mac80211])
> [  294.947963] [] (ieee80211_do_open [mac80211]) from
> [] (__dev_open+0xa8/0x110)
> [  294.957307] [] (__dev_open) from []
> (__dev_change_flags+0x88/0x148)
> [  294.965713] [] (__dev_change_flags) from []
> (dev_change_flags+0x18/0x48)
> [  294.974576] [] (dev_change_flags) from []
> (devinet_ioctl+0x6b4/0x7d0)
> [  294.983191] [] (devinet_ioctl) from []
> (sock_ioctl+0x1e4/0x2bc)
> [  294.991244] [] (sock_ioctl) from []
> (do_vfs_ioctl+0x420/0x6b0)
> [  294.999208] [] (do_vfs_ioctl) from []
> (SyS_ioctl+0x6c/0x7c)
> [  295.006880] [] (SyS_ioctl) from []
> (ret_fast_syscall+0x0/0x54)
> [  295.014835] Code: e1550004 e2444034 0a7d e5953018 (e5942008)
> [  295.021544] ---[ end trace 66ed188198f4e24e ]---
> 
> Signed-off-by: Uri Mashiach <uri.mashi...@compulab.co.il>
> Acked-by: Igor Grinberg <grinb...@compulab.co.il>
> Cc: sta...@vger.kernel.org

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: prism54: fix compare_const_fl.cocci warnings

[Kalle Valo]

> Move constants to the right of binary operators.
> 
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang...@intel.com>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: mwifiex: fix semicolon.cocci warnings

[Kalle Valo]

> Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang...@intel.com>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: brcm80211: fix compare_const_fl.cocci warnings

[Kalle Valo]

> Move constants to the right of binary operators.
> 
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang...@intel.com>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: iwlegacy: mark il_adjust_beacon_interval as noinline

[Kalle Valo]

> With the new optimized do_div() code, some versions of gcc
> produce obviously incorrect code that leads to a link error
> in iwlegacy/common.o:
> 
> drivers/built-in.o: In function `il_send_rxon_timing':
> :(.text+0xa6b4d4): undefined reference to `ilog2_NaN'
> :(.text+0xa6b4f0): undefined reference to `__aeabi_uldivmod'
> 
> In a few thousand randconfig builds, I have seen this problem
> a couple of times in this file, but never anywhere else in the
> kernel, so we can try to work around this in the only file
> that shows the behavior, by marking the il_adjust_beacon_interval
> function as noinline, which convinces gcc to use the unoptimized
> do_div() all the time.
> 
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
> Acked-by: Nicolas Pitre <n...@linaro.org>
> Acked-by: Stanislaw Gruszka <sgrus...@redhat.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: brcmfmac: only lock and unlock fws if fws is not null

[Kalle Valo]

> From: Colin Ian King <colin.k...@canonical.com>
> 
> There is a null ptr check for fws to set bcmc_credit_check, however,
> there a lock and unlock on fws should only performed if fwts is
> also not null to also avoid a potential null pointer deference.
> 
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> Acked-by: Arend van Spriel <ar...@broadcom.com>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v2] rtlwifi: fix memory leak for USB device

[Kalle Valo]

> Free skb for received frames with a wrong checksum. This can happen
> pretty rapidly, exhausting all memory.
> 
> This fixes a memleak (detected with kmemleak). Originally found while
> using monitor mode, but it also appears during managed mode (once the
> link is up).
> 
> Cc: sta...@vger.kernel.org
> Signed-off-by: Peter Wu <pe...@lekensteyn.nl>
> ACKed-by: Larry Finger <larry.fin...@lwfinger.net>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ath9k: fix inconsistent indenting on return statement

[Kalle Valo]

Colin King <colin.k...@canonical.com> writes:

> From: Colin Ian King <colin.k...@canonical.com>
>
> minor change, indenting is one tab out.
>
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>

Applied to ath.git, thanks.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fixing full name in patchwork

[Kalle Valo]

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:

> On Tue, Dec 08, 2015 at 09:54:41AM +0200, Kalle Valo wrote:
>> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:
>> 
>> > On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote:
>> >> Hi Sudip,
>> >> 
>> >> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:
>> >> 
> 
>> >
>> > I have also noticed the patch. Anyway, I have created a profile in
>> > patchwork and given full name. Hopefully that should solve the problem.
>> 
>> At least now your name in the patchwork link above looks correct:
>
> Yes, but I am still surprised why this happened for only this patch.

I don't know what other patches you are referring to, but I download the
patches I apply directly from patchwork. If other maintainers take the
patch from a mail folder this issue would not happen.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Fixing full name in patchwork

[Kalle Valo]

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:

> On Mon, Dec 07, 2015 at 08:03:54PM +0200, Kalle Valo wrote:
>> Hi Sudip,
>> 
>> Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:
>> 
>> > We were dereferencing cmd first and checking for NULL later. Lets first
>> > check for NULL.
>> >
>> > Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>
>> 
>> I noticed that your name in git log is not your full name:
>> 
>> commit 0a38c8e1b592c16d959da456f425053e323a5153
>> Author: sudip <sudipm.mukher...@gmail.com>
>> Date:   Tue Nov 24 13:51:38 2015 +0530
>> 
>> This is because for some reason in patchwork your fullname is just
>> "sudip":
>> 
>> https://patchwork.kernel.org/patch/7688171/
>> 
>> Could you please fix your name in patchwork so that in the future we can
>> use your correct full name? The problem is that I don't know exactly how
>> to do this but it should be possible because I remember someone else
>> having a similar problem and he was able to fix it.
>
> I have also noticed the patch. Anyway, I have created a profile in
> patchwork and given full name. Hopefully that should solve the problem.

At least now your name in the patchwork link above looks correct:

Sudip Mukherjee - Nov. 24, 2015, 8:21 a.m.

Thanks for fixing this.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] rtlwifi: fix gigantic memleak in rtl_usb

[Kalle Valo]

Peter Wu <pe...@lekensteyn.nl> writes:

> Originally I had the Cc: stable line added, but the SubmittingPatches
> document seems to discourage that for networking. Added it again.

Yeah, stable wireless patches are handled differently from rest of the
networking subsystem. It would be great if somebody could update the
documentation.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

pull-request: wireless-drivers-next 2015-12-07

[Kalle Valo]

ig default
  iwlwifi: trans: make various conversion macros inlines
  iwlwifi: dvm: remove stray debug code
  iwlwifi: pcie: remove ICT allocation message
  iwlwifi: mvm: use build-time assertion for fw trigger ID
  iwlwifi: clean up transport debugfs handling
  iwlwifi: pcie: remove pointer from debug message
  iwlwifi: mvm: use firmware station lookup, combine code
  iwlwifi: print index in api/capa flags parsing message
  iwlwifi: mvm: add 9000-series RX API

Julia Lawall (1):
  brcmfmac: constify brcmf_bus_ops structures

Kalle Valo (8):
  ath10k: fix otp board id error message
  ath10k: reorganise hardware and firmware info messages
  ath10k: always show bmi chip ids and subdevice ids
  ath10k: split driver info messages during device initialisation
  ath10k: print crc32 checksums for firmware and board files
  ath10k: implement fw_checksums debugfs file
  Merge ath-next from ath.git
  Merge tag 'iwlwifi-next-for-kalle-2015-12-01' of 
https://git.kernel.org/.../iwlwifi/iwlwifi-next

Luca Coelho (6):
  iwlwifi: mvm: ignore LMAC scan notifications when running UMAC scans
  iwlwifi: generalize d0i3_entry_timeout module parameter
  iwlwifi: mvm: remove redundant d0i3 flag from the config struct
  iwlwifi: mvm: remove stray nd_config element
  iwlwifi: mvm: flush all used TX queues before suspending
  iwlwifi: mvm: remove unnecessary check in iwl_mvm_is_d0i3_supported()

Manikanta Pubbisetty (1):
  ath10k: consolidate if statements in ath10k_wmi_event_mgmt_rx

Markus Elfring (2):
  brcm80211: Delete an unnecessary check before the function call 
"release_firmware"
  rtlwifi: Delete unnecessary checks before the function call "kfree_skb"

Matti Gottlieb (2):
  iwlwifi: mvm: check FW's response for nvm access write cmd
  iwlwifi: mvm: ROC: Extend the ROC max delay duration & limit ROC duration

Michal Kazior (9):
  ath10k: merge is_protected with nohwcrypt
  ath10k: rename function to adhere to naming convention
  ath10k: remove txmode from skb_cb
  ath10k: remove is_offchan
  ath10k: remove freq from skb_cb
  ath10k: pack up flags in skb_cb
  ath10k: fix tx header parsing
  ath10k: replace vdev_id and tid in skb cb
  ath10k: store msdu_id instead of txbuf pointers

Mohammed Shafi Shajakhan (2):
  ath10k: Enable AP + STA interface combination support for 10.x
  ath10k: Fix write permission on few debugfs files

Moshe Harel (2):
  iwlwifi: mvm: add bt settings to debugfs
  iwlwifi: mvm: add bt rrc and ttc to debugfs

Nicholas Krause (1):
  iwlwifi: mvm: fix incorrect fallthrough in iwl_mvm_check_running_scans()

Oren Givon (2):
  iwlwifi: Add PCI IDs for the new 3168 series
  iwlwifi: Add PCI IDs for the new series 8165

Peter Oh (4):
  ath10k: fix board data fetch error message
  ath10k: update WMI 10.x service map
  ath10k: introduce new subtypes for proxy STA and Mesh
  ath10k: apply Mesh subtype when Mesh interface created.

Tamizh chelvam (3):
  ath10k: add abstraction layer for peer flags
  ath10k: set peer MFP flag in peer assoc command
  ath10k: add thermal throttling support for 10.4 firmware

Vasanthakumar Thiagarajan (6):
  ath10k: add new service defines for 10.4
  ath10k: add new WMI cmd/event defines for 10.4
  ath10k: add new pdev params defines to 10.4
  ath10k: fix peer assoc complete WMI command for 10.4
  ath10k: rename the helper which is used for off-channel tx
  ath10k: fix peerid configuration in htt tx desc for htt version < 3.4

Vivek Natarajan (1):
  ath10k: add support for pktlog in QCA99X0

Vladimir Kondratiev (1):
  wil6210: hold wil->mutex while managing vrings

Yanbo Li (3):
  ath10k: debugfs file to enable Bluetooth coexistence feature
  ath10k: fix the wrong RX rate idx report at 11G mode
  ath10k: adjust the RX packet pad offset at QCA99X0 4addr mode

sudip (1):
  libertas: check for NULL before use

 drivers/net/wireless/ath/ath10k/Kconfig|1 +
 drivers/net/wireless/ath/ath10k/core.c |   16 +-
 drivers/net/wireless/ath/ath10k/core.h |   38 +-
 drivers/net/wireless/ath/ath10k/debug.c|  197 -
 drivers/net/wireless/ath/ath10k/debug.h|4 +
 drivers/net/wireless/ath/ath10k/htt.h  |   15 +-
 drivers/net/wireless/ath/ath10k/htt_rx.c   |   33 +-
 drivers/net/wireless/ath/ath10k/htt_tx.c   |  130 ++--
 drivers/net/wireless/ath/ath10k/hw.h   |   15 +
 drivers/net/wireless/ath/ath10k/mac.c  |  204 ++---
 drivers/net/wireless/ath/ath10k/mac.h  |3 +-
 drivers/net/wireless/ath/ath10k/pci.c  |   11 +
 drivers/net/wireless/ath/ath10k/thermal.c  |2 +-
 drivers/net/wireless/ath/ath10k/txrx.c |   15 +-
 drivers/net/wireless/ath/ath10k/

Fixing full name in patchwork

[Kalle Valo]

Hi Sudip,

Sudip Mukherjee <sudipm.mukher...@gmail.com> writes:

> We were dereferencing cmd first and checking for NULL later. Lets first
> check for NULL.
>
> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org>

I noticed that your name in git log is not your full name:

commit 0a38c8e1b592c16d959da456f425053e323a5153
Author: sudip <sudipm.mukher...@gmail.com>
Date:   Tue Nov 24 13:51:38 2015 +0530

This is because for some reason in patchwork your fullname is just
"sudip":

https://patchwork.kernel.org/patch/7688171/

Could you please fix your name in patchwork so that in the future we can
use your correct full name? The problem is that I don't know exactly how
to do this but it should be possible because I remember someone else
having a similar problem and he was able to fix it.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree

[Kalle Valo]

Kalle Valo <kv...@qca.qualcomm.com> writes:

> Brent Taylor <moto...@gmail.com> writes:
>
>> Signed-off-by: Brent Taylor <moto...@gmail.com>
>>
>> ath6kl: Use vmalloc for loading firmware using api1 method and free using 
>> kvfree
>> ---
>> Changes v1 -> v2:
>>- simplify memory allocation
>>- use kvfree
>
> Why? The commit log should _always_ answer that. Are you fixing a bug
> (what bug exactly?), is this just cleanup or what?
>
> And the commit log is wrongly formatted anyway, the Signed-off-by line
> should be the last and there should be no "ath6kl:" string in the commit
> log (just in the title). Use 'git log' to find examples.

Fixing netdev address (kenrel -> kernel)

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html