Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

[Shyam Saini]

Hi,

Did you read this?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO


Thanks,
Shyam


> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Sumit Pundir 
> ---
>  drivers/staging/irda/drivers/act200l-sir.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/irda/drivers/act200l-sir.c 
> b/drivers/staging/irda/drivers/act200l-sir.c
> index e891751..62a02e5 100644
> --- a/drivers/staging/irda/drivers/act200l-sir.c
> +++ b/drivers/staging/irda/drivers/act200l-sir.c
> @@ -29,7 +29,7 @@
>  static int act200l_reset(struct sir_dev *dev);
>  static int act200l_open(struct sir_dev *dev);
>  static int act200l_close(struct sir_dev *dev);
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);
>
>  /* Regsiter 0: Control register #1 */
>  #define ACT200L_REG00x00
> @@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
>   *Set the speed for the ACTiSYS ACT-IR200L type dongle.
>   *
>   */
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
>  {
> u8 control[3];
> int ret = 0;
> @@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, 
> unsigned speed)
>
>  static int act200l_reset(struct sir_dev *dev)
>  {
> -   unsigned state = dev->fsm.substate;
> -   unsigned delay = 0;
> +   unsigned int state = dev->fsm.substate;
> +   unsigned int delay = 0;
> static const u8 control[9] = {
> ACT200L_REG15,
> ACT200L_REG13 | ACT200L_SHDW,
> --
> 2.7.4
>

Re: [PATCH] qed: Replace memset with eth_zero_addr

[Shyam Saini]

On Mon, Jan 16, 2017 at 02:58:19PM -0500, David Miller wrote:
> From: Shyam Saini <mayhs11sa...@gmail.com>
> Date: Tue, 17 Jan 2017 00:21:38 +0530
> 
> > Use eth_zero_addr to assign zero address to the given address array
> > instead of memset when the second argument in memset is address
> > of zero. Also, it makes the code clearer
> > 
> > Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
> 
> This patch does not apply cleanly to the net-next tree.

I always send patches from linux-next tree and that caused this mistake

I apologize for this.

> Please state if you don't understand what that means instead of
> submitting this patch over and over again against the wrong source
> tree.

Now sent from net-next tree

Thanks a lot,
Shyam

[PATCH] qed: Replace memset with eth_zero_addr

[Shyam Saini]

Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +-
 drivers/net/ethernet/qlogic/qed/qed_sriov.c | 7 +++
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c 
b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index c92a850..7520eb3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -1846,7 +1846,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev,
qed_fill_dev_info(cdev, >common);
 
if (IS_VF(cdev))
-   memset(info->common.hw_mac, 0, ETH_ALEN);
+   eth_zero_addr(info->common.hw_mac);
 
return 0;
 }
diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c 
b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
index b121364..3f4bf31 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
@@ -1224,7 +1224,7 @@ static void qed_iov_clean_vf(struct qed_hwfn *p_hwfn, u8 
vfid)
return;
 
/* Clear the VF mac */
-   memset(vf_info->mac, 0, ETH_ALEN);
+   eth_zero_addr(vf_info->mac);
 
vf_info->rx_accept_mode = 0;
vf_info->tx_accept_mode = 0;
@@ -2626,8 +2626,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++) {
if (ether_addr_equal(p_vf->shadow_config.macs[i],
 p_params->mac)) {
-   memset(p_vf->shadow_config.macs[i], 0,
-  ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
break;
}
}
@@ -2640,7 +2639,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
} else if (p_params->opcode == QED_FILTER_REPLACE ||
   p_params->opcode == QED_FILTER_FLUSH) {
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++)
-   memset(p_vf->shadow_config.macs[i], 0, ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
}
 
/* List the new MAC address */
-- 
2.7.4

[PATCH] qed: Replace memset with eth_zero_addr

[Shyam Saini]

Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +-
 drivers/net/ethernet/qlogic/qed/qed_sriov.c | 7 +++
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c 
b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index 6a3727c..778c52c 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -1776,7 +1776,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev,
qed_fill_dev_info(cdev, >common);
 
if (IS_VF(cdev))
-   memset(info->common.hw_mac, 0, ETH_ALEN);
+   eth_zero_addr(info->common.hw_mac);
 
return 0;
 }
diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c 
b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
index 85b09dd..a15fff4 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
@@ -1199,7 +1199,7 @@ static void qed_iov_clean_vf(struct qed_hwfn *p_hwfn, u8 
vfid)
return;
 
/* Clear the VF mac */
-   memset(vf_info->mac, 0, ETH_ALEN);
+   eth_zero_addr(vf_info->mac);
 }
 
 static void qed_iov_vf_cleanup(struct qed_hwfn *p_hwfn,
@@ -2539,8 +2539,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++) {
if (ether_addr_equal(p_vf->shadow_config.macs[i],
 p_params->mac)) {
-   memset(p_vf->shadow_config.macs[i], 0,
-  ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
break;
}
}
@@ -2553,7 +2552,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
} else if (p_params->opcode == QED_FILTER_REPLACE ||
   p_params->opcode == QED_FILTER_FLUSH) {
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++)
-   memset(p_vf->shadow_config.macs[i], 0, ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
}
 
/* List the new MAC address */
-- 
2.7.4

[PATCH] qed: Replace memset with eth_zero_addr

[Shyam Saini]

Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +-
 drivers/net/ethernet/qlogic/qed/qed_sriov.c | 7 +++
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c 
b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index 6a3727c..778c52c 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -1776,7 +1776,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev,
qed_fill_dev_info(cdev, >common);
 
if (IS_VF(cdev))
-   memset(info->common.hw_mac, 0, ETH_ALEN);
+   eth_zero_addr(info->common.hw_mac);
 
return 0;
 }
diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c 
b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
index 85b09dd..a15fff4 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
@@ -1199,7 +1199,7 @@ static void qed_iov_clean_vf(struct qed_hwfn *p_hwfn, u8 
vfid)
return;
 
/* Clear the VF mac */
-   memset(vf_info->mac, 0, ETH_ALEN);
+   eth_zero_addr(vf_info->mac);
 }
 
 static void qed_iov_vf_cleanup(struct qed_hwfn *p_hwfn,
@@ -2539,8 +2539,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++) {
if (ether_addr_equal(p_vf->shadow_config.macs[i],
 p_params->mac)) {
-   memset(p_vf->shadow_config.macs[i], 0,
-  ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
break;
}
}
@@ -2553,7 +2552,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
} else if (p_params->opcode == QED_FILTER_REPLACE ||
   p_params->opcode == QED_FILTER_FLUSH) {
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++)
-   memset(p_vf->shadow_config.macs[i], 0, ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
}
 
/* List the new MAC address */
-- 
2.7.4

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

[Shyam Saini]

On Mon, Jan 16, 2017 at 11:46:06AM -0500, David Miller wrote:
> From: Shyam Saini <mayhs11sa...@gmail.com>
> Date: Mon, 16 Jan 2017 14:54:35 +0530
> 
> > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote:
> >> 
> >> Please do not ever submit two patches which have the same exact commit
> >> header line, as these two patches do.
> >> 
> >> When someone looks into the shortlog of GIT history all they will see
> >> is "qed: Replace memset with eth_zero_addr" twice.
> >> 
> >> This gives the reader no idea what might be different between those
> >> two changes.
> >> 
> >> Therefore you must give unique a commit header text for each change,
> >> which communicates sufficiently what is different in each change.
> > 
> > Thanks a lot for correcting me. I'll take care of this thing.
> > 
> > I'm resending these two patches as 
> > 1). qed: Replace memset with eth_zero_addr
> > 2). qed: Use eth_zero_addr
> > 
> > I hope it resolves same commit header line conflict.
> 
> You aren't understanding the point.
> 
> Those two lines still say exactly the same thing.
> 
> What is different about these two changes?  The answer to that question
> must propagate into those lines of text.

I got your point now. As pointed by you and Mintz,  I'll resend it
as a single patch. 

I sincerely appreciate your efforts for making things clearer and
correcting me.

Thanks a lot,
Shyam

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

[Shyam Saini]

On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote:
> 
> Please do not ever submit two patches which have the same exact commit
> header line, as these two patches do.
> 
> When someone looks into the shortlog of GIT history all they will see
> is "qed: Replace memset with eth_zero_addr" twice.
> 
> This gives the reader no idea what might be different between those
> two changes.
> 
> Therefore you must give unique a commit header text for each change,
> which communicates sufficiently what is different in each change.

Thanks a lot for correcting me. I'll take care of this thing.

I'm resending these two patches as 
1). qed: Replace memset with eth_zero_addr
2). qed: Use eth_zero_addr

I hope it resolves same commit header line conflict.

Regards,
Shyam

[PATCH] sfc: Replace memset with eth_zero_addr

[Shyam Saini]

Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero which makes the code clearer and also add header
file linux/etherdevice.h

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/sfc/ef10_sriov.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c 
b/drivers/net/ethernet/sfc/ef10_sriov.c
index a949b9d..228806c 100644
--- a/drivers/net/ethernet/sfc/ef10_sriov.c
+++ b/drivers/net/ethernet/sfc/ef10_sriov.c
@@ -6,6 +6,7 @@
  * under the terms of the GNU General Public License version 2 as published
  * by the Free Software Foundation, incorporated herein by reference.
  */
+#include 
 #include 
 #include 
 #include "net_driver.h"
@@ -554,7 +555,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int 
vf_i, u8 *mac)
return 0;
 
 fail:
-   memset(vf->mac, 0, ETH_ALEN);
+   eth_zero_addr(vf->mac);
return rc;
 }
 
-- 
2.7.4

[PATCH 1/2] qed: Replace memset with eth_zero_addr

[Shyam Saini]

Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_l2.c 
b/drivers/net/ethernet/qlogic/qed/qed_l2.c
index 6a3727c..778c52c 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_l2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_l2.c
@@ -1776,7 +1776,7 @@ static int qed_fill_eth_dev_info(struct qed_dev *cdev,
qed_fill_dev_info(cdev, >common);
 
if (IS_VF(cdev))
-   memset(info->common.hw_mac, 0, ETH_ALEN);
+   eth_zero_addr(info->common.hw_mac);
 
return 0;
 }
-- 
2.7.4

[PATCH 2/2] qed: Replace memset with eth_zero_addr

[Shyam Saini]

Use eth_zero_addr to assign zero address to the given address array
instead of memset when the second argument in memset is address
of zero. Also, it makes the code clearer

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/qlogic/qed/qed_sriov.c | 7 +++
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c 
b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
index 85b09dd..a15fff4 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c
@@ -1199,7 +1199,7 @@ static void qed_iov_clean_vf(struct qed_hwfn *p_hwfn, u8 
vfid)
return;
 
/* Clear the VF mac */
-   memset(vf_info->mac, 0, ETH_ALEN);
+   eth_zero_addr(vf_info->mac);
 }
 
 static void qed_iov_vf_cleanup(struct qed_hwfn *p_hwfn,
@@ -2539,8 +2539,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++) {
if (ether_addr_equal(p_vf->shadow_config.macs[i],
 p_params->mac)) {
-   memset(p_vf->shadow_config.macs[i], 0,
-  ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
break;
}
}
@@ -2553,7 +2552,7 @@ static int qed_iov_vf_update_mac_shadow(struct qed_hwfn 
*p_hwfn,
} else if (p_params->opcode == QED_FILTER_REPLACE ||
   p_params->opcode == QED_FILTER_FLUSH) {
for (i = 0; i < QED_ETH_VF_NUM_MAC_FILTERS; i++)
-   memset(p_vf->shadow_config.macs[i], 0, ETH_ALEN);
+   eth_zero_addr(p_vf->shadow_config.macs[i]);
}
 
/* List the new MAC address */
-- 
2.7.4

[PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

The region set by the call to memset, immediately overwritten by
the subsequent call to memcpy and thus makes the  memset redundant.

Also remove the memset((, 0, sizeof(info)) on line 398 because
info is memcpy()'ed to before being used in the loop and it isn't
used outside of the loop.

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb4/sched.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8..c902635 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -397,9 +397,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
struct ch_sched_params info;
struct ch_sched_params tp;
 
-   memset(, 0, sizeof(info));
-   memset(, 0, sizeof(tp));
-
memcpy(, p, sizeof(tp));
/* Don't try to match class parameter */
tp.u.params.class = SCHED_CLS_NONE;
@@ -409,7 +406,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
if (e->state == SCHED_STATE_UNUSED)
continue;
 
-   memset(, 0, sizeof(info));
memcpy(, >info, sizeof(info));
/* Don't try to match class parameter */
info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +454,6 @@ static struct sched_class *t4_sched_class_alloc(struct 
port_info *pi,
if (!e)
goto out;
 
-   memset(, 0, sizeof(np));
memcpy(, p, sizeof(np));
np.u.params.class = e->idx;
 
-- 
2.7.4

[PATCH] cxgb4: Remove redundant memset before memcpy

[Shyam Saini]

The region set by the call to memset, immediately overwritten by the
subsequent call to memcpy and thus makes the  memset redundant

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c 
b/drivers/net/ethernet/chelsio/cxgb4/sched.c
index cbd68a8..5725693 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/sched.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/sched.c
@@ -398,7 +398,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
struct ch_sched_params tp;
 
memset(, 0, sizeof(info));
-   memset(, 0, sizeof(tp));
 
memcpy(, p, sizeof(tp));
/* Don't try to match class parameter */
@@ -409,7 +408,6 @@ static struct sched_class *t4_sched_class_lookup(struct 
port_info *pi,
if (e->state == SCHED_STATE_UNUSED)
continue;
 
-   memset(, 0, sizeof(info));
memcpy(, >info, sizeof(info));
/* Don't try to match class parameter */
info.u.params.class = SCHED_CLS_NONE;
@@ -458,7 +456,6 @@ static struct sched_class *t4_sched_class_alloc(struct 
port_info *pi,
if (!e)
goto out;
 
-   memset(, 0, sizeof(np));
memcpy(, p, sizeof(np));
np.u.params.class = e->idx;
 
-- 
2.7.4

[PATCH] net: Use kmemdup instead of kmalloc and memcpy

[Shyam Saini]

when some other buffer is immediately copied into allocated region.
Replace calls to kmalloc followed by a memcpy with a direct
call to kmemdup.

Signed-off-by: Shyam Saini <mayhs11sa...@gmail.com>
---
 drivers/net/virtio_net.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index ba1aa24..dde4bc4 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1206,10 +1206,9 @@ static int virtnet_set_mac_address(struct net_device 
*dev, void *p)
struct sockaddr *addr;
struct scatterlist sg;
 
-   addr = kmalloc(sizeof(*addr), GFP_KERNEL);
+   addr = kmemdup(p, sizeof(*addr), GFP_KERNEL);
if (!addr)
return -ENOMEM;
-   memcpy(addr, p, sizeof(*addr));
 
ret = eth_prepare_mac_addr_change(dev, addr);
if (ret)
-- 
2.7.4

Re: How to submit potential patch in linux kernel

[Shyam Saini]

On Thu, 2016-09-29 at 13:15 +0300, Daniel Baluta wrote:
> Hi Shyam,
> 
> On Thu, Sep 29, 2016 at 1:02 PM, Andrew Lunn <and...@lunn.ch> wrote:
> > 
> > On Thu, Sep 29, 2016 at 04:32:29AM +0530, Shyam Saini wrote:
> > > 
> > > Hi everyone,
> > > 
> > > I'm Shyam, final year undergraduate student. I wanted to know how
> > > one can
> > > submit potential linux kernel patch in networking subsystem.
> > Documentation/SubmittingPatches is a good starting point.
> > 
> > Then post a patch and we will help you learn the rest of the
> > process.
> 
> You can have a look at https://kernelnewbies.org/FirstKernelPatch.
> There is also this presentation from Greg:
> https://www.youtube.com/watch?v=LLBrBBImJt4
> 
> thanks,
> Daniel.


Thanks for your reply. But I already know how to submit patches. I've
submitted some trivial kernel patches. But Now, I want to submit some
potential or good patches. 
So, I wanted to know how can I move to that direction? 

Thanks, 
Shyam

How to submit potential patch in linux kernel

[Shyam Saini]

Hi everyone,

I'm Shyam, final year undergraduate student. I wanted to know how one can
submit potential linux kernel patch in networking subsystem.

Thanks,
Shyam