Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Eliad Peller writes: > On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches wrote: >> On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >>> Joe Perches writes: >>> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >>> > > Joe Perches writes: >>> > > > >>> > > > Using the normal kernel logging mechanisms makes this code >>> > > > a bit more like other wireless drivers. >>> > > Personally I don't see the point but I don't have any strong opinions. A >>> > > bigger problem is that TI drivers are not really in active development >>> > > and that's I'm not thrilled to take big patches like this for dormant >>> > > drivers. >>> > Not very dormant. >>> > >>> > 35 patches in the last year, most of them adding functionality. >>> Oh, I didn't realise it had that many patches. But the driver is >>> orphaned and doesn't have a maintainer so could I then have an ack from >>> one of the active contributors that this ok? >> >> Fine by me. >> >> $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/ >> >> Kalle Valo (maintainer:NETWORKING DRIVERS >> (WIRELESS),commit_signer:27/35=77%) >> Eliad Peller (commit_signer:9/35=26%,authored:7/35=20%) >> Guy Mishol (commit_signer:6/35=17%,authored:5/35=14%) >> Johannes Berg >> (commit_signer:6/35=17%,authored:3/35=9%) >> Uri Mashiach >> (commit_signer:4/35=11%,authored:4/35=11%) >> >> For those people now added to the cc list, >> here's the original patch thread: >> >> https://lkml.org/lkml/2016/3/7/1099 > > I don't have a strong opinion here either. > (I do like the trailing newline being added automatically, but that's > hardly an issue...) Ok, I didn't get any objections so I'm planning to this set. If someone thinks this is a bad idea speak up now. -- Kalle Valo
Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
On Thu, Mar 31, 2016 at 11:07 AM, Joe Perches wrote: > On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: >> Joe Perches writes: >> > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> > > Joe Perches writes: >> > > > >> > > > Using the normal kernel logging mechanisms makes this code >> > > > a bit more like other wireless drivers. >> > > Personally I don't see the point but I don't have any strong opinions. A >> > > bigger problem is that TI drivers are not really in active development >> > > and that's I'm not thrilled to take big patches like this for dormant >> > > drivers. >> > Not very dormant. >> > >> > 35 patches in the last year, most of them adding functionality. >> Oh, I didn't realise it had that many patches. But the driver is >> orphaned and doesn't have a maintainer so could I then have an ack from >> one of the active contributors that this ok? > > Fine by me. > > $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/ > > Kalle Valo (maintainer:NETWORKING DRIVERS > (WIRELESS),commit_signer:27/35=77%) > Eliad Peller (commit_signer:9/35=26%,authored:7/35=20%) > Guy Mishol (commit_signer:6/35=17%,authored:5/35=14%) > Johannes Berg > (commit_signer:6/35=17%,authored:3/35=9%) > Uri Mashiach > (commit_signer:4/35=11%,authored:4/35=11%) > > For those people now added to the cc list, > here's the original patch thread: > > https://lkml.org/lkml/2016/3/7/1099 I don't have a strong opinion here either. (I do like the trailing newline being added automatically, but that's hardly an issue...) Eliad.
Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
On Thu, 2016-03-31 at 10:39 +0300, Kalle Valo wrote: > Joe Perches writes: > > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > > > Joe Perches writes: > > > > > > > > Using the normal kernel logging mechanisms makes this code > > > > a bit more like other wireless drivers. > > > Personally I don't see the point but I don't have any strong opinions. A > > > bigger problem is that TI drivers are not really in active development > > > and that's I'm not thrilled to take big patches like this for dormant > > > drivers. > > Not very dormant. > > > > 35 patches in the last year, most of them adding functionality. > Oh, I didn't realise it had that many patches. But the driver is > orphaned and doesn't have a maintainer so could I then have an ack from > one of the active contributors that this ok? Fine by me. $ ./scripts/get_maintainer.pl -f --git drivers/net/wireless/ti/ Kalle Valo (maintainer:NETWORKING DRIVERS (WIRELESS),commit_signer:27/35=77%) Eliad Peller (commit_signer:9/35=26%,authored:7/35=20%) Guy Mishol (commit_signer:6/35=17%,authored:5/35=14%) Johannes Berg (commit_signer:6/35=17%,authored:3/35=9%) Uri Mashiach (commit_signer:4/35=11%,authored:4/35=11%) For those people now added to the cc list, here's the original patch thread: https://lkml.org/lkml/2016/3/7/1099
Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Joe Perches writes: > On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: >> Joe Perches writes: >> > Using the normal kernel logging mechanisms makes this code >> > a bit more like other wireless drivers. >> Personally I don't see the point but I don't have any strong opinions. A >> bigger problem is that TI drivers are not really in active development >> and that's I'm not thrilled to take big patches like this for dormant >> drivers. > > Not very dormant. > > 35 patches in the last year, most of them adding functionality. Oh, I didn't realise it had that many patches. But the driver is orphaned and doesn't have a maintainer so could I then have an ack from one of the active contributors that this ok? -- Kalle Valo
Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
On Wed, 2016-03-30 at 14:51 +0300, Kalle Valo wrote: > Joe Perches writes: > > Using the normal kernel logging mechanisms makes this code > > a bit more like other wireless drivers. > Personally I don't see the point but I don't have any strong opinions. A > bigger problem is that TI drivers are not really in active development > and that's I'm not thrilled to take big patches like this for dormant > drivers. Not very dormant. 35 patches in the last year, most of them adding functionality.
Re: [PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Joe Perches writes: > Using the normal kernel logging mechanisms makes this code > a bit more like other wireless drivers. Personally I don't see the point but I don't have any strong opinions. A bigger problem is that TI drivers are not really in active development and that's I'm not thrilled to take big patches like this for dormant drivers. -- Kalle Valo
[PATCH 0/5] wireless: ti: Convert specialized logging macros to kernel style
Using the normal kernel logging mechanisms makes this code a bit more like other wireless drivers. Joe Perches (5): ti: Convert wl1271_ logging macros to dev_ or pr_ ti: wl1251: Convert wl1251_error to wiphy_err/pr_err ti: wl1251: Convert wl1251_warning to wiphy_warn ti: wl1251: Convert wl1251_notice to wiphy_info/pr_info ti: wl1251: Convert wl1251_info to wl1251_debug drivers/net/wireless/ti/wl1251/acx.c | 97 +++- drivers/net/wireless/ti/wl1251/boot.c | 18 +-- drivers/net/wireless/ti/wl1251/cmd.c | 52 --- drivers/net/wireless/ti/wl1251/event.c| 2 +- drivers/net/wireless/ti/wl1251/init.c | 27 ++-- drivers/net/wireless/ti/wl1251/io.c | 3 +- drivers/net/wireless/ti/wl1251/main.c | 75 + drivers/net/wireless/ti/wl1251/ps.c | 2 +- drivers/net/wireless/ti/wl1251/rx.c | 6 +- drivers/net/wireless/ti/wl1251/sdio.c | 25 +-- drivers/net/wireless/ti/wl1251/spi.c | 19 +-- drivers/net/wireless/ti/wl1251/tx.c | 9 +- drivers/net/wireless/ti/wl1251/wl1251.h | 15 +- drivers/net/wireless/ti/wl12xx/acx.c | 2 +- drivers/net/wireless/ti/wl12xx/cmd.c | 20 +-- drivers/net/wireless/ti/wl12xx/main.c | 34 ++-- drivers/net/wireless/ti/wl12xx/scan.c | 24 +-- drivers/net/wireless/ti/wl18xx/acx.c | 25 +-- drivers/net/wireless/ti/wl18xx/cmd.c | 20 +-- drivers/net/wireless/ti/wl18xx/debugfs.c | 2 +- drivers/net/wireless/ti/wl18xx/event.c| 8 +- drivers/net/wireless/ti/wl18xx/main.c | 50 +++--- drivers/net/wireless/ti/wl18xx/scan.c | 16 +- drivers/net/wireless/ti/wl18xx/tx.c | 8 +- drivers/net/wireless/ti/wlcore/acx.c | 132 drivers/net/wireless/ti/wlcore/boot.c | 45 +++--- drivers/net/wireless/ti/wlcore/cmd.c | 103 +++-- drivers/net/wireless/ti/wlcore/debug.h| 14 +- drivers/net/wireless/ti/wlcore/debugfs.c | 54 +++ drivers/net/wireless/ti/wlcore/event.c| 14 +- drivers/net/wireless/ti/wlcore/main.c | 248 -- drivers/net/wireless/ti/wlcore/ps.c | 15 +- drivers/net/wireless/ti/wlcore/rx.c | 26 ++-- drivers/net/wireless/ti/wlcore/scan.c | 4 +- drivers/net/wireless/ti/wlcore/sysfs.c| 8 +- drivers/net/wireless/ti/wlcore/testmode.c | 14 +- drivers/net/wireless/ti/wlcore/tx.c | 14 +- drivers/net/wireless/ti/wlcore/wlcore_i.h | 3 - 38 files changed, 653 insertions(+), 600 deletions(-) -- 2.6.3.368.gf34be46