Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Friday 03 November 2006 05:15, John W. Linville wrote: On Fri, Nov 03, 2006 at 01:46:31AM +0100, Johannes Berg wrote: Ok, that one was wrong. But what is it doing in the public API? We need to remove it from the public API and leave struct net_device *dev as the parameter. adm8211 actually uses it and increases the tx_fifo_error counter, but that's a bit strange. Fixed, and since, as always, netdev doesn't like my patches, they're here instead: http://johannes.sipsolutions.net/files/d80211-mdev-cleanup/ I also added d80211-reduce-mdev.patch which reduces stupid mdev usage, but see the description in the patch itself. 403 Forbidden (shouldn't that be Verboten? :-) FWIW, I have the other 6 patches on the 'pending' branch of wireless-dev. Driver authors, please proceed accordingly. I am currently working on the fixes for rt2x00, the above patches look very good, and also provide me with a chance to cleanup some garbage in rt2x00. :) I'll make the patches for this part of my patch series which I will send to the netdev list in 1 or 2 weeks. (I cannot do it any sooner due to school and work). Ivo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Sun, 2006-11-05 at 16:20 +0100, Ivo van Doorn wrote: I am currently working on the fixes for rt2x00, the above patches look very good, and also provide me with a chance to cleanup some garbage in rt2x00. :) I'll make the patches for this part of my patch series which I will send to the netdev list in 1 or 2 weeks. (I cannot do it any sooner due to school and work). Actually, disregard these patches. I have totally different ones I'm about to post. johannes signature.asc Description: This is a digitally signed message part
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Thu, 2006-11-02 at 23:15 -0500, John W. Linville wrote: 403 Forbidden (shouldn't that be Verboten? :-) Nah, that's ok, that particular Apache instance is running in London, UK :) Fixed, sorry about that, I don't usually allow directory listing in that hierarchy and forgot to enable it (so you could have gotten d80211-reduce-mdev.patch by appending it to that URL :) johannes - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Thu, 2006-11-02 at 21:28 -0500, Michael Wu wrote: That's because TX might fail for reasons other than not getting an ACK. I can't say I've actually seen this happen, so it might just be something left over from tulip that doesn't need to be there now. (or perhaps it only happens when there's something really bad going on) However, what's so bad about letting drivers update some statistics if it is possible? If you remove ieee80211_dev_stats, please provide some other way for drivers to access struct net_device_stats. Well, you were only changing the master netdev's stats, which isn't really useful because you want to change the device that transmitted the frame. But you cannot, because you don't have access to it. In general, the stack should be doing this, so if some other tx errors are possible maybe we should add a flag to the tx status. johannes - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Fri, 2006-11-03 at 01:46 +0100, Johannes Berg wrote:
d80211-reduce-mdev.patch
d80211-ethtool.patch
d80211-cookie.patch
G, whitespace damaged. I swear I'm going to submit a s/ {8}/\t/
patch some of these days. wiggle should handle that just fine, and
personally, I have reached a point where I'm far more annoyed by the
damaged whitespace all over than I would be if a patch failed to apply
(which actually happens all the time, so it's sort of a regular thing)
In the meantime, I've fixed the damage.
johannes
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Fri, 2006-11-03 at 00:09 +0100, Johannes Berg wrote: /* Return a pointer to network statistics data area for the given device. */ -void * ieee80211_dev_stats(struct net_device *dev); +void *ieee80211_dev_stats(struct ieee80211_local *ieee80211_ptr); Ok, that one was wrong. But what is it doing in the public API? We need to remove it from the public API and leave struct net_device *dev as the parameter. adm8211 actually uses it and increases the tx_fifo_error counter, but that's a bit strange. johannes signature.asc Description: This is a digitally signed message part
Re: [PATCH 1/6] d80211: change the cookie to be opaque
Ok, that one was wrong. But what is it doing in the public API? We need to remove it from the public API and leave struct net_device *dev as the parameter. adm8211 actually uses it and increases the tx_fifo_error counter, but that's a bit strange. Fixed, and since, as always, netdev doesn't like my patches, they're here instead: http://johannes.sipsolutions.net/files/d80211-mdev-cleanup/ I also added d80211-reduce-mdev.patch which reduces stupid mdev usage, but see the description in the patch itself. johannes signature.asc Description: This is a digitally signed message part
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Thursday 02 November 2006 19:22, Johannes Berg wrote: Ok, that one was wrong. But what is it doing in the public API? We need to remove it from the public API and leave struct net_device *dev as the parameter. adm8211 actually uses it and increases the tx_fifo_error counter, but that's a bit strange. That's because TX might fail for reasons other than not getting an ACK. I can't say I've actually seen this happen, so it might just be something left over from tulip that doesn't need to be there now. (or perhaps it only happens when there's something really bad going on) However, what's so bad about letting drivers update some statistics if it is possible? If you remove ieee80211_dev_stats, please provide some other way for drivers to access struct net_device_stats. -Michael Wu pgpSXbD257dOW.pgp Description: PGP signature
Re: [PATCH 1/6] d80211: change the cookie to be opaque
On Fri, Nov 03, 2006 at 01:46:31AM +0100, Johannes Berg wrote: Ok, that one was wrong. But what is it doing in the public API? We need to remove it from the public API and leave struct net_device *dev as the parameter. adm8211 actually uses it and increases the tx_fifo_error counter, but that's a bit strange. Fixed, and since, as always, netdev doesn't like my patches, they're here instead: http://johannes.sipsolutions.net/files/d80211-mdev-cleanup/ I also added d80211-reduce-mdev.patch which reduces stupid mdev usage, but see the description in the patch itself. 403 Forbidden (shouldn't that be Verboten? :-) FWIW, I have the other 6 patches on the 'pending' branch of wireless-dev. Driver authors, please proceed accordingly. Thanks, John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
