Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file
Sergej Stepanov wrote: We also need to change the reference to port C in fsl,mdio-pin and fsl,mdc-pin. Do you mean this: Currently defined compatibles: fsl,pq1-fec-mdio (reg is same as first resource of FEC device) -> fsl,cpm2-mdio-bitbang (reg is port C registers) Properties for fsl,cpm2-mdio-bitbang: -> fsl,mdio-pin : pin of port C controlling mdio data -> fsl,mdc-pin : pin of port C controlling mdio clock Yes. Right. But i thought it would be related to the example, and than the reader gets the short comment about I/O ports. No, the example is the example, and the spec is the spec. :-) Or the other variant would be: iv) MDIO Currently defined compatibles: fsl,pq1-fec-mdio (reg is same as first resource of FEC device) fsl,cpm2-mdio-bitbang (reg is the I/O port register block(s)) Properties for fsl,cpm2-mdio-bitbang: The first reg resource is the I/O port register block on which MDIO resides. The second reg resource is the I/O port register block on which MDC resides. If there is only one reg resource, it is used for both MDIO and MDC. fsl,mdio-pin : pin of chosen port for controlling mdio data fsl,mdc-pin : pin of chosen port for controlling mdio clock Looks good. We can eliminate the parenthetical for fsl,cpm2-mdio-bitbang because reg is now explained below. -Scott - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file
Am Donnerstag, den 08.11.2007, 14:20 -0600 schrieb Scott Wood:
> Sergej Stepanov wrote:
> > If both mdio and mdc controlling pins are on the same processor port,
> > one resource should be used.
> > Otherwise, two resources are used: the 1-st - mdio, the 2-nd - mdc.
>
> How about:
> The first reg resource is the I/O port register block on which MDIO
> resides. The second reg resource is the I/O port register block on
> which MDC resides. If there is only one reg resource, it is used for
> both MDIO and MDC.
>
Ok.
> We also need to change the reference to port C in fsl,mdio-pin and
> fsl,mdc-pin.
Do you mean this:
Currently defined compatibles:
fsl,pq1-fec-mdio (reg is same as first resource of FEC device)
-> fsl,cpm2-mdio-bitbang (reg is port C registers)
Properties for fsl,cpm2-mdio-bitbang:
-> fsl,mdio-pin : pin of port C controlling mdio data
-> fsl,mdc-pin : pin of port C controlling mdio clock
Right. But i thought it would be related to the example,
and than the reader gets the short comment about I/O ports.
Or the other variant would be:
iv) MDIO
Currently defined compatibles:
fsl,pq1-fec-mdio (reg is same as first resource of FEC device)
fsl,cpm2-mdio-bitbang (reg is the I/O port register block(s))
Properties for fsl,cpm2-mdio-bitbang:
The first reg resource is the I/O port register block on which MDIO
resides. The second reg resource is the I/O port register block on
which MDC resides. If there is only one reg resource, it is used for
both MDIO and MDC.
fsl,mdio-pin : pin of chosen port for controlling mdio data
fsl,mdc-pin : pin of chosen port for controlling mdio clock
Example:
[EMAIL PROTECTED] {
device_type = "mdio";
compatible = "fsl,mpc8272ads-mdio-bitbang",
"fsl,mpc8272-mdio-bitbang",
"fsl,cpm2-mdio-bitbang";
reg = <10d40 14>;
#address-cells = <1>;
#size-cells = <0>;
fsl,mdio-pin = <12>;
fsl,mdc-pin = <13>;
};
-
Regards
Sergej.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file
Sergej Stepanov wrote: If both mdio and mdc controlling pins are on the same processor port, one resource should be used. Otherwise, two resources are used: the 1-st - mdio, the 2-nd - mdc. How about: The first reg resource is the I/O port register block on which MDIO resides. The second reg resource is the I/O port register block on which MDC resides. If there is only one reg resource, it is used for both MDIO and MDC. We also need to change the reference to port C in fsl,mdio-pin and fsl,mdc-pin. -Scott - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file
Am Dienstag, den 06.11.2007, 12:46 -0600 schrieb Scott Wood: > > > > + The "reg"-property may have also depending on board design > > + the following form: > > + reg = <10d40 14 10d60 14>; > > + In that case the pin for mdio data controlling is on the port C, > > + and the pin for mdio clock controlling is on the port D. > > It'd be better to explicitly say that the first resource is mdio, and the > second resource is mdc, rather than require the reader to know/look up which > corresponds to 10d40 and which to 10d60. > > -Scott Ok. What would you say about something like that: -- If both mdio and mdc controlling pins are on the same processor port, one resource should be used. Otherwise, two resources are used: the 1-st - mdio, the 2-nd - mdc. -- Please, correct me, if it sounds bad. Thanks and regards Sergej. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] using mii-bitbang on different processor ports - update the booting-without-of.txt-file
On Tue, Nov 06, 2007 at 09:51:57AM +0100, Sergej Stepanov wrote: > The patch updates the booting-without-of.txt-file. > There is a description for the case > if mdio data and clock pins are on different processor ports. > It is a extending for e-mail "[PATCH v3] using mii-bitbang on different > processor ports". > > Signed-off-by: Sergej Stepanov <[EMAIL PROTECTED]> > -- > > diff --git a/Documentation/powerpc/booting-without-of.txt > b/Documentation/powerpc/booting-without-of.txt > index a96e853..497d8d8 100644 > --- a/Documentation/powerpc/booting-without-of.txt > +++ b/Documentation/powerpc/booting-without-of.txt > @@ -1956,6 +1956,12 @@ platforms are moved over to use the > flattened-device-tree model. > fsl,mdc-pin = <13>; > }; > > + The "reg"-property may have also depending on board design > + the following form: > + reg = <10d40 14 10d60 14>; > + In that case the pin for mdio data controlling is on the port C, > + and the pin for mdio clock controlling is on the port D. It'd be better to explicitly say that the first resource is mdio, and the second resource is mdc, rather than require the reader to know/look up which corresponds to 10d40 and which to 10d60. -Scott - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
