Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup
On Wed, May 27, 2015 at 8:44 PM, Cong Wang cw...@twopensource.com wrote: On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru so...@returnze.ro wrote: We're seeing some softlockups from this function when there are a lot fdb entries on a vxlan device. Taking the lock for each bucket instead of the whole table is enough to fix that. Hmm, then the spinlock could be moved into each bucket, right? Yes, it could, but I'm not sure if it will benefit us too much. I didn't see too much contention on this lock while adding and removing fdb entries. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup
From: Cong Wang cw...@twopensource.com Date: Wed, 27 May 2015 10:44:26 -0700 On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru so...@returnze.ro wrote: We're seeing some softlockups from this function when there are a lot fdb entries on a vxlan device. Taking the lock for each bucket instead of the whole table is enough to fix that. Hmm, then the spinlock could be moved into each bucket, right? Just because this one big one-time cleanup operation holds the lock for a long time, doesn't justify making it more granular. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup
From: Sorin Dumitru so...@returnze.ro Date: Tue, 26 May 2015 10:42:04 +0300 We're seeing some softlockups from this function when there are a lot fdb entries on a vxlan device. Taking the lock for each bucket instead of the whole table is enough to fix that. Signed-off-by: Sorin Dumitru sdumi...@ixiacom.com Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup
On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru so...@returnze.ro wrote: We're seeing some softlockups from this function when there are a lot fdb entries on a vxlan device. Taking the lock for each bucket instead of the whole table is enough to fix that. Hmm, then the spinlock could be moved into each bucket, right? -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
