Re: [RFC PATCH v2 net-next 01/12] net: core: trivial netif_receive_skb_list() entry point

2018-06-27 Thread Edward Cree
On 27/06/18 01:06, Eric Dumazet wrote:
> On 06/26/2018 11:17 AM, Edward Cree wrote:
>> Just calls netif_receive_skb() in a loop.
> ...
>
>> +void netif_receive_skb_list(struct sk_buff_head *list)
>
> Please use a standard list_head and standard list operators.
>
> (In all your patches)
>
> 1) We do not want to carry a spinlock_t + count per list...
>
> 2) We get nice debugging features with CONFIG_DEBUG_LIST=y
>
> Note that we now have skb->list after 
> commit d4546c2509b1e9cd082e3682dcec98472e37ee5a ("net: Convert GRO SKB 
> handling to list_head.")
So we do.  That hadn't gone in yet on Monday when I last pulled net-next; I'll 
make sure to use it in the next spin.
Thanks.


Re: [RFC PATCH v2 net-next 01/12] net: core: trivial netif_receive_skb_list() entry point

2018-06-26 Thread Eric Dumazet



On 06/26/2018 11:17 AM, Edward Cree wrote:
> Just calls netif_receive_skb() in a loop.

...

> +void netif_receive_skb_list(struct sk_buff_head *list)


Please use a standard list_head and standard list operators.

(In all your patches)

1) We do not want to carry a spinlock_t + count per list...

2) We get nice debugging features with CONFIG_DEBUG_LIST=y

Note that we now have skb->list after 
commit d4546c2509b1e9cd082e3682dcec98472e37ee5a ("net: Convert GRO SKB handling 
to list_head.")

Thanks !