Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-10 Thread Jiri Pirko 
Sat, Oct 10, 2015 at 04:51:20AM CEST, sfel...@gmail.com wrote:
>On Fri, Oct 9, 2015 at 7:36 AM, Jiri Pirko  wrote:
>> Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote:
>>>Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote:
On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko  wrote:
> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
>>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
>>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
> From: Jiri Pirko 
>
> This patchset allows new rocker worlds to be easily added in future 
> (like eBPF
> based one I have been working on). The main part of the patchset is 
> the OF-DPA
> carve-out. It resuts in OF-DPA specific file. Clean cut.
>
> v1->v2:
>  - rtnl rocker mode change userspace expose patch was removed
>
> Jiri Pirko (13):
>   rocker: remove unused rocker_port param from alloc funcs and shorten
> their names
>   rocker: rename rocker.h to rocker_hw.h
>   rocker: rename rocker.c to rocker_main.c
>   rocker: push tlv processing into separate files
>   rocker: implement set settings mode command
>   rocker: introduce worlds infrastructure
>   rocker: introduce OF-DPA world skeleton
>   rocker: set default world on port probe and clean world on remove
>   rocker: pass "learning" value as a parameter to
> rocker_port_set_learning
>   rocker: pre-allocate wait structures during cmd ring init
>   rocker: remove trans parameter to rocker_cmd_exec function
>   rocker: call rocker_cmd_exec function with "nowait" boolean instead 
> of
> flags
>   rocker: move OF-DPA stuff into separate file

A couple of my tests are failing with this patchset.  A simple port
test is failing and IPv4 routing test is failing.

The port test is simple: just connect a port on DUT to a port on
another system and assign an IP address to each port and verify IP
connectivity.  I have this:

   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)

The IPv4 routing tests is a bit more complicated to setup.  I'm using
OSPF, but I'm not seeing full routes formed in the topology, so I
suspect OSPF hellos aren't getting thru.

Please fix find/fix these issues and send v3.  I don't want any git
bisect issues when running tests.  Thanks.
>>>
>>> I fixed that. Sending v3 in a sec. Thanks.
>>
>>Sorry, both tests are still broken.  Would you send me your tests
>>scripts so I can see why your tests are passing?
>
> I'm trying some smoke tests including bridge setup and just ip-ip
> setup by hand. Meybe if you send me your scripts, I can run it locally.

My test scripts are already included in the qemu tree.
>>>
>>>Okay, will rework and use your scripts. Hope I will find some time
>>>during this weekend.
>>
>> Scott, could you try to test with current net-next?
>> I'm trying basic:
>> DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>> and it does not work for me now. It worked previously when I tested with
>> my patchset. This is getting odd.
>
>I had just re-run the tests against net-next before submitting the
>ageing_time patchset and everything passes.
>
>Are you using a namespace or a VM for host1?  Either one should work.
>
>This would be a bad test, as the kernel will loop the traffic and the
>offload device will not see it:
>
>DUT:sw1p1 (11.0.0.1/24) <>DUT:sw1p2(11.0.0.2/24)

For this test, I'm using 2 namespaces on baremetal.

I just discovered very odd behaviour.
I'm using 2 scripts so setup basic bridging scenario:
On host, I use "setupns.sh": http://pastebin.com/f9igGxgV
On vm, I use "setbr.sh" http://pastebin.com/Ycyyj8PK

Now when I turn on the vm and do:
vm# ./setbr.sh
host# ./setupns.sh
It works fine.

But when I execute these if reverse order:
host# ./setupns.sh
vm# ./setbr.sh
It does not work.

Can you reprocude this or is it something local? (I don't understand
what.)

Thanks.

Jiri
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-10 Thread Jiri Pirko 
Sat, Oct 10, 2015 at 09:21:15AM CEST, j...@resnulli.us wrote:



>>
>>I had just re-run the tests against net-next before submitting the
>>ageing_time patchset and everything passes.
>>
>>Are you using a namespace or a VM for host1?  Either one should work.
>>
>>This would be a bad test, as the kernel will loop the traffic and the
>>offload device will not see it:
>>
>>DUT:sw1p1 (11.0.0.1/24) <>DUT:sw1p2(11.0.0.2/24)
>
>For this test, I'm using 2 namespaces on baremetal.
>
>I just discovered very odd behaviour.
>I'm using 2 scripts so setup basic bridging scenario:
>On host, I use "setupns.sh": http://pastebin.com/f9igGxgV
>On vm, I use "setbr.sh" http://pastebin.com/Ycyyj8PK
>
>Now when I turn on the vm and do:
>vm# ./setbr.sh
>host# ./setupns.sh
>It works fine.
>
>But when I execute these if reverse order:
>host# ./setupns.sh
>vm# ./setbr.sh
>It does not work.

Hmm, I compiled git master qemu and with that, it works fine. I guess
that was some but in my previous qemu version. Sorry about the fuzz :/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-09 Thread Scott Feldman 
On Fri, Oct 9, 2015 at 7:36 AM, Jiri Pirko  wrote:
> Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote:
>>Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote:
>>>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko  wrote:
 Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
 From: Jiri Pirko 

 This patchset allows new rocker worlds to be easily added in future 
 (like eBPF
 based one I have been working on). The main part of the patchset is 
 the OF-DPA
 carve-out. It resuts in OF-DPA specific file. Clean cut.

 v1->v2:
  - rtnl rocker mode change userspace expose patch was removed

 Jiri Pirko (13):
   rocker: remove unused rocker_port param from alloc funcs and shorten
 their names
   rocker: rename rocker.h to rocker_hw.h
   rocker: rename rocker.c to rocker_main.c
   rocker: push tlv processing into separate files
   rocker: implement set settings mode command
   rocker: introduce worlds infrastructure
   rocker: introduce OF-DPA world skeleton
   rocker: set default world on port probe and clean world on remove
   rocker: pass "learning" value as a parameter to
 rocker_port_set_learning
   rocker: pre-allocate wait structures during cmd ring init
   rocker: remove trans parameter to rocker_cmd_exec function
   rocker: call rocker_cmd_exec function with "nowait" boolean instead 
 of
 flags
   rocker: move OF-DPA stuff into separate file
>>>
>>>A couple of my tests are failing with this patchset.  A simple port
>>>test is failing and IPv4 routing test is failing.
>>>
>>>The port test is simple: just connect a port on DUT to a port on
>>>another system and assign an IP address to each port and verify IP
>>>connectivity.  I have this:
>>>
>>>   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>>>
>>>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>>>OSPF, but I'm not seeing full routes formed in the topology, so I
>>>suspect OSPF hellos aren't getting thru.
>>>
>>>Please fix find/fix these issues and send v3.  I don't want any git
>>>bisect issues when running tests.  Thanks.
>>
>> I fixed that. Sending v3 in a sec. Thanks.
>
>Sorry, both tests are still broken.  Would you send me your tests
>scripts so I can see why your tests are passing?

 I'm trying some smoke tests including bridge setup and just ip-ip
 setup by hand. Meybe if you send me your scripts, I can run it locally.
>>>
>>>My test scripts are already included in the qemu tree.
>>
>>Okay, will rework and use your scripts. Hope I will find some time
>>during this weekend.
>
> Scott, could you try to test with current net-next?
> I'm trying basic:
> DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
> and it does not work for me now. It worked previously when I tested with
> my patchset. This is getting odd.

I had just re-run the tests against net-next before submitting the
ageing_time patchset and everything passes.

Are you using a namespace or a VM for host1?  Either one should work.

This would be a bad test, as the kernel will loop the traffic and the
offload device will not see it:

DUT:sw1p1 (11.0.0.1/24) <>DUT:sw1p2(11.0.0.2/24)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-09 Thread Jiri Pirko 
Wed, Oct 07, 2015 at 07:39:56PM CEST, j...@resnulli.us wrote:
>Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote:
>>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko  wrote:
>>> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
>>> From: Jiri Pirko 
>>>
>>> This patchset allows new rocker worlds to be easily added in future 
>>> (like eBPF
>>> based one I have been working on). The main part of the patchset is the 
>>> OF-DPA
>>> carve-out. It resuts in OF-DPA specific file. Clean cut.
>>>
>>> v1->v2:
>>>  - rtnl rocker mode change userspace expose patch was removed
>>>
>>> Jiri Pirko (13):
>>>   rocker: remove unused rocker_port param from alloc funcs and shorten
>>> their names
>>>   rocker: rename rocker.h to rocker_hw.h
>>>   rocker: rename rocker.c to rocker_main.c
>>>   rocker: push tlv processing into separate files
>>>   rocker: implement set settings mode command
>>>   rocker: introduce worlds infrastructure
>>>   rocker: introduce OF-DPA world skeleton
>>>   rocker: set default world on port probe and clean world on remove
>>>   rocker: pass "learning" value as a parameter to
>>> rocker_port_set_learning
>>>   rocker: pre-allocate wait structures during cmd ring init
>>>   rocker: remove trans parameter to rocker_cmd_exec function
>>>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
>>> flags
>>>   rocker: move OF-DPA stuff into separate file
>>
>>A couple of my tests are failing with this patchset.  A simple port
>>test is failing and IPv4 routing test is failing.
>>
>>The port test is simple: just connect a port on DUT to a port on
>>another system and assign an IP address to each port and verify IP
>>connectivity.  I have this:
>>
>>   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>>
>>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>>OSPF, but I'm not seeing full routes formed in the topology, so I
>>suspect OSPF hellos aren't getting thru.
>>
>>Please fix find/fix these issues and send v3.  I don't want any git
>>bisect issues when running tests.  Thanks.
>
> I fixed that. Sending v3 in a sec. Thanks.

Sorry, both tests are still broken.  Would you send me your tests
scripts so I can see why your tests are passing?
>>>
>>> I'm trying some smoke tests including bridge setup and just ip-ip
>>> setup by hand. Meybe if you send me your scripts, I can run it locally.
>>
>>My test scripts are already included in the qemu tree.
>
>Okay, will rework and use your scripts. Hope I will find some time
>during this weekend.

Scott, could you try to test with current net-next?
I'm trying basic:
DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
and it does not work for me now. It worked previously when I tested with
my patchset. This is getting odd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-07 Thread Jiri Pirko 
Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
 From: Jiri Pirko 

 This patchset allows new rocker worlds to be easily added in future (like 
 eBPF
 based one I have been working on). The main part of the patchset is the 
 OF-DPA
 carve-out. It resuts in OF-DPA specific file. Clean cut.

 v1->v2:
  - rtnl rocker mode change userspace expose patch was removed

 Jiri Pirko (13):
   rocker: remove unused rocker_port param from alloc funcs and shorten
 their names
   rocker: rename rocker.h to rocker_hw.h
   rocker: rename rocker.c to rocker_main.c
   rocker: push tlv processing into separate files
   rocker: implement set settings mode command
   rocker: introduce worlds infrastructure
   rocker: introduce OF-DPA world skeleton
   rocker: set default world on port probe and clean world on remove
   rocker: pass "learning" value as a parameter to
 rocker_port_set_learning
   rocker: pre-allocate wait structures during cmd ring init
   rocker: remove trans parameter to rocker_cmd_exec function
   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
 flags
   rocker: move OF-DPA stuff into separate file
>>>
>>>A couple of my tests are failing with this patchset.  A simple port
>>>test is failing and IPv4 routing test is failing.
>>>
>>>The port test is simple: just connect a port on DUT to a port on
>>>another system and assign an IP address to each port and verify IP
>>>connectivity.  I have this:
>>>
>>>   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>>>
>>>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>>>OSPF, but I'm not seeing full routes formed in the topology, so I
>>>suspect OSPF hellos aren't getting thru.
>>>
>>>Please fix find/fix these issues and send v3.  I don't want any git
>>>bisect issues when running tests.  Thanks.
>>
>> I fixed that. Sending v3 in a sec. Thanks.
>
>Sorry, both tests are still broken.  Would you send me your tests
>scripts so I can see why your tests are passing?

I'm trying some smoke tests including bridge setup and just ip-ip
setup by hand. Meybe if you send me your scripts, I can run it locally.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-07 Thread Jiri Pirko 
Wed, Oct 07, 2015 at 06:53:22PM CEST, sfel...@gmail.com wrote:
>On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko  wrote:
>> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
>>>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
 Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
>> From: Jiri Pirko 
>>
>> This patchset allows new rocker worlds to be easily added in future 
>> (like eBPF
>> based one I have been working on). The main part of the patchset is the 
>> OF-DPA
>> carve-out. It resuts in OF-DPA specific file. Clean cut.
>>
>> v1->v2:
>>  - rtnl rocker mode change userspace expose patch was removed
>>
>> Jiri Pirko (13):
>>   rocker: remove unused rocker_port param from alloc funcs and shorten
>> their names
>>   rocker: rename rocker.h to rocker_hw.h
>>   rocker: rename rocker.c to rocker_main.c
>>   rocker: push tlv processing into separate files
>>   rocker: implement set settings mode command
>>   rocker: introduce worlds infrastructure
>>   rocker: introduce OF-DPA world skeleton
>>   rocker: set default world on port probe and clean world on remove
>>   rocker: pass "learning" value as a parameter to
>> rocker_port_set_learning
>>   rocker: pre-allocate wait structures during cmd ring init
>>   rocker: remove trans parameter to rocker_cmd_exec function
>>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
>> flags
>>   rocker: move OF-DPA stuff into separate file
>
>A couple of my tests are failing with this patchset.  A simple port
>test is failing and IPv4 routing test is failing.
>
>The port test is simple: just connect a port on DUT to a port on
>another system and assign an IP address to each port and verify IP
>connectivity.  I have this:
>
>   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>
>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>OSPF, but I'm not seeing full routes formed in the topology, so I
>suspect OSPF hellos aren't getting thru.
>
>Please fix find/fix these issues and send v3.  I don't want any git
>bisect issues when running tests.  Thanks.

 I fixed that. Sending v3 in a sec. Thanks.
>>>
>>>Sorry, both tests are still broken.  Would you send me your tests
>>>scripts so I can see why your tests are passing?
>>
>> I'm trying some smoke tests including bridge setup and just ip-ip
>> setup by hand. Meybe if you send me your scripts, I can run it locally.
>
>My test scripts are already included in the qemu tree.

Okay, will rework and use your scripts. Hope I will find some time
during this weekend.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-07 Thread Scott Feldman 
On Tue, Oct 6, 2015 at 11:03 PM, Jiri Pirko  wrote:
> Tue, Oct 06, 2015 at 07:14:39PM CEST, sfel...@gmail.com wrote:
>>On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
>>> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
> From: Jiri Pirko 
>
> This patchset allows new rocker worlds to be easily added in future (like 
> eBPF
> based one I have been working on). The main part of the patchset is the 
> OF-DPA
> carve-out. It resuts in OF-DPA specific file. Clean cut.
>
> v1->v2:
>  - rtnl rocker mode change userspace expose patch was removed
>
> Jiri Pirko (13):
>   rocker: remove unused rocker_port param from alloc funcs and shorten
> their names
>   rocker: rename rocker.h to rocker_hw.h
>   rocker: rename rocker.c to rocker_main.c
>   rocker: push tlv processing into separate files
>   rocker: implement set settings mode command
>   rocker: introduce worlds infrastructure
>   rocker: introduce OF-DPA world skeleton
>   rocker: set default world on port probe and clean world on remove
>   rocker: pass "learning" value as a parameter to
> rocker_port_set_learning
>   rocker: pre-allocate wait structures during cmd ring init
>   rocker: remove trans parameter to rocker_cmd_exec function
>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
> flags
>   rocker: move OF-DPA stuff into separate file

A couple of my tests are failing with this patchset.  A simple port
test is failing and IPv4 routing test is failing.

The port test is simple: just connect a port on DUT to a port on
another system and assign an IP address to each port and verify IP
connectivity.  I have this:

   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)

The IPv4 routing tests is a bit more complicated to setup.  I'm using
OSPF, but I'm not seeing full routes formed in the topology, so I
suspect OSPF hellos aren't getting thru.

Please fix find/fix these issues and send v3.  I don't want any git
bisect issues when running tests.  Thanks.
>>>
>>> I fixed that. Sending v3 in a sec. Thanks.
>>
>>Sorry, both tests are still broken.  Would you send me your tests
>>scripts so I can see why your tests are passing?
>
> I'm trying some smoke tests including bridge setup and just ip-ip
> setup by hand. Meybe if you send me your scripts, I can run it locally.

My test scripts are already included in the qemu tree.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-06 Thread Jiri Pirko 
Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
>> From: Jiri Pirko 
>>
>> This patchset allows new rocker worlds to be easily added in future (like 
>> eBPF
>> based one I have been working on). The main part of the patchset is the 
>> OF-DPA
>> carve-out. It resuts in OF-DPA specific file. Clean cut.
>>
>> v1->v2:
>>  - rtnl rocker mode change userspace expose patch was removed
>>
>> Jiri Pirko (13):
>>   rocker: remove unused rocker_port param from alloc funcs and shorten
>> their names
>>   rocker: rename rocker.h to rocker_hw.h
>>   rocker: rename rocker.c to rocker_main.c
>>   rocker: push tlv processing into separate files
>>   rocker: implement set settings mode command
>>   rocker: introduce worlds infrastructure
>>   rocker: introduce OF-DPA world skeleton
>>   rocker: set default world on port probe and clean world on remove
>>   rocker: pass "learning" value as a parameter to
>> rocker_port_set_learning
>>   rocker: pre-allocate wait structures during cmd ring init
>>   rocker: remove trans parameter to rocker_cmd_exec function
>>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
>> flags
>>   rocker: move OF-DPA stuff into separate file
>
>A couple of my tests are failing with this patchset.  A simple port
>test is failing and IPv4 routing test is failing.
>
>The port test is simple: just connect a port on DUT to a port on
>another system and assign an IP address to each port and verify IP
>connectivity.  I have this:
>
>   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>
>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>OSPF, but I'm not seeing full routes formed in the topology, so I
>suspect OSPF hellos aren't getting thru.
>
>Please fix find/fix these issues and send v3.  I don't want any git
>bisect issues when running tests.  Thanks.

I fixed that. Sending v3 in a sec. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-06 Thread Scott Feldman 
On Tue, Oct 6, 2015 at 12:30 AM, Jiri Pirko  wrote:
> Tue, Oct 06, 2015 at 05:56:12AM CEST, sfel...@gmail.com wrote:
>>On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
>>> From: Jiri Pirko 
>>>
>>> This patchset allows new rocker worlds to be easily added in future (like 
>>> eBPF
>>> based one I have been working on). The main part of the patchset is the 
>>> OF-DPA
>>> carve-out. It resuts in OF-DPA specific file. Clean cut.
>>>
>>> v1->v2:
>>>  - rtnl rocker mode change userspace expose patch was removed
>>>
>>> Jiri Pirko (13):
>>>   rocker: remove unused rocker_port param from alloc funcs and shorten
>>> their names
>>>   rocker: rename rocker.h to rocker_hw.h
>>>   rocker: rename rocker.c to rocker_main.c
>>>   rocker: push tlv processing into separate files
>>>   rocker: implement set settings mode command
>>>   rocker: introduce worlds infrastructure
>>>   rocker: introduce OF-DPA world skeleton
>>>   rocker: set default world on port probe and clean world on remove
>>>   rocker: pass "learning" value as a parameter to
>>> rocker_port_set_learning
>>>   rocker: pre-allocate wait structures during cmd ring init
>>>   rocker: remove trans parameter to rocker_cmd_exec function
>>>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
>>> flags
>>>   rocker: move OF-DPA stuff into separate file
>>
>>A couple of my tests are failing with this patchset.  A simple port
>>test is failing and IPv4 routing test is failing.
>>
>>The port test is simple: just connect a port on DUT to a port on
>>another system and assign an IP address to each port and verify IP
>>connectivity.  I have this:
>>
>>   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)
>>
>>The IPv4 routing tests is a bit more complicated to setup.  I'm using
>>OSPF, but I'm not seeing full routes formed in the topology, so I
>>suspect OSPF hellos aren't getting thru.
>>
>>Please fix find/fix these issues and send v3.  I don't want any git
>>bisect issues when running tests.  Thanks.
>
> I fixed that. Sending v3 in a sec. Thanks.

Sorry, both tests are still broken.  Would you send me your tests
scripts so I can see why your tests are passing?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [patch net-next v2 00/13] rocker: add support for multiple worlds

2015-10-05 Thread Scott Feldman 
On Mon, Oct 5, 2015 at 10:43 AM, Jiri Pirko  wrote:
> From: Jiri Pirko 
>
> This patchset allows new rocker worlds to be easily added in future (like eBPF
> based one I have been working on). The main part of the patchset is the OF-DPA
> carve-out. It resuts in OF-DPA specific file. Clean cut.
>
> v1->v2:
>  - rtnl rocker mode change userspace expose patch was removed
>
> Jiri Pirko (13):
>   rocker: remove unused rocker_port param from alloc funcs and shorten
> their names
>   rocker: rename rocker.h to rocker_hw.h
>   rocker: rename rocker.c to rocker_main.c
>   rocker: push tlv processing into separate files
>   rocker: implement set settings mode command
>   rocker: introduce worlds infrastructure
>   rocker: introduce OF-DPA world skeleton
>   rocker: set default world on port probe and clean world on remove
>   rocker: pass "learning" value as a parameter to
> rocker_port_set_learning
>   rocker: pre-allocate wait structures during cmd ring init
>   rocker: remove trans parameter to rocker_cmd_exec function
>   rocker: call rocker_cmd_exec function with "nowait" boolean instead of
> flags
>   rocker: move OF-DPA stuff into separate file

A couple of my tests are failing with this patchset.  A simple port
test is failing and IPv4 routing test is failing.

The port test is simple: just connect a port on DUT to a port on
another system and assign an IP address to each port and verify IP
connectivity.  I have this:

   DUT:sw1p1 (11.0.0.1/24) <---> host1:eth0 (11.0.0.2/24)

The IPv4 routing tests is a bit more complicated to setup.  I'm using
OSPF, but I'm not seeing full routes formed in the topology, so I
suspect OSPF hellos aren't getting thru.

Please fix find/fix these issues and send v3.  I don't want any git
bisect issues when running tests.  Thanks.

-scott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html