Re: Experimental treeview search feature

2017-10-03 Thread Michael Drake



On 03/10/17 16:09, Bernard Boase wrote:


By the way, 'Global history' doesn't appear to include the list given
by the main window's drop-down 'URL suggestion icon'. That list is
stored in file Choices.WWW.NetSurf.URL. I'm unclear which URLs are
placed there, but I  do see that it is unaffected by deleting the
items from Global history.


That's something separate from the core global history that is
managed by the RISC OS front end.  It stores the URLs that are
typed manually into the URL bar, I think.

Cheers,

--
Michael Drake  http://www.codethink.co.uk/



Re: Experimental treeview search feature

2017-10-03 Thread Bernard Boase
On 18 Sep, t...@netsurf-browser.org typed:

>1. Hotlist viewer (bookmarks)
>2. Global history viewer
>3. Cookie manager window

By the way, 'Global history' doesn't appear to include the list given 
by the main window's drop-down 'URL suggestion icon'. That list is 
stored in file Choices.WWW.NetSurf.URL. I'm unclear which URLs are 
placed there, but I  do see that it is unaffected by deleting the 
items from Global history.

Yet it is a history of sorts which has to be manually deleted should 
one wish to clear all actual history.

Any thoughts?

RISC OS 5.23 Netsurf 3.7 (Dev CI #4213)

-- 
Bernard



Re: Experimental treeview search feature - a problem

2017-09-28 Thread Peter Young
On 28 Sep 2017  Michael Drake  wrote:


> On 25/09/17 14:19, Richard Torrens (lists) wrote:
>> I have just spotted a (hopefully small) problem - it's impossible to
>> delete items!

> Is #4213 any better?

Yes, many thanks.

Best wishes,

Peter.

-- 
Peter Young (zfc Pt) and family
Prestbury, Cheltenham, Glos. GL52, England
http://pnyoung.orpheusweb.co.uk
pnyo...@ormail.co.uk



Re: Experimental treeview search feature - a problem

2017-09-28 Thread Michael Drake


On 25/09/17 14:19, Richard Torrens (lists) wrote:

I have just spotted a (hopefully small) problem - it's impossible to
delete items!


Is #4213 any better?

Cheers,

--
Michael Drake  http://www.codethink.co.uk/



Re: Experimental treeview search feature - a problem

2017-09-27 Thread Michael Drake

On 27/09/17 13:43, Peter Young wrote:

On 25 Sep 2017  "Richard Torrens (lists)"  wrote:


I have just spotted a (hopefully small) problem - it's impossible to
delete items!



Well, up to a point! If I try to select an item in, say the hotlist
and then press menu over it, the white-on-black colouring vanishes,
and selecting delete from the menu does nothing. However, if you press
the delete key while the item is highlighted the deletion occurs.


Interesting.  I can't reproduce this on the GTK front end.

I'll look into it over the next view days to see if I can work
out what the RISC OS front end is doing differently.

Cheers,

--
Michael Drake  http://www.codethink.co.uk/



Re: Experimental treeview search feature - a problem

2017-09-27 Thread Peter Young
On 25 Sep 2017  "Richard Torrens (lists)"  wrote:

> I have just spotted a (hopefully small) problem - it's impossible to
> delete items!

> Select an item and assoon as the mouse pointer moves away from the window
> or over the search box, the item is delelected.

> Same thing happens if you press Menu!

> #4211,  ARMX6 5.23

Well, up to a point! If I try to select an item in, say the hotlist 
and then press menu over it, the white-on-black colouring vanishes, 
and selecting delete from the menu does nothing. However, if you press 
the delete key while the item is highlighted the deletion occurs.

#4212, same RISC OS.

Best wishes,

Peter.

-- 
Peter Young (zfc Pt) and family
Prestbury, Cheltenham, Glos. GL52, England
http://pnyoung.orpheusweb.co.uk
pnyo...@ormail.co.uk



Experimental treeview search feature - a problem

2017-09-27 Thread Richard Torrens (lists)
I have just spotted a (hopefully small) problem - it's impossible to
delete items!

Select an item and assoon as the mouse pointer moves away from the window
or over the search box, the item is delelected.

Same thing happens if you press Menu!

#4211,  ARMX6 5.23

-- 
Richard Torrens.
http://www.Torrens.org for genealogy, natural history, wild food, walks, cats
and more!



Re: Experimental treeview search feature

2017-09-24 Thread Chris Young
Hi Michael

On Mon, 18 Sep 2017 23:29:47 +0100, Michael Drake wrote:

> It would be helpful if people could put it thoroughly through its
> paces.  Any feedback gratefully received.

I've finally had a chance to test it out here (Amiga frontend).  It is
working well, except for a couple of minor issues;

1. When there are a lot of search results, the treeview is scrolling
to the end of the list.  This is confusing because it means the search
string is no longer in view.  I think it should be remaining at the
top.

If you have enough entries to fill up the window you can test this out
easily by typing a single common letter into the search field.

2. If the window is closed with a search in progress, when the window
is re-opened the search string does not display but the results are
still present.  I think this is due to how I implemented the windows
as they are disposed of completely and re-created on the Amiga
frontend, whereas on others the state is remembered and re-used.

I guess the treeview cleanup code is clearing the search string but
not the underlying results?  Or forgetting the search string?  I'm not
sure what the correct thing for it to do is, but the state of the
treeview (which folders are open/closed) is normally remembered, so it
should probably be remembering the search string.

Chris



Re: Experimental treeview search feature

2017-09-23 Thread Richard Torrens (lists)
In article <9fd418f6-1f08-b24e-3aff-5bfce9381...@codethink.co.uk>,
   Michael Drake  wrote:
> On 22/09/17 02:20, Harriet Bazley wrote:
> > Other thoughts: from a practical point of view, I think it would be
> > preferable if any active search were deleted when the window is closed.
> > Otherwise it gets a bit disconcerting when you go to reopen your
> > history/hotlist and there are only two or three entries visible, due to a
> > search you carried out earlier and have long since finished with -
> > particularly as the icon in question doesn't have the input focus when the
> > window reopens,

> I agree, it would be better to cancel the search when the window
> is closed.  Unfortunately the core doesn't know when the front
> end closes the window at the moment, so it's not straightforward
> to change that just yet.

> and clearing the old search string is a pain!

> Once the search field has focus, either ESC or CTRL+U should clear it.

Would a "clear" button make sense? Maybe a click on the search icon?

-- 
Richard Torrens.
http://www.Torrens.org for genealogy, natural history, wild food, walks, cats
and more!



Re: Experimental treeview search feature

2017-09-22 Thread Michael Drake

On 22/09/17 02:20, Harriet Bazley wrote:

Other thoughts: from a practical point of view, I think it would be
preferable if any active search were deleted when the window is closed.
Otherwise it gets a bit disconcerting when you go to reopen your
history/hotlist and there are only two or three entries visible, due to a
search you carried out earlier and have long since finished with -
particularly as the icon in question doesn't have the input focus when the
window reopens,


I agree, it would be better to cancel the search when the window
is closed.  Unfortunately the core doesn't know when the front
end closes the window at the moment, so it's not straightforward
to change that just yet.

and clearing the old search string is a pain!

Once the search field has focus, either ESC or CTRL+U should clear it.

Cheers,

--
Michael Drake  http://www.codethink.co.uk/



Re: Experimental treeview search feature

2017-09-22 Thread Michael Drake

On 22/09/17 01:11, Harriet Bazley wrote:


The size of the work area gets a bit confused if you toggle the 'expand
entries' icon with a search active (seems to reset to what it would be if
the whole window were being displayed, rather than just the visible
entries). It corrects itself if you then carry out a fresh search.


Good spot, that should be fixed in the latest build.

Cheers,

--
Michael Drake  http://www.codethink.co.uk/



Re: Experimental treeview search feature

2017-09-21 Thread Harriet Bazley
On 18 Sep 2017 as I do recall,
  Michael Drake  wrote:



> Any feedback gratefully received.
>
Other thoughts: from a practical point of view, I think it would be
preferable if any active search were deleted when the window is closed.
Otherwise it gets a bit disconcerting when you go to reopen your
history/hotlist and there are only two or three entries visible, due to a
search you carried out earlier and have long since finished with -
particularly as the icon in question doesn't have the input focus when the
window reopens, and clearing the old search string is a pain!

-- 
Harriet Bazley ==  Loyaulte me lie ==

A poor workman blames his tools.



Re: Experimental treeview search feature

2017-09-21 Thread Harriet Bazley
On 18 Sep 2017 as I do recall,
  Michael Drake  wrote:

> Hello,
>
> An experimental search feature has been added to the following:
>
>1. Hotlist viewer (bookmarks)
>2. Global history viewer
>3. Cookie manager window

Seems to work - thanks.
The size of the work area gets a bit confused if you toggle the 'expand
entries' icon with a search active (seems to reset to what it would be if
the whole window were being displayed, rather than just the visible
entries). It corrects itself if you then carry out a fresh search.

-- 
Harriet Bazley ==  Loyaulte me lie ==

Sattinger's Law:  It works better if you plug it in.



Re: Experimental treeview search feature

2017-09-20 Thread Peter Slegg

> Message: 1
> Date: Mon, 18 Sep 2017 23:29:47 +0100
> From: Michael Drake 
> Subject: Re: Experimental treeview search feature
> To: netsurf-users@netsurf-browser.org
> Message-ID: <8e933e3d-f507-99c8-2fec-26a5ca310...@netsurf-browser.org>
> Hello,
>
> An experimental search feature has been added to the following:
>
>1. Hotlist viewer (bookmarks)
>2. Global history viewer
>3. Cookie manager window
>
> To use it, click in the area next to the search icon at the top
> of the window, and start typing.
>
> It has currently only been tried under the GTK front end.
>
> It would be helpful if people could put it thoroughly through its
> paces.  Any feedback gratefully received.
>
> Cheers,

I just tried it in Atari build and it works fine.

Thanks,

Peter








Re: Experimental treeview search feature

2017-09-19 Thread Richard Torrens (lists)
In article <8e933e3d-f507-99c8-2fec-26a5ca310...@netsurf-browser.org>,
   Michael Drake  wrote:
> An experimental search feature has been added to the following:

>1. Hotlist viewer (bookmarks)
>2. Global history viewer
>3. Cookie manager window

> To use it, click in the area next to the search icon at the top
> of the window, and start typing.

A feature I have sometimes wished was present - it works fine (ARMX6 5.23).

Thanks.

-- 
Richard Torrens.
http://www.Torrens.org for genealogy, natural history, wild food, walks, cats
and more!



Re: Experimental treeview search feature

2017-09-19 Thread Peter Young
On 18 Sep 2017  Michael Drake  wrote:

> Hello,

> An experimental search feature has been added to the following:

>1. Hotlist viewer (bookmarks)
>2. Global history viewer
>3. Cookie manager window

> To use it, click in the area next to the search icon at the top
> of the window, and start typing.

> It has currently only been tried under the GTK front end.

> It would be helpful if people could put it thoroughly through its
> paces.  Any feedback gratefully received.

I've very briefly tried it in RISC OS, #4200, and it works well. Many 
thanks for the improvement.

Best wishes,

Peter.

-- 
Peter Young (zfc Pt) and family
Prestbury, Cheltenham, Glos. GL52, England
http://pnyoung.orpheusweb.co.uk
pnyo...@ormail.co.uk



Experimental treeview search feature

2017-09-18 Thread Michael Drake

Hello,

An experimental search feature has been added to the following:

  1. Hotlist viewer (bookmarks)
  2. Global history viewer
  3. Cookie manager window

To use it, click in the area next to the search icon at the top
of the window, and start typing.

It has currently only been tried under the GTK front end.

It would be helpful if people could put it thoroughly through its
paces.  Any feedback gratefully received.

Cheers,

--
Michael Drake  http://www.netsurf-browser.org/