Re: More graceful handling of failed image renders?

2012-11-06 Thread Michael Drake
In article 5097fc3c.6080...@unsatisfactorysoftware.co.uk,
   Chris Young chris.yo...@unsatisfactorysoftware.co.uk wrote:
 On 04/11/12 16:16, Martin Bazley wrote:

  if an error occurs (e.g. JPEG data is invalid or otherwise fails to
  decode), the redraw of the entire section is cancelled.

 Sounds as if this might be a manifestation of bug #3435099

Fixed.

-- 

Michael Drake (tlsa)  http://www.netsurf-browser.org/



Re: More graceful handling of failed image renders?

2012-11-06 Thread Martin Bazley
The following bytes were arranged on 6 Nov 2012 by Michael Drake :

 In article 5097fc3c.6080...@unsatisfactorysoftware.co.uk,
Chris Young chris.yo...@unsatisfactorysoftware.co.uk wrote:
  On 04/11/12 16:16, Martin Bazley wrote:

   if an error occurs (e.g. JPEG data is invalid or otherwise fails to
   decode), the redraw of the entire section is cancelled.

  Sounds as if this might be a manifestation of bug #3435099

 Fixed.

CI #607 works much better.  Thank you!  (Well, it now displays ff fc
instead of an image, but that's still preferable to the alternative.
Any RISC OS-friendly Unicode fonts with this character in them?)

Hopefully this'll also take care of an occasional problem I've had on
Twitter where a couple of people's avatar images are broken and take
their tweets and most of the rest of the page down with them.

-- 
  __^__
 / _   _ \ You always find something in the last place you look.
( ( |_| ) )
 \_   _/  === Martin Bazley ==



Re: More graceful handling of failed image renders?

2012-11-06 Thread Michael Drake
In article ade962ea52.mar...@blueyonder.co.uk,
   Martin Bazley martin.baz...@blueyonder.co.uk wrote:

 CI #607 works much better.  Thank you!  (Well, it now displays ff fc
 instead of an image, but that's still preferable to the alternative.
 Any RISC OS-friendly Unicode fonts with this character in them?)

I just used the OBJECT REPLACEMENT CHARACTER:

http://www.fileformat.info/info/unicode/char/fffc/index.htm

Some font I converted with TTF2f must include it.  Maybe Cyberbit or Arial
Unicode MS.

If anyone wants to help they could create and add the glyph to
!NetSurf.Resources.Fonts.NSSymbol.

Cheers,

-- 

Michael Drake (tlsa)  http://www.netsurf-browser.org/



Re: More graceful handling of failed image renders?

2012-11-05 Thread Chris Young

On 04/11/12 16:16, Martin Bazley wrote:

NetSurf redraws its pages in rectangular sections.  This process
involves decoding any image files, such as JPEGs, which may be present
in that section.

At the moment, if an error occurs (e.g. JPEG data is invalid or
otherwise fails to decode), the redraw of the entire section is
cancelled.  This is undesirable, because it leads to the appearance of
large blank white spaces on a page with invalid images on it.

You can see an example of the problems this causes here:

http://www.corporateskull.com/

There are two invalid JPEGs in the sidebar there (or at least JPEGs
which RISC OS doesn't seem to like; Linux renders them OK).  These are
the link to 'Skull Art' just beneath the (working) 'Corporate Skull
Guest Artist Week' image, and the Ink Outbreak avatar in the top-left of
the box beneath that.

If you slowly scroll down the page using NetSurf on RISC OS, you'll see
a thick white horizontal bar blotting out the image in the blog post to
the left of the Skull Art picture, as well as the Skull Art picture
itself failing to render.

If you press F12 and then Return with the faulty JPEG showing, most of
the window goes white!

NetSurf may not be able to render an image, but could it at least not
trash the rest of the page because of it?


Sounds as if this might be a manifestation of bug #3435099

Chris




More graceful handling of failed image renders?

2012-11-04 Thread Martin Bazley
NetSurf redraws its pages in rectangular sections.  This process
involves decoding any image files, such as JPEGs, which may be present
in that section.

At the moment, if an error occurs (e.g. JPEG data is invalid or
otherwise fails to decode), the redraw of the entire section is
cancelled.  This is undesirable, because it leads to the appearance of
large blank white spaces on a page with invalid images on it.

You can see an example of the problems this causes here:

http://www.corporateskull.com/

There are two invalid JPEGs in the sidebar there (or at least JPEGs
which RISC OS doesn't seem to like; Linux renders them OK).  These are
the link to 'Skull Art' just beneath the (working) 'Corporate Skull
Guest Artist Week' image, and the Ink Outbreak avatar in the top-left of
the box beneath that.

If you slowly scroll down the page using NetSurf on RISC OS, you'll see
a thick white horizontal bar blotting out the image in the blog post to
the left of the Skull Art picture, as well as the Skull Art picture
itself failing to render.

If you press F12 and then Return with the faulty JPEG showing, most of
the window goes white!

NetSurf may not be able to render an image, but could it at least not
trash the rest of the page because of it?

-- 
  __^__
 / _   _ \ You always find something in the last place you look.
( ( |_| ) )
 \_   _/  === Martin Bazley ==