Text area refresh
While work is being done on textareas maybe it is a good time to raise this again ? When typing in a textarea, each key press causes a refresh of the entire textarea. You may not notice this on a fast cpu but on a 68060 it is very noticeable and the more text there is, the slower it gets. Could this be improved by just refreshing the current line ? Regards, Peter
Re: Text area refresh
In article <00112fcb.01dac5001...@smtp.freeola.net>, Peter Slegg wrote: > When typing in a textarea, each key press causes a refresh of the entire > textarea. I've updated the single line textarea (used for search boxes and passwords), to reduce unnecessary redraw in some cases. Please try CI build #1000 or later and let me know if it's any better. For multi-line textareas, it's a bit more complex. I'll work on them next. I've already done little -- scrollbars won't be redrawn with every letter you type now, unless the input actually forces the textarea to scroll. -- Michael Drake (tlsa) http://www.netsurf-browser.org/
Re: Text area refresh
On Thursday 21 March 2013 19:01:53 Michael Drake wrote: > In article <00112fcb.01dac5001...@smtp.freeola.net>, > >Peter Slegg wrote: > > When typing in a textarea, each key press causes a refresh of the entire > > textarea. > > I've updated the single line textarea (used for search boxes and > passwords), to reduce unnecessary redraw in some cases. Please try CI > build #1000 or later and let me know if it's any better. I tried the Atari build and indeed it is much better now. It would be fantastic if multi-line textareas could be improved in the same way. Thanks for this! Cheers, JFL -- Jean-François Lemaire
Re: Text area refresh
Am Donnerstag, den 21.03.2013, 20:25 +0100 schrieb Jean-François Lemaire I tried the Atari build and indeed it is much better now. It would be fantastic if multi-line textareas could be improved in the same way. Thanks for this! Yes, typing results in no flickering now. Thanks!
Re: Text area refresh
In article <4136879.Nb86WAdMgm@chertsey>, Jean-François Lemaire wrote: > > I've updated the single line textarea (used for search boxes and > > passwords), to reduce unnecessary redraw in some cases. Please try CI > > build #1000 or later and let me know if it's any better. > I tried the Atari build and indeed it is much better now. It would be > fantastic if multi-line textareas could be improved in the same way. Please try CI build #1009 or later. When editing multi-line textareas, the redraw area has been reduced significantly in some common cases. Cheers, -- Michael Drake (tlsa) http://www.netsurf-browser.org/
Re: Text area refresh
On 26/03/2013, Michael Drake wrote: > In article <4136879.Nb86WAdMgm@chertsey>, >Jean-François Lemaire wrote: >> I tried the Atari build and indeed it is much better now. It would be >> fantastic if multi-line textareas could be improved in the same way. > Please try CI build #1009 or later. When editing multi-line textareas, > the redraw area has been reduced significantly in some common cases. Yes, it's becoming quite useful. I'm typing this in Gmail and I don't notice any flickering when typing or deleting characters in most cases. Many thanks! Cheers, JFL -- Jean-François Lemaire
Re: Text area refresh
What I have noticed recently is that pasting into the text area with Ctrl-V creates 2 copies of the pasted text. Peter
Re: Text area refresh
On 5 April 2013 12:30, wrote: > What I have noticed recently is that pasting into the text area with Ctrl-V > creates 2 copies of the pasted text. Yes, I noticed this too. I suspect this is a frontend issue, however, not a core one, since each platform has its own mechanism to access the clipboard. Cheers, JFL -- Jean-François Lemaire
Re: Text area refresh
On Fri, 5 Apr 2013 13:09:01 +0200, J. F. Lemaire wrote: > On 5 April 2013 12:30, wrote: > > > What I have noticed recently is that pasting into the text area with Ctrl-V > > creates 2 copies of the pasted text. > > Yes, I noticed this too. I suspect this is a frontend issue, however, > not a core one, since each platform has its own mechanism to access > the clipboard. I'm not so sure. Here the frontend handles RAmiga-V as a paste shortcut, and that works wonderfully. However, something (I'm suspecting the core, as I haven't added any code for this) is trapping Ctrl-V and handling that as a paste operation too. You've neglected to mention what platform you are using, but what I suspect is happening, is the frontend is handling Ctrl-V as a paste operation, and that shortcut is also reaching the core, which handles it again as a paste - hence the two pastes. The core handling of Ctrl-V (and any other similar shortcuts) probably needs to be tracked down and obliterated. Chris
Re: Text area refresh
In article , Chris Young wrote: > The core handling of Ctrl-V (and any other similar shortcuts) probably > needs to be tracked down and obliterated. The core handling of Ctrl-V is the only supported way of pasting. When you select "Paste" in a menu, the front end should be implementing it by passing Ctrl-V to the core. When the core gets a Ctrl-V it passes it on internally to whatever has input focus. If there is a textarea with focus, the textarea handles the keypress (by calling gui_get_clipboard, in the case of Ctrl-V). -- Michael Drake (tlsa) http://www.netsurf-browser.org/
Re: Text area refresh
On Mon, 08 Apr 2013 19:54:52 +0100, Michael Drake wrote: > The core handling of Ctrl-V is the only supported way of pasting. > > When you select "Paste" in a menu, the front end should be implementing it > by passing Ctrl-V to the core. Oh yes, I didn't realise KEY_PASTE = ASCII 22 = Ctrl-V (until I looked it up) I still think the double-pasting would be the frontend interpreting it directly as a KEY_PASTE *and* passing the original key press as well. Chris
Re: Text area refresh
Am Montag, den 08.04.2013, 21:53 +0200 schrieb "Chris Young"
:
Oh yes, I didn't realise KEY_PASTE = ASCII 22 = Ctrl-V (until I
looked
it up)
I still think the double-pasting would be the frontend interpreting
it
directly as a KEY_PASTE *and* passing the original key press as well.
The following is happening with the Atari frontend:
- First Ctrl+V is captured by the main menu... ("paste" action is
executed).
- The browser window key handling routine passes the keycode to the
internal browser_window structure.
I have to think about how to solve it...:
1. I would still like to process menu events before
browser_window events.
2. catching ctrl+v and not passing it to the core is maybe
incorrect(??).
What looks best suited to me is to drop events which are handled by the
menu area (should be done already,
so this is an bug in the frontend), however, that solution maybe
conflicts with policy number 2 (see above).
Greets,
Ole
Re: Text area refresh
Am Montag, den 08.04.2013, 23:52 +0200 schrieb Ole : Am Montag, den 08.04.2013, 21:53 +0200 schrieb "Chris Young" I have to think about how to solve it...: 1. I would still like to process menu events before browser_window events. 2. catching ctrl+v and not passing it to the core is maybe incorrect(??). What looks best suited to me is to drop events which are handled by the menu area (should be done already, so this is an bug in the frontend), however, that solution maybe conflicts with policy number 2 (see above). I was wrong, browser_window_key_input is called before the deskmenu shortcut processing, so now I'm ignoring inputs which are handled by browser_window_key_input. The problem should be fixed in the next build, I hope this doesn't introduce any side-effects :) Greets, Ole
Re: Text area refresh
> Date: Mon, 08 Apr 2013 19:54:52 +0100 > Subject: Re: Text area refresh > In article > , >Chris Young wrote: > > > The core handling of Ctrl-V (and any other similar shortcuts) probably > > needs to be tracked down and obliterated. > > The core handling of Ctrl-V is the only supported way of pasting. > > When you select "Paste" in a menu, the front end should be implementing it > by passing Ctrl-V to the core. > > When the core gets a Ctrl-V it passes it on internally to whatever has > input focus. If there is a textarea with focus, the textarea handles the > keypress (by calling gui_get_clipboard, in the case of Ctrl-V). > The double paste problem has gone. Thanks. I don't know if it related but the Page Up key does a page-down action. Peter Netsurf Port : Atari Machine : Milan 68060
Re: Text area refresh
Am Mittwoch, den 10.04.2013, 22:11 +0200 schrieb Peter Slegg : I don't know if it related but the Page Up key does a page-down action. Not related, but should be fixed in the next auto-build.
Re: Text area refresh (Michael Drake)
>Date: Fri, 22 Mar 2013 00:28:11 +0100 >From: Ole >Subject: Re: Text area refresh > > > Am Donnerstag, den 21.03.2013, 20:25 +0100 schrieb Jean-François > Lemaire > >> I tried the Atari build and indeed it is much better now. It would be >> fantastic if multi-line textareas could be improved in the same way. >> Thanks >> for this! > > Yes, typing results in no flickering now. Thanks! Thanks Micheal that's a lot better. Still a little flickering but it doesn't miss keystrokes like before. I know it is a small improvement for everyone else but small performance improvements will hopefully help allround. Regards, Peter
