Re: [PATCH 1/1] openvpn: add support to change interface name
On Tue, 2014-09-30 at 21:07 +0200, Christian Hesse wrote:
Christian Hesse m...@eworm.de on Mon, 2014/09/29 14:46:
By default interface name is 'tun' or 'tap' with an incrementing number
(tun0, tun1, ... or tap0, tap1, ...). By specifying 'Interface name' in
vpnc config you can change the name to something more descriptice.
The vpnc part has been merge with some changes. So questions arise:
* Do you want to update the UI file for GTK+ 3.4 and get an updated patch for
that?
I just did that and pushed it. Perhaps you wanted to do it yourself? :)
But it's really tedious and I figured you didn't...
* Do you want the interface name widget on Advanced dialog? I suppose yes.
Yeah, lets do that, on the first tab page where stuff like ports and
tun/tap are.
* Any other changes?
One other style change, when there's code like:
+ g_object_set (G_OBJECT (s_con),
+ NM_SETTING_CONNECTION_INTERFACE_NAME,
str, NULL);
if it all fits on one line within about 100 characters, then let's put
it on one line. If it's longer than that, then multi-line, but in that
case lets do some { } and align it like so (two places to do this...):
+ if (str strlen (str)) {
+ g_object_set (G_OBJECT (s_con),
+ NM_SETTING_CONNECTION_INTERFACE_NAME, str,
+ NULL);
+ }
Sound OK? Thanks!
Dan
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH 1/1] openvpn: add support to change interface name
Dan Williams d...@redhat.com on Wed, 2014/10/01 09:19:
On Tue, 2014-09-30 at 21:07 +0200, Christian Hesse wrote:
Christian Hesse m...@eworm.de on Mon, 2014/09/29 14:46:
By default interface name is 'tun' or 'tap' with an incrementing number
(tun0, tun1, ... or tap0, tap1, ...). By specifying 'Interface name' in
vpnc config you can change the name to something more descriptice.
The vpnc part has been merge with some changes. So questions arise:
* Do you want to update the UI file for GTK+ 3.4 and get an updated patch
for that?
I just did that and pushed it. Perhaps you wanted to do it yourself? :)
But it's really tedious and I figured you didn't...
No, I did not. ;)
* Do you want the interface name widget on Advanced dialog? I suppose yes.
Yeah, lets do that, on the first tab page where stuff like ports and
tun/tap are.
Done.
Though this does not (yet) have a checkbox. Do we want that? Requires some
callback function then, no?
* Any other changes?
One other style change, when there's code like:
+ g_object_set (G_OBJECT (s_con),
+ NM_SETTING_CONNECTION_INTERFACE_NAME,
str, NULL);
if it all fits on one line within about 100 characters, then let's put
it on one line. If it's longer than that, then multi-line, but in that
case lets do some { } and align it like so (two places to do this...):
+ if (str strlen (str)) {
+ g_object_set (G_OBJECT (s_con),
+ NM_SETTING_CONNECTION_INTERFACE_NAME, str,
+ NULL);
+ }
Sound OK? Thanks!
Sure. I did break lines whenever I felt it was too long. And I made it look
ok in relation to the surrounding code. Within about 100 characters is not
that precise... ;)
I will reply with a new patch soon.
--
Schoene Gruesse
Chris
O ascii ribbon campaign
stop html mail - www.asciiribbon.org
signature.asc
Description: PGP signature
___
networkmanager-list mailing list
networkmanager-list@gnome.org
https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH 1/1] openvpn: add support to change interface name
Christian Hesse m...@eworm.de on Wed, 2014/10/01 21:47: Dan Williams d...@redhat.com on Wed, 2014/10/01 09:19: On Tue, 2014-09-30 at 21:07 +0200, Christian Hesse wrote: Christian Hesse m...@eworm.de on Mon, 2014/09/29 14:46: * Do you want the interface name widget on Advanced dialog? I suppose yes. Yeah, lets do that, on the first tab page where stuff like ports and tun/tap are. Done. Though this does not (yet) have a checkbox. Do we want that? Requires some callback function then, no? Uh, I spoke too soon. Do I have to handle GHashTable to get my information to and from advanced dialog? Looks a lot more complicated than I thought. -- Schoene Gruesse Chris O ascii ribbon campaign stop html mail - www.asciiribbon.org signature.asc Description: PGP signature ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: RTL8188SU(rtl8192su) - unavailable
On 29.09.2014 21:46, Dan Williams wrote: On Mon, 2014-09-29 at 11:29 +0200, poma wrote: [platform/nm-platform.c:806] nm_platform_link_set_up(): link: setting up 'wlp0s4f1u1' (4) [platform/nm-linux-platform.c:2356] link_change_flags(): link: change 4: flags set 'up' (1) [platform/nm-linux-platform.c:2250] link_change(): Netlink error changing link 4: UP mtu 0 (1) driver 'rtl8192su' udi '/sys/devices/pci:00/:00:04.1/usb2/2-1/2-1:1.0/net/wlp0s4f1u1': No such device (wlp0s4f1u1): preparing device This is likely the core problem, and it's also probably the cause of the wpa_supplicant failures too. You can test this out without NM running by simply doing: ifconfig wlp0s4f1u1 up and see if it returns an error or not. Does it? Does anything show up in 'dmesg'? If we can't get 'ifconfig up' working for the device, clearly NM won't work either... Dan It's OK Dan, NM ain't problem. WIP encore party [ cut here ] WARNING: CPU: 1 PID: 867 at /rtl8192su/rtlwifi/rtl8192s/phy_common.c:1313 rtl92s_phy_chk_fwcmd_iodone+0x61/0x70 [rtl8192s_common]() Modules linked in: ... rtl8192su(OE) rtl8192s_common(OE) rtl_usb(OE) rtlwifi(OE) mac80211 cfg80211 ... CPU: 1 PID: 867 Comm: wpa_supplicant Tainted: G OE 3.17.0-0.rc7.git0.2.fc21.x86_64 #1 Call Trace: [8173c1f1] dump_stack+0x45/0x56 [81096e9d] warn_slowpath_common+0x7d/0xa0 [81096fca] warn_slowpath_null+0x1a/0x20 [a05b3b71] rtl92s_phy_chk_fwcmd_iodone+0x61/0x70 [rtl8192s_common] [a05b5871] rtl92s_phy_set_fw_cmd+0x131/0x780 [rtl8192s_common] [a05b5efa] rtl92s_phy_scan_operation_backup+0x3a/0x40 [rtl8192s_common] [a043054c] rtl_op_sw_scan_start+0x8c/0xe0 [rtlwifi] [a051b63f] __ieee80211_start_scan+0x34f/0x5d0 [mac80211] [a051c4a0] ieee80211_request_scan+0x30/0x50 [mac80211] [a052b838] ieee80211_scan+0x68/0xc0 [mac80211] [a04b7dab] nl80211_trigger_scan+0x5bb/0x640 [cfg80211] [816604ac] genl_family_rcv_msg+0x1bc/0x3e0 [8161cc7b] ? __alloc_skb+0x5b/0x200 [816606d0] ? genl_family_rcv_msg+0x3e0/0x3e0 [81660749] genl_rcv_msg+0x79/0xc0 [8165fd59] netlink_rcv_skb+0xa9/0xd0 [816602d8] genl_rcv+0x28/0x40 [8165f37a] netlink_unicast+0x12a/0x1a0 [8165f741] netlink_sendmsg+0x351/0x7b0 [8130f9f2] ? sock_has_perm+0x72/0x90 [816132fe] sock_sendmsg+0x9e/0xe0 [81612fce] ? move_addr_to_kernel.part.20+0x1e/0x70 [81613ed1] ? move_addr_to_kernel+0x21/0x30 [81613768] ___sys_sendmsg+0x3c8/0x3e0 [810a5e86] ? __set_current_blocked+0x36/0x60 [8101f67e] ? fpu_finit+0x1e/0x30 [8101f8e1] ? init_fpu+0x51/0xb0 [81020b58] ? __restore_xstate_sig+0x268/0x660 [81013745] ? do_signal+0x1a5/0x6f0 [81614681] __sys_sendmsg+0x51/0x90 [816146d2] SyS_sendmsg+0x12/0x20 [81743369] system_call_fastpath+0x16/0x1b ---[ end trace 561080c39bcc6e50 ]--- [ cut here ] WARNING: CPU: 2 PID: 81 at /rtl8192su/rtlwifi/rtl8192s/phy_common.c:1313 rtl92s_phy_chk_fwcmd_iodone+0x61/0x70 [rtl8192s_common]() CPU: 2 PID: 81 Comm: kworker/u8:6 Tainted: GW OE 3.17.0-0.rc7.git0.2.fc21.x86_64 #1 Workqueue: phy0 ieee80211_scan_work [mac80211] Call Trace: [8173c1f1] dump_stack+0x45/0x56 [81096e9d] warn_slowpath_common+0x7d/0xa0 [81096fca] warn_slowpath_null+0x1a/0x20 [a05b3b71] rtl92s_phy_chk_fwcmd_iodone+0x61/0x70 [rtl8192s_common] [a05b5871] rtl92s_phy_set_fw_cmd+0x131/0x780 [rtl8192s_common] [a05b5eeb] rtl92s_phy_scan_operation_backup+0x2b/0x40 [rtl8192s_common] [a042fd9b] rtl_op_sw_scan_complete+0x6b/0xa0 [rtlwifi] [a051b1ba] __ieee80211_scan_completed+0x1ea/0x320 [mac80211] [81012691] ? __switch_to+0x191/0x5f0 [a051c06d] ieee80211_scan_work+0xdd/0x4e0 [mac80211] [810af67d] process_one_work+0x14d/0x400 [810b000b] worker_thread+0x6b/0x4a0 [810affa0] ? rescuer_thread+0x2a0/0x2a0 [810b50ea] kthread+0xea/0x100 [810b5000] ? kthread_create_on_node+0x1a0/0x1a0 [817432bc] ret_from_fork+0x7c/0xb0 [810b5000] ? kthread_create_on_node+0x1a0/0x1a0 ---[ end trace 561080c39bcc6e51 ]--- [ cut here ] WARNING: CPU: 2 PID: 867 at /rtl8192su/rtlwifi/rtl8192s/phy_common.c:1313 rtl92s_phy_chk_fwcmd_iodone+0x61/0x70 [rtl8192s_common]() CPU: 2 PID: 867 Comm: wpa_supplicant Tainted: GW OE 3.17.0-0.rc7.git0.2.fc21.x86_64 #1 Call Trace: [8173c1f1] dump_stack+0x45/0x56 [81096e9d] warn_slowpath_common+0x7d/0xa0 [81096fca] warn_slowpath_null+0x1a/0x20 [a05b3b71] rtl92s_phy_chk_fwcmd_iodone+0x61/0x70 [rtl8192s_common] [a05b5871] rtl92s_phy_set_fw_cmd+0x131/0x780 [rtl8192s_common] [a05b5efa] rtl92s_phy_scan_operation_backup+0x3a/0x40
