Re: [review] th/keyfile
On Sun, 2015-03-15 at 18:49 +0100, Thomas Haller wrote: On Fri, 2015-03-13 at 13:20 -0500, Dan Williams wrote: Hi Thomas, About th/keyfile... libnm: add _nm_utils_hash_values_to_ptrarray() function What about g_hash_table_get_values() instead? It returns the values as a GList* instead of a GPtrArray, were you just worried about memory allocation here? I forgot about g_hash_table_get_values(), but yes, the idea was to keep additional overhead small. I refactored it again, so that no malloc is needed. Repushed. The rest looks OK to me. Do we need to update any testcases for the sort ordering? I think not, they still work for me. The sort order before was unspecified. merged as http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=89c88f24805f6092ea0f9725556fb9944316467f Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [review] th/keyfile
On Fri, 2015-03-13 at 13:20 -0500, Dan Williams wrote: Hi Thomas, About th/keyfile... libnm: add _nm_utils_hash_values_to_ptrarray() function What about g_hash_table_get_values() instead? It returns the values as a GList* instead of a GPtrArray, were you just worried about memory allocation here? I forgot about g_hash_table_get_values(), but yes, the idea was to keep additional overhead small. I refactored it again, so that no malloc is needed. Repushed. The rest looks OK to me. Do we need to update any testcases for the sort ordering? I think not, they still work for me. The sort order before was unspecified. Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [review] th/keyfile
Hi Thomas, About th/keyfile... libnm: add _nm_utils_hash_values_to_ptrarray() function What about g_hash_table_get_values() instead? It returns the values as a GList* instead of a GPtrArray, were you just worried about memory allocation here? The rest looks OK to me. Do we need to update any testcases for the sort ordering? Dan ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
