Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes
On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote: > Use DBus to make nameserver updates rather than restarting the > dnsmasq binary > again and again. > > Signed-off-by: Mathieu Trudel-Lapierre ical.com> For the record: The patch got merged to master [1] and bug https://bugzilla.gnome.org/show_bug.cgi?id=765043 is resolved. [1] https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=497a8aa5c6463404200a3fcc745aa65396dc4f22 Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes
On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote: > Use DBus to make nameserver updates rather than restarting the > dnsmasq binary > again and again. > > Signed-off-by: Mathieu Trudel-Lapierre ical.com> Hi, I opened a bug for this patch. https://bugzilla.gnome.org/show_bug.cgi?id=765043 And you'll find the code at https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=th/dnsmasq-dbus-bgo765043 Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes
On Tue, 2016-03-22 at 12:44 -0400, Mathieu Trudel-Lapierre wrote: > On Tue, Mar 22, 2016 at 12:33 PM, Thomas Haller > wrote: > [...] > > Hi Mathieu, > > > [...] > > Can I give it back to you in this form and let's take it from > > there? > Sure, but what changes would you like to see? > > [...] > > I dislike a bit the builder-member > > GVariantBuilder *servers; > > Could we instead make it a > > GVariant *set_server_ex_args; > > > It seems rather better to me (or at least much easier to handle) to > build one large array of array of string to pass to SetServersEx once > via a GVariantBuilder (which allows us to add just like if it was a > simple array), rather than mucking with one large unwieldy GVariant > -- with GVariantBuilder, you can open a subcontainer and add into it. > > I guess the jist of it is that it seems to me like easier to maintain > down the line, provided it is technically correct-- and I have used > pretty much the code from examples in GLib documentation. I pushed another commit to the branch, to show what I mean. Feel free to drop that. Actually, I pushed more changes... :) I also dropped passing CONFFILE. Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes
On Tue, Mar 22, 2016 at 12:33 PM, Thomas Haller wrote: [...] > Hi Mathieu, > > [...] > Can I give it back to you in this form and let's take it from there? > Sure, but what changes would you like to see? [...] > I dislike a bit the builder-member > GVariantBuilder *servers; > Could we instead make it a > GVariant *set_server_ex_args; > It seems rather better to me (or at least much easier to handle) to build one large array of array of string to pass to SetServersEx once via a GVariantBuilder (which allows us to add just like if it was a simple array), rather than mucking with one large unwieldy GVariant -- with GVariantBuilder, you can open a subcontainer and add into it. I guess the jist of it is that it seems to me like easier to maintain down the line, provided it is technically correct-- and I have used pretty much the code from examples in GLib documentation. -- Mathieu Trudel-Lapierre Freenode: cyphermox, Jabber: mathieu...@gmail.com 4096R/65B58DA1 818A D123 0992 275B 23C2 CF89 C67B B4D6 65B5 8DA1 ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [PATCH] dns: use DBus to make dnsmasq nameserver changes
On Tue, 2016-03-22 at 10:03 -0400, Mathieu Trudel-Lapierre wrote: > Use DBus to make nameserver updates rather than restarting the > dnsmasq binary > again and again. > > Signed-off-by: Mathieu Trudel-Lapierre lapie...@canonical.com> Hi Mathieu, I picked one part of this patch and pushed it as https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=2bb769cf10ab9c19c1690753405352a0f7082dde After that, I did a few minor changes to nm-dns-manager for things I disliked in the existing code. Your patch still mostly applies. Anyway, I took your patch and pushed it to a branch for easier(?) review and sharing. https://cgit.freedesktop.org/NetworkManager/NetworkManager/log/?h=th/dnsmasq-dbus And I added a few fixup commits for style issues and minor bugs. Can I give it back to you in this form and let's take it from there? I dislike a bit the builder-member GVariantBuilder *servers; Could we instead make it a GVariant *set_server_ex_args; Thomas signature.asc Description: This is a digitally signed message part ___ networkmanager-list mailing list networkmanager-list@gnome.org https://mail.gnome.org/mailman/listinfo/networkmanager-list
