Re: [patch] more stetic, broken up, 2/2
Bryan Clark wrote: So that was definitely done purposefully, here's why. :-) We didn't use a disabled menu item because those are reserved for items that will _eventually_ become enabled. In your menus the items are either enabled, disabled with a possibility of becoming enabled, or not there at all. Since the 'Wireless Networks' item never actually becomes enabled we opted to leave it normal. Opposite is the 'Wired Network' menu which does become enabled when you have a wired connection, and thus we felt a disabled item was perfect for that. To make the Wireless Network item stand out as "something you won't be clicking on", we centered it. The centering also gives a header style look to it that I think works. I don't know if GTK supports this, but HTML 4 lets you group drop-down menu items together by indenting them beneath a non-selectable title item. The product menu on mozilla.org's Bugzilla search page is a good example. Seems like that would be an effective solution here, too. -myk ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch] more stetic, broken up, 2/2
On Fri, 2005-06-17 at 12:43 -0400, David Zeuthen wrote: > Hey, > > So while we're talking about UI and stuff how about combining the Right > and Left click context menus? I always end up pressing the wrong one. Part of the problem with this is that certain options (I would argue everything in the right-click menu, from the different scanning options to Stop All wireless Devices) are things that you really shouldn't ahve to touch, and hence shouldn't be in the main menu. its better to stick those somewhere people who really need to can get at them. Perhaps a capplet or something... IMHO, they don't belong in the main menu since you shouldn't really have to touch them more than a couple times (in the best case). Dan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch] more stetic, broken up, 2/2
On Fri, 2005-06-17 at 12:50 -0400, Robert Love wrote: > On Fri, 2005-06-17 at 12:43 -0400, David Zeuthen wrote: > > > So while we're talking about UI and stuff how about combining the Right > > and Left click context menus? I always end up pressing the wrong one. > > That was next on my list. I don't like having both. Totally > non-stetic, dudes. Would that be "dynemic"? :-P ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch] more stetic, broken up, 2/2
On Fri, 2005-06-17 at 12:43 -0400, David Zeuthen wrote: > So while we're talking about UI and stuff how about combining the Right > and Left click context menus? I always end up pressing the wrong one. That was next on my list. I don't like having both. Totally non-stetic, dudes. Robert Love ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch] more stetic, broken up, 2/2
Hey, So while we're talking about UI and stuff how about combining the Right and Left click context menus? I always end up pressing the wrong one. David ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch] more stetic, broken up, 2/2
On Thu, 2005-06-16 at 21:50 -0400, Bryan Clark wrote: > So that was definitely done purposefully, here's why. :-) We didn't use > a disabled menu item because those are reserved for items that will > _eventually_ become enabled. In your menus the items are either > enabled, disabled with a possibility of becoming enabled, or not there > at all. Since the 'Wireless Networks' item never actually becomes > enabled we opted to leave it normal. Opposite is the 'Wired Network' > menu which does become enabled when you have a wired connection, and > thus we felt a disabled item was perfect for that. To make the Wireless > Network item stand out as "something you won't be clicking on", we > centered it. The centering also gives a header style look to it that I > think works. So you disagree with the greying-out, the centering, and the horizontal separator? It seems to me that we are already breaking rules--having a menu item that is never selectable and is actually just a heading. I guess I don't think that the greying-out confuses users as much as the non-greyed-out-centered label is non-stetic. ;-) Robert Love ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
Re: [patch] more stetic, broken up, 2/2
Hi ~ On Thu, 2005-06-16 at 21:32 -0400, Robert Love wrote: > Meanwhile, this patch includes the following changes: > > - Don't center the "Wireless Networks" menu item. > - Actually make the "Wireless Networks" menu item inactive. > I realize this was done deliberately (with the nasty signal > hack), but the thing /is/ insensitive, unselectable, and a > label, not a menu item. The greyed-out look is in. > - Use gtk_menu_new_with_label(), not the previous complications. So that was definitely done purposefully, here's why. :-) We didn't use a disabled menu item because those are reserved for items that will _eventually_ become enabled. In your menus the items are either enabled, disabled with a possibility of becoming enabled, or not there at all. Since the 'Wireless Networks' item never actually becomes enabled we opted to leave it normal. Opposite is the 'Wired Network' menu which does become enabled when you have a wired connection, and thus we felt a disabled item was perfect for that. To make the Wireless Network item stand out as "something you won't be clicking on", we centered it. The centering also gives a header style look to it that I think works. I didn't pay attention to what was done to make that magic happen in the code, but I definitely think it's better to not make it a disabled menu item. The non-greyed-out look is retro these days and soon will be mainstream, at which point we'll be too cool for it and leave it. > - Consolidate a few seemingly related functions, all called from > the same place once, into one. That sounds cool to me... > - Draw a horizontal separator above the "Wireless Networks" > label. The line I think is a little excessive to add it. It makes the whole menu look very boxy, especially without the other label change. Cheers, ~ Bryan ___ NetworkManager-list mailing list NetworkManager-list@gnome.org http://mail.gnome.org/mailman/listinfo/networkmanager-list
