[GitHub] ctubbsii commented on a change in pull request #465: Initial ideas for new Encryption interface
ctubbsii commented on a change in pull request #465: Initial ideas for new
Encryption interface
URL: https://github.com/apache/accumulo/pull/465#discussion_r186585853
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -45,78 +45,14 @@
// Crypto-related properties
@Experimental
CRYPTO_PREFIX("crypto.", null, PropertyType.PREFIX,
- "Properties in this category related to the configuration of both
default and custom crypto"
- + " modules."),
+ "Properties related to encryption."),
Review comment:
I'm saying 1) I like the shortening of the description, but 2) I think it
should say something like "Properties related to on-disk file encryption" or
"Properties related to encryption-at-rest" or whatever makes the most sense to
clarify that it's separate from the RPC encryption properties.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186583239 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides Review comment: Although added to check for overrides, the profile activates errorprone compiler, and should probably be named `use-errorprone` or `compile-with-errorprone` or similar. Also, it might be worth adding a brief XML comment at the top of the profile (above the ``) to briefly explain what the profile is for. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186583455 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides + + + +org.apache.maven.plugins +maven-compiler-plugin + + javac-with-errorprone + true + 1.8 + 1.8 + +-XepDisableAllChecks +-Xep:MissingOverride:ERROR + -XepExcludedPaths:.*/(proto|thrift|generated-sources)/.* + + true Review comment: Isn't showWarnings already the default? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186583393 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides + + + +org.apache.maven.plugins +maven-compiler-plugin + + javac-with-errorprone + true + 1.8 Review comment: Should not override the source/target versions already set in the parent POM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438 URL: https://github.com/apache/accumulo/pull/456#discussion_r186582484 ## File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java ## @@ -135,14 +135,15 @@ public static AccumuloConfiguration getAccumuloConfiguration(Class implementi * @param conf * the Hadoop configuration object to configure * @param compressionType - * one of "none", "gz", "lzo", or "snappy" + * one of "none", "gz", "lzo", "snappy", or "zst" Review comment: Oh, also, we don't name our files following the compressor naming conventions anyway. It's always `.rf` regardless of compression type. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438 URL: https://github.com/apache/accumulo/pull/456#discussion_r186582102 ## File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java ## @@ -135,14 +135,15 @@ public static AccumuloConfiguration getAccumuloConfiguration(Class implementi * @param conf * the Hadoop configuration object to configure * @param compressionType - * one of "none", "gz", "lzo", or "snappy" + * one of "none", "gz", "lzo", "snappy", or "zst" Review comment: If we don't need to truncate it to `zst` for Hadoop compatibility, then I think `zstd` is better since it's used everywhere pretty consistently: * https://github.com/facebook/zstd * http://www.zstd.net * libzstd-1.3.4-1.fc28.x86_64 * zstd-1.3.4-1.fc28.x86_64 * "Zstd, short for Zstandard, is a fast lossless compression algorithm, targeting real-time compression scenarios at zlib-level compression ratio." * /usr/lib64/libzstd.so.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
ctubbsii commented on a change in pull request #456: Add ZStandard compression
codec. Fixes #438
URL: https://github.com/apache/accumulo/pull/456#discussion_r186581545
##
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
##
@@ -456,6 +458,122 @@ public boolean isSupported() {
return snappyCodec != null;
}
+},
+
+ZSTANDARD(COMPRESSION_ZSTD) {
Review comment:
Oh, interesting. I assumed Hadoop supported snappy already.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Accumulo-Pull-Requests - Build # 1193 - Still Failing
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1193) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1193/ to view the results.
Accumulo-Master - Build # 2341 - Fixed
The Apache Jenkins build system has built Accumulo-Master (build #2341) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Master/2341/ to view the results.
Accumulo-Pull-Requests - Build # 1192 - Failure
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1192) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1192/ to view the results.
Accumulo-Pull-Requests - Build # 1191 - Fixed
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1191) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1191/ to view the results.
[GitHub] jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186537462 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides + + + +org.apache.maven.plugins +maven-compiler-plugin + + javac-with-errorprone + true + 1.8 + 1.8 + +-XepDisableAllChecks +-Xep:MissingOverride:ERROR + -XepExcludedPaths:.*/(proto|thrift|generated-sources)/.* Review comment: Looking a little more into this, I'm not sure that is going to be sufficient. I re-ran using the XepDisableWarningsInGeneratedCode and the TRange.java file was flagged for multiple violations. But when I examined the file, it contains the expected annotation (@javax.annotation.Generated) and still gets flagged. Not sure if there is some buggy behavior in errorprone or if something else going on. Noticed the same behavior in a couple of more files. I may try search the web later and see if I find any info. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Accumulo-Pull-Requests - Build # 1190 - Still Failing
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1190) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1190/ to view the results.
Accumulo-Master - Build # 2340 - Still Failing
The Apache Jenkins build system has built Accumulo-Master (build #2340) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Master/2340/ to view the results.
[GitHub] keith-turner opened a new issue #477: -1 tablet log id used in WAL when table durability is set to None
keith-turner opened a new issue #477: -1 tablet log id used in WAL when table durability is set to None URL: https://github.com/apache/accumulo/issues/477 When a tables durability is set to none tablets get a tablet log id of -1. The durability can be set per batch writer and the table setting can be changed. Howerver when this change in durability happens, the tablet id in the WALs is still -1. This means that a tablet may recover data from other tablets because multiple tablets would be mapped to the same id of -1. I discovered this with changes I made for #458. My changes caused an IT to fail with this pre-existing bug. This bug may have existed since 1.7.0. This bug would only be seen when setting `table.durability=NONE` and then later changing it to something else. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] madrob commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
madrob commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186495874 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides + + + +org.apache.maven.plugins +maven-compiler-plugin + + javac-with-errorprone + true + 1.8 + 1.8 + +-XepDisableAllChecks +-Xep:MissingOverride:ERROR + -XepExcludedPaths:.*/(proto|thrift|generated-sources)/.* Review comment: Can we annotate generated code with the appropriate annotations? Seems like that would be useful for other static analysis tools we use as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186493042 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides + + + +org.apache.maven.plugins +maven-compiler-plugin + + javac-with-errorprone + true + 1.8 + 1.8 + +-XepDisableAllChecks +-Xep:MissingOverride:ERROR + -XepExcludedPaths:.*/(proto|thrift|generated-sources)/.* Review comment: Unfortunately, yes. That flag only ignores generated code if certain annotations are in the code. The majority of our generated code does not have the annotation and were not ignored. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] madrob commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
madrob commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186492164 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides + + + +org.apache.maven.plugins +maven-compiler-plugin + + javac-with-errorprone + true + 1.8 + 1.8 + +-XepDisableAllChecks +-Xep:MissingOverride:ERROR + -XepExcludedPaths:.*/(proto|thrift|generated-sources)/.* Review comment: Is this better than `-XepDisableWarningsInGeneratedCode`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Accumulo-Pull-Requests - Build # 1189 - Still Failing
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1189) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1189/ to view the results.
[jira] [Resolved] (ACCUMULO-2537) Add @Override Annotations
[ https://issues.apache.org/jira/browse/ACCUMULO-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Owens resolved ACCUMULO-2537. -- Resolution: Duplicate Duplicate of [https://github.com/apache/accumulo/pull/476.] > Add @Override Annotations > - > > Key: ACCUMULO-2537 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2537 > Project: Accumulo > Issue Type: Task >Reporter: Mike Drob >Assignee: Mark Owens >Priority: Trivial > Labels: newbie, pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > We should add @Override annotations to methods in our code. This can be > detected and fixed automatically using eclipse. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ACCUMULO-2537) Add @Override Annotations
[ https://issues.apache.org/jira/browse/ACCUMULO-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Owens reassigned ACCUMULO-2537: Assignee: Mark Owens > Add @Override Annotations > - > > Key: ACCUMULO-2537 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2537 > Project: Accumulo > Issue Type: Task >Reporter: Mike Drob >Assignee: Mark Owens >Priority: Trivial > Labels: newbie, pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > We should add @Override annotations to methods in our code. This can be > detected and fixed automatically using eclipse. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] jmark99 opened a new pull request #476: ACCUMULO-2537 Add @Override Annotations
jmark99 opened a new pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476 Added a profile 'overrides' to enforce use of the override annotation on required methods. Uses google errorprone to handle enforcement. It ignores the generated code in the project (i,e, thrift/proto/generated-sources). Findbugs/Spotbugs do not currently enable enforcement of the annotation, thus the use of errorprone. Initially setup as a profile to verify it works as expected and satisfies the goal of the annotation enforcement. Can be incorporated into standard build in the future if desired. Added the annotation to the necessary files in the process. Ignoring the generated code, there were not a huge number of missing annotations. There are currently 432 locations in the generated code that are missing the annotation. All other errorprone checks are disabled. There is a related ticket to examine possible use of errorprone as a general error detecting tool. This pull request replaces Jira ticket ACCUMULO-2537. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (ACCUMULO-2537) Add @Override Annotations
[ https://issues.apache.org/jira/browse/ACCUMULO-2537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated ACCUMULO-2537: - Labels: newbie pull-request-available (was: newbie) > Add @Override Annotations > - > > Key: ACCUMULO-2537 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2537 > Project: Accumulo > Issue Type: Task >Reporter: Mike Drob >Priority: Trivial > Labels: newbie, pull-request-available > > We should add @Override annotations to methods in our code. This can be > detected and fixed automatically using eclipse. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Accumulo-Pull-Requests - Build # 1188 - Still Failing
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1188) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1188/ to view the results.
Accumulo-Pull-Requests - Build # 1187 - Still Failing
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1187) Status: Still Failing Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1187/ to view the results.
[GitHub] milleruntime commented on a change in pull request #465: Initial ideas for new Encryption interface
milleruntime commented on a change in pull request #465: Initial ideas for new
Encryption interface
URL: https://github.com/apache/accumulo/pull/465#discussion_r186468929
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -45,78 +45,14 @@
// Crypto-related properties
@Experimental
CRYPTO_PREFIX("crypto.", null, PropertyType.PREFIX,
- "Properties in this category related to the configuration of both
default and custom crypto"
- + " modules."),
+ "Properties related to encryption."),
Review comment:
A little more for the description? Or you saying one of the properties
should be "data-at-rest"?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] milleruntime commented on issue #475: Monitor 2.0 Bulk Import State
milleruntime commented on issue #475: Monitor 2.0 Bulk Import State URL: https://github.com/apache/accumulo/issues/475#issuecomment-387111468 > We could put a message on the page saying it only tracks bulk imports made via the deprecated method. That was my thinking as well but I am not sure the old bulk import state tracking works with the new Monitor. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
milleruntime commented on a change in pull request #456: Add ZStandard
compression codec. Fixes #438
URL: https://github.com/apache/accumulo/pull/456#discussion_r186465747
##
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
##
@@ -456,6 +458,122 @@ public boolean isSupported() {
return snappyCodec != null;
}
+},
+
+ZSTANDARD(COMPRESSION_ZSTD) {
Review comment:
This is custom code, copied from our other enums. The Hadoop
Compression.java[1] that this was originally copied from has not changed (it
only has lzo and gz). I thought of refactoring this class since we have
branched off pretty far but that could be a follow on.
[1]
https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/file/tfile/Compression.java
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] keith-turner commented on issue #475: Monitor 2.0 Bulk Import State
keith-turner commented on issue #475: Monitor 2.0 Bulk Import State URL: https://github.com/apache/accumulo/issues/475#issuecomment-387109494 We could put a message on the page saying it only tracks bulk imports made via the deprecated method. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438 URL: https://github.com/apache/accumulo/pull/456#discussion_r186464090 ## File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java ## @@ -135,14 +135,15 @@ public static AccumuloConfiguration getAccumuloConfiguration(Class implementi * @param conf * the Hadoop configuration object to configure * @param compressionType - * one of "none", "gz", "lzo", or "snappy" + * one of "none", "gz", "lzo", "snappy", or "zst" Review comment: I went back and forth between those names. I had `zstd` everywhere until I saw this: https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/ZStandardCodec.java#L232 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime opened a new issue #475: Monitor 2.0 Bulk Import State
milleruntime opened a new issue #475: Monitor 2.0 Bulk Import State URL: https://github.com/apache/accumulo/issues/475 Follow on for #436 and for new Monitor. The Monitor had previously displayed (or attempted to) the state of Bulk import processes. Hopefully, for Bulk Import 2.0, this won't be needed. If so, then the bulk import page could be removed in Monitor 2.0. Otherwise we need to determine how/what to monitor for the new bulk import. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mikewalch closed pull request #82: Updated Uno & Muchos URLs
mikewalch closed pull request #82: Updated Uno & Muchos URLs
URL: https://github.com/apache/accumulo-website/pull/82
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/_posts/blog/2017-04-21-introducing-uno-and-muchos.md
b/_posts/blog/2017-04-21-introducing-uno-and-muchos.md
index 1c285938..ff081bee 100644
--- a/_posts/blog/2017-04-21-introducing-uno-and-muchos.md
+++ b/_posts/blog/2017-04-21-introducing-uno-and-muchos.md
@@ -24,8 +24,8 @@ pages.
Uno git repo.
```bash
-git clone https://github.com/astralway/uno.git
-cd uno
+git clone https://github.com/apache/fluo-uno.git
+cd fluo-uno
```
Uno works out of the box but it can be customized by modifying `conf/uno.conf`.
@@ -62,8 +62,8 @@ If you need a fresh cluster, you can run `uno setup accumulo`
again. To kill you
cloning its git repo.
```bash
-git clone https://github.com/astralway/muchos.git
-cd muchos
+git clone https://github.com/apache/fluo-muchos.git
+cd fluo-muchos
```
Before using Muchos, create `muchos.props` in `conf/` and edit it for your AWS
environment.
@@ -96,6 +96,6 @@ reference the [Ansible] code in Muchos to automate management
of their own clust
[install]: https://github.com/apache/accumulo/blob/master/INSTALL.md
[Hadoop]: https://hadoop.apache.org/
[Zookeeper]: https://zookeeper.apache.org/
-[Uno]: https://github.com/astralway/uno
-[Muchos]: https://github.com/astralway/muchos
+[Uno]: https://github.com/apache/fluo-uno
+[Muchos]: https://github.com/apache/fluo-muchos
[Ansible]: https://www.ansible.com/
diff --git a/_posts/blog/2018-03-22-view-metrics-in-grafana.md
b/_posts/blog/2018-03-22-view-metrics-in-grafana.md
index 63c14054..c99031bd 100644
--- a/_posts/blog/2018-03-22-view-metrics-in-grafana.md
+++ b/_posts/blog/2018-03-22-view-metrics-in-grafana.md
@@ -79,11 +79,11 @@ Metrics from Accumulo will be immediately viewable in
Grafana at [http://localho
be empty unless you have Accumulo running and configured to send data to
InfluxDB. When you start
sending data, you may need to refresh the dashboard page in the browser to
start viewing metrics.
-[Uno]: https://github.com/astralway/uno
+[Uno]: https://github.com/apache/fluo-uno
[metrics2]: {{ site.baseurl
}}/docs/2.0/administration/monitoring-metrics#hadoop-metrics2
[Graphite]: https://graphiteapp.org/
[Ganglia]: http://ganglia.sourceforge.net/
[monitor]: {{ site.baseurl }}/features/#screenshots
[Grafana]: http://grafana.org/
[InfluxDB]: https://influxdb.com/
-[dashboard]:
https://raw.githubusercontent.com/astralway/uno/master/conf/grafana/accumulo-dashboard.json
+[dashboard]:
https://raw.githubusercontent.com/apache/fluo-uno/master/conf/grafana/accumulo-dashboard.json
diff --git a/contributor/contributors-guide.md
b/contributor/contributors-guide.md
index 93021b28..bf3cbae2 100644
--- a/contributor/contributors-guide.md
+++ b/contributor/contributors-guide.md
@@ -655,7 +655,7 @@ Below are more projects with integration tests:
[manual]: {{ site.baseurl }}/{{ site.latest_minor_release
}}/accumulo_user_manual.html
[quickstart1x]: {{ site.baseurl }}/quickstart-1.x/
[quickstart2x]: {{ site.baseurl }}/quickstart-2.x/
-[Uno]: https://github.com/astralway/uno
+[Uno]: https://github.com/apache/fluo-uno
[get-involved]: {{ site.baseurl }}/get_involved
[git]: https://git-scm.com/
[github]: https://github.com/apache/accumulo
diff --git a/pages/related-projects.md b/pages/related-projects.md
index 920f05a1..a41dc9a1 100644
--- a/pages/related-projects.md
+++ b/pages/related-projects.md
@@ -63,7 +63,7 @@ enable higher-level graph algorithms and analytics.
Uno and Muchos
-[Uno](https://github.com/astralway/uno) and
[Muchos](https://github.com/astralway/muchos) provide automation for quickly
setting up Accumulo instances for testing. These project were created to
enable Fluo testing, but can be used to setup just Accumulo.
+[Uno](https://github.com/apache/fluo-uno) and
[Muchos](https://github.com/apache/fluo-muchos) provide automation for quickly
setting up Accumulo instances for testing. These project were created to
enable Fluo testing, but can be used to setup just Accumulo.
## User-Created Applications
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] keith-turner opened a new issue #474: Ensure all files are present in bulk import load mapping.
keith-turner opened a new issue #474: Ensure all files are present in bulk import load mapping. URL: https://github.com/apache/accumulo/issues/474 This is follow up work to #436.It would be nice to add a sanity check to the new bulk import code that ensures every file in the dir is represented in the load mapping file. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner opened a new issue #473: Bulk import scans all table metadata when removing load flags.
keith-turner opened a new issue #473: Bulk import scans all table metadata when removing load flags. URL: https://github.com/apache/accumulo/issues/473 This is follow up work to #436. When bulk import is complete, load flags are removed. To do this all table metadata is scanned. Could just scan the metadata range that was bulk imported to. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hlgp commented on a change in pull request #453: Add retry mechanism to AccumuloReloadingVFSClassLoader.
hlgp commented on a change in pull request #453: Add retry mechanism to
AccumuloReloadingVFSClassLoader.
URL: https://github.com/apache/accumulo/pull/453#discussion_r186449986
##
File path:
start/src/test/java/org/apache/accumulo/start/classloader/vfs/AccumuloReloadingVFSClassLoaderTest.java
##
@@ -135,6 +138,57 @@ public ClassLoader getClassLoader() {
arvcl.close();
}
+ @Test
+ public void testReloadingWithLongerTimeout() throws Exception {
+FileObject testDir = vfs.resolveFile(folder1.getRoot().toURI().toString());
+FileObject[] dirContents = testDir.getChildren();
+
+AccumuloReloadingVFSClassLoader arvcl = new
AccumuloReloadingVFSClassLoader(folderPath, vfs,
+new ReloadingClassLoader() {
+ @Override
+ public ClassLoader getClassLoader() {
+return ClassLoader.getSystemClassLoader();
+ }
+}, 1000, true);
+
+FileObject[] files = ((VFSClassLoader)
arvcl.getClassLoader()).getFileObjects();
+Assert.assertArrayEquals(createFileSystems(dirContents), files);
+
+// set retry settings sufficiently high such that reloading happens in the
first rounds
+arvcl.setMaxRetries(3);
+
+Class clazz1 = arvcl.getClassLoader().loadClass("test.HelloWorld");
+Object o1 = clazz1.newInstance();
+Assert.assertEquals("Hello World!", o1.toString());
+
+// Check that the class is the same before the update
+Class clazz1_5 = arvcl.getClassLoader().loadClass("test.HelloWorld");
+Assert.assertEquals(clazz1, clazz1_5);
+
+assertTrue(new File(folder1.getRoot(), "HelloWorld.jar").delete());
+
+// VFS-487 significantly wait to avoid failure
+Thread.sleep(7000);
+
+// Update the class
+FileUtils.copyURLToFile(this.getClass().getResource("/HelloWorld.jar"),
+folder1.newFile("HelloWorld2.jar"));
+
+// Wait for the monitor to notice
+// VFS-487 significantly wait to avoid failure
+Thread.sleep(7000);
+
+Class clazz2 = arvcl.getClassLoader().loadClass("test.HelloWorld");
Review comment:
Yes. I modified the test above to show that with insufficient retries
clazz1 does not equal clazz2.
In the new test, with more retries, clazz1 equals clazz2.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] keith-turner opened a new issue #472: Support bulk import into offline tables
keith-turner opened a new issue #472: Support bulk import into offline tables URL: https://github.com/apache/accumulo/issues/472 This is follow up work to #436. The new bulk import API could easily operate on an offline table. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner opened a new issue #471: Retry when conncurrent merge happens in bulk import.
keith-turner opened a new issue #471: Retry when conncurrent merge happens in bulk import. URL: https://github.com/apache/accumulo/issues/471 This is follow up work to #436. Currently, the new bulk import API detects concurrent merges and throws an exception. It would be better to retry. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner opened a new issue #470: Support new bulk import API in shell
keith-turner opened a new issue #470: Support new bulk import API in shell URL: https://github.com/apache/accumulo/issues/470 This is follow up work for #436. Need to support the new bulk import API in the shell. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner opened a new issue #469: Make bulk import metadata scan split tolerant
keith-turner opened a new issue #469: Make bulk import metadata scan split tolerant URL: https://github.com/apache/accumulo/issues/469 This is follow on work for #436. The metadata scan that is done for loading files should be split tolerant. The scan should check that the metadata table form a linked list and back up when it does not. The GC scans the metadata table like this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner commented on issue #458: fixes #449 fix two bugs with WAL recovery
keith-turner commented on issue #458: fixes #449 fix two bugs with WAL recovery URL: https://github.com/apache/accumulo/pull/458#issuecomment-387083473 Using these changes, a ~24hr test of CI w/ agitation completed with no data loss. There were 8 nodes runnning tservers and tservers were killed 279 times during the test. ``` org.apache.accumulo.test.continuous.ContinuousVerify$Counts REFERENCED=24169811377 UNREFERENCED=7532412 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
