[GitHub] [apisix-dashboard] bisakhmondal commented on issue #682: feature: support custom CPU quantity used for `manager api`
bisakhmondal commented on issue #682: URL: https://github.com/apache/apisix-dashboard/issues/682#issuecomment-793509670 Hi guys. I'm interested in working with the manager API. Could you please briefly explain the issue? I am not getting it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas closed pull request #3785: docs: updated to new users-wall in powered-by.md
iamayushdas closed pull request #3785: URL: https://github.com/apache/apisix/pull/3785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3760: feat: support the configuration of keepalive related parameters in config.yaml
membphis commented on issue #3760: URL: https://github.com/apache/apisix/issues/3760#issuecomment-793496859 We should support specifying more directive values: http://nginx.org/en/docs/http/ngx_http_upstream_module.html  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3788: docs: update the content of "Does APISIX have a console interface" in the FAQ doc
spacewander commented on a change in pull request #3788: URL: https://github.com/apache/apisix/pull/3788#discussion_r590014161 ## File path: docs/en/latest/FAQ.md ## @@ -41,7 +41,7 @@ APISIX is the highest performance API gateway with a single-core QPS of 23,000, ## Does APISIX have a console interface? -Yes, in version 0.6 we have dashboard built in, you can operate APISIX through the web interface. +Yes, APISIX has a powerful Dashboard, APISIX and [APISIX Dashboard](https://github.com/apache/apisix-dashboard) are independent projects, you can deploy [APISIX Dashboard](https://github.com/apache/apisix-dashboard) to operate APISIX through the web interface. Review comment: "APISIX has a powerful Dashboard,", the comma should be a period. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3785: docs: updated to new users-wall in powered-by.md
spacewander commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793478316 You need to search "how to squash git commit" with your favorite search engine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis edited a comment on pull request #3253: chore: fix spelling
membphis edited a comment on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-793477499 @Firstsawyou Do you have time to find out why the test case failed? You can submit a patch for @jbampton help him to finish this PR, many thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3253: chore: fix spelling
membphis commented on pull request #3253: URL: https://github.com/apache/apisix/pull/3253#issuecomment-793477499 @Firstsawyou Do you have time to find out why the test case failed? You can submit a patch for @jbampton help him to finish this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3785: docs: updated to new users-wall in powered-by.md
iamayushdas commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793474155 > > It seems that there have some historical changes > > all good now? @juzhiyuan @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1563: discuss: the "Host" in the active health check should be optional
membphis commented on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793473185 > IMO, "host" should be optional. agree this +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3726: [Discuss] standardize release guide & branch/tag relations
membphis commented on issue #3726: URL: https://github.com/apache/apisix/issues/3726#issuecomment-793470752 the new way is better than before. We can follow @Yiyiyimu 's suggestion +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis edited a comment on issue #1547: show the running step detail info about this API
membphis edited a comment on issue #1547: URL: https://github.com/apache/apisix-dashboard/issues/1547#issuecomment-793464065 > Here have feedbacks from AISPEECH. > > 1. the core point is that unpublished routes should only allow test traffic access, no official traffic can be put in. > 2. Suggestion: APISIX supports defining global test traffic characteristics, such as defining special fields in the request header to indicate that this is test traffic; route match is done in the full set of routes (including published routes and unpublished routes) when processing test traffic, and after testing and verifying that it meets expectations After testing and verifying that it meets expectations, then publish. > > cc @membphis @liuxiran to take a look looks good to me. we can implement this feature with a new APISIX plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #2258: bug: failed to match any routes"
spacewander closed issue #2258: URL: https://github.com/apache/apisix/issues/2258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1379: feature: add global name
spacewander closed issue #1379: URL: https://github.com/apache/apisix/issues/1379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1547: show the running step detail info about this API
membphis commented on issue #1547: URL: https://github.com/apache/apisix-dashboard/issues/1547#issuecomment-793464065 > Here have feedbacks from AISPEECH. > > 1. the core point is that unpublished routes should only allow test traffic access, no official traffic can be put in. > 2. Suggestion: APISIX supports defining global test traffic characteristics, such as defining special fields in the request header to indicate that this is test traffic; route match is done in the full set of routes (including published routes and unpublished routes) when processing test traffic, and after testing and verifying that it meets expectations After testing and verifying that it meets expectations, then publish. > > cc @membphis @liuxiran to take a look looks good to me. we can implement this feature by a new plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1557: feat: sync fields of `upstream` from APISIX
codecov-io edited a comment on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-791091588 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=h1) Report > Merging [#1557](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=desc) (72f856c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6b795db47d44f14ed7327fa30f0027ec266317b2?el=desc) (6b795db) will **decrease** coverage by `19.25%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1557 +/- ## === - Coverage 70.90% 51.64% -19.26% === Files 135 40 -95 Lines5485 2707 -2778 Branches 5830 -583 === - Hits 3889 1398 -2491 + Misses 1348 1128 -220 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.64% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | ... and [117 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1557/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=footer). Last update [6b795db...72f856c](https://codecov.io/gh/apache/apisix-dashboard/pull/1557?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1557: feat: sync fields of `upstream` from APISIX
nic-chen commented on pull request #1557: URL: https://github.com/apache/apisix-dashboard/pull/1557#issuecomment-793444587 @starsz @tokers please help review when you have time, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou opened a new pull request #3788: docs: update the content of "Does APISIX have a console interface" in the FAQ doc
Firstsawyou opened a new pull request #3788: URL: https://github.com/apache/apisix/pull/3788 ### What this PR does / why we need it: Update the content of `Does APISIX have a console interface` in the FAQ document. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3785: docs: updated to new users-wall in powered-by.md
iamayushdas commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793392893 > It seems that there have some historical changes all good now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3785: docs: updated to new users-wall in powered-by.md
juzhiyuan commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793390855 It seems that there have some historical changes 樂 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3785: docs: updated to new users-wall in powered-by.md
iamayushdas commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793383732 @juzhiyuan i have cleaned it now. check please :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1558: feat:Support duplicate one existing Route
LiteSun commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-793372617 > I will try to fix backend CI this afternoon. > @LiteSun could you please help for the FE? ok This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1561: feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo
nic-chen merged pull request #1561: URL: https://github.com/apache/apisix-dashboard/pull/1561 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1561: feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo
nic-chen commented on pull request #1561: URL: https://github.com/apache/apisix-dashboard/pull/1561#issuecomment-793368725 merged. thanks very much. @Jaycean This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo (#1561)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 6b795db feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo
(#1561)
6b795db is described below
commit 6b795db47d44f14ed7327fa30f0027ec266317b2
Author: JinChen <36916582+jayc...@users.noreply.github.com>
AuthorDate: Tue Mar 9 12:27:02 2021 +0800
feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo (#1561)
---
api/test/e2e/route_with_uri_uris_test.go | 116
api/test/e2enew/route/route_with_uri_uris_test.go | 127 ++
2 files changed, 127 insertions(+), 116 deletions(-)
diff --git a/api/test/e2e/route_with_uri_uris_test.go
b/api/test/e2e/route_with_uri_uris_test.go
deleted file mode 100644
index 60755a8..000
--- a/api/test/e2e/route_with_uri_uris_test.go
+++ /dev/null
@@ -1,116 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "net/http"
- "testing"
-)
-
-func TestRoute_with_valid_uri_uris(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc: "add route with valid uri",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "uri": "/hello",
- "upstream": {
- "type": "roundrobin",
- "nodes": [{
- "host": "172.16.238.20",
- "port": 1980,
- "weight": 1
- }]
- }
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- },
- {
- Desc: "hit the route (r1)",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello",
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "delete the route (r1)",
- Object: ManagerApiExpect(t),
- Method: http.MethodDelete,
- Path: "/apisix/admin/routes/r1",
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- Sleep:sleepTime,
- },
- {
- Desc: "add route with valid uris",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "uris": ["/hello","/status"],
- "upstream": {
- "type": "roundrobin",
- "nodes": [{
- "host": "172.16.238.20",
- "port": 1980,
- "weight": 1
- }]
- }
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
-
[GitHub] [apisix] spacewander commented on pull request #3785: docs: updated to new users-wall in powered-by.md
spacewander commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793367247 @iamayushdas Please fix it now. No "next time". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] anjia0532 removed a comment on pull request #1566: fix(doc): fix some document url
anjia0532 removed a comment on pull request #1566: URL: https://github.com/apache/apisix-dashboard/pull/1566#issuecomment-793342426 but not found plugin's document href  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-793362163 > > > > > can we add a logic in create/update API to set the name from url params if it does not exists in the request body? > > > > > > > > > > > > oh, no, we should not do that. > > > > we could fix in test cases which do duplicate. I think there will not be a lot, because most of test cases will delete the routes at the end. > > > > > > > > > ok, can you help to fix the rest test cases, thanks > > > > > > sure, my pleasure. will update later. > > thanks. I have squashed all my test case commits into one commit, and rebased from master (which includes the latest frontend e2e fix), but the test case still failed I will try to fix backend CI this afternoon. @LiteSun could you please help for the FE? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1563: discuss: the "Host" in the active health check should be optional
nic-chen commented on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793359859 > IMO, "host" should be optional. > @nic-chen @membphis please check the lua-resty-healthcheck. > @Firstsawyou this issue should @ to apisix too. It is not just a FE issue OK, I will check the lib ` lua-resty-healthcheck` to confirm it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas commented on pull request #3785: docs: updated to new users-wall in powered-by.md
iamayushdas commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793358495 > Hi, would you please clean your commits history would take care of it next time. please review it this time This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass opened a new issue #3787: [discuss]: does the traffic-split plugin has a way to implement the original capabilities without corrupting the data?
tzssangglass opened a new issue #3787: URL: https://github.com/apache/apisix/issues/3787 ### Issue description prerequisite: the traffic-split plugin now controls the request proxy to a specific upstream by corrupting the upstream configuration in the route. topic: is there a way to do the same thing without corrupting the upstream configuration in the route? if there are problems with the prerequisite, please correct me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1565: The upstream timeout unit is seconds instead of milliseconds
nic-chen commented on issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565#issuecomment-793357991 thanks for feedback, we will recheck it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1561: feat: rewrite e2e test(route_with_uri_uris_test) with ginkgo
codecov-io edited a comment on pull request #1561: URL: https://github.com/apache/apisix-dashboard/pull/1561#issuecomment-792275760 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=h1) Report > Merging [#1561](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=desc) (d871880) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **increase** coverage by `3.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1561 +/- ## == + Coverage 70.18% 73.24% +3.05% == Files 130 86 -44 Lines5340 2321-3019 Branches 549 583 +34 == - Hits 3748 1700-2048 + Misses 1344 621 -723 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.24% <ø> (+1.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=) | `100.00% <0.00%> (ø)` | | | [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | `100.00% <0.00%> (ø)` | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | ... and [57 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1561/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=footer). Last update [9130e09...d871880](https://codecov.io/gh/apache/apisix-dashboard/pull/1561?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1566: fix(doc): fix some document url
codecov-io commented on pull request #1566: URL: https://github.com/apache/apisix-dashboard/pull/1566#issuecomment-793356441 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=h1) Report > Merging [#1566](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=desc) (6e3555c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/6dce9e09640b1c81f14dbb88e5f6f8c43371af31?el=desc) (6dce9e0) will **increase** coverage by `2.50%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1566 +/- ## == + Coverage 70.82% 73.33% +2.50% == Files 135 86 -49 Lines5485 2321-3164 Branches 583 583 == - Hits 3885 1702-2183 + Misses 1352 619 -733 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.33% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=) | `52.94% <ø> (ø)` | | | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | `83.70% <ø> (ø)` | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | | | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | ... and [41 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1566/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=footer). Last update [6dce9e0...6e3555c](https://codecov.io/gh/apache/apisix-dashboard/pull/1566?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
nic-chen commented on pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560#issuecomment-793355574 merged. thanks a lot. @Jaycean This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
nic-chen merged pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo (#1560)
This is an automated email from the ASF dual-hosted git repository.
chenjunxu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 39e0370 feat: rewrite e2e test(route-with-valid-remote-addr-test)
with ginkgo (#1560)
39e0370 is described below
commit 39e03706ee0492f2f00c69e1917633cd74df818e
Author: JinChen <36916582+jayc...@users.noreply.github.com>
AuthorDate: Tue Mar 9 12:09:44 2021 +0800
feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
(#1560)
---
api/test/e2e/route_with_valid_remote_addr_test.go | 197 -
.../route/route_with_valid_remote_addr_test.go | 181 +++
2 files changed, 181 insertions(+), 197 deletions(-)
diff --git a/api/test/e2e/route_with_valid_remote_addr_test.go
b/api/test/e2e/route_with_valid_remote_addr_test.go
deleted file mode 100644
index 8c5f130..000
--- a/api/test/e2e/route_with_valid_remote_addr_test.go
+++ /dev/null
@@ -1,197 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package e2e
-
-import (
- "net/http"
- "testing"
-)
-
-func TestRoute_with_valid_remote_addr(t *testing.T) {
- tests := []HttpTestCase{
- {
- Desc: "add route with valid remote_addr",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "uri": "/hello",
- "remote_addr": "172.16.238.1",
- "upstream": {
- "type": "roundrobin",
- "nodes": [{
- "host": "172.16.238.20",
- "port": 1980,
- "weight": 1
- }]
- }
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello",
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- ExpectBody: "hello world",
- Sleep:sleepTime,
- },
- {
- Desc: "update route with valid remote_addr (CIDR)",
- Object: ManagerApiExpect(t),
- Method: http.MethodPut,
- Path: "/apisix/admin/routes/r1",
- Body: `{
- "uri": "/hello",
- "remote_addr": "172.16.238.1/24",
- "upstream": {
- "type": "roundrobin",
- "nodes": [{
- "host": "172.16.238.20",
- "port": 1980,
- "weight": 1
- }]
- }
- }`,
- Headers: map[string]string{"Authorization": token},
- ExpectStatus: http.StatusOK,
- },
- {
- Desc: "verify route",
- Object: APISIXExpect(t),
- Method: http.MethodGet,
- Path: "/hello",
- Headers:
[GitHub] [apisix-dashboard] anjia0532 commented on pull request #1566: fix(doc): fix some document url
anjia0532 commented on pull request #1566: URL: https://github.com/apache/apisix-dashboard/pull/1566#issuecomment-793342426 but not found plugin's document href  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] anjia0532 opened a new pull request #1566: fix(doc): fix some document url
anjia0532 opened a new pull request #1566: URL: https://github.com/apache/apisix-dashboard/pull/1566 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description some document is Outdated,fix it - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Please add the corresponding test cases if necessary. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
codecov-io edited a comment on pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560#issuecomment-791589509 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=h1) Report > Merging [#1560](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=desc) (81a54a4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `1.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1560 +/- ## == - Coverage 70.18% 69.12% -1.07% == Files 130 49 -81 Lines5340 3164-2176 Branches 5490 -549 == - Hits 3748 2187-1561 + Misses 1344 729 -615 Partials 248 248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `55.68% <ø> (ø)` | | | backend-e2e-test-ginkgo | `39.91% <ø> (+0.31%)` | :arrow_up: | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Plugin/PluginMarket.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vUGx1Z2luTWFya2V0LnRzeA==) | | | | [web/src/pages/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vc2VydmljZS50cw==) | | | | [web/src/pages/Service/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TZXJ2aWNlL0NyZWF0ZS50c3g=) | | | | [web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4) | | | | [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | | | [web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9nbG9iYWwudHN4) | | | | [web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=) | | | | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | | | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | | | | [.../Route/components/DebugViews/DebugFormDataView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdGb3JtRGF0YVZpZXcudHN4) | | | | ... and [71 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=footer). Last update [9130e09...81a54a4](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
codecov-io edited a comment on pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560#issuecomment-791589509 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=h1) Report > Merging [#1560](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=desc) (81a54a4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `5.55%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1560 +/- ## == - Coverage 70.18% 64.63% -5.56% == Files 130 49 -81 Lines5340 3164-2176 Branches 5490 -549 == - Hits 3748 2045-1703 + Misses 1344 863 -481 - Partials 248 256 +8 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `39.91% <ø> (+0.31%)` | :arrow_up: | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <0.00%> (-8.58%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `63.55% <0.00%> (-7.48%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `71.96% <0.00%> (-6.28%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `49.57% <0.00%> (-5.89%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | ... and [82 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=footer). Last update [9130e09...81a54a4](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1560: feat: rewrite e2e test(route-with-valid-remote-addr-test) with ginkgo
codecov-io edited a comment on pull request #1560: URL: https://github.com/apache/apisix-dashboard/pull/1560#issuecomment-791589509 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=h1) Report > Merging [#1560](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=desc) (81a54a4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9130e09837f7e6283ba4645fab5c482b18a61949?el=desc) (9130e09) will **decrease** coverage by `18.50%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1560 +/- ## === - Coverage 70.18% 51.68% -18.51% === Files 130 40 -90 Lines5340 2707 -2633 Branches 5490 -549 === - Hits 3748 1399 -2349 + Misses 1344 1127 -217 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.68% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [111 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1560/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=footer). Last update [9130e09...81a54a4](https://codecov.io/gh/apache/apisix-dashboard/pull/1560?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] dickens7 opened a new issue #1565: The upstream timeout unit is seconds instead of milliseconds
dickens7 opened a new issue #1565: URL: https://github.com/apache/apisix-dashboard/issues/1565  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
spacewander commented on a change in pull request #3758: URL: https://github.com/apache/apisix/pull/3758#discussion_r589897285 ## File path: apisix/plugins/traffic-split.lua ## @@ -309,7 +314,8 @@ function _M.access(conf, ctx) return end -local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams) +local rr_up, err = lrucache(weighted_upstreams, nil, new_rr_obj, weighted_upstreams, Review comment: @tzssangglass Personally, we need to add `route_upstream_id` to the key as `route_upstream_id` and `weighted_upstreams` may change differently. As using `route_upstream_id` in the second argument will hit the bug I mention, maybe we can switch to use https://github.com/apache/apisix/blob/c530135c5a179c99637d52d99e0e8a45ce4cc8b8/apisix/plugins/limit-req.lua#L69? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
LiteSun commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-793275805 > Do you want me to add an extra optional prop (`maskClosable`) for `PluginPage` itself to get a more precise control over the mask to use it from any page? > > Thanks for the approval @juzhiyuan The current code is ok. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu merged pull request #3782: perf(standalone): load configuration in the init phase
Yiyiyimu merged pull request #3782: URL: https://github.com/apache/apisix/pull/3782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: perf(standalone): load configuration in the init phase (#3782)
This is an automated email from the ASF dual-hosted git repository.
shuyangw pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c530135 perf(standalone): load configuration in the init phase (#3782)
c530135 is described below
commit c530135c5a179c99637d52d99e0e8a45ce4cc8b8
Author: 罗泽轩
AuthorDate: Tue Mar 9 10:12:39 2021 +0800
perf(standalone): load configuration in the init phase (#3782)
Signed-off-by: spacewander
---
apisix/core/config_yaml.lua | 6 +-
apisix/init.lua | 8
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/apisix/core/config_yaml.lua b/apisix/core/config_yaml.lua
index 808daf6..04b450d 100644
--- a/apisix/core/config_yaml.lua
+++ b/apisix/core/config_yaml.lua
@@ -358,9 +358,13 @@ function _M.fetch_created_obj(key)
end
+function _M.init()
+read_apisix_yaml()
+end
+
+
function _M.init_worker()
-- sync data in each non-master process
-read_apisix_yaml()
ngx.timer.every(1, read_apisix_yaml)
end
diff --git a/apisix/init.lua b/apisix/init.lua
index e35343b..a8d851c 100644
--- a/apisix/init.lua
+++ b/apisix/init.lua
@@ -79,6 +79,10 @@ function _M.http_init(args)
if not ok then
core.log.error("failed to enable privileged_agent: ", err)
end
+
+if core.config == require("apisix.core.config_yaml") then
+core.config.init()
+end
end
@@ -694,6 +698,10 @@ end
function _M.stream_init()
core.log.info("enter stream_init")
+
+if core.config == require("apisix.core.config_yaml") then
+core.config.init()
+end
end
[GitHub] [apisix-docker] Yiyiyimu commented on issue #148: Use Github Actions to automate upload image to Dockerhub
Yiyiyimu commented on issue #148: URL: https://github.com/apache/apisix-docker/issues/148#issuecomment-793270255 > That's a good idea but how to prevent our password from leaking. As you could see in https://docs.github.com/en/actions/guides/publishing-docker-images#publishing-images-to-docker-hub, we could store the secrets in secret part in the repo, so we could use it as the environment variable in Actions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kongjun01 commented on issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number
kongjun01 commented on issue #3783: URL: https://github.com/apache/apisix/issues/3783#issuecomment-793266493 > > SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number > > What's your upstream's TLS protocol version? 上游服务是tomcat，没有任何的ssl配置。可能不是上游的问题，因为upsream的scheme设置为http，用https访问正常。 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3786: refactor: remove unused etcd key node_status
spacewander opened a new pull request #3786: URL: https://github.com/apache/apisix/pull/3786 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kongjun01 removed a comment on issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number
kongjun01 removed a comment on issue #3783: URL: https://github.com/apache/apisix/issues/3783#issuecomment-793261336 > > SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number > > What's your upstream's TLS protocol version? ssl_protocols TLSv1.2 TLSv1.3; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kongjun01 commented on issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number
kongjun01 commented on issue #3783: URL: https://github.com/apache/apisix/issues/3783#issuecomment-793261336 > > SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number > > What's your upstream's TLS protocol version? ssl_protocols TLSv1.2 TLSv1.3; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3785: docs: updated to new users-wall in powered-by.md
juzhiyuan commented on pull request #3785: URL: https://github.com/apache/apisix/pull/3785#issuecomment-793252165 Hi, would you please clean your commits history This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yangzcy423911 commented on issue #3784: request help: api-breaker
Yangzcy423911 commented on issue #3784: URL: https://github.com/apache/apisix/issues/3784#issuecomment-793240012 I've read this document. When the service is available, the maximum time of fusing is exceeded. How should the gateway recover the request and call to the upstream service This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass edited a comment on pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tzssangglass edited a comment on pull request #3758: URL: https://github.com/apache/apisix/pull/3758#issuecomment-793235239 > There should be a way to do the same thing without corrupting the data. Otherwise once the cache is evicted we will be in trouble. This PR does not do this work. If needed, we should open another issue to discuss it, as it would involve refactoring the plugin's implementation logic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tzssangglass commented on pull request #3758: URL: https://github.com/apache/apisix/pull/3758#issuecomment-793235239 This PR does not do this work. We should open another issue to discuss it if needed, because this time it involves refactoring the plugin's implementation logic. > There should be a way to do the same thing without corrupting the data. Otherwise once the cache is evicted we will be in trouble. This PR does not do this work. If needed, we should open another issue to discuss it, as it would involve refactoring the plugin's implementation logic. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] iamayushdas opened a new pull request #3785: docs: updated to new users-wall in powered-by.md
iamayushdas opened a new pull request #3785: URL: https://github.com/apache/apisix/pull/3785 ### What this PR does / why we need it: updated to new users-wall in powered-by.md link: https://github.com/apache/apisix/blob/master/powered-by.md ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-793230705 oh got you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan edited a comment on issue #230: docs: tell users where they are
juzhiyuan edited a comment on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-793229484 oh sure, as you could see, when we see no matter the `APISIX` docs or `APISIX Dashboard` docs, users may get confusing because they couldn't know which project they are reading. We could add the Project name here or other places.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #230: docs: tell users where they are
juzhiyuan commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-793229484 oh sure, as you could see, when we see no matter the `APISIX` docs or `APISIX Dashboard` docs, users may get confusing because they couldn't know which project they are reading. We could add the Project name here or other places. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on issue #148: Use Github Actions to automate upload image to Dockerhub
tokers commented on issue #148: URL: https://github.com/apache/apisix-docker/issues/148#issuecomment-793228767 That's a good idea but how to prevent our password from leaking. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan merged pull request #3780: docs: rewrite sidebar
juzhiyuan merged pull request #3780: URL: https://github.com/apache/apisix/pull/3780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: rewrite sidebar (#3780)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 630769c docs: rewrite sidebar (#3780)
630769c is described below
commit 630769c4ac1b98b5353b117b7af537ce37c1c5d5
Author: 罗泽轩
AuthorDate: Tue Mar 9 09:05:26 2021 +0800
docs: rewrite sidebar (#3780)
Signed-off-by: spacewander
---
docs/en/latest/config.json | 104 +
1 file changed, 58 insertions(+), 46 deletions(-)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index eee4294..ff66c66 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -125,57 +125,69 @@
]
},
{
- "type": "doc",
- "id": "admin-api"
-},
-{
- "type": "doc",
- "id": "control-api"
-},
-{
- "type": "doc",
- "id": "health-check"
-},
-{
- "type": "doc",
- "id": "router-radixtree"
-},
-{
- "type": "doc",
- "id": "stand-alone"
-},
-{
- "type": "doc",
- "id": "stream-proxy"
-},
-{
- "type": "doc",
- "id": "grpc-proxy"
-},
-{
- "type": "doc",
- "id": "customize-nginx-configuration"
-},
-{
- "type": "doc",
- "id": "https"
-},
-{
- "type": "doc",
- "id": "benchmark"
-},
-{
- "type": "link",
- "label": "CODE_STYLE",
- "href": "https://github.com/apache/apisix/blob/master/CODE_STYLE.md;
+ "type": "category",
+ "label": "API",
+ "items": [
+{
+ "type": "doc",
+ "id": "admin-api"
+},
+{
+ "type": "doc",
+ "id": "control-api"
+}
+ ]
},
{
"type": "doc",
- "id": "debug-function"
+ "id": "FAQ"
},
{
- "type": "doc",
- "id": "FAQ"
+ "type": "category",
+ "label": "Others",
+ "items": [
+{
+ "type": "doc",
+ "id": "health-check"
+},
+{
+ "type": "doc",
+ "id": "router-radixtree"
+},
+{
+ "type": "doc",
+ "id": "stand-alone"
+},
+{
+ "type": "doc",
+ "id": "stream-proxy"
+},
+{
+ "type": "doc",
+ "id": "grpc-proxy"
+},
+{
+ "type": "doc",
+ "id": "customize-nginx-configuration"
+},
+{
+ "type": "doc",
+ "id": "https"
+},
+{
+ "type": "doc",
+ "id": "benchmark"
+},
+{
+ "type": "link",
+ "label": "CODE_STYLE",
+ "href": "https://github.com/apache/apisix/blob/master/CODE_STYLE.md;
+},
+{
+ "type": "doc",
+ "id": "debug-function"
+}
+ ]
},
{
"type": "link",
[GitHub] [apisix] spacewander commented on issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number
spacewander commented on issue #3783: URL: https://github.com/apache/apisix/issues/3783#issuecomment-793224435 > SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number What's your upstream's TLS protocol version? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
spacewander commented on pull request #3758: URL: https://github.com/apache/apisix/pull/3758#issuecomment-793221849 There should be a way to do the same thing without corrupting the data. Otherwise once the cache is evicted we will be in trouble. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3784: request help: api-breaker
tokers commented on issue #3784: URL: https://github.com/apache/apisix/issues/3784#issuecomment-793221418 Currently the service has to wait until the `max_breaker_sec` time elapsed. See https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/api-breaker.md for more details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route
batman-ezio commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-793201896 > > > > can we add a logic in create/update API to set the name from url params if it does not exists in the request body? > > > > > > > > > oh, no, we should not do that. > > > we could fix in test cases which do duplicate. I think there will not be a lot, because most of test cases will delete the routes at the end. > > > > > > ok, can you help to fix the rest test cases, thanks > > sure, my pleasure. will update later. thanks. I have squashed all my test case commits into one commit, and rebased from master (which includes the latest frontend e2e fix), but the test case still failed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-793199249 > > > can we add a logic in create/update API to set the name from url params if it does not exists in the request body? > > > > > > oh, no, we should not do that. > > we could fix in test cases which do duplicate. I think there will not be a lot, because most of test cases will delete the routes at the end. > > ok, can you help to fix the rest test cases, thanks sure, my pleasure. will update later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas opened a new pull request #253: fix: improved the description for users to join slack
iamayushdas opened a new pull request #253: URL: https://github.com/apache/apisix-website/pull/253 Fixes: #229 Changes: improved the description for users to join slack slack link updated Screenshots of the change: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yangzcy423911 opened a new issue #3784: request help: api-breaker
Yangzcy423911 opened a new issue #3784: URL: https://github.com/apache/apisix/issues/3784 ### Issue description ### Environment * apisix version (cmd: `apisix version`):2.2 * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): Tengine.2.3 * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: What the gateway will do when the service resumes available beyond the maximum fuse duration configured by the gateway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #1563: discuss: the "Host" in the active health check should be optional
moonming commented on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793193822 What does the text hint in the input box mean? “active host” is confusing This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #1563: discuss: the "Host" in the active health check should be optional
moonming commented on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-793193091 IMO, "host" should be optional. @nic-chen @membphis please check the lua-resty-healthcheck. @Firstsawyou this issue should @ to apisix too. It is not just a FE issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-793130671 Could you elaborate more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
bisakhmondal commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-793036844 Oops! one test is failing. But at my local machine all tests of `test:e2e` are working fine. I have made available the full test report at [pastebin](https://pastebin.com/pF7P02U9). Could you please look into it? Thank you. (Run Finished) Spec Tests Passing Failing Pending Skipped ┌┐ │ ✔ consumer/create_and_delete_consumer 00:1344 --- │ │.spec.js │ ├┤ │ ✔ lang/switch-language.spec.js 00:0511 --- │ ├┤ │ ✔ metrics/metrics-smoketest.spec.js00:0211 --- │ ├┤ │ ✔ plugin/create-edit-delete-plugin.sp 16:4333 --- │ │ec.js │ ├┤ │ ✔ pluginTemplate/create-edit-delete-p 00:1233 --- │ │lugin-template.spec.js │ ├┤ │ ✔ pluginTemplate/create-plugin-templa 00:2044 --- │ │te-with-route.spec.js │ ├┤ │ ✔ route/can-skip-upstream-when-select 00:2044 --- │ │-service-id.spec.js │ ├┤ │ ✔ route/create-edit-delete-route.spec 00:2244 --- │ │.js │ ├┤ │ ✔ route/create-route-with-upstream.sp 00:1944 --- │ │ec.js │ ├┤ │ ✔ route/import_export_route.spec.js00:2544 --- │ ├┤ │ ✔ route/online-debug.spec.js 00:2933 --- │ ├┤ │ ✔ route/search-route.spec.js 00:2544 --- │ ├┤ │ ✔ service/create-edit-delete-service. 00:1644 --- │ │spec.js │ ├┤ │ ✔ service/edit-service-with-upstream. 00:1844 --- │ │spec.js │ ├┤ │ ✔ settings/settings-smoketest.spec.js 00:1033 --- │ ├┤ │ ✔ ssl/ssl-smoketest.spec.js01:0933 --- │
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
bisakhmondal commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792887934 >The drawer in route and service also needs to be handled. You can search globally for this component to prevent missing some pages Hey @LiteSun, for the plugins @ route and service, components are reflecting the current changes. It's using the existing `PluginPage` component (on which the changes have been made) for rendering the plugins in different use cases. for example inside `service` https://github.com/apache/apisix-dashboard/blob/6dce9e09640b1c81f14dbb88e5f6f8c43371af31/web/src/pages/Service/Create.tsx#L133-L135 in `routes` https://github.com/apache/apisix-dashboard/blob/6dce9e09640b1c81f14dbb88e5f6f8c43371af31/web/src/pages/Route/components/Step3/index.tsx#L86-L95 In short, if I am not mistaken, desired changes are getting reflected for plugins across the components you mentioned. Do you want me to add an extra optional prop (`maskClosable`) for `PluginPage` itself to get a more precise control over the mask to use it from any page? Thanks for the approval @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1564: feat: disable closing plugin drawer on clicking the mask
juzhiyuan commented on a change in pull request #1564:
URL: https://github.com/apache/apisix-dashboard/pull/1564#discussion_r589534022
##
File path: web/src/components/Plugin/PluginDetail.tsx
##
@@ -46,6 +46,7 @@ type Props = {
pluginList: PluginComponent.Meta[];
readonly?: boolean;
visible: boolean;
+ maskClosable: boolean;
Review comment:
```suggestion
maskClosable?: boolean;
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1559: test: update test
juzhiyuan merged pull request #1559: URL: https://github.com/apache/apisix-dashboard/pull/1559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: improve test cases (#1559)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 6dce9e0 feat: improve test cases (#1559)
6dce9e0 is described below
commit 6dce9e09640b1c81f14dbb88e5f6f8c43371af31
Author: guoqqqi <72343596+guoq...@users.noreply.github.com>
AuthorDate: Mon Mar 8 23:56:16 2021 +0800
feat: improve test cases (#1559)
---
web/cypress/fixtures/selector.json | 2 ++
.../integration/route/import_export_route.spec.js | 17 +++--
web/cypress/integration/route/online-debug.spec.js | 6 --
web/cypress/integration/route/search-route.spec.js | 11 ---
4 files changed, 21 insertions(+), 15 deletions(-)
diff --git a/web/cypress/fixtures/selector.json
b/web/cypress/fixtures/selector.json
index e7b2abb..61615f2 100644
--- a/web/cypress/fixtures/selector.json
+++ b/web/cypress/fixtures/selector.json
@@ -43,6 +43,7 @@
"fileSelector": "[type=file]",
"fileTypeRadio": "[type=radio]",
+ "fileSelectorClose": ".ant-modal-close",
"debugUri": "#debugUri",
@@ -50,6 +51,7 @@
"labels_0_labelKey": "#labels_0_labelKey",
"labels_0_labelValue": "#labels_0_labelValue",
"labelSelector": "[title=Labels]",
+ "labelSelect_0": ".ant-select-selection-overflow",
"pageContainer": ".ant-pro-page-container",
"notificationMessage": ".ant-notification-notice-message",
diff --git a/web/cypress/integration/route/import_export_route.spec.js
b/web/cypress/integration/route/import_export_route.spec.js
index dcf9c1a..1786b40 100644
--- a/web/cypress/integration/route/import_export_route.spec.js
+++ b/web/cypress/integration/route/import_export_route.spec.js
@@ -45,6 +45,7 @@ context('import and export routes', () => {
cy.fixture('data.json').as('data');
cy.fixture('export-route-dataset.json').as('exportFile');
});
+
it('should create route1 and route2', function () {
cy.visit('/');
// create two routes
@@ -146,24 +147,28 @@ context('import and export routes', () => {
cy.get(this.domSelector.fileSelector).attachFile(file);
// click submit
cy.contains(componentLocaleUS['component.global.confirm']).click();
+
// show upload notification
if (file === 'import-error.txt') {
// show error msg
cy.get(this.domSelector.notificationDesc).should('contain',
data.importErrorMsg);
// close modal
cy.contains(componentLocaleUS['component.global.cancel']).click();
- } else {
+cy.get(this.domSelector.notificationCloseIcon).click();
+ } else if (file !== 'import-error.txt') {
cy.get(this.domSelector.notification).should(
'contain', 'Success'
);
-cy.get(this.domSelector.notificationCloseIcon).click();
+cy.get(this.domSelector.fileSelectorClose).click();
+
cy.get(this.domSelector.notificationCloseIcon).click().should('not.exist');
// delete route just imported
-cy.contains(componentLocaleUS['component.global.delete']).click();
-cy.contains(componentLocaleUS['component.global.confirm']).click();
+cy.reload();
+cy.get(this.domSelector.deleteButton).should('exist').click();
+cy.contains('button',
componentLocaleUS['component.global.confirm']).click({ force: true });
+
// show delete successfully notification
cy.get(this.domSelector.notification).should(
- 'contain',
- `${componentLocaleUS['component.global.delete']}
${menuLocaleUS['menu.routes']}
${componentLocaleUS['component.status.success']}`,
+ 'contain', this.data.deleteRouteSuccess
);
cy.get(this.domSelector.notificationCloseIcon).click();
}
diff --git a/web/cypress/integration/route/online-debug.spec.js
b/web/cypress/integration/route/online-debug.spec.js
index b8b1883..f491a1c 100644
--- a/web/cypress/integration/route/online-debug.spec.js
+++ b/web/cypress/integration/route/online-debug.spec.js
@@ -151,8 +151,10 @@ context('Online debug', () => {
cy.contains(routeLocaleUS['page.route.button.send']).click();
// assert: send request return
-cy.get(domSelector.codeMirrorCode).contains('data').should('be.visible');
-cy.get(domSelector.codeMirrorCode).contains('routes').should('be.visible');
+cy.get(domSelector.codeMirrorCode).within(() => {
+ cy.contains('data').should('be.visible');
+ cy.contains('routes').should('be.visible');
+});
// close debug drawer
cy.get(this.domSelector.drawerClose).click();
diff --git a/web/cypress/integration/route/search-route.spec.js
b/web/cypress/integration/route/search-route.spec.js
index be3e0c2..9bc2951 100644
--- a/web/cypress/integration/route/search-route.spec.js
+++ b/web/cypress/integration/route/search-route.spec.js
@@ -97,17 +97,14 @@
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
bisakhmondal commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792786009 >Very glad to see you pr! The drawer in route and service also needs to be handled. Yeah sure. On issue #1548, you only mentioned the plugins, that's why I left the rest of them as it is. Pushing the changes soon. Thanks for the review @LiteSun :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1564: feat: disable closing plugin drawer on clicking the mask
codecov-io edited a comment on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792782216 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=h1) Report > Merging [#1564](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=desc) (f1bbfde) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `15.17%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1564 +/- ## === - Coverage 70.86% 55.68% -15.18% === Files 135 49 -86 Lines5485 3164 -2321 Branches 5830 -583 === - Hits 3887 1762 -2125 + Misses 1350 1098 -252 - Partials 248 304 +56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `55.68% <ø> (+0.06%)` | :arrow_up: | | backend-e2e-test-ginkgo | `40.04% <ø> (ø)` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `57.44% <0.00%> (-34.05%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `38.46% <0.00%> (-30.77%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | ... and [98 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=footer). Last update [938b2b9...f1bbfde](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
codecov-io commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792782216 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=h1) Report > Merging [#1564](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=desc) (f1bbfde) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/938b2b9f34c5fa5e7ef6fddef29acb29b25c09a1?el=desc) (938b2b9) will **decrease** coverage by `30.82%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1564 +/- ## === - Coverage 70.86% 40.04% -30.83% === Files 135 49 -86 Lines5485 3164 -2321 Branches 5830 -583 === - Hits 3887 1267 -2620 - Misses 1350 1628 +278 - Partials 248 269 +21 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `40.04% <ø> (ø)` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `15.15% <0.00%> (-72.73%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `33.47% <0.00%> (-44.77%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `30.55% <0.00%> (-41.67%)` | :arrow_down: | | ... and [103 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1564/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=footer). Last update [938b2b9...f1bbfde](https://codecov.io/gh/apache/apisix-dashboard/pull/1564?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL
[GitHub] [apisix-dashboard] LiteSun edited a comment on pull request #1564: feat: disable closing plugin drawer on clicking the mask
LiteSun edited a comment on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792779756 Very glad to see you pr! The drawer in route and service also needs to be handled. You can search globally for this component to prevent missing some pages @bisakhmondal   This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1564: feat: disable closing plugin drawer on clicking the mask
LiteSun commented on pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564#issuecomment-792779756 Very glad to see you pr! The drawer in route and service also needs to be handled. You can search globally for this component to prevent missing some pages @bisakhmondal  ![Uploading image.png…]() This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1548: Clicking on a mask while editing a plugin does not allow the drawer to be closed
LiteSun commented on issue #1548: URL: https://github.com/apache/apisix-dashboard/issues/1548#issuecomment-792774554 > Yeah, it sounds logical. Can I work on this issue, @LiteSun, @nic-chen? I also noticed that editing any existing plugins also result in the same behaviour. Should I restrict that too? > > Edit: I have made the changes. Can I open a PR? Looking forward to your PR! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1548: Clicking on a mask while editing a plugin does not allow the drawer to be closed
bisakhmondal commented on issue #1548: URL: https://github.com/apache/apisix-dashboard/issues/1548#issuecomment-792777282 Hello guys!! Just opened it :) Waiting for the review, hehe. Thanks for the super quick reply. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1564: feat: disable closing plugin drawer on clicking the mask
bisakhmondal opened a new pull request #1564: URL: https://github.com/apache/apisix-dashboard/pull/1564 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues resolves #1548 ### New feature or improvement Now, clicking on the masked area of the plugin drawer does not close it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on issue #1563: discuss: the "Host" in the active health check should be optional
guoqqqi commented on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-792765589 Yes, please refer to #1551. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #1563: discuss: the "Host" in the active health check should be optional
juzhiyuan edited a comment on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-792761708 @guoqqqi I remember there was a similar issue, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1563: discuss: the "Host" in the active health check should be optional
juzhiyuan commented on issue #1563: URL: https://github.com/apache/apisix-dashboard/issues/1563#issuecomment-792761708 @guoqqqi I remember there was a similar issue, right This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kongjun01 opened a new issue #3783: request help: SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number
kongjun01 opened a new issue #3783:
URL: https://github.com/apache/apisix/issues/3783
### Issue description
我有个upsream的scheme设置为http，然后这个路由也配置了SSL证书，用https直接访问能够正常返回，但是upsream的scheme设置为https（强制跳转https），访问一直报502
Bad Gateway
路由配置：
{
"uri": "/test/*",
"hosts": ["nutsta.cn"],
"plugins": {
},
"upstream": {
"service_name": "TEST-SERVICE",
"type": "roundrobin",
"discovery_type": "eureka",
"scheme": "https"
}
}
错误日志：
2021/03/08 21:16:09 [error] 65945#681239: *2862 SSL_do_handshake() failed
(SSL: error:1408F10B:SSL routines:ssl3_get_record:wrong version number),
client: 127.0.0.1, server: , request: "GET /test/test HTTP/1.1", subrequest:
"/proxy_mirror", host: "nutsta.cn:9080"
### Environment
本地
* apisix version (cmd: `apisix version`): 2.4
* OS (cmd: `uname -a`): Darwin MacBook-Pro.local 20.3.0 Darwin Kernel
Version 20.3.0: Thu Jan 21 00:07:06 PST 2021;
root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): nginx
version: openresty/1.19.3.1
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
{
"id": "f7444900-a7af-4b20-9f83-365947024ee8",
"version": "2.4",
"boot_time": 1615209248,
"etcd_version": "3.4.0",
"up_time": 572,
"last_report_time": 1615209788,
"hostname": "sMacBook-Pro.local"
}
* apisix-dashboard version, if have:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] jp-gouin closed issue #3635: feat: Add method filter on consummer-restriction plugin
jp-gouin closed issue #3635: URL: https://github.com/apache/apisix/issues/3635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3749: docs: update the limit-conn.md doc
spacewander closed issue #3749: URL: https://github.com/apache/apisix/issues/3749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3750: docs: add more detailed desc of `default_conn_delay`.
spacewander merged pull request #3750: URL: https://github.com/apache/apisix/pull/3750 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: add more detailed desc of `default_conn_delay`. (#3750)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new dedf798 docs: add more detailed desc of `default_conn_delay`. (#3750) dedf798 is described below commit dedf79875d26e7351ae10b348662b936ce7768bb Author: Wen Ming AuthorDate: Mon Mar 8 19:34:32 2021 +0800 docs: add more detailed desc of `default_conn_delay`. (#3750) --- docs/en/latest/plugins/limit-conn.md | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/en/latest/plugins/limit-conn.md b/docs/en/latest/plugins/limit-conn.md index e74e54a..ed04e05 100644 --- a/docs/en/latest/plugins/limit-conn.md +++ b/docs/en/latest/plugins/limit-conn.md @@ -23,11 +23,11 @@ title: limit-conn ## Summary -- [**Name**](#name) -- [**Attributes**](#attributes) -- [**How To Enable**](#how-to-enable) -- [**Test Plugin**](#test-plugin) -- [**Disable Plugin**](#disable-plugin) +- [Name](#name) +- [Attributes](#attributes) +- [How To Enable](#how-to-enable) +- [Test Plugin](#test-plugin) +- [Disable Plugin](#disable-plugin) ## Name @@ -37,9 +37,9 @@ Limiting request concurrency plugin. | Name | Type| Requirement | Default | Valid | Description [...] | -- | --- | --- | --- | - | --- [...] -| conn | integer | required| | conn > 0 | the maximum number of concurrent requests allowed. Requests exceeding this ratio (and below `conn` + `burst`) will get delayed to conform to this threshold. [...] +| conn | integer | required| | conn > 0 | the maximum number of concurrent requests allowed. Requests exceeding this ratio (and below `conn` + `burst`) will get delayed(the latency seconds is configured by `default_conn_delay`) to conform to this threshold. [...] | burst | integer | required| | burst >= 0 | the number of excessive concurrent requests (or connections) allowed to be delayed. [...] -| default_conn_delay | number | required| | default_conn_delay > 0| the default processing latency of a typical connection (or request). [...] +| default_conn_delay | number | required| | default_conn_delay > 0| the latency seconds of request when concurrent requests exceeding `conn` but below (`conn` + `burst`). [...] | key| object | required| | ["remote_addr", "server_addr", "http_x_real_ip", "http_x_forwarded_for", "consumer_name"] | to limit the
[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route
batman-ezio commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792691011 > > can we add a logic in create/update API to set the name from url params if it does not exists in the request body? > > oh, no, we should not do that. > we could fix in test cases which do duplicate. I think there will not be a lot, because most of test cases will delete the routes at the end. ok, can you help to fix the rest test cases, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3632: docs: the FAQ document adds the issue of failure to execute the make deps command
spacewander closed issue #3632: URL: https://github.com/apache/apisix/issues/3632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3636: docs: FAQ doc added make deps execution failed
spacewander merged pull request #3636: URL: https://github.com/apache/apisix/pull/3636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: FAQ doc added make deps execution failed (#3636)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 50ece6a docs: FAQ doc added make deps execution failed (#3636) 50ece6a is described below commit 50ece6a70fa219bfa3d6f13cd515930be7d539bf Author: Yuelin Zheng <2226815...@qq.com> AuthorDate: Mon Mar 8 19:17:04 2021 +0800 docs: FAQ doc added make deps execution failed (#3636) --- docs/en/latest/FAQ.md | 14 ++ docs/zh/latest/FAQ.md | 14 ++ 2 files changed, 28 insertions(+) diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md index 3b603eb..b6f38d6 100644 --- a/docs/en/latest/FAQ.md +++ b/docs/en/latest/FAQ.md @@ -357,3 +357,17 @@ The high availability of APISIX can be divided into two parts: 1. The data plane of Apache APISIX is stateless and can be elastically scaled at will. Just add a layer of LB in front. 2. The control plane of Apache APISIX relies on the highly available implementation of `etcd cluster` and does not require any relational database dependency. + +## Why does the `make deps` command fail in source installation? + +When executing the `make deps` command, an error such as the one shown below occurs. This is caused by the missing openresty's `openssl` development kit, you need to install it first. Please refer to the [install-dependencies.md](doc/install-dependencies.md) document for installation. + +```shell +$ make deps +.. +Error: Failed installing dependency: https://luarocks.org/luasec-0.9-1.src.rock - Could not find header file for OPENSSL + No file openssl/ssl.h in /usr/local/include +You may have to install OPENSSL in your system and/or pass OPENSSL_DIR or OPENSSL_INCDIR to the luarocks command. +Example: luarocks install luasec OPENSSL_DIR=/usr/local +make: *** [deps] Error 1 +``` diff --git a/docs/zh/latest/FAQ.md b/docs/zh/latest/FAQ.md index fa8b93c..612294d 100644 --- a/docs/zh/latest/FAQ.md +++ b/docs/zh/latest/FAQ.md @@ -305,3 +305,17 @@ APISIX 的高可用可分为两个部分： 1、Apache APISIX 的数据平面是无状态的，可以进行随意的弹性伸缩，前面加一层 LB 即可。 2、Apache APISIX 的控制平面是依赖于 `etcd cluster` 的高可用实现的，不需要任何关系型数据库的依赖。 + +## 为什么源码安装中执行 `make deps` 命令失败？ + +1、当执行 `make deps` 命令时，发生诸如下面所示的错误。这是由于缺少 OpenResty 的 `openssl` 开发软件包导致的，你需要先安装它。请参考 [install-dependencies.md](doc/zh-cn/install-dependencies.md) 文档进行安装。 + +```shell +$ make deps +.. +Error: Failed installing dependency: https://luarocks.org/luasec-0.9-1.src.rock - Could not find header file for OPENSSL + No file openssl/ssl.h in /usr/local/include +You may have to install OPENSSL in your system and/or pass OPENSSL_DIR or OPENSSL_INCDIR to the luarocks command. +Example: luarocks install luasec OPENSSL_DIR=/usr/local +make: *** [deps] Error 1 +```
[GitHub] [apisix] spacewander opened a new pull request #3782: perf(standalone): load configuration in the init phase
spacewander opened a new pull request #3782: URL: https://github.com/apache/apisix/pull/3782 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-792684252 > can we add a logic in create/update API to set the name from url params if it does not exists in the request body? oh, no, we should not do that. we could fix in test cases which do duplicate. I think there will not be a lot, because most of test cases will delete the routes at the end. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] mdh67899 closed issue #1428: why apisix dashboard Path limit must Begin with / , and * can only at the end ?
mdh67899 closed issue #1428: URL: https://github.com/apache/apisix-dashboard/issues/1428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
