[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

[GitBox]

codecov-io edited a comment on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=h1) 
Report
   > Merging 
[#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=desc) 
(0054591) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `9.85%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1597  +/-   ##
   ==
   - Coverage   71.69%   61.83%   -9.86% 
   ==
 Files 133   47  -86 
 Lines5469 3113-2356 
 Branches  5920 -592 
   ==
   - Hits 3921 1925-1996 
   + Misses   1305  876 -429 
   - Partials  243  312  +69 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.83% <ø> (+0.09%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `47.96% <ø> (+0.09%)` | :arrow_up: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
   | 
[api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=)
 | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
   | 
[...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv)
 | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
   | 
[api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=)
 | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
   | 
[api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=)
 | `77.14% <0.00%> (-13.58%)` | :arrow_down: |
   | ... and [100 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=footer).
 Last update 
[1ba32d9...0054591](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

[GitBox]

codecov-io edited a comment on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=h1) 
Report
   > Merging 
[#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=desc) 
(6568ab6) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `2.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1620  +/-   ##
   ==
   - Coverage   71.65%   69.46%   -2.19% 
   ==
 Files 133  133  
 Lines5429 5469  +40 
 Branches  592  592  
   ==
   - Hits 3890 3799  -91 
   - Misses   1296 1427 +131 
 Partials  243  243  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.67% <ø> (+0.32%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `72.58% <ø> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-9.65%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `41.81% <0.00%> (-5.46%)` | :arrow_down: |
   | 
[api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv)
 | `54.05% <0.00%> (-5.41%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | ... and [6 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=footer).
 Last update 
[38cf0ba...6568ab6](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about t

[GitHub] [apisix-docker] nic-chen commented on a change in pull request #152: feat: add apisix-dashboard dockerfile & CI

[GitBox]

nic-chen commented on a change in pull request #152:
URL: https://github.com/apache/apisix-docker/pull/152#discussion_r598080218



##
File path: dashboard/Dockerfile
##
@@ -0,0 +1,69 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+FROM alpine:latest as pre-build
+
+ARG APISIX_DASHBOARD_VERSION=v2.4
+
+RUN set -x \
+&& apk add --no-cache --virtual .builddeps git \
+&& git clone https://github.com/apache/apisix-dashboard.git -b 
${APISIX_DASHBOARD_VERSION} /usr/local/apisix-dashboard \
+&& cd /usr/local/apisix-dashboard && git clean -Xdf \
+&& rm -f ./.githash && git log --pretty=format:"%h" -1 > ./.githash
+
+FROM golang:1.14 as api-builder
+
+ARG ENABLE_PROXY=false
+
+WORKDIR /usr/local/apisix-dashboard
+
+COPY --from=pre-build /usr/local/apisix-dashboard .
+
+RUN if [ "$ENABLE_PROXY" = "true" ] ; then go env -w 
GOPROXY=https://goproxy.io,direct ; fi \
+&& go env -w GO111MODULE=on \
+&& CGO_ENABLED=0 ./api/build.sh
+
+FROM node:14-alpine as fe-builder
+
+ARG ENABLE_PROXY=false
+
+WORKDIR /usr/local/apisix-dashboard
+
+COPY --from=pre-build /usr/local/apisix-dashboard .
+
+WORKDIR /usr/local/apisix-dashboard/web
+
+RUN if [ "$ENABLE_PROXY" = "true" ] ; then yarn config set registry 
https://registry.npm.taobao.org/ ; fi \
+&& yarn install \
+&& yarn build
+
+FROM alpine:latest as prod
+
+ARG ENABLE_PROXY=false
+
+RUN if [ "$ENABLE_PROXY" = "true" ] ; then sed -i 
's/dl-cdn.alpinelinux.org/mirrors.ustc.edu.cn/g' /etc/apk/repositories ; fi
+
+WORKDIR /usr/local/apisix-dashboard
+
+COPY --from=api-builder /usr/local/apisix-dashboard/output/ ./
+
+COPY --from=fe-builder /usr/local/apisix-dashboard/output/ ./
+
+RUN mkdir logs
+
+EXPOSE 9000
+
+CMD [ "/usr/local/apisix-dashboard/manager-api" ]

Review comment:
   new line..




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1597: test: add the create and delete plugin in drawer

[GitBox]

nic-chen commented on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-803269627


   @stu01509  FE e2e test failed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script

[GitBox]

bzp2010 commented on pull request #263:
URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803271048


    Updated 2021-3-20
   - add link conversion and check function for non document files
    Tips
   - non document files link will be converse to a web link on GitHub


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

[GitBox]

codecov-io edited a comment on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=h1) 
Report
   > Merging 
[#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=desc) 
(053740e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `19.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1597   +/-   ##
   ===
   - Coverage   71.69%   51.81%   -19.89% 
   ===
 Files 133   38   -95 
 Lines5469 2650 -2819 
 Branches  5920  -592 
   ===
   - Hits 3921 1373 -2548 
   + Misses   1305 1089  -216 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [119 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=footer).
 Last update 
[1ba32d9...053740e](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact 

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

[GitBox]

codecov-io edited a comment on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=h1) 
Report
   > Merging 
[#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=desc) 
(053740e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `4.39%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1597  +/-   ##
   ==
   - Coverage   71.69%   67.29%   -4.40% 
   ==
 Files 133   47  -86 
 Lines5469 3113-2356 
 Branches  5920 -592 
   ==
   - Hits 3921 2095-1826 
   + Misses   1305  771 -534 
   - Partials  243  247   +4 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.86% <ø> (ø)` | |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | ... and [86 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=footer).
 Last update 
[1ba32d9...053740e](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@in

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1597: test: add the create and delete plugin in drawer

[GitBox]

codecov-io edited a comment on pull request #1597:
URL: https://github.com/apache/apisix-dashboard/pull/1597#issuecomment-799889165


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=h1) 
Report
   > Merging 
[#1597](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=desc) 
(053740e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `0.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1597  +/-   ##
   ==
   - Coverage   71.69%   71.02%   -0.68% 
   ==
 Files 133   47  -86 
 Lines5469 3113-2356 
 Branches  5920 -592 
   ==
   - Hits 3921 2211-1710 
   + Misses   1305  658 -647 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.74% <ø> (ø)` | |
   | backend-e2e-test-ginkgo | `47.86% <ø> (ø)` | |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | 
[web/src/pages/Consumer/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9DcmVhdGUudHN4)
 | | |
   | 
[web/src/pages/SSL/components/Step1/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9TdGVwMS9pbmRleC50c3g=)
 | | |
   | 
[web/src/components/ActionBar/ActionBar.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0FjdGlvbkJhci9BY3Rpb25CYXIudHN4)
 | | |
   | 
[...rc/components/PluginOrchestration/customConfig.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY3VzdG9tQ29uZmlnLnRzeA==)
 | | |
   | 
[web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=)
 | | |
   | 
[...nts/PluginOrchestration/components/SidebarItem.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9TaWRlYmFySXRlbS50c3g=)
 | | |
   | 
[web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4)
 | | |
   | 
[web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz)
 | | |
   | ... and [77 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1597/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=footer).
 Last update 
[1ba32d9...053740e](https://codecov.io/gh/apache/apisix-dashboard/pull/1597?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

[GitBox]

codecov-io edited a comment on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=h1) 
Report
   > Merging 
[#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=desc) 
(de7f92c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `19.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1620   +/-   ##
   ===
   - Coverage   71.65%   51.81%   -19.85% 
   ===
 Files 133   38   -95 
 Lines5429 2650 -2779 
 Branches  5920  -592 
   ===
   - Hits 3890 1373 -2517 
   + Misses   1296 1089  -207 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [119 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=footer).
 Last update 
[38cf0ba...de7f92c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

[GitBox]

codecov-io edited a comment on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=h1) 
Report
   > Merging 
[#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=desc) 
(de7f92c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `4.48%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1620  +/-   ##
   ==
   - Coverage   71.65%   67.16%   -4.49% 
   ==
 Files 133   47  -86 
 Lines5429 3113-2316 
 Branches  5920 -592 
   ==
   - Hits 3890 2091-1799 
   + Misses   1296  778 -518 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.73% <ø> (+0.38%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-9.65%)` | :arrow_down: |
   | 
[api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv)
 | `54.05% <0.00%> (-5.41%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | ... and [91 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=footer).
 Last update 
[38cf0ba...de7f92c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please cont

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

[GitBox]

codecov-io edited a comment on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=h1) 
Report
   > Merging 
[#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=desc) 
(de7f92c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `0.49%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1620  +/-   ##
   ==
   - Coverage   71.65%   71.15%   -0.50% 
   ==
 Files 133   47  -86 
 Lines5429 3113-2316 
 Branches  5920 -592 
   ==
   - Hits 3890 2215-1675 
   + Misses   1296  654 -642 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.86% <ø> (+0.30%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `47.73% <ø> (+0.38%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <0.00%> (-0.82%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.95% <0.00%> (-0.61%)` | :arrow_down: |
   | 
[web/src/services/tool.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy90b29sLnRz)
 | | |
   | 
[.../src/pages/User/components/LoginMethodPassword.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RQYXNzd29yZC50c3g=)
 | | |
   | 
[web/src/global.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9nbG9iYWwudHN4)
 | | |
   | 
[.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz)
 | | |
   | 
[...b/src/pages/User/components/LoginMethodExample.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RFeGFtcGxlLnRzeA==)
 | | |
   | 
[web/src/pages/Consumer/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9jb21wb25lbnRzL1N0ZXAxLnRzeA==)
 | | |
   | 
[web/src/pages/Consumer/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9zZXJ2aWNlLnRz)
 | | |
   | 
[...pages/Route/components/CreateStep4/CreateStep4.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0NyZWF0ZVN0ZXA0L0NyZWF0ZVN0ZXA0LnRzeA==)
 | | |
   | ... and [80 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=footer).
 Last update 
[38cf0ba...de7f92c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1620: feat: update yarn.lock

[GitBox]

codecov-io edited a comment on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-802638797


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=h1) 
Report
   > Merging 
[#1620](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=desc) 
(de7f92c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **increase** coverage by `0.07%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1620  +/-   ##
   ==
   + Coverage   71.65%   71.73%   +0.07% 
   ==
 Files 133  133  
 Lines5429 5469  +40 
 Branches  592  592  
   ==
   + Hits 3890 3923  +33 
   - Misses   1296 1302   +6 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.86% <ø> (+0.30%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `47.73% <ø> (+0.38%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `72.49% <ø> (-0.17%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==)
 | `77.04% <0.00%> (-3.28%)` | :arrow_down: |
   | 
[...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=)
 | `75.38% <0.00%> (-1.54%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <0.00%> (-0.82%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.95% <0.00%> (-0.61%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `92.17% <0.00%> (+0.17%)` | :arrow_up: |
   | 
[api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1620/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=)
 | `90.71% <0.00%> (+1.33%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=footer).
 Last update 
[38cf0ba...de7f92c](https://codecov.io/gh/apache/apisix-dashboard/pull/1620?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1584: feat: save Service list page's meta status

[GitBox]

LiteSun commented on a change in pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r598086719



##
File path: web/cypress/integration/service/save-paginator-status.spec.js
##
@@ -30,15 +34,26 @@ context('Save Paginator Status', () => {
 cy.contains('Service').click();
 
 for (let i = 0; i <= 10; i++) {
-  cy.contains('Create').click();
-  cy.get(this.domSelector.name).type(`${this.data.serviceName}&${i}`);
-  cy.get(this.domSelector.nodes_0_host).click();
-  cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
-  cy.contains('Next').click();
-  cy.contains('Next').click();
-  cy.contains('Submit').click();
-  cy.get(this.domSelector.notification).should('contain', 
this.data.createServiceSuccess);
-  
cy.get(this.domSelector.notificationCloseIcon).should('be.visible').click();
+  cy.request({
+method: 'POST',
+url: `${defaultSettings.serveUrlMap[SERVE_ENV]}/apisix/admin/services`,
+headers: {
+  Authorization: token,
+},
+body: {
+  upstream: {
+nodes: {"39.97.63.215:80": 1},
+timeout: {connect: 6, read: 6, send: 6},
+type: 'roundrobin',
+pass_host: 'pass',
+  },
+  enable_websocket: true,
+  plugins: {},  
+  name: `asd${i}`,

Review comment:
   Bad name.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1620: feat: update yarn.lock

[GitBox]

LiteSun commented on pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620#issuecomment-803277119


   ping~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bisakhmondal opened a new pull request #1625: docs: Updating docs for e2e tests

[GitBox]

bisakhmondal opened a new pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   #1303
   closes #1581 
   
   Changes made:
   Updated the `back-end-e2e.md` doc with the latest updates & created a script 
to automate setting up the environment for e2e tests.
   
   TODO:
   - [ ] Doc for how to write unit tests & e2e tests.
   
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1624: Discussion: Is the name field required or not when BE create a route

[GitBox]

juzhiyuan commented on issue #1624:
URL: 
https://github.com/apache/apisix-dashboard/issues/1624#issuecomment-803278379


   cc @nic-chen to confirm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io commented on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(fc31b97) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `19.88%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1625   +/-   ##
   ===
   - Coverage   71.69%   51.81%   -19.89% 
   ===
 Files 133   38   -95 
 Lines5469 2650 -2819 
 Branches  5920  -592 
   ===
   - Hits 3921 1373 -2548 
   + Misses   1305 1089  -216 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [119 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...fc31b97](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrast

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io edited a comment on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(fc31b97) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `4.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1625  +/-   ##
   ==
   - Coverage   71.69%   67.07%   -4.63% 
   ==
 Files 133   47  -86 
 Lines5469 3113-2356 
 Branches  5920 -592 
   ==
   - Hits 3921 2088-1833 
   + Misses   1305  778 -527 
   - Partials  243  247   +4 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.63% <ø> (-0.23%)` | :arrow_down: |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `32.25% <0.00%> (-32.67%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | ... and [86 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...fc31b97](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastru

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io edited a comment on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(fc31b97) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `0.67%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1625  +/-   ##
   ==
   - Coverage   71.69%   71.02%   -0.68% 
   ==
 Files 133   47  -86 
 Lines5469 3113-2356 
 Branches  5920 -592 
   ==
   - Hits 3921 2211-1710 
   + Misses   1305  658 -647 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.74% <ø> (ø)` | |
   | backend-e2e-test-ginkgo | `47.63% <ø> (-0.23%)` | :arrow_down: |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | 
[...components/PluginOrchestration/components/Page.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9QYWdlLnRzeA==)
 | | |
   | 
[.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz)
 | | |
   | 
[...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==)
 | | |
   | 
[web/src/pages/PluginTemplate/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/pages/Upstream/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS90cmFuc2Zvcm0udHM=)
 | | |
   | 
[...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=)
 | | |
   | 
[web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=)
 | | |
   | 
[web/src/pages/Consumer/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Db25zdW1lci9MaXN0LnRzeA==)
 | | |
   | 
[web/src/components/RawDataEditor/RawDataEditor.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Jhd0RhdGFFZGl0b3IvUmF3RGF0YUVkaXRvci50c3g=)
 | | |
   | ... and [77 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...fc31b97](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1624: Discussion: Is the name field required or not when BE create a route

[GitBox]

nic-chen commented on issue #1624:
URL: 
https://github.com/apache/apisix-dashboard/issues/1624#issuecomment-803281404


   I think we could change `name` to be required when we use Manager API 
instead of Admin API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #1623: SSL parse failed when creating Route in v2.4

[GitBox]

nic-chen commented on issue #1623:
URL: 
https://github.com/apache/apisix-dashboard/issues/1623#issuecomment-803281533


   yes, this issue is fixed in the master branch. you could have a try with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1603: chore: improve user friendly on Upstream

[GitBox]

juzhiyuan commented on pull request #1603:
URL: https://github.com/apache/apisix-dashboard/pull/1603#issuecomment-803285842


   ping ~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan opened a new issue #266: support jsDelivr to speedup static files

[GitBox]

juzhiyuan opened a new issue #266:
URL: https://github.com/apache/apisix-website/issues/266


   Hi, after https://github.com/apache/apisix-website/pull/260 is merged, we 
have all logos inside our repository, and now when users visit 
apisix.apache.org , all logos will serve from GitHub, we need to speedup those 
files.
   
   **Solution**
   1. visit https://www.jsdelivr.com/?docs=gh to know what jsDelivr does;
   2. update 
https://github.com/apache/apisix-website/blob/master/website/src/pages/index.js#L123
 `src` prop with jsDelivr . All files are under 
https://github.com/apache/apisix-website/tree/master/website/static/img/showcase
 this folder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1623: SSL parse failed when creating Route in v2.4

[GitBox]

juzhiyuan commented on issue #1623:
URL: 
https://github.com/apache/apisix-dashboard/issues/1623#issuecomment-803289945


   I'm going to close this one, if that issue still occurred in the master 
branch, kindly reopen it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1623: SSL parse failed when creating Route in v2.4

[GitBox]

juzhiyuan closed issue #1623:
URL: https://github.com/apache/apisix-dashboard/issues/1623


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1626: improve Login module

[GitBox]

juzhiyuan opened a new issue #1626:
URL: https://github.com/apache/apisix-dashboard/issues/1626


   Here are some minor issues on the Login page we could resolve.
   
   ## TODO
   
   - [ ] In the upper right corner of the landing page, remove the Settings 
button.
   - [ ] Landing page logo is slightly smaller.
   - [ ] Removing the sample login from the landing page.
   - [ ] Default account password should be entered by default on the landing 
page, so users could log in directly.
   - [ ] Spacing between "How to change default account and password" and the 
login button and password input box on the landing page is too large.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1627: improve Metrics module

[GitBox]

juzhiyuan opened a new issue #1627:
URL: https://github.com/apache/apisix-dashboard/issues/1627


   Here are some minor issues on the Login page we could resolve.
   
   ## TODO
   
   - [ ] Metrics page name change to: Dashboard.
   - [ ] Metrics page hint: Use browser localStorage mechanism to store Grafana 
links locally, as a preview page only, currently no substantive function.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1628: improve Route module

[GitBox]

juzhiyuan opened a new issue #1628:
URL: https://github.com/apache/apisix-dashboard/issues/1628


   Here are some minor issues on the Route page we could resolve.
   
   ## TODO
   
   - [ ] List page, search area field, supplement Placeholder.
   - [ ] Create routing page, step 1, form should be aligned to the left, not 
centered.
   - [ ] Create routing page, title remove spaces.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1629: improve Upstream/Service/SSL/System Info module

[GitBox]

juzhiyuan opened a new issue #1629:
URL: https://github.com/apache/apisix-dashboard/issues/1629


   Here are some minor issues on the Upstream/Service/SSL/System Info page we 
could resolve.
   
   ## Upstream TODO
   
   - [ ] search area, using Table's own, using fuzzy search.
   - [ ] Title section of the list page, add description: upstream (Upstream) 
is .
   
   ## Service TODO
   - [ ] search area, using Table's own, using fuzzy search.
   - [ ] List page title section, add description: Service (Service) is .
   - [ ] Create page, need to add Placeholder for each field.
   - [ ] Create page, select upstream Modify to upstream.
   
   ## SSL TODO
   - [ ] search area, using Table's own, using fuzzy search.
   
   ## System Info
   - [ ] left list, system status modified to System Info.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1630: improve Consumer module

[GitBox]

juzhiyuan opened a new issue #1630:
URL: https://github.com/apache/apisix-dashboard/issues/1630


   Here are some minor issues on the Consumer page we could resolve.
   
   ## TODO
   
   - [ ] search area, using Table's own, using fuzzy search.
   - [ ] List page title section, add description: Consumer (Consumer) is XXX.
   - [ ] Create page, title: Create Consumer, not `Create Consumer`.
   - [ ] Create page, step one, name input box, Placeholder remove spaces.
   - [ ] Create page, step one, description under Name input box: consumer name 
needs to be globally unique; [ ] Create page, step one, description under Name 
input box: consumer name needs to be globally unique.
   - [ ] Create/edit/delete successfully prompt, do not include spaces.
   - [ ] list page, add enabled plugin fields, wrap them in tags for display.
   - [ ] Edit mode, the title needs to be changed to: Edit Consumer.
   
   
   Translated with www.DeepL.com/Translator (free version)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1631: improve Plugin module

[GitBox]

juzhiyuan opened a new issue #1631:
URL: https://github.com/apache/apisix-dashboard/issues/1631


   Here are some minor issues on the Plugin page we could resolve.
   
   ## TODO
   
   - [ ] Search area, using Table's own, using fuzzy search.
   - [ ] page title not internationalized: configure global plugins/Configure 
Global Plugin.
   - [ ] Add icon for Plugin Marketplace plugins.
   - [ ] list page top title, add description: list of enabled plugins.
   - [ ] list page, edit button in action area modified to: `配置/Configure`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1632: improve some minor issue

[GitBox]

juzhiyuan opened a new issue #1632:
URL: https://github.com/apache/apisix-dashboard/issues/1632


   Here are some minor issues on the Login page we could resolve.
   
   ## TODO
   - [ ] Left icon replacement. @LiteSun 
   - [ ] Extracting Table as a separate component for reuse in various modules.
   - [ ] APISIX plugin type change.
   - [ ] GitHub hyperlink (icon) added to Header section.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1584: feat: save Service list page's meta status

[GitBox]

guoqqqi commented on a change in pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#discussion_r598099217



##
File path: web/cypress/integration/service/save-paginator-status.spec.js
##
@@ -30,15 +34,26 @@ context('Save Paginator Status', () => {
 cy.contains('Service').click();
 
 for (let i = 0; i <= 10; i++) {
-  cy.contains('Create').click();
-  cy.get(this.domSelector.name).type(`${this.data.serviceName}&${i}`);
-  cy.get(this.domSelector.nodes_0_host).click();
-  cy.get(this.domSelector.nodes_0_host).type(this.data.ip1);
-  cy.contains('Next').click();
-  cy.contains('Next').click();
-  cy.contains('Submit').click();
-  cy.get(this.domSelector.notification).should('contain', 
this.data.createServiceSuccess);
-  
cy.get(this.domSelector.notificationCloseIcon).should('be.visible').click();
+  cy.request({
+method: 'POST',
+url: `${defaultSettings.serveUrlMap[SERVE_ENV]}/apisix/admin/services`,
+headers: {
+  Authorization: token,
+},
+body: {
+  upstream: {
+nodes: {"39.97.63.215:80": 1},
+timeout: {connect: 6, read: 6, send: 6},
+type: 'roundrobin',
+pass_host: 'pass',
+  },
+  enable_websocket: true,
+  plugins: {},  
+  name: `asd${i}`,

Review comment:
   done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status

[GitBox]

codecov-io edited a comment on pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=h1) 
Report
   > Merging 
[#1584](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=desc) 
(d912dcb) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `19.84%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1584   +/-   ##
   ===
   - Coverage   71.65%   51.81%   -19.85% 
   ===
 Files 133   38   -95 
 Lines5429 2650 -2779 
 Branches  5920  -592 
   ===
   - Hits 3890 1373 -2517 
   + Misses   1296 1089  -207 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [112 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=footer).
 Last update 
[38cf0ba...d912dcb](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status

[GitBox]

codecov-io edited a comment on pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=h1) 
Report
   > Merging 
[#1584](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=desc) 
(d912dcb) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `4.28%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1584  +/-   ##
   ==
   - Coverage   71.65%   67.36%   -4.29% 
   ==
 Files 133   47  -86 
 Lines5429 3113-2316 
 Branches  5920 -592 
   ==
   - Hits 3890 2097-1793 
   + Misses   1296  770 -526 
   - Partials  243  246   +3 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.92% <ø> (+0.58%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-9.65%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-3.64%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | ... and [82 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=footer).
 Last update 
[38cf0ba...d912dcb](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries abo

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1584: feat: save Service list page's meta status

[GitBox]

codecov-io edited a comment on pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-797880776


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=h1) 
Report
   > Merging 
[#1584](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=desc) 
(d912dcb) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/38cf0ba32264d5a7bb4f22bd40ce037e2f66a939?el=desc)
 (38cf0ba) will **decrease** coverage by `0.56%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1584  +/-   ##
   ==
   - Coverage   71.65%   71.08%   -0.57% 
   ==
 Files 133   47  -86 
 Lines5429 3113-2316 
 Branches  5920 -592 
   ==
   - Hits 3890 2213-1677 
   + Misses   1296  657 -639 
 Partials  243  243  
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.80% <ø> (+0.23%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `47.92% <ø> (+0.58%)` | :arrow_up: |
   | backend-unit-test | `51.81% <ø> (+0.58%)` | :arrow_up: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-3.64%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <0.00%> (-0.82%)` | :arrow_down: |
   | 
[...pages/Route/components/Step1/MatchingRulesView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01hdGNoaW5nUnVsZXNWaWV3LnRzeA==)
 | | |
   | 
[web/src/services/tool.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy90b29sLnRz)
 | | |
   | 
[web/src/pages/SSL/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvc2VydmljZS50cw==)
 | | |
   | 
[.../Route/components/DebugViews/DebugFormDataView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdGb3JtRGF0YVZpZXcudHN4)
 | | |
   | 
[web/src/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb25zdGFudHMudHM=)
 | | |
   | 
[...eb/src/pages/PluginTemplate/components/Preview.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1ByZXZpZXcudHN4)
 | | |
   | 
[web/src/pages/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/pages/Route/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS90cmFuc2Zvcm0udHM=)
 | | |
   | ... and [74 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1584/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=footer).
 Last update 
[38cf0ba...d912dcb](https://codecov.io/gh/apache/apisix-dashboard/pull/1584?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique (#1619)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 45df5b2  fix: (route_online_debug)Change the appended Content-type 
data to overlay to ensure that the Content-type is unique (#1619)
45df5b2 is described below

commit 45df5b26715abc1f02bd69799147a634a20e1b2e
Author: JinChen 
AuthorDate: Sat Mar 20 19:41:42 2021 +0800

fix: (route_online_debug)Change the appended Content-type data to overlay 
to ensure that the Content-type is unique (#1619)

Co-authored-by: liuxiran 
---
 .../route_online_debug/route_online_debug.go   |  6 ++-
 .../route_online_debug/route_online_debug_test.go  | 63 +-
 .../consumer/create_and_delete_consumer.spec.js| 10 ++--
 web/cypress/integration/route/search-route.spec.js |  4 +-
 4 files changed, 72 insertions(+), 11 deletions(-)

diff --git a/api/internal/handler/route_online_debug/route_online_debug.go 
b/api/internal/handler/route_online_debug/route_online_debug.go
index a419757..e7bbee3 100644
--- a/api/internal/handler/route_online_debug/route_online_debug.go
+++ b/api/internal/handler/route_online_debug/route_online_debug.go
@@ -118,7 +118,11 @@ func (h *HTTPProtocolSupport) RequestForwarding(c 
droplet.Context) (interface{},
req.Header.Add("Content-Type", contentType)
for k, v := range tempMap {
for _, v1 := range v {
-   req.Header.Add(k, v1)
+   if !strings.EqualFold(k, "Content-Type") {
+   req.Header.Add(k, v1)
+   } else {
+   req.Header.Set(k, v1)
+   }
}
}
 
diff --git a/api/test/e2enew/route_online_debug/route_online_debug_test.go 
b/api/test/e2enew/route_online_debug/route_online_debug_test.go
index fc52c81..cd09aef 100644
--- a/api/test/e2enew/route_online_debug/route_online_debug_test.go
+++ b/api/test/e2enew/route_online_debug/route_online_debug_test.go
@@ -156,6 +156,7 @@ var _ = 
ginkgo.Describe("Route_Online_Debug_Route_With_Header_Params", func() {
ginkgo.It("create route with header params", func() {
t := ginkgo.GinkgoT()
var routeBody map[string]interface{} = map[string]interface{}{
+   "name":"route1",
"uri": "/hello",
"methods": []string{"GET"},
"vars": []interface{}{
@@ -193,7 +194,46 @@ var _ = 
ginkgo.Describe("Route_Online_Debug_Route_With_Header_Params", func() {
Sleep:base.SleepTime,
})
})
-   ginkgo.It("delete the route just created", func() {
+   ginkgo.It("online debug route with header params(add Content-type to 
header params to create route)", func() {
+   t := ginkgo.GinkgoT()
+   var routeBody map[string]interface{} = map[string]interface{}{
+   "name": "route2",
+   "status":   1,
+   "uri":  "/hello_",
+   "methods":  []string{"GET"},
+   "upstream": upstream,
+   }
+   _reqRouteBody, err := json.Marshal(routeBody)
+   assert.Nil(t, err)
+   base.RunTestCase(base.HttpTestCase{
+   Object: base.ManagerApiExpect(),
+   Method: http.MethodPost,
+   Path:   "/apisix/admin/debug-request-forwarding",
+   Body:   string(_reqRouteBody),
+   Headers: map[string]string{
+   "Authorization": 
base.GetToken(),
+   "online_debug_url":  
base.ManagerAPIHost + `/apisix/admin/routes/r2`,
+   "online_debug_request_protocol": "http",
+   "online_debug_method":   http.MethodPut,
+   "Content-Type":  
"text/plain;charset=UTF-8",
+   "online_debug_header_params":
`{"Content-type":["application/json"],"Authorization":["` + base.GetToken() + 
`"]}`,
+   },
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   `{"code":200,"message":"200 OK"`,
+   Sleep:base.SleepTime,
+   })
+   })
+   ginkgo.It("hit the route (r2)", func() {
+   base.RunTestCase(base.HttpTestCase{
+   Object:   base.APISIXExpect(),
+   Method:   http.MethodGet,
+   Path: "/hello_",
+   ExpectStatus: http.StatusOK,
+   ExpectBody:   "he

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1619: fix: (route_online_debug)Change the appended Content-type data to overlay to ensure that the Content-type is unique

[GitBox]

juzhiyuan merged pull request #1619:
URL: https://github.com/apache/apisix-dashboard/pull/1619


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1632: improve some minor issues

[GitBox]

iamayushdas commented on issue #1632:
URL: 
https://github.com/apache/apisix-dashboard/issues/1632#issuecomment-803296597


   Would like to work on this Assign this to me @juzhiyuan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1632: improve some minor issues

[GitBox]

juzhiyuan commented on issue #1632:
URL: 
https://github.com/apache/apisix-dashboard/issues/1632#issuecomment-803296971


   as for the first one, @LiteSun will do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1626: improve Login module

[GitBox]

iamayushdas commented on issue #1626:
URL: 
https://github.com/apache/apisix-dashboard/issues/1626#issuecomment-803297047


   Assign this to me @juzhiyuan 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1626: improve Login module

[GitBox]

juzhiyuan commented on issue #1626:
URL: 
https://github.com/apache/apisix-dashboard/issues/1626#issuecomment-803297209


   thanks, and you could resolve those 2 issues first :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on issue #1627: improve Metrics module

[GitBox]

stu01509 commented on issue #1627:
URL: 
https://github.com/apache/apisix-dashboard/issues/1627#issuecomment-803299560


   I would like to try this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on issue #1629: improve Upstream/Service/SSL/System Info module

[GitBox]

stu01509 commented on issue #1629:
URL: 
https://github.com/apache/apisix-dashboard/issues/1629#issuecomment-803299678


   I would like to fix it, please assign this issue to me :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1605: fix: fix the uptime translation error

[GitBox]

stu01509 commented on pull request #1605:
URL: https://github.com/apache/apisix-dashboard/pull/1605#issuecomment-803299873


   Hi @juzhiyuan and @guoqqqi 
   
   Seems like this PR passed the CI, Please review it 😀


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] qian0817 commented on issue #1628: improve Route module

[GitBox]

qian0817 commented on issue #1628:
URL: 
https://github.com/apache/apisix-dashboard/issues/1628#issuecomment-803301401


   @juzhiyuan Can I work on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1628: improve Route module

[GitBox]

juzhiyuan commented on issue #1628:
URL: 
https://github.com/apache/apisix-dashboard/issues/1628#issuecomment-803301467


   Sure 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-ingress-controller] branch master updated: chore: redesign nginxVars to exprs (#306)

[kvn]

This is an automated email from the ASF dual-hosted git repository.

kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git


The following commit(s) were added to refs/heads/master by this push:
 new 6461186  chore: redesign nginxVars to exprs (#306)
6461186 is described below

commit 646118696c3eb998ec1619cfdd6560f8c6662105
Author: Alex Zhang 
AuthorDate: Sat Mar 20 20:58:19 2021 +0800

chore: redesign nginxVars to exprs (#306)
---
 docs/en/latest/concepts/apisix_route.md|  13 +-
 docs/en/latest/references/apisix_route_v2alpha1.md |  12 +-
 pkg/kube/apisix/apis/config/v2alpha1/types.go  |  28 +++-
 .../apis/config/v2alpha1/zz_generated.deepcopy.go  |  27 +++-
 pkg/kube/translation/apisix_route.go   |  29 +++-
 pkg/kube/translation/apisix_route_test.go  | 178 +++--
 .../{nginx_vars.go => route_match_exprs.go}|  62 ---
 7 files changed, 222 insertions(+), 127 deletions(-)

diff --git a/docs/en/latest/concepts/apisix_route.md 
b/docs/en/latest/concepts/apisix_route.md
index 52a9a7e..9d0c11f 100644
--- a/docs/en/latest/concepts/apisix_route.md
+++ b/docs/en/latest/concepts/apisix_route.md
@@ -67,7 +67,7 @@ Advanced route features
 ---
 
 Path based route are most common, but if it's not enough, try
-other route features in `ApisixRoute` such as `methods`, `nginxVars`.
+other route features in `ApisixRoute` such as `methods`, `exprs`.
 
 The `methods` splits traffic according to the HTTP method, the following 
configurations routes requests
 with `GET` method to `foo` service (a Kubernetes Service).
@@ -90,7 +90,7 @@ spec:
 servicePort: 80
 ```
 
-The `nginxVars` allows user to configure match conditions with arbitrary 
predicates in HTTP, such as queries, HTTP headers and etc.
+The `exprs` allows user to configure match conditions with arbitrary 
predicates in HTTP, such as queries, HTTP headers, Cookie.
 It's composed by several expressions, which in turn composed by subject, 
operator and value/set.
 
 ```yaml
@@ -104,8 +104,10 @@ spec:
   match:
 paths:
   - /
-nginxVars:
-  - subject: arg_id
+exprs:
+  - subject:
+  scope: Query
+  name: id
 op: Equal
 value: 2143
   backend:
@@ -114,8 +116,7 @@ spec:
 ```
 
 The above configuration configures an extra route match condition, which asks 
the
-query `id` must be equal to `2143`. Note the subject is in [Nginx 
Variables](http://nginx.org/en/docs/varindex.html) style
-(but without the leading `$` symbol).
+query `id` must be equal to `2143`.
 
 Service Resolution Granularity
 --
diff --git a/docs/en/latest/references/apisix_route_v2alpha1.md 
b/docs/en/latest/references/apisix_route_v2alpha1.md
index 40795c5..827d411 100644
--- a/docs/en/latest/references/apisix_route_v2alpha1.md
+++ b/docs/en/latest/references/apisix_route_v2alpha1.md
@@ -35,11 +35,13 @@ Meaning of each field in the spec of ApisixRoute are 
followed, the top level fie
 | http[].match.hosts   | array   | A series of hosts that should be matched 
(oneof) to use this route rule.
 | http[].match.methods | array | A series of HTTP methods(`GET`, `POST`, 
`PUT`, `DELETE`, `PATCH`, `HEAD`, `OPTIONS`, `CONNECT`, `TRACE`) that should be 
matched (oneof) to use this route rule.
 | http[].match.remote_addrs   | array  | A series of IP address (CIDR 
format) that should be matched (oneof) to use this route rule.
-| http[].match.nginxVars  | array   | A series expressions that the 
results should be matched (oneof) to use this route rule.
-| http[].match.nginxVars[].subject   | string| Expression subject, 
which is in [Nginx Variables](http://nginx.org/en/docs/varindex.html) style.
-| http[].match.nginxVars[].op | string | Expression operator, see [Expression 
Operators](#expression-operators) for the detail of enumerations.
-| http[].match.nginxVars[].value | string | Expected expression result, it's 
exclusive with `http[].match.nginxVars[].set`.
-| http[].match.nginxVars[].set | array | Expected expression result set, only 
used when the operator is `In` or `NotIn`, it's exclusive with 
`http[].match.nginxVars[].value`.
+| http[].match.exprs  | array   | A series expressions that the 
results should be matched (oneof) to use this route rule.
+| http[].match.exprs[].subject   | object| Expression subject.
+| http[].match.exprs[].subject.scope   | string| Specify where to find 
the subject, values can be `Header`, `Query`, `Cookie` and `Path`.
+| http[].match.exprs[].subject.name   | string| Specify subject name, 
when scope is `Path`, this field can be absent.
+| http[].match.exprs[].op | string | Expression operator, see [Expression 
Operators](#expression-operators) for the detail of enumerations.
+| http[].match.exprs[].value | string | Expected expression re

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #306: chore: re-design nginxVars to exprs

[GitBox]

gxthrj merged pull request #306:
URL: https://github.com/apache/apisix-ingress-controller/pull/306


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #307: chore: add yaml tags for types

[GitBox]

gxthrj commented on pull request #307:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/307#issuecomment-803314819


   @fgksgf There are some conflicting files need to be resolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

[GitBox]

codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=h1) 
Report
   > Merging 
[#1612](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=desc) 
(152f85e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/735a0828da1af0b952a685f39d93439b028d0dbf?el=desc)
 (735a082) will **decrease** coverage by `19.35%`.
   > The diff coverage is `87.50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1612   +/-   ##
   ===
   - Coverage   71.12%   51.77%   -19.36% 
   ===
 Files  47   38-9 
 Lines3100 2650  -450 
   ===
   - Hits 2205 1372  -833 
   - Misses652 1090  +438 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.77% <87.50%> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `68.69% <87.50%> (-23.31%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | ... and [32 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=footer).
 Last update 
[735a082...152f85e](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 opened a new pull request #1633: feat: add the service page upstream select option

[GitBox]

stu01509 opened a new pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   Fix #16166
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   Add the **None** option in the service page upstream select.
   
   
![image](https://user-images.githubusercontent.com/22230889/111870606-a5018b00-89c0-11eb-9fb6-0a75335bf777.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1633: feat: add the service page upstream select option

[GitBox]

stu01509 commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r598110242



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -663,6 +663,9 @@ const UpstreamForm: React.FC = forwardRef(
   name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.option' }),
   id: '',
 },
+{
+  name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.none' }),
+},

Review comment:
   Hi @juzhiyuan, @Firstsawyou, and @nic-chen 
   
   Could you guide should remove the id field or change it to another value?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1633: feat: add the service page upstream select option

[GitBox]

codecov-io commented on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=h1) 
Report
   > Merging 
[#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=desc) 
(78199c5) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `20.11%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1633   +/-   ##
   ===
   - Coverage   71.92%   51.81%   -20.12% 
   ===
 Files 133   38   -95 
 Lines5472 2650 -2822 
 Branches  5920  -592 
   ===
   - Hits 3936 1373 -2563 
   + Misses   1293 1089  -204 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-74.77%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [118 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=footer).
 Last update 
[45df5b2...78199c5](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrast

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

[GitBox]

codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=h1) 
Report
   > Merging 
[#1612](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=desc) 
(131c530) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/735a0828da1af0b952a685f39d93439b028d0dbf?el=desc)
 (735a082) will **decrease** coverage by `19.35%`.
   > The diff coverage is `87.50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1612   +/-   ##
   ===
   - Coverage   71.12%   51.77%   -19.36% 
   ===
 Files  47   38-9 
 Lines3100 2650  -450 
   ===
   - Hits 2205 1372  -833 
   - Misses652 1090  +438 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.77% <87.50%> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `68.69% <87.50%> (-23.31%)` | :arrow_down: |
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | ... and [32 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=footer).
 Last update 
[735a082...131c530](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

[GitBox]

codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=h1) 
Report
   > Merging 
[#1612](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=desc) 
(152f85e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/735a0828da1af0b952a685f39d93439b028d0dbf?el=desc)
 (735a082) will **decrease** coverage by `3.79%`.
   > The diff coverage is `95.00%`.
   
   > :exclamation: Current head 152f85e differs from pull request most recent 
head 131c530. Consider uploading reports for the commit 131c530 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1612  +/-   ##
   ==
   - Coverage   71.12%   67.32%   -3.80% 
   ==
 Files  47   47  
 Lines3100 3116  +16 
   ==
   - Hits 2205 2098 -107 
   - Misses652  771 +119 
   - Partials  243  247   +4 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.94% <80.00%> (+0.07%)` | :arrow_up: |
   | backend-unit-test | `51.77% <87.50%> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <ø> (-9.65%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `92.17% <93.75%> (+0.17%)` | :arrow_up: |
   | 
[...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==)
 | `75.92% <100.00%> (+1.41%)` | :arrow_up: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | ... and [4 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=footer).
 Last update 
[735a082...131c530](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure a

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

[GitBox]

codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=h1) 
Report
   > Merging 
[#1612](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=desc) 
(152f85e) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/735a0828da1af0b952a685f39d93439b028d0dbf?el=desc)
 (735a082) will **increase** coverage by `0.01%`.
   > The diff coverage is `95.00%`.
   
   > :exclamation: Current head 152f85e differs from pull request most recent 
head 131c530. Consider uploading reports for the commit 131c530 to get more 
accurate results
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1612  +/-   ##
   ==
   + Coverage   71.12%   71.14%   +0.01% 
   ==
 Files  47   47  
 Lines3100 3116  +16 
   ==
   + Hits 2205 2217  +12 
   - Misses652  655   +3 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.90% <80.00%> (+0.09%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `47.94% <80.00%> (+0.07%)` | :arrow_up: |
   | backend-unit-test | `51.77% <87.50%> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <ø> (-0.82%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `92.17% <93.75%> (+0.17%)` | :arrow_up: |
   | 
[...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==)
 | `75.92% <100.00%> (+1.41%)` | :arrow_up: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-1.81%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=footer).
 Last update 
[735a082...131c530](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option

[GitBox]

codecov-io edited a comment on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=h1) 
Report
   > Merging 
[#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=desc) 
(78199c5) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `4.59%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1633  +/-   ##
   ==
   - Coverage   71.92%   67.32%   -4.60% 
   ==
 Files 133   47  -86 
 Lines5472 3116-2356 
 Branches  5920 -592 
   ==
   - Hits 3936 2098-1838 
   + Misses   1293  771 -522 
   - Partials  243  247   +4 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.91% <ø> (-0.36%)` | :arrow_down: |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-7.48%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-7.28%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | ... and [85 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=footer).
 Last update 
[45df5b2...78199c5](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this servic

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option

[GitBox]

codecov-io edited a comment on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=h1) 
Report
   > Merging 
[#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=desc) 
(78199c5) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `0.74%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1633  +/-   ##
   ==
   - Coverage   71.92%   71.18%   -0.75% 
   ==
 Files 133   47  -86 
 Lines5472 3116-2356 
 Branches  5920 -592 
   ==
   - Hits 3936 2218-1718 
   + Misses   1293  654 -639 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.90% <ø> (-0.36%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `47.91% <ø> (-0.36%)` | :arrow_down: |
   | backend-unit-test | `51.81% <ø> (ø)` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `71.02% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `47.27% <0.00%> (-3.64%)` | :arrow_down: |
   | 
[web/src/pages/PluginTemplate/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9jb21wb25lbnRzL1N0ZXAxLnRzeA==)
 | | |
   | 
[web/src/pages/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW4vc2VydmljZS50cw==)
 | | |
   | 
[...eb/src/components/PluginOrchestration/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29uc3RhbnRzLnRz)
 | | |
   | 
[web/src/components/IconFont/IconFont.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0ljb25Gb250L0ljb25Gb250LnRzeA==)
 | | |
   | 
[...eb/src/components/PluginOrchestration/transform.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vdHJhbnNmb3JtLnRz)
 | | |
   | 
[...pages/Route/components/Step1/RequestConfigView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL1JlcXVlc3RDb25maWdWaWV3LnRzeA==)
 | | |
   | 
[web/src/components/LabelsfDrawer/LabelsDrawer.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0xhYmVsc2ZEcmF3ZXIvTGFiZWxzRHJhd2VyLnRzeA==)
 | | |
   | 
[web/src/pages/Route/constants.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb25zdGFudHMudHM=)
 | | |
   | ... and [77 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=footer).
 Last update 
[45df5b2...78199c5](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

[GitBox]

codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=h1) 
Report
   > Merging 
[#1612](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=desc) 
(131c530) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/735a0828da1af0b952a685f39d93439b028d0dbf?el=desc)
 (735a082) will **decrease** coverage by `3.86%`.
   > The diff coverage is `95.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1612  +/-   ##
   ==
   - Coverage   71.12%   67.26%   -3.87% 
   ==
 Files  47   47  
 Lines3100 3116  +16 
   ==
   - Hits 2205 2096 -109 
   - Misses652  775 +123 
   - Partials  243  245   +2 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.88% <80.00%> (+0.01%)` | :arrow_up: |
   | backend-unit-test | `51.77% <87.50%> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <ø> (-9.65%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `92.17% <93.75%> (+0.17%)` | :arrow_up: |
   | 
[...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==)
 | `75.92% <100.00%> (+1.41%)` | :arrow_up: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `42.72% <0.00%> (-4.55%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | ... and [5 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=footer).
 Last update 
[735a082...131c530](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1612: add more fe e2e test cases for online debug

[GitBox]

codecov-io edited a comment on pull request #1612:
URL: https://github.com/apache/apisix-dashboard/pull/1612#issuecomment-801563633


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=h1) 
Report
   > Merging 
[#1612](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=desc) 
(131c530) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/735a0828da1af0b952a685f39d93439b028d0dbf?el=desc)
 (735a082) will **decrease** coverage by `0.10%`.
   > The diff coverage is `95.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1612  +/-   ##
   ==
   - Coverage   71.12%   71.02%   -0.11% 
   ==
 Files  47   47  
 Lines3100 3116  +16 
   ==
   + Hits 2205 2213   +8 
   - Misses652  659   +7 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.77% <80.00%> (-0.03%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `47.88% <80.00%> (+0.01%)` | :arrow_up: |
   | backend-unit-test | `51.77% <87.50%> (+0.16%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <ø> (-0.82%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `92.17% <93.75%> (+0.17%)` | :arrow_up: |
   | 
[...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==)
 | `75.92% <100.00%> (+1.41%)` | :arrow_up: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-3.64%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1612/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-1.81%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=footer).
 Last update 
[735a082...131c530](https://codecov.io/gh/apache/apisix-dashboard/pull/1612?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #308: feat: traffic split

[GitBox]

gxthrj commented on a change in pull request #308:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/308#discussion_r598109279



##
File path: docs/en/latest/concepts/apisix_route.md
##
@@ -139,12 +139,46 @@ spec:
   - /*
 methods:
   - GET
-  backend:
-serviceName: foo
-servicePort: 80
-resolveGranularity: service
+  backends:
+- serviceName: foo
+  servicePort: 80
+  resolveGranularity: service
 ```
 
+Weight Based Traffic Split
+--
+
+There can more than one backend specified in one route rule,
+when multiple backends co-exist there, the traffic split based on weights
+will be applied (which actually uses the 
[traffic-split](http://apisix.apache.org/docs/apisix/plugins/traffic-split/) 
plugin in Apache APISIX).
+You can specify weight for each backend, the default weight is `100`.
+
+```yaml
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+  name: method-route
+spec:
+  http:
+- name: method
+  match:
+paths:
+  - /*
+methods:
+  - GET
+  backends:
+- serviceName: foo
+  servicePort: 80
+  weight: 100
+- serviceName: bar
+  servicePort: 81
+  weight: 50
+```
+
+The above `ApisixRoute` has one route rule, which contains two backends `foo` 
and `bar`, the
+weight ratio is `100:50`, which means `2/3` requests will be sent to service 
`foo` and `1/3` requests
+will be proxied to serivce `bar`.
+

Review comment:
   Need example to show `match` with `vars`.

##
File path: pkg/kube/translation/util.go
##
@@ -0,0 +1,86 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package translation
+
+import (
+   "errors"
+
+   "go.uber.org/zap"
+   "k8s.io/apimachinery/pkg/util/intstr"
+
+   "github.com/apache/apisix-ingress-controller/pkg/id"
+   configv2alpha1 
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2alpha1"
+   "github.com/apache/apisix-ingress-controller/pkg/log"
+   apisixv1 
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
+)
+
+func (t *translator) getServiceClusterIPAndPort(backend 
*configv2alpha1.ApisixRouteHTTPBackend, ar *configv2alpha1.ApisixRoute) 
(string, int32, error) {
+   svc, err := 
t.ServiceLister.Services(ar.Namespace).Get(backend.ServiceName)
+   if err != nil {
+   return "", 0, err
+   }
+   svcPort := int32(-1)
+loop:
+   for _, port := range svc.Spec.Ports {
+   switch backend.ServicePort.Type {
+   case intstr.Int:
+   if backend.ServicePort.IntVal == port.Port {
+   svcPort = port.Port
+   break loop
+   }
+   case intstr.String:
+   if backend.ServicePort.StrVal == port.Name {
+   svcPort = port.Port
+   break loop
+   }
+   }
+   }
+   if svcPort == -1 {
+   log.Errorw("ApisixRoute refers to non-existent Service port",
+   zap.Any("ApisixRoute", ar),
+   zap.String("port", backend.ServicePort.String()),
+   )
+   return "", 0, err
+   }
+
+   if backend.ResolveGranularity == "service" && svc.Spec.ClusterIP == "" {
+   log.Errorw("ApisixRoute refers to a headless service but want 
to use the service level resolve granularity",
+   zap.Any("ApisixRoute", ar),
+   zap.Any("service", svc),
+   )
+   return "", 0, errors.New("conflict headless service and backend 
resolve granularity")
+   }
+   return svc.Spec.ClusterIP, svcPort, nil
+}
+
+func (t *translator) translateUpstream(namespace, svcName, 
svcResolveGranularity, svcClusterIP string, svcPort int32) (*apisixv1.Upstream, 
error) {
+   ups, err := t.TranslateUpstream(namespace, svcName, svcPort)
+   if err != nil {
+   return nil, err
+   }
+   if svcResolveGranularity == "serv

[GitHub] [apisix] keenbo opened a new issue #3874: bug: [grpc transcode] Can not conver protobuf message's sub message from json input

[GitBox]

keenbo opened a new issue #3874:
URL: https://github.com/apache/apisix/issues/3874


   ### Issue description
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 2.4
   * OS (cmd: `uname -a`):centos 8 
   * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   nginx version: openresty/1.19.3.1
   built by gcc 8.3.1 20190311 (Red Hat 8.3.1-3) (GCC) 
   built with OpenSSL 1.1.1h  22 Sep 2020 (running with OpenSSL 1.1.1i  8 Dec 
2020)
   TLS SNI support enabled
   configure arguments: --prefix=/usr/local/openresty/nginx --with-cc-opt='-O2 
-DNGX_LUA_ABORT_AT_PANIC -I/usr/local/openresty/zlib/include 
-I/usr/local/openresty/pcre/include -I/usr/local/openresty/openssl111/include' 
--add-module=../ngx_devel_kit-0.3.1 --add-module=../echo-nginx-module-0.62 
--add-module=../xss-nginx-module-0.06 --add-module=../ngx_coolkit-0.2 
--add-module=../set-misc-nginx-module-0.32 
--add-module=../form-input-nginx-module-0.12 
--add-module=../encrypted-session-nginx-module-0.08 
--add-module=../srcache-nginx-module-0.32 --add-module=../ngx_lua-0.10.19 
--add-module=../ngx_lua_upstream-0.07 
--add-module=../headers-more-nginx-module-0.33 
--add-module=../array-var-nginx-module-0.05 
--add-module=../memc-nginx-module-0.19 --add-module=../redis2-nginx-module-0.15 
--add-module=../redis-nginx-module-0.3.7 --add-module=../ngx_stream_lua-0.0.9 
--with-ld-opt='-Wl,-rpath,/usr/local/openresty/luajit/lib 
-L/usr/local/openresty/zlib/lib -L/usr/local/openresty/pcre/lib -L/usr/loca
 l/openresty/openssl111/lib 
-Wl,-rpath,/usr/local/openresty/zlib/lib:/usr/local/openresty/pcre/lib:/usr/local/openresty/openssl111/lib'
 --with-cc='ccache gcc -fdiagnostics-color=always' --with-pcre-jit 
--with-stream --with-stream_ssl_module --with-stream_ssl_preread_module 
--with-http_v2_module --without-mail_pop3_module --without-mail_imap_module 
--without-mail_smtp_module --with-http_stub_status_module 
--with-http_realip_module --with-http_addition_module 
--with-http_auth_request_module --with-http_secure_link_module 
--with-http_random_index_module --with-http_gzip_static_module 
--with-http_sub_module --with-http_dav_module --with-http_flv_module 
--with-http_mp4_module --with-http_gunzip_module --with-threads --with-compat 
--with-stream --with-http_ssl_module
   
   * etcd version, if have (cmd: run `curl 
http://127.0.0.1:9090/v1/server_info` to get the info from server-info 
API):3.4.9
   * apisix-dashboard version, if have: no
   
   ### Minimal test code / Steps to reproduce the issue
   
   1.step 1: set correct proto and upstream svr
   ```
   curl http://127.0.0.1:9080/apisix/admin/proto/1 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "content" : "syntax = \"proto3\";
   package helloworld;
   service Greeter {
   rpc SayHello (HelloRequest) returns (HelloReply) {}
   }
   message Info {
 string id = 1;
 string msg = 2;
   }
   message HelloRequest {
 string name = 1;
 Info req_info = 2;
   }
   message HelloReply {
   string message = 1;
Info rsp_info = 2;
   }"
   }'
   
   curl http://127.0.0.1:9080/apisix/admin/routes/111 -H 'X-API-KEY: 
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
   {
   "methods": ["GET","POST"],
   "uri": "/grpctest2",
   "plugins": {
   "grpc-transcode": {
   "proto_id": "1",
   "service": "helloworld.Greeter",
   "method": "SayHello"
   }
   },
   "upstream": {
   "scheme": "grpc",
   "type": "roundrobin",
   "nodes": {
   "192.168.155.111:5000": 1
   }
   }
   }'
   
   ```
   2.Use curl for requesting the upstream.
   ```
   curl -X POST  -H  "Content-Type:application/json"  -H "te:trailers" -i 
http://127.0.0.1:9080/grpctest2  \
   -d '{"name":"jack2","req_info":{"id":"id-001","msg":""}}'
   ```
   
   ### What's the actual result? (including assertion message & call stack if 
applicable)
   
   The grpc server should receive the *req_info* field successfully. But the 
grpc server do not received the field while processing the request. 
   
   The printed result of pb's DebugString() method looks like:
   ```
   name: "jack2"
   req_info {
   }
   ```
   
   ### What's the expected result?
   
   ```
   name: "jack2"
   req_info {
 id: "id-001",
msg: ""
   }
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1633: feat: add the service page upstream select option

[GitBox]

bisakhmondal commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r598115503



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -663,6 +663,9 @@ const UpstreamForm: React.FC = forwardRef(
   name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.option' }),
   id: '',
 },
+{
+  name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.none' }),

Review comment:
   Hii @stu01509, thanks for the good work :+1: . I'm just curious a bit 
about the changes. The generic component UpstreamForm is used by services as we 
as other two pages
   
![image](https://user-images.githubusercontent.com/41498427/111871855-39b0bc80-89b2-11eb-8cd3-9b1eab00fea5.png)
   which includes routes & upstream too. Making a global change to the 
component itself will let others select `None` which is not solicited (because 
route/upstream with none value doesn't make sense). I may be wrong though, haha.
   
   Hey, guys please confirm.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1633: feat: add the service page upstream select option

[GitBox]

stu01509 commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r598116103



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -663,6 +663,9 @@ const UpstreamForm: React.FC = forwardRef(
   name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.option' }),
   id: '',
 },
+{
+  name: formatMessage({ id: 
'page.upstream.step.select.upstream.select.none' }),

Review comment:
   Hi @bisakhmondal 
   
   Thanks for your mention, I think it may need to wait for @juzhiyuan and 
@Firstsawyou confirm haha.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option

[GitBox]

codecov-io edited a comment on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=h1) 
Report
   > Merging 
[#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=desc) 
(6749ff0) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `23.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1633   +/-   ##
   ===
   - Coverage   71.92%   47.97%   -23.96% 
   ===
 Files 133   47   -86 
 Lines5472 3116 -2356 
 Branches  5920  -592 
   ===
   - Hits 3936 1495 -2441 
   - Misses   1293 1338   +45 
   - Partials  243  283   +40 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.97% <ø> (-0.29%)` | :arrow_down: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `36.11% <0.00%> (-41.67%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `57.22% <0.00%> (-30.73%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `51.83% <0.00%> (-26.94%)` | :arrow_down: |
   | ... and [103 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=footer).
 Last update 
[45df5b2...6749ff0](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1633: feat: add the service page upstream select option

[GitBox]

codecov-io edited a comment on pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-803316539


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=h1) 
Report
   > Merging 
[#1633](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=desc) 
(6749ff0) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `10.02%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1633   +/-   ##
   ===
   - Coverage   71.92%   61.90%   -10.03% 
   ===
 Files 133   47   -86 
 Lines5472 3116 -2356 
 Branches  5920  -592 
   ===
   - Hits 3936 1929 -2007 
   + Misses   1293  874  -419 
   - Partials  243  313   +70 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.90% <ø> (-0.36%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `47.97% <ø> (-0.29%)` | :arrow_down: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
   | 
[api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=)
 | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
   | 
[...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv)
 | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
   | 
[api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=)
 | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
   | 
[api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=)
 | `77.14% <0.00%> (-13.58%)` | :arrow_down: |
   | ... and [99 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1633/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=footer).
 Last update 
[45df5b2...6749ff0](https://codecov.io/gh/apache/apisix-dashboard/pull/1633?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache

[GitHub] [apisix-dashboard] qian0817 opened a new pull request #1634: feat: improve Route module

[GitBox]

qian0817 opened a new pull request #1634:
URL: https://github.com/apache/apisix-dashboard/pull/1634


   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   - Related  #1628 
   ___
   ### New feature or improvement
   
   1. List page, search area field, supplement Placeholder.
   2. Create routing page, step 1, form should be aligned to the left, not 
centered.
   3. Create routing page, title remove spaces.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1634: feat: improve Route module

[GitBox]

codecov-io commented on pull request #1634:
URL: https://github.com/apache/apisix-dashboard/pull/1634#issuecomment-803372045


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=h1) 
Report
   > Merging 
[#1634](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=desc) 
(7954c9c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `23.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1634   +/-   ##
   ===
   - Coverage   71.92%   47.97%   -23.96% 
   ===
 Files 133   47   -86 
 Lines5472 3116 -2356 
 Branches  5920  -592 
   ===
   - Hits 3936 1495 -2441 
   - Misses   1293 1337   +44 
   - Partials  243  284   +41 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `47.97% <ø> (-0.29%)` | :arrow_down: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `9.43% <0.00%> (-72.65%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv)
 | `3.38% <0.00%> (-65.79%)` | :arrow_down: |
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `27.41% <0.00%> (-56.46%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `36.11% <0.00%> (-41.67%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `58.43% <0.00%> (-29.52%)` | :arrow_down: |
   | 
[api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=)
 | `51.83% <0.00%> (-26.94%)` | :arrow_down: |
   | ... and [101 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=footer).
 Last update 
[45df5b2...7954c9c](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To re

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1634: feat: improve Route module

[GitBox]

codecov-io edited a comment on pull request #1634:
URL: https://github.com/apache/apisix-dashboard/pull/1634#issuecomment-803372045


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=h1) 
Report
   > Merging 
[#1634](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=desc) 
(7954c9c) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/45df5b26715abc1f02bd69799147a634a20e1b2e?el=desc)
 (45df5b2) will **decrease** coverage by `9.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1634  +/-   ##
   ==
   - Coverage   71.92%   61.97%   -9.96% 
   ==
 Files 133   47  -86 
 Lines5472 3116-2356 
 Branches  5920 -592 
   ==
   - Hits 3936 1931-2005 
   + Misses   1293  873 -420 
   - Partials  243  312  +69 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.97% <ø> (-0.29%)` | :arrow_down: |
   | backend-e2e-test-ginkgo | `47.97% <ø> (-0.29%)` | :arrow_down: |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==)
 | `0.00% <0.00%> (-64.29%)` | :arrow_down: |
   | 
[api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==)
 | `47.22% <0.00%> (-30.56%)` | :arrow_down: |
   | 
[api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv)
 | `62.60% <0.00%> (-29.57%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `59.63% <0.00%> (-28.32%)` | :arrow_down: |
   | 
[api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=)
 | `48.71% <0.00%> (-23.08%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `64.51% <0.00%> (-19.36%)` | :arrow_down: |
   | 
[...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv)
 | `59.57% <0.00%> (-18.09%)` | :arrow_down: |
   | 
[api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=)
 | `44.82% <0.00%> (-13.80%)` | :arrow_down: |
   | 
[api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=)
 | `77.14% <0.00%> (-13.58%)` | :arrow_down: |
   | ... and [97 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1634/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=footer).
 Last update 
[45df5b2...7954c9c](https://codecov.io/gh/apache/apisix-dashboard/pull/1634?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1603: chore: improve user friendly on Upstream

[GitBox]

liuxiran commented on a change in pull request #1603:
URL: https://github.com/apache/apisix-dashboard/pull/1603#discussion_r598126526



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -728,8 +727,14 @@ const UpstreamForm: React.FC = forwardRef(
 

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1601: feat: add rawDataEditor in route

[GitBox]

liuxiran commented on a change in pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#discussion_r598127825



##
File path: web/cypress/integration/rawDataEditor/test-rawDataEditor.spec.js
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Test RawDataEditor', () => {
+  const timeout = 1000;
+
+  beforeEach(() => {
+cy.login();
+
+cy.fixture('rawDataEditor-dataset.json').as('dataset');
+cy.fixture('selector.json').as('domSelector');
+cy.fixture('data.json').as('data');
+  });
+
+  it('should create and update with rawDataEditor', function () {
+const menuList = ['Route', 'Service', 'Upstream', 'Consumer'];
+const publicData = this.data;
+const dateset = this.dataset;
+const domSelector = this.domSelector;
+menuList.forEach(function (item) {
+  cy.visit('/');
+  cy.contains(item).click();
+  cy.contains('Create with Editor').click();
+  const data = dateset[item];
+
+  // create with editor
+  cy.window().then(({ codemirror }) => {
+if (codemirror) {
+  codemirror.setValue(JSON.stringify(data));
+}
+cy.get(domSelector.drawer).should('exist');
+cy.get(domSelector.drawer, { timeout }).within(() => {
+  cy.contains('Submit').click({
+force: true,
+  });
+  cy.get(domSelector.drawer).should('not.exist');
+});
+  });
+
+  cy.reload();
+
+  // update with editor
+  cy.contains(item === 'Consumer' ? data.username : data.name)
+.siblings()
+.contains('View')
+.click();
+
+  cy.window().then(({ codemirror }) => {
+if (codemirror) {
+  if (item === 'Consumer') {
+codemirror.setValue(JSON.stringify({ ...data, desc: 'newDesc' }));
+  } else {
+codemirror.setValue(JSON.stringify({ ...data, name: 'newName' }));
+  }
+}
+cy.get(domSelector.drawer).should('exist');
+cy.get(domSelector.drawer, { timeout }).within(() => {
+  cy.contains('Submit').click({
+force: true,
+  });
+  cy.get(domSelector.drawer).should('not.exist');
+});
+  });
+
+  cy.reload();
+  cy.get('.ant-table-tbody').should('contain', item === 'Consumer' ? 
'newDesc' : 'newName');

Review comment:
   it would be better to use `domSelector` here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1601: feat: add rawDataEditor in route

[GitBox]

liuxiran commented on pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-803401383


   in my local env, there is a problem:
   
![image](https://user-images.githubusercontent.com/2561857/111877155-e2741180-89dc-11eb-9f67-f4e7f9b114a6.png)
   
   test steps:
   1. raw edit a route, change the code mirror mode to `yaml`, submit
   2. create with editor, cancel
   3. raw edit a route, you will see the problem.
   
   it would be better to recover the code mirror mode to `json` when open the 
raw data editor.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1603: chore: improve user friendly on Upstream

[GitBox]

juzhiyuan commented on a change in pull request #1603:
URL: https://github.com/apache/apisix-dashboard/pull/1603#discussion_r598132571



##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -728,8 +727,14 @@ const UpstreamForm: React.FC = forwardRef(
 

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1601: feat: add rawDataEditor in route

[GitBox]

juzhiyuan commented on pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-803401834


   cc @LiteSun to check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] Jaycean merged pull request #1620: feat: update yarn.lock

[GitBox]

Jaycean merged pull request #1620:
URL: https://github.com/apache/apisix-dashboard/pull/1620


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1635: fix: login_module_#1626

[GitBox]

iamayushdas opened a new pull request #1635:
URL: https://github.com/apache/apisix-dashboard/pull/1635


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [x] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   login module fixes
   - size of logo
   - removed settings from login page
   
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   ___
   ### Please add the corresponding test cases if necessary.
   
   ___
   ### Backport  #patches
   - Why need to backport?
   
   - Source branch
   
   - Related commits and pull requests
   
   issue
   - #1626 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1626: improve Login module

[GitBox]

iamayushdas commented on issue #1626:
URL: 
https://github.com/apache/apisix-dashboard/issues/1626#issuecomment-803430393


   > Here are some minor issues on the Login page we could resolve.
   > 
   > ## TODO
   > * [x]  In the upper right corner of the landing page, remove the Settings 
button.
   > * [x]  Landing page logo is slightly smaller.
   > * [ ]  Removing the sample login from the landing page.
   > * [ ]  Default account password should be entered by default on the 
landing page, so users could log in directly.
   > * [ ]  Spacing between "How to change default account and password" and 
the login button and password input box on the landing page is too large.
   
   #1635 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1635: fix: login_module_#1626

[GitBox]

codecov-io commented on pull request #1635:
URL: https://github.com/apache/apisix-dashboard/pull/1635#issuecomment-803430422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=h1) 
Report
   > Merging 
[#1635](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=desc) 
(3861c68) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/76e0e05c86b83dedf4afa7d3fcc7a00f320453e7?el=desc)
 (76e0e05) will **decrease** coverage by `17.15%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1635   +/-   ##
   ===
   - Coverage   68.96%   51.81%   -17.16% 
   ===
 Files  48   38   -10 
 Lines3055 2650  -405 
   ===
   - Hits 2107 1373  -734 
   - Misses708 1089  +381 
   + Partials  240  188   -52 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-unit-test | `51.81% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-74.49%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=)
 | `57.14% <0.00%> (-33.34%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [35 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=footer).
 Last update 
[76e0e05...3861c68](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1632: improve some minor issues

[GitBox]

iamayushdas commented on issue #1632:
URL: 
https://github.com/apache/apisix-dashboard/issues/1632#issuecomment-803430565


   > Here are some minor issues on the Login page we could resolve.
   > 
   > ## TODO
   > * [ ]  Left icon replacement. @LiteSun
   > * [ ]  Extracting Table as a separate component for reuse in various 
modules.
   > * [ ]  APISIX plugin type change.
   > * [ ]  GitHub hyperlink (icon) added to Header section.
   
   could please brief 3rd todo?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1635: fix: login_module_#1626

[GitBox]

codecov-io edited a comment on pull request #1635:
URL: https://github.com/apache/apisix-dashboard/pull/1635#issuecomment-803430422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=h1) 
Report
   > Merging 
[#1635](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=desc) 
(3861c68) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/76e0e05c86b83dedf4afa7d3fcc7a00f320453e7?el=desc)
 (76e0e05) will **decrease** coverage by `1.57%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1635  +/-   ##
   ==
   - Coverage   68.96%   67.39%   -1.58% 
   ==
 Files  48   47   -1 
 Lines3055 3116  +61 
   ==
   - Hits 2107 2100   -7 
   - Misses708  770  +62 
   - Partials  240  246   +6 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test-ginkgo | `47.97% <ø> (?)` | |
   | backend-unit-test | `51.81% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `43.63% <0.00%> (-7.28%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-7.21%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==)
 | `69.01% <0.00%> (-2.87%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | ... and [18 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=footer).
 Last update 
[76e0e05...3861c68](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1635: fix: login_module_#1626

[GitBox]

codecov-io edited a comment on pull request #1635:
URL: https://github.com/apache/apisix-dashboard/pull/1635#issuecomment-803430422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=h1) 
Report
   > Merging 
[#1635](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=desc) 
(3861c68) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/76e0e05c86b83dedf4afa7d3fcc7a00f320453e7?el=desc)
 (76e0e05) will **increase** coverage by `2.37%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1635  +/-   ##
   ==
   + Coverage   68.96%   71.34%   +2.37% 
   ==
 Files  48   47   -1 
 Lines3055 3116  +61 
   ==
   + Hits 2107 2223 +116 
   + Misses708  651  -57 
   - Partials  240  242   +2 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `62.06% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `47.97% <ø> (?)` | |
   | backend-unit-test | `51.81% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `71.02% <0.00%> (-3.47%)` | :arrow_down: |
   | 
[api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==)
 | `69.01% <0.00%> (-2.87%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `50.00% <0.00%> (-0.91%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <0.00%> (ø)` | |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | | |
   | 
[api/internal/core/entity/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L3F1ZXJ5Lmdv)
 | | |
   | 
[api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=)
 | | |
   | 
[api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=)
 | | |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | ... and [13 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=footer).
 Last update 
[76e0e05...3861c68](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1635: fix: login_module_#1626

[GitBox]

codecov-io edited a comment on pull request #1635:
URL: https://github.com/apache/apisix-dashboard/pull/1635#issuecomment-803430422


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=h1) 
Report
   > Merging 
[#1635](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=desc) 
(3861c68) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/76e0e05c86b83dedf4afa7d3fcc7a00f320453e7?el=desc)
 (76e0e05) will **increase** coverage by `2.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1635  +/-   ##
   ==
   + Coverage   68.96%   71.88%   +2.91% 
   ==
 Files  48  133  +85 
 Lines3055 5470+2415 
 Branches0  592 +592 
   ==
   + Hits 2107 3932+1825 
   - Misses708 1296 +588 
   - Partials  240  242   +2 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `62.06% <ø> (?)` | |
   | backend-e2e-test-ginkgo | `47.97% <ø> (?)` | |
   | backend-unit-test | `51.81% <ø> (?)` | |
   | frontend-e2e-test | `72.59% <ø> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==)
 | `72.00% <ø> (ø)` | |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `71.02% <0.00%> (-3.47%)` | :arrow_down: |
   | 
[api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==)
 | `69.01% <0.00%> (-2.87%)` | :arrow_down: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `50.00% <0.00%> (-0.91%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `85.29% <0.00%> (ø)` | |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `100.00% <0.00%> (ø)` | |
   | 
[api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==)
 | | |
   | 
[api/internal/core/entity/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L3F1ZXJ5Lmdv)
 | | |
   | 
[api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=)
 | | |
   | 
[api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=)
 | | |
   | ... and [100 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1635/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=footer).
 Last update 
[76e0e05...3861c68](https://codecov.io/gh/apache/apisix-dashboard/pull/1635?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io edited a comment on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(1e777be) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `19.92%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   master#1625   +/-   ##
   ===
   - Coverage   71.69%   51.77%   -19.93% 
   ===
 Files 133   38   -95 
 Lines5469 2650 -2819 
 Branches  5920  -592 
   ===
   - Hits 3921 1372 -2549 
   + Misses   1305 1090  -215 
   + Partials  243  188   -55 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `0.00% <0.00%> (-71.03%)` | :arrow_down: |
   | 
[api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv)
 | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `0.00% <0.00%> (-55.47%)` | :arrow_down: |
   | 
[api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=)
 | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `27.41% <0.00%> (-37.50%)` | :arrow_down: |
   | 
[api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==)
 | `42.59% <0.00%> (-35.19%)` | :arrow_down: |
   | 
[api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==)
 | `66.66% <0.00%> (-33.34%)` | :arrow_down: |
   | ... and [119 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...1e777be](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this servic

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

bisakhmondal commented on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803440931


   cc @nic-chen, @juzhiyuan to review when you have time :)
   
   Guys, please suggest me a markdown linter, it seems mine is not working😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io edited a comment on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(1e777be) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `4.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1625  +/-   ##
   ==
   - Coverage   71.69%   67.42%   -4.27% 
   ==
 Files 133   47  -86 
 Lines5469 3116-2353 
 Branches  5920 -592 
   ==
   - Hits 3921 2101-1820 
   + Misses   1305  768 -537 
   - Partials  243  247   +4 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `48.10% <ø> (+0.24%)` | :arrow_up: |
   | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv)
 | `35.08% <0.00%> (-29.84%)` | :arrow_down: |
   | 
[api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==)
 | `75.00% <0.00%> (-25.00%)` | :arrow_down: |
   | 
[api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=)
 | `66.12% <0.00%> (-17.75%)` | :arrow_down: |
   | 
[api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv)
 | `54.11% <0.00%> (-11.77%)` | :arrow_down: |
   | 
[api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv)
 | `76.47% <0.00%> (-8.83%)` | :arrow_down: |
   | 
[api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=)
 | `67.28% <0.00%> (-3.74%)` | :arrow_down: |
   | 
[api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=)
 | `52.10% <0.00%> (-3.37%)` | :arrow_down: |
   | 
[api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=)
 | `67.03% <0.00%> (-2.24%)` | :arrow_down: |
   | 
[api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=)
 | `80.18% <0.00%> (-1.89%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-0.61%)` | :arrow_down: |
   | ... and [89 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...1e777be](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries ab

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io edited a comment on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(1e777be) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **decrease** coverage by `0.54%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1625  +/-   ##
   ==
   - Coverage   71.69%   71.14%   -0.55% 
   ==
 Files 133   47  -86 
 Lines5469 3116-2353 
 Branches  5920 -592 
   ==
   - Hits 3921 2217-1704 
   + Misses   1305  655 -650 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.90% <ø> (+0.16%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `48.10% <ø> (+0.24%)` | :arrow_up: |
   | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-0.61%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | 
[...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4)
 | | |
   | 
[...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=)
 | | |
   | 
[web/src/pages/SSL/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9TU0wvTGlzdC50c3g=)
 | | |
   | 
[web/src/components/RightContent/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1JpZ2h0Q29udGVudC9pbmRleC50c3g=)
 | | |
   | 
[web/src/pages/PluginTemplate/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9QbHVnaW5UZW1wbGF0ZS9MaXN0LnRzeA==)
 | | |
   | 
[web/src/access.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9hY2Nlc3MudHM=)
 | | |
   | 
[web/src/pages/Upstream/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9zZXJ2aWNlLnRz)
 | | |
   | 
[web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz)
 | | |
   | ... and [80 
more](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...1e777be](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1625: docs: Updating docs for e2e tests

[GitBox]

codecov-io edited a comment on pull request #1625:
URL: https://github.com/apache/apisix-dashboard/pull/1625#issuecomment-803278601


   # 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=h1) 
Report
   > Merging 
[#1625](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=desc) 
(1e777be) into 
[master](https://codecov.io/gh/apache/apisix-dashboard/commit/1ba32d9c0b47c06ebb067935692385f28aae9fe5?el=desc)
 (1ba32d9) will **increase** coverage by `0.03%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1625  +/-   ##
   ==
   + Coverage   71.69%   71.72%   +0.03% 
   ==
 Files 133  133  
 Lines5469 5472   +3 
 Branches  592  592  
   ==
   + Hits 3921 3925   +4 
   + Misses   1305 1303   -2 
   - Partials  243  244   +1 
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `61.90% <ø> (+0.16%)` | :arrow_up: |
   | backend-e2e-test-ginkgo | `48.10% <ø> (+0.24%)` | :arrow_up: |
   | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: |
   | frontend-e2e-test | `72.49% <ø> (-0.09%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click 
here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
 to find out more.
   
   | [Impacted 
Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=tree) 
| Coverage Δ | |
   |---|---|---|
   | 
[web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==)
 | `77.04% <0.00%> (-3.28%)` | :arrow_down: |
   | 
[api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=)
 | `87.34% <0.00%> (-0.61%)` | :arrow_down: |
   | 
[api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==)
 | `33.33% <0.00%> (ø)` | |
   | 
[...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==)
 | `75.92% <0.00%> (+1.41%)` | :arrow_up: |
   | 
[api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1625/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv)
 | `47.27% <0.00%> (+3.63%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=footer).
 Last update 
[1ba32d9...1e777be](https://codecov.io/gh/apache/apisix-dashboard/pull/1625?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1601: feat: add rawDataEditor in route

[GitBox]

LiteSun commented on pull request #1601:
URL: https://github.com/apache/apisix-dashboard/pull/1601#issuecomment-803492261


   > in my local env, there is a problem:
   > 
![image](https://user-images.githubusercontent.com/2561857/111877155-e2741180-89dc-11eb-9f67-f4e7f9b114a6.png)
   > 
   > test steps:
   > 
   > 1. raw edit a route, change the code mirror mode to `yaml`, submit
   > 2. create with editor, cancel
   > 3. raw edit a route, you will see the problem.
   > 
   > it would be better to recover the code mirror mode to `json` when open the 
raw data editor.
   
   ok, many thanks. I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun closed issue #1313: FE: save List page's meta status

[GitBox]

LiteSun closed issue #1313:
URL: https://github.com/apache/apisix-dashboard/issues/1313


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun merged pull request #1584: feat: save Service list page's meta status

[GitBox]

LiteSun merged pull request #1584:
URL: https://github.com/apache/apisix-dashboard/pull/1584


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: feat: save list page's meta status (#1584)

[sunyi]

This is an automated email from the ASF dual-hosted git repository.

sunyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 3da7370  feat: save list page's meta status (#1584)
3da7370 is described below

commit 3da737017121632a47a28bcd3460a10f6f309250
Author: guoqqqi <72343596+guoq...@users.noreply.github.com>
AuthorDate: Sun Mar 21 09:00:28 2021 +0800

feat: save list page's meta status (#1584)
---
 web/cypress/fixtures/selector.json |  9 +-
 .../plugin/create-edit-delete-plugin.spec.js   |  6 +-
 .../service/create-edit-delete-service.spec.js |  7 +-
 .../service/save-paginator-status.spec.js  | 98 ++
 web/src/pages/Consumer/List.tsx| 18 +++-
 web/src/pages/Plugin/List.tsx  | 16 
 web/src/pages/PluginTemplate/List.tsx  | 16 
 web/src/pages/Route/List.tsx   | 20 -
 web/src/pages/SSL/List.tsx | 18 +++-
 web/src/pages/Service/List.tsx | 18 +++-
 web/src/pages/Upstream/List.tsx| 18 +++-
 11 files changed, 232 insertions(+), 12 deletions(-)

diff --git a/web/cypress/fixtures/selector.json 
b/web/cypress/fixtures/selector.json
index 15de3f7..121adf1 100644
--- a/web/cypress/fixtures/selector.json
+++ b/web/cypress/fixtures/selector.json
@@ -71,5 +71,12 @@
   "customSelector": "[title=Custom]",
   "notificationClose": ".anticon-close",
   "redirectURIInput": "#redirectURI",
-  "redirectCodeSelector": "#ret_code"
+  "redirectCodeSelector": "#ret_code",
+
+  "paginationOptions": ".ant-pagination-options",
+  "fiftyPerPage": "[title=\"50 / page\"]",
+  "twentyPerPage": "[title=\"20 / page\"]",
+  "pageList": ".ant-table-pagination-right",
+  "pageTwo": ".ant-pagination-item-2",
+  "pageTwoActived": ".ant-pagination-item-2.ant-pagination-item-active"
 }
diff --git a/web/cypress/integration/plugin/create-edit-delete-plugin.spec.js 
b/web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
index dcde1b4..136ab49 100644
--- a/web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
+++ b/web/cypress/integration/plugin/create-edit-delete-plugin.spec.js
@@ -52,8 +52,12 @@ context('Create and Delete Plugin List', () => {
 
   it('should delete plugin list', function () {
 cy.visit('/plugin/list');
-
 cy.get(this.domSelector.refresh).click();
+cy.get(this.domSelector.paginationOptions).click();
+cy.contains('50 / page').should('be.visible').click();
+cy.get(this.domSelector.fiftyPerPage).should('exist');
+cy.location('href').should('include', 'pageSize=50');
+
 cy.get(this.domSelector.deleteButton, { timeout 
}).should('exist').each(function ($el) {
   cy.wrap($el).click().click({ timeout });
   cy.contains('button', 'Confirm').click({ force: true });
diff --git a/web/cypress/integration/service/create-edit-delete-service.spec.js 
b/web/cypress/integration/service/create-edit-delete-service.spec.js
index e7e3507..83f5641 100644
--- a/web/cypress/integration/service/create-edit-delete-service.spec.js
+++ b/web/cypress/integration/service/create-edit-delete-service.spec.js
@@ -16,7 +16,7 @@
  */
 /* eslint-disable no-undef */
 
-context('create and delete service ', () => {
+context('Create and Delete Service ', () => {
   beforeEach(() => {
 cy.login();
 
@@ -50,7 +50,7 @@ context('create and delete service ', () => {
 cy.get(this.domSelector.drawer).should('be.visible');
 
 cy.get(this.domSelector.codemirrorScroll).within(() => {
-  cy.contains('upstream').should("exist");
+  cy.contains('upstream').should('exist');
   cy.contains(this.data.serviceName).should('exist');
 });
   });
@@ -65,7 +65,7 @@ context('create and delete service ', () => {
 
 // Confirm whether the created data is saved.
 cy.get(this.domSelector.nodes_0_host).should('value', this.data.ip1);
-cy.get(this.domSelector.description).should('value', this.data.description)
+cy.get(this.domSelector.description).should('value', 
this.data.description);
 cy.get(this.domSelector.name).clear().type(this.data.serviceName2);
 cy.get(this.domSelector.description).clear().type(this.data.description2);
 cy.get(this.domSelector.nodes_0_host).click();
@@ -101,4 +101,3 @@ context('create and delete service ', () => {
 cy.get(this.domSelector.notification).should('contain', 
this.data.deleteServiceSuccess);
   });
 });
-
diff --git a/web/cypress/integration/service/save-paginator-status.spec.js 
b/web/cypress/integration/service/save-paginator-status.spec.js
new file mode 100644
index 000..895768b
--- /dev/null
+++ b/web/cypress/integration/service/save-paginator-status.spec.js
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE fil

[GitHub] [apisix-website] bzp2010 commented on pull request #263: feat: broken link checker script

[GitBox]

bzp2010 commented on pull request #263:
URL: https://github.com/apache/apisix-website/pull/263#issuecomment-803495601


   ### Summary
   - The target function has been realized. **(request review)**
   - In order to ensure the correctness of the document, the link conversion 
function is not introduced in the workflow involving the output of compiled 
products. **(Do we need this?)**
   - The current implementation is not elegant enough. **(Need help for 
improvement)**
   
   **Thanks**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #263: feat: broken link checker script

[GitBox]

juzhiyuan commented on a change in pull request #263:
URL: https://github.com/apache/apisix-website/pull/263#discussion_r598205468



##
File path: link-checker.js
##
@@ -0,0 +1,186 @@
+const fs = require("fs");
+const path = require("path");
+const childProcess = require("child_process");
+
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];

Review comment:
   I notice that we check projects here, so could we remove some logics 
from`sync-doc` script?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #263: feat: broken link checker script

[GitBox]

juzhiyuan commented on a change in pull request #263:
URL: https://github.com/apache/apisix-website/pull/263#discussion_r598205468



##
File path: link-checker.js
##
@@ -0,0 +1,186 @@
+const fs = require("fs");
+const path = require("path");
+const childProcess = require("child_process");
+
+const projects = ["apisix-ingress-controller", "apisix", "apisix-dashboard"];

Review comment:
   I notice that there have some logics repeated as `sync-doc.js`, could we 
take some function alongside?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: fix: config proxy-rewrite out of the plugin market in route module (#1576)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 42f8740  fix: config proxy-rewrite out of the plugin market in route 
module (#1576)
42f8740 is described below

commit 42f8740225b634102a567e06612e2132257584cd
Author: liuxiran 
AuthorDate: Sun Mar 21 09:39:46 2021 +0800

fix: config proxy-rewrite out of the plugin market in route module (#1576)
---
 .../create-route-with-proxy-rewrite-plugin.spec.js | 139 ++
 web/src/components/Plugin/data.tsx |   1 +
 web/src/pages/Route/Create.tsx |   7 +
 .../pages/Route/components/Step1/ProxyRewrite.tsx  | 289 +
 web/src/pages/Route/components/Step1/index.tsx |   2 +
 web/src/pages/Route/components/Step3/index.tsx |  15 +-
 web/src/pages/Route/constants.ts   |  21 ++
 web/src/pages/Route/locales/en-US.ts   |  15 +-
 web/src/pages/Route/locales/zh-CN.ts   |  20 +-
 web/src/pages/Route/transform.ts   | 148 ++-
 web/src/pages/Route/typing.d.ts|  15 ++
 11 files changed, 650 insertions(+), 22 deletions(-)

diff --git 
a/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js 
b/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
new file mode 100644
index 000..04fa0f7
--- /dev/null
+++ 
b/web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+import menuLocaleUS from '../../../src/locales/en-US/menu';
+import componentLocaleUS from '../../../src/locales/en-US/component';
+import routeLocaleUS from '../../../src/pages/Route/locales/en-US';
+
+context('create route with proxy-rewrite plugin', () => {
+  const data = {
+rewriteUri: '/get',
+rewriteHeaderKey1: 'test1',
+rewriteHeaderKey2: 'test2',
+rewriteHeaderValue1: '1',
+rewriteHeaderValue2: '2',
+  };
+
+  const domSelector = {
+staticUri: '[data-cy=uri-static]',
+staticHost: '[data-cy=host-static]',
+keepHost: '[data-cy=host-keep]',
+newUri: '#proxyRewrite_uri',
+uriRewriteReg: '#proxyRewrite_regex_uri_0',
+uriRewriteTemp: '#proxyRewrite_regex_uri_1',
+newHost: '#proxyRewrite_host',
+buttonCreateNewRewriteHeader: '[data-cy=create-new-rewrite-header]',
+rewriteHeaderKey1: '#proxyRewrite_kvHeaders_0_key',
+rewriteHeaderValue1: '#proxyRewrite_kvHeaders_0_value',
+rewriteHeaderKey2: '#proxyRewrite_kvHeaders_1_key',
+rewriteHeaderValue2: '#proxyRewrite_kvHeaders_1_value',
+  }
+
+  beforeEach(() => {
+cy.login();
+
+cy.fixture('selector.json').as('domSelector');
+cy.fixture('data.json').as('data');
+  });
+
+  it('should create route with proxy-rewrite plugin', function () {
+cy.visit('/');
+cy.contains(menuLocaleUS['menu.routes']).click();
+
+// show create page
+cy.contains(componentLocaleUS['component.global.create']).click();
+cy.get(this.domSelector.name).type(this.data.routeName);
+
+// show requestOverride PanelSection
+
cy.contains(routeLocaleUS['page.route.panelSection.title.requestOverride']).should('be.visible');
+// should show newPath after the URIRewriteType static clicked
+cy.get(domSelector.staticUri).click();
+
cy.contains(routeLocaleUS['page.route.form.itemLabel.newPath']).should('be.visible');
+cy.get(domSelector.newUri).should('be.visible').type(data.rewriteUri);
+// should show regexp and template after URIRewriteType regexp clicked
+cy.contains(routeLocaleUS['page.route.radio.regex']).click();
+
cy.contains(routeLocaleUS['page.route.form.itemLabel.regex']).should('be.visible');
+cy.get(domSelector.uriRewriteReg).should('be.visible');
+
cy.contains(routeLocaleUS['page.route.form.itemLabel.template']).should('be.visible');
+cy.get(domSelector.uriRewriteTemp).should('be.visible');
+
+cy.get(domSelector.staticUri).click();
+
+// should show newhost after static host

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1241: Cannot configure request path rewrite when creating a route using dashboard

[GitBox]

juzhiyuan closed issue #1241:
URL: https://github.com/apache/apisix-dashboard/issues/1241


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

[GitBox]

juzhiyuan merged pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[apisix-dashboard] branch master updated: feat: add more fe e2e test cases for online debug (#1612)

[juzhiyuan]

This is an automated email from the ASF dual-hosted git repository.

juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git


The following commit(s) were added to refs/heads/master by this push:
 new 76f083a  feat: add more fe e2e test cases for online debug (#1612)
76f083a is described below

commit 76f083a97ae475fcce6258d207fe61e4674a3c0b
Author: liuxiran 
AuthorDate: Sun Mar 21 09:40:11 2021 +0800

feat: add more fe e2e test cases for online debug (#1612)
---
 web/cypress/fixtures/route-json-data.json  |  30 +
 web/cypress/integration/route/online-debug.spec.js | 132 +++--
 .../components/DebugViews/AuthenticationView.tsx   |   2 +-
 .../Route/components/DebugViews/DebugDrawView.tsx  | 118 --
 4 files changed, 232 insertions(+), 50 deletions(-)

diff --git a/web/cypress/fixtures/route-json-data.json 
b/web/cypress/fixtures/route-json-data.json
new file mode 100644
index 000..c9ee52c
--- /dev/null
+++ b/web/cypress/fixtures/route-json-data.json
@@ -0,0 +1,30 @@
+{
+  "debugPostJson": {
+"name": "test_https",
+"status": 1,
+"methods": ["GET", "HEAD", "POST", "PUT", "DELETE", "OPTIONS", "PATCH"],
+"priority": 0,
+"uris": ["/*"],
+"labels": {},
+"plugins": {
+  "redirect": {
+"http_to_https": true
+  }
+},
+"vars": [],
+"upstream": {
+  "type": "roundrobin",
+  "nodes": [{
+"host": "httpbin.org",
+"port": 80,
+"weight": 1
+  }],
+  "pass_host": "pass",
+  "timeout": {
+"connect": 6,
+"send": 6,
+"read": 6
+  }
+}
+  }
+}
diff --git a/web/cypress/integration/route/online-debug.spec.js 
b/web/cypress/integration/route/online-debug.spec.js
index 992efaa..3c32c02 100644
--- a/web/cypress/integration/route/online-debug.spec.js
+++ b/web/cypress/integration/route/online-debug.spec.js
@@ -39,10 +39,12 @@ context('Online debug', () => {
   
'localhost:9000/js6/main.jsp?sid=pARQZYHABxkSVdeMvXAAEtfJKbWQocOA&df=mail126_mailmaster#module=mbox.ListModule%7C%7B',
 ],
 invalidUrls: ['000'],
-postUrl: 
`${defaultSettings.serveUrlMap[SERVE_ENV].split('//')[1]}/apisix/admin/import/routes`,
+postFileUrl: 
`${defaultSettings.serveUrlMap[SERVE_ENV].split('//')[1]}/apisix/admin/import/routes`,
+routeOptUrl: 
`${defaultSettings.serveUrlMap[SERVE_ENV].split('//')[1]}/apisix/admin/routes`,
 uploadFile: '../../../api/test/testdata/import/default.json',
 headerAuthorizationKey: 'Authorization',
 routeName: 'hello',
+queryKey0: 'name',
   };
 
   const domSelector = {
@@ -53,9 +55,17 @@ context('Online debug', () => {
 debugFormDataType0: '[data-cy=debug-formdata-type-0]',
 debugFormDataValue0: '#dynamic_form_data_item_params_0_value',
 debugFormDataFileButton0: '[data-cy=debug-upload-btn-0]',
-codeMirrorCode: '.CodeMirror-code',
+codeMirrorResp: '#codeMirror-response',
 headerDataKey0: '#headerForm_params_0_key',
 headerDataValue0: '#headerForm_params_0_value',
+queryDataKey0: '#queryForm_params_0_key',
+queryDataValue0: '#queryForm_params_0_value',
+queryTab: '#rc-tabs-0-tab-query',
+authTab: '#rc-tabs-0-tab-auth',
+headerTab: '#rc-tabs-0-tab-header',
+bodyTab: '#rc-tabs-0-tab-body',
+jwtAuth: '[data-cy=jwt-auth]',
+jwtTokenInput: '#authForm_Authorization',
   };
 
   beforeEach(() => {
@@ -63,6 +73,7 @@ context('Online debug', () => {
 
 cy.fixture('selector.json').as('domSelector');
 cy.fixture('data.json').as('data');
+cy.fixture('route-json-data.json').as('routeData');
 cy.intercept('/apisix/admin/debug-request-forwarding').as('DebugAPI');
   });
 
@@ -72,6 +83,7 @@ context('Online debug', () => {
 
 // show online debug draw
 cy.contains(routeLocaleUS['page.route.onlineDebug']).click();
+cy.get(domSelector.debugDraw).should('be.visible');
 // input uri with specified special characters
 data.validUris.forEach((uri) => {
   cy.get(this.domSelector.debugUri).clear();
@@ -89,6 +101,7 @@ context('Online debug', () => {
 
 // show online debug draw
 cy.contains(routeLocaleUS['page.route.onlineDebug']).click();
+cy.get(domSelector.debugDraw).should('be.visible');
 
 // click send without type debugUrl
 cy.contains(routeLocaleUS['page.route.button.send']).click({ force: true 
});
@@ -124,9 +137,9 @@ context('Online debug', () => {
 cy.get(domSelector.debugProtocol).click();
 cy.contains('http://').click();
 // set debug uri
-cy.get(this.domSelector.debugUri).type(data.postUrl);
+cy.get(this.domSelector.debugUri).type(data.postFileUrl);
 // set request body
-cy.contains('Body Params').should('be.visible').click();
+cy.get(domSelector.bodyTab).should('be.visible').click();
 
 cy.contains('form-data').should('be.visible').click();
 cy.get(domSelector.debugFormDataKey0).type('file');
@@ -144,7 +157,

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1291: test(fe): add e2e test for online debug

[GitBox]

juzhiyuan closed issue #1291:
URL: https://github.com/apache/apisix-dashboard/issues/1291


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org